< sipa> achow101: fixed my issue with the offline descriptor by specifying an explicit range
< sipa> i'm confused why it apparently only works for the first index without that (it looks like it should be defaulting to [0,-keypoolsize])
< achow101> that's strange
< sipa> it could still be an issue with my changes
< sipa> but i have it with simple wpkh() as well
< achow101> I'll look into
< achow101> it
< sipa> let me clean up my test branch a bit, and try it on master
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ed25cb58f605...48725e64fbfb
< bitcoin-git> bitcoin/master ee35745 fanquake: build: use newer source for libnatpmp
< bitcoin-git> bitcoin/master 7af2502 fanquake: build: compile libnatpmp with -DNATPMP_STATICLIB on Windows
< bitcoin-git> bitcoin/master 48725e6 fanquake: Merge #21209: build: use newer source for libnatpmp
< bitcoin-git> [bitcoin] fanquake merged pull request #21209: build: use newer source for libnatpmp (master...newer_libnatpmp) https://github.com/bitcoin/bitcoin/pull/21209
< sipa> that works
< sipa> if you remove the "range": [0, 100] on line 254-255, it doesn't
< achow101> sipa: is the issue with fetching the second address, i.e. at index 1?
< achow101> sipa: oh, I see what the problem is. ParseRange (called by ParseDescriptorRange) takes the value given as the end of the range, not the start
< achow101> although TopUp should be called so that shouldn't matter
< achow101> oh, without range, so no parsing happens
< achow101> sipa: ok, the real problem is that that test has -keypool=1 and that self.psbt_offline doesn't use any rpc that calls topup before it tries to sign
< sipa> achow101: oh!
< sipa> that explains
< achow101> sipa: listdescriptors outputs the range so it's useful to use that to debug too
< sipa> is keypool=1 just the default in the functional tests?
< achow101> yeah
< achow101> it's set in the bitcoin.conf in test_framework/util
< sipa> ok, that was boring
< sipa> thanks for having a look
< achow101> no problem
< bitcoin-git> [bitcoin] fanquake opened pull request #21376: depends: Qt 5.12.10 (master...qt_5_12_10_enhanced) https://github.com/bitcoin/bitcoin/pull/21376
< bitcoin-git> [bitcoin] ajtowns opened pull request #21377: Speedy trial support for versionbits (master...202103-bip9-speedy-trial-support) https://github.com/bitcoin/bitcoin/pull/21377
< bitcoin-git> [bitcoin] ajtowns opened pull request #21378: Convert taproot to flag day activation (master...202103-taproot-flag-day) https://github.com/bitcoin/bitcoin/pull/21378
< bitcoin-git> [bitcoin] DesWurstes closed pull request #21372: RPC: minetxlocally (master...bb) https://github.com/bitcoin/bitcoin/pull/21372