00:56 < sipa> achow101: fixed my issue with the offline descriptor by specifying an explicit range

00:56 < sipa> i'm confused why it apparently only works for the first index without that (it looks like it should be defaulting to [0,-keypoolsize])

01:02 < achow101> that's strange

01:04 < sipa> it could still be an issue with my changes

01:04 < sipa> but i have it with simple wpkh() as well

01:04 < achow101> I'll look into

01:04 < achow101> it

01:05 < sipa> let me clean up my test branch a bit, and try it on master

01:20 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ed25cb58f605...48725e64fbfb

01:20 < bitcoin-git> bitcoin/master ee35745 fanquake: build: use newer source for libnatpmp

01:20 < bitcoin-git> bitcoin/master 7af2502 fanquake: build: compile libnatpmp with -DNATPMP_STATICLIB on Windows

01:20 < bitcoin-git> bitcoin/master 48725e6 fanquake: Merge #21209: build: use newer source for libnatpmp

01:20 < bitcoin-git> [bitcoin] fanquake merged pull request #21209: build: use newer source for libnatpmp (master...newer_libnatpmp) https://github.com/bitcoin/bitcoin/pull/21209

01:55 < sipa> achow101: https://github.com/sipa/bitcoin/commits/202103_descriptor_weirdness

01:56 < sipa> that works

01:56 < sipa> if you remove the "range": [0, 100] on line 254-255, it doesn't

02:02 < achow101> sipa: is the issue with fetching the second address, i.e. at index 1?

02:04 < achow101> sipa: oh, I see what the problem is. ParseRange (called by ParseDescriptorRange) takes the value given as the end of the range, not the start

02:07 < achow101> although TopUp should be called so that shouldn't matter

02:12 < achow101> oh, without range, so no parsing happens

02:49 < achow101> sipa: ok, the real problem is that that test has -keypool=1 and that self.psbt_offline doesn't use any rpc that calls topup before it tries to sign

02:52 < sipa> achow101: oh!

02:52 < sipa> that explains

02:53 < achow101> sipa: listdescriptors outputs the range so it's useful to use that to debug too

02:54 < sipa> is keypool=1 just the default in the functional tests?

02:54 < achow101> yeah

02:54 < achow101> it's set in the bitcoin.conf in test_framework/util

02:54 < sipa> ok, that was boring

02:54 < sipa> thanks for having a look

02:55 < achow101> no problem

06:17 < bitcoin-git> [bitcoin] fanquake opened pull request #21376: depends: Qt 5.12.10 (master...qt_5_12_10_enhanced) https://github.com/bitcoin/bitcoin/pull/21376

09:21 < bitcoin-git> [bitcoin] ajtowns opened pull request #21377: Speedy trial support for versionbits (master...202103-bip9-speedy-trial-support) https://github.com/bitcoin/bitcoin/pull/21377

11:27 < bitcoin-git> [bitcoin] ajtowns opened pull request #21378: Convert taproot to flag day activation (master...202103-taproot-flag-day) https://github.com/bitcoin/bitcoin/pull/21378

20:13 < bitcoin-git> [bitcoin] DesWurstes closed pull request #21372: RPC: minetxlocally (master...bb) https://github.com/bitcoin/bitcoin/pull/21372