< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1a4a9305c2d2...e797388f8b91
< bitcoin-git> bitcoin/master 21b6a23 Jon Atack: doc: add signet to share/examples/bitcoin.conf
< bitcoin-git> bitcoin/master 4a28510 Jon Atack: doc: add signet to doc/bitcoin-conf.md
< bitcoin-git> bitcoin/master e797388 MarcoFalke: Merge #21384: doc: add signet to bitcoin.conf documentation
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21384: doc: add signet to bitcoin.conf documentation (master...add-signet-to-bitcoin-conf) https://github.com/bitcoin/bitcoin/pull/21384
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e797388f8b91...a22653a636e8
< bitcoin-git> bitcoin/master 36aa295 Jon Atack: fuzz: fix gcc Woverloaded-virtual build warnings
< bitcoin-git> bitcoin/master a22653a MarcoFalke: Merge #21371: fuzz: fix gcc Woverloaded-virtual build warnings
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21371: fuzz: fix gcc Woverloaded-virtual build warnings (master...sock-Woverloaded-virtual) https://github.com/bitcoin/bitcoin/pull/21371
< wumpus> MarcoFalke: #20170 seems to be stuck on your signature; is there anywhere we can find a non-expired version of your PGP key? it fetches the trusted keys from the ubuntu server as the CI does but somehow that doesn't work (not locally either)
< gribble> https://github.com/bitcoin/bitcoin/issues/20170 | Packages missing from from https://bitcoincore.org/depends-sources 404 Not Found · Issue #20170 · bitcoin/bitcoin · GitHub
< S3RK> What happens with chainstate db in cause of power loss to the drive? Is it pretty much guaranteed that it gets corrputed?
< sipa_> it should never get corrupted
< sipa_> in theory ;)
< S3RK> hm... maybe something wrong with my setup then
< S3RK> I got LevelDB read failure: IO error: /media/btc/Bitcoin/chainstate/102989.ldb: Input/output error
< sipa_> that's *your drive* that is broken
< sipa_> input/output errors means hardware failure
< S3RK> you're right. I tried to remount disk and then Deserialize or I/O error - CAutoFile::read: fread failed: unspecified iostream_category error at FlatFilePos(nFile=2479, nPos=69638818)
< S3RK> Corrupted block database detected.
< vasild> wumpus: Marco posted a link some time ago to an updated gpg key here: http://www.erisian.com.au/bitcoin-core-dev/log-2021-02-18.html#l-283
< vasild> MarcoFalke: wrt fuzzing, right, that is my understanding too. And if a test is changed (very little) to just do ConsumeBool() before any other consumes, that would "invalidate" the fuzz seeds, I guess.
< wumpus> vasild: thanks!
< bitcoin-git> [bitcoin] vasild opened pull request #21387: fuzz: test the I2P Session public interface (master...i2p_tests) https://github.com/bitcoin/bitcoin/pull/21387
< MarcoFalke> vasild: integral types smaller than 2^64 are consumed from the end. Byte vectors from the beginning.
< MarcoFalke> So it could happen that adding a ConsumeBool doesn't invalidate some seeds
< vasild> I see
< MarcoFalke> Currently it looks like we are hovering around 64%-65% total coverage. Decreasing when the code changes, increasing when the fuzz engine caught up
< vasild> I wonder if I should try to create a seed _manually_, because it is known that a reply on the socket like "foobar RESULT=OK baz" would trigger more coverage
< vasild> but waiting for the fuzzed to discover this may take a looong time
< vasild> s/fuzzed/fuzzer/
< darosior> vasild: manually generating a corpus is generally a pretty good idea (can't think of a scenario where it would not?), so that the fuzzing engine can start from this to discover new code paths
< vasild> alright, will try that
< MarcoFalke> You can also try to embedd a dictionary in the source code (The message type fuzzers do that with the message type)
< MarcoFalke> If the replies are "OK" or "NOT_OK", you could generate them as: reply = ConsumeBool()? Pick({"OK", "NOT_OK"}) : ConsumeString()
< MarcoFalke> Ideally the fuzz engine would figure out all of this by itself, but we are not there yet
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21388: scripted-diff: [doc] Rename fuzz seed_dir to corpus_dir (master...2103-docInputDir) https://github.com/bitcoin/bitcoin/pull/21388
< Norrin> dimitaracev35 i think here would be better for that
< dimitaracev35> Ah, already asked that question here but chat seems to be quiet atm
< dimitaracev35> thanks anyways!
< Norrin> dimitaracev35 that's weird. it's not in my scrollback
< dimitaracev35> it was under a different username since I'm quite new to irc and had to make an account with weechat
< bitcoin-git> [gui] MarcoFalke merged pull request #233: qt test: Don't bind to regtest port (master...qttest-other-port) https://github.com/bitcoin-core/gui/pull/233
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a22653a636e8...2067f9e5e891
< bitcoin-git> bitcoin/master e21276a Andrew Chow: qt test: Don't bind to regtest port
< bitcoin-git> bitcoin/master 2067f9e MarcoFalke: Merge bitcoin-core/gui#233: qt test: Don't bind to regtest port
< phantomcircuit> sipa_, hi it's march 8th
< sipa_> phantomcircuit: p2p meeting is tomorrow 1pm pacific, i believe
< phantomcircuit> ah
< phantomcircuit> ok
< jnewbery> next p2p meeting is tomorrow (March 9) at 21:00 UTC. Feel free to add suggested topics here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings
< amiti> wumpus: heads up that the Bitcoin-dev google calendar event for p2p meeting hasn't been updated for this week, but is updated after that
< wumpus> amiti: strange, thanks for letting me know, will take a look
< wumpus> should be corrected now
< ariard> jnewbery: i guess new p2p meeting hours should be bumped here https://bitcoincore.org/en/meetings/
< bitcoin-git> [bitcoin] fjahr opened pull request #21390: test: Test improvements for UTXO set hash tests (master...19145_followup) https://github.com/bitcoin/bitcoin/pull/21390
< bitcoin-git> [bitcoin] dongcarl opened pull request #21391: [Bundle 5/n] Prune g_chainman usage in RPC modules (master...2020-10-libbitcoinruntime-v7) https://github.com/bitcoin/bitcoin/pull/21391
< ariard> wumpus: thank
< bitcoin-git> [bitcoin] meshcollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/2067f9e5e891...a8b0892b743b
< bitcoin-git> bitcoin/master 51e2cd3 Andrew Chow: Have CalculateMaximumSignedTxSize also compute tx weight
< bitcoin-git> bitcoin/master 3e69939 Andrew Chow: Fail if maximum weight is too large
< bitcoin-git> bitcoin/master 48a0319 Andrew Chow: Add a test that selects too large if BnB is used
< bitcoin-git> [bitcoin] meshcollider merged pull request #20536: wallet: Error with "Transaction too large" if the funded tx will end up being too large after signing (master...fundtx-error-large-tx) https://github.com/bitcoin/bitcoin/pull/20536
< jonatack__> exit
< luke-jr> O.o
< jonatack> (oops)
< bitcoin-git> [bitcoin] achow101 opened pull request #21392: Implement BIP 8 based Speedy Trial activation (master...bip8-speedy-trial) https://github.com/bitcoin/bitcoin/pull/21392
< bitcoin-git> [bitcoin] achow101 opened pull request #21393: BIP 341: Add Speedy Trial activation parameters (master...taproot-speedy-trial) https://github.com/bitcoin/bitcoin/pull/21393