Kaizen_Kintsugi has quit [Ping timeout: 245 seconds]
c_arc has joined #bitcoin-core-dev
bomb-on has quit [Quit: aллилѹіа!]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Kaizen_Kintsugi has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 245 seconds]
c_arc has joined #bitcoin-core-dev
jarthur has quit [Read error: Connection reset by peer]
jarthur_ has joined #bitcoin-core-dev
Kaizen_Kintsugi has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
AaronvanW has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 260 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 252 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
earnestly has quit [Ping timeout: 252 seconds]
c_arc has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 245 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
piku has joined #bitcoin-core-dev
piku has quit [Client Quit]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
saranshsharma has joined #bitcoin-core-dev
SpellChecker_ has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 276 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Remote host closed the connection]
Kaizen_Kintsugi has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 260 seconds]
c_arc has joined #bitcoin-core-dev
bairen has quit [Remote host closed the connection]
bairen has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
saranshsharma has quit [Remote host closed the connection]
saranshsharma has joined #bitcoin-core-dev
saranshs_ has joined #bitcoin-core-dev
saranshsharma has quit [Ping timeout: 245 seconds]
saranshs_ has quit [Ping timeout: 245 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Kaizen_Kintsugi has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 252 seconds]
c_arc has joined #bitcoin-core-dev
dodo has quit [Quit: dodo]
dodo has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
jarthur_ is now known as jarthur
AaronvanW has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 265 seconds]
cryptapus has quit [Remote host closed the connection]
Kaizen_Kintsugi has joined #bitcoin-core-dev
cryptapus has joined #bitcoin-core-dev
gnaf_ has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 252 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
gnaf_ has quit [Ping timeout: 245 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 276 seconds]
Kaizen_Kintsugi has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 252 seconds]
upekkha has quit [Quit: upekkha]
upekkha has joined #bitcoin-core-dev
upekkha has joined #bitcoin-core-dev
upekkha has quit [Client Quit]
upekkha has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
SpellChecker_ has quit [Remote host closed the connection]
<laanwj>
if time() doesn't work but other syscalls do it might be something with the kernel DSO, this handles time calls nowadays for performance reasons, and reads the time from some page that is mapped into every process; just a guess though
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Kaizen_Kintsugi has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 252 seconds]
AaronvanW has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 252 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
commmon has quit [Remote host closed the connection]
commmon has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
mikehu44_ has quit [Client Quit]
mikehu44_ has joined #bitcoin-core-dev
mikehu44_ has quit [Client Quit]
mikehu44_ has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
earnestly has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
tootal has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Guest48 has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Guest48 has quit [Ping timeout: 256 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Kaizen_Kintsugi has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 245 seconds]
prayank has quit [Remote host closed the connection]
KaizenKintsugi has quit [Remote host closed the connection]
Kaizen_Kintsugi has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 252 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Kaizen_Kintsugi has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
___nick___ has quit [Ping timeout: 252 seconds]
c_arc has joined #bitcoin-core-dev
<jamesob>
MarcoFalke: you had been working on something like #20664 initially, right? Am I remembering wrong or didn't you find some issue that made it infeasible, or at least made you stop working on it?
<luke-jr>
jamesob: I think they're subtly different. It's less of a problem if 20664 misses something since it's a new RPC, whereas 15845 missing something is a rather annoying bug
<luke-jr>
(since it means the wallet scan failed to find wallet txs)
<luke-jr>
of course, best if 20664 finds everything :P
<luke-jr>
IIRC being descriptor-based avoided the issue tho?
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
igh4st has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
igh4st has quit [Ping timeout: 256 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
bomb-on has quit [Quit: aллилѹіа!]
c_arc has joined #bitcoin-core-dev
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
c_arc has joined #bitcoin-core-dev
javi404_ is now known as javi404
<Davidbak>
I'm looking around after reading the "how to get involved" information - which points to "good first issue" issues. And one of the first ones there is #18222 - https://github.com/bitcoin/bitcoin/issues/18822
<Davidbak>
19117 was closed with the comment "Seems like a generic feature discovery method is a better approach, so closing this".
<Davidbak>
(18827 sort of petered out and was closed by the author for some reason.)
<Davidbak>
Anyhow, my question is: is there interest in adding this RPC call? Is the comment "Seems like a generic feature discovery method is a better approach, so closing this" dispositive? Should issue 18822 be closed? What's the status?
<Davidbak>
And my meta-comment is: Is this the appropriate way to investigate: just asking here?
<Davidbak>
meta-comment -> meta-question
<sipa>
probably the best way is commenting on the issue with your thoughts
<sipa>
but you'll have to live with the fact that generally not everyone agrees what the right approach is
midnight_ is now known as midnight
<Davidbak>
I get that not everyone will agree on the right approach. And I understand discussing the issue. But in this case BOTH PRs, attempting to resolve this "good first issue" were closed _by the authors_ after doing all the work. Seems a shame in and of itself, but more to the point here: Leaves me uncertain as to whether this is an issue at all, much less a "good first issue"?
<Davidbak>
And that, of course, leaves me uncertain as to the value of the "good first issue" concept for getting involved in the first place ...
<Davidbak>
But my question really is: should the "good first issue" tag be taken off of 18822?
<sipa>
Perhaps, yes.
<sipa>
Sorry I don't really have good advice here, I haven't really followed up on this particular issue.
gnaf_ has joined #bitcoin-core-dev
<Davidbak>
Well, I just now added a comment to 18822 about this and I guess I'll see what happens.
<luke-jr>
davidbak: I agree "good first issue" probably is wrong considering this
<luke-jr>
davidbak: note that the first PR author ragequit, and closed ALL his PRs
<Davidbak>
ok. luke-jr - is "good first issues" still considered a good way to onboard to bitcoin-core development? And with or without the "PR Club" for getting tips?
<luke-jr>
and I closed mine because I was convinced it was the wrong approach
<luke-jr>
davidbak: generally, I recommend starting into dev by reviewing existing PRs
gnaf has joined #bitcoin-core-dev
gnaf_ has quit [Ping timeout: 252 seconds]
<Davidbak>
Do you mean standard code review stuff, I assume "concept (n)ack" comments aren't really appropriate until you get some decent traction?
<sipa>
i think the review club is very helpful, yes
<Davidbak>
ok, i'm reading fairly widely right now about how to usefully/effectively join - I'll add those two immediately
<sipa>
and yes, an unnuanced "concept ack" or "concept nack" from a new contributor isn't going to mean much
<luke-jr>
yes, code review
<hebasto>
davidbak: #bitcoin-core-pr-reviews
<luke-jr>
1) code review tends to be our bottleneck; 2) code review is a good way to learn the codebase
<Davidbak>
well, i certainly agree to both those points, so I'll get started there - and of course, my creating a dev environment that can build/run unit/functional tests and so on. thanks.
<Davidbak>
btw - speaking of unit tests - are prs out of the blue that _do_ add unit tests (only) considered valuable?
<Davidbak>
(because I do know how to write those)
<sipa>
in some cases, definitely
<luke-jr>
if they're good tests
<luke-jr>
in the past, I've seen some newbies make tests that basically check 1+2=3
<Davidbak>
yes, well I know good vs bad there too, it's kind of a specialty
<Davidbak>
no, i'm new to bitcoin-core but not to development, but for you: that claim will remain to be seen until I produce
<luke-jr>
we've come a long way in the past years, but I think there's still a lot of potential good tests missing
<sipa>
the difficulty for those is knowing (a) what's undertested by asking around/getting an idea of existing tests and (b) writing tests that test for the desirable behavior, and not "accidentally" true properties that may change with a code improvement
<sipa>
davidbak: in any case, questions about setting up a dev env tend to also be welcome in #bitcoin-core-pr-reviews i've noticed
<Davidbak>
good tips, thanks!
<luke-jr>
ideally tests would find bugs before we get to RCs :P
<sipa>
they often do
gnaf has quit [Ping timeout: 252 seconds]
<sipa>
in fact, they often find bugs before a PR is even opened ;)
<Davidbak>
yes indeed, so i guess a good place to start looking for needed coverage would be PRs accepted to the next (i.e., pending) release
<luke-jr>
sipa: right, I mean all ☺
<luke-jr>
davidbak: actually, newer code is probably more likely to have tests
<sipa>
davidbak: most development is on the master branch, which will become the 23.0 release in a few months
<Davidbak>
hmmm, so ... perhaps you're suggesting look for problematic areas that have _fixes_ for hte next release, that may have a history of being problem spots?
<luke-jr>
fixes tend to include tests to avoid regressions, too
<Davidbak>
yes, regrressions, but do they include a review of current test coverage for that feature that points to inadequacies? I guess no such area comes to your mind or you would have mentioned it.
<Davidbak>
i won't take your time anymore today - I'll continue my general "how to onboard" reading, and start looking at the code + tests myself. thanks!
<sipa>
yw!
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Remote host closed the connection]
Kaizen_Kintsugi has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 260 seconds]
c_arc has joined #bitcoin-core-dev
belcher has quit [Ping timeout: 252 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
belcher has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<luke-jr>
quite puzzled by the xenial 0.21.2 armhf build failure. I don't see any changes that are suspect :/