#bitcoin-core-dev on 2021-10-15 — searchable irc log

00:01 roconnor_ has quit [Quit: Konversation terminated!]

00:03 AaronvanW has joined #bitcoin-core-dev

00:04 ghost43 has quit [Remote host closed the connection]

00:05 ghost43 has joined #bitcoin-core-dev

00:09 c_arc has joined #bitcoin-core-dev

00:09 jamesob has quit [Quit: Connection closed for inactivity]

00:13 c_arc has joined #bitcoin-core-dev

00:25 c_arc has joined #bitcoin-core-dev

00:29 c_arc has joined #bitcoin-core-dev

00:33 c_arc has joined #bitcoin-core-dev

00:37 AaronvanW has quit [Ping timeout: 252 seconds]

00:40 Kaizen_Kintsugi has joined #bitcoin-core-dev

00:45 c_arc has joined #bitcoin-core-dev

00:49 c_arc has joined #bitcoin-core-dev

00:53 c_arc has joined #bitcoin-core-dev

00:55 ghostkeeper has joined #bitcoin-core-dev

00:57 bitcoin-git has joined #bitcoin-core-dev

00:57 <bitcoin-git> [bitcoin] theStack opened pull request #23281: test: check that bumpfee RPC fails for txs with descendants in mempool (master...202110-test-bumpfee_test_descendant_in_mempool) https://github.com/bitcoin/bitcoin/pull/23281

00:57 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

01:00 Davidbak has joined #bitcoin-core-dev

01:02 jespada has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]

01:03 jespada has joined #bitcoin-core-dev

01:03 <Davidbak> `build_msvc/vcpkg.json` lists `double-conversion` as a required package - this doesn't show up in `doc/dependencies.md` nor does it show up anywhere else in the repo (via grep). Still needed, if so why? Or maybe an leftover from some past need no longer required?

01:04 <Davidbak> (Or maybe somehow some other package needs it, but only on Windows?)

01:08 ghostkeeper has quit [Ping timeout: 265 seconds]

01:08 jespada has quit [Ping timeout: 268 seconds]

01:08 bitcoin-git has joined #bitcoin-core-dev

01:08 <bitcoin-git> [bitcoin] theuni opened pull request #23282: build: remove build stubs for external leveldb (master...no_external_leveldb) https://github.com/bitcoin/bitcoin/pull/23282

01:08 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

01:14 c_arc has joined #bitcoin-core-dev

01:17 earnestly has quit [Ping timeout: 252 seconds]

01:21 c_arc has joined #bitcoin-core-dev

01:25 c_arc has joined #bitcoin-core-dev

01:29 c_arc has joined #bitcoin-core-dev

01:33 c_arc has joined #bitcoin-core-dev

01:41 c_arc has joined #bitcoin-core-dev

01:45 jespada has joined #bitcoin-core-dev

01:49 c_arc has joined #bitcoin-core-dev

01:53 c_arc has joined #bitcoin-core-dev

01:57 c_arc has joined #bitcoin-core-dev

02:01 c_arc has joined #bitcoin-core-dev

02:07 c_arc has joined #bitcoin-core-dev

02:15 c_arc has joined #bitcoin-core-dev

02:20 c_arc has joined #bitcoin-core-dev

02:24 c_arc has joined #bitcoin-core-dev

02:28 c_arc has joined #bitcoin-core-dev

02:31 jespada has quit [Ping timeout: 252 seconds]

02:35 AaronvanW has joined #bitcoin-core-dev

02:42 c_arc has joined #bitcoin-core-dev

02:48 c_arc has joined #bitcoin-core-dev

02:54 c_arc has joined #bitcoin-core-dev

02:58 c_arc has joined #bitcoin-core-dev

03:02 c_arc has joined #bitcoin-core-dev

03:06 c_arc has joined #bitcoin-core-dev

03:10 c_arc has joined #bitcoin-core-dev

03:16 c_arc has joined #bitcoin-core-dev

03:20 c_arc has joined #bitcoin-core-dev

03:22 Kaizen_Kintsugi has quit [Remote host closed the connection]

03:23 Kaizen_Kintsugi has joined #bitcoin-core-dev

03:27 c_arc has joined #bitcoin-core-dev

03:28 Kaizen_Kintsugi has quit [Ping timeout: 252 seconds]

03:32 c_arc has joined #bitcoin-core-dev

03:32 AaronvanW has quit [Remote host closed the connection]

03:36 c_arc has joined #bitcoin-core-dev

03:40 c_arc has joined #bitcoin-core-dev

03:44 <Davidbak> in `randomenv.cpp` a `memory_cleanse` is done (https://github.com/bitcoin/bitcoin/blame/master/src/randomenv.cpp#L92) for a vector full of Windows performance data. Why? (It doesn't seem security related to me, so I'm wondering about the philosophy. Note that at line 87 just above the vector is resized without cleansing the soon-to-be-freed data.)

03:50 c_arc has joined #bitcoin-core-dev

03:54 Kaizen_Kintsugi has joined #bitcoin-core-dev

03:58 c_arc has joined #bitcoin-core-dev

03:59 Kaizen_Kintsugi has quit [Ping timeout: 252 seconds]

04:01 cmirror has quit [Remote host closed the connection]

04:01 cmirror has joined #bitcoin-core-dev

04:02 AaronvanW has joined #bitcoin-core-dev

04:06 c_arc has joined #bitcoin-core-dev

04:08 <Davidbak> (it could, if needed, be using the `zero_after_free_allocator`)

04:12 morcos_ has joined #bitcoin-core-dev

04:14 morcos has quit [Ping timeout: 276 seconds]

04:14 morcos_ is now known as morcos

04:18 c_arc has joined #bitcoin-core-dev

04:18 <jeremyrubin> davidbak: i think we seed our RNG with that data

04:18 <jeremyrubin> so if an adversary can learn what we seed the rng with that would be bad

04:19 <Davidbak> well, it is one of many such seed input - and in fact it comes from the os - but if that's the philosophy then I do understand it.

04:22 <Davidbak> now, my question would be: suppose I contribute a (tested) two line fix that 1) makes the vector's allocator be zero-after-free and 2) removes the then-unnecessary memory_cleanse call. Would this be something worth doing in the sense that reviewers would look at it? (I am brand new to the process, and everything I've read - the really good docs and external blog post on how to contribute - emphasize making your PRs

04:22 <Davidbak> important (as well as correct, etc. etc.) so that it doesn't burden the scarce resource of reviewers. So what would be the likelihood this change would be considered interesting?

04:23 <Davidbak> (for me: it might be a "good first issue"? that's what I'm actually trying to find: a _good first issue_!)

04:26 <Davidbak> BTW - I'm also looking to contribute to reviews. But at this stage - I find it difficult for two reasons. First: some of the active recent reviews are very complex refactorings that have been in progress for a long time. I'm not ready for that on this projects

04:26 <Davidbak> Second: a lot of the recent active PRs are in the build system. I'm _definitely_ not ready for that on this project.

04:27 <Davidbak> It's hard to tell (for me) what are the reviews that would be useful to look at because I have the capability. I'm not ready (no reputation at the project) to do any concept ack/nak - so I'm just looking for code to read and test.

04:31 c_arc has joined #bitcoin-core-dev

04:33 <_aj_> davidbak: for me, the best "first issues" are always adding more test coverage. touching anything security related seems a very high risk way to get started

04:33 ghostkeeper has joined #bitcoin-core-dev

04:33 <_aj_> davidbak: there's fuzz (c++/libfuzz), unit (c++) and functional (python) testing code, all of which have plenty of room to cover more things, imho

04:35 <_aj_> davidbak: if you find an interesting PR that you understand, adding tests for it is both helpful to review and usually helpful on its own merits too ("hi, i added some tests here <link>, feel free to grab the commit")

04:37 <Davidbak> ah, I haven't worked in an environment where you can add commits (even tests) to something someone else is actively working on - i.e., authored, opened the PR.

04:37 <Davidbak> that's acceptable, for tests? (perhaps if coordinated in PR comments, or how?)

04:38 <Davidbak> oh wait, i see now - I add the commit in my own fork and point to it ... ok, that I get

04:38 <_aj_> yeah, exactly

04:38 <Davidbak> haven't done it before but sounds totally reasonable ... and tests, I do get that. ok!

04:38 ghostkeeper has quit [Ping timeout: 265 seconds]

04:38 <_aj_> they might pull the commit from your branch into their PR, or you could PR it later separately, or it could just have been something helpful for review

04:39 <_aj_> best is if your new tests actually find some bugs, of course

04:39 <Davidbak> _aj_ - is there another user name I could correlate your nickname with? I've just read some blog posts by a guy with initials AJ for example ...

04:39 <Davidbak> actually JA

04:39 <_aj_> i'm ajtowns on social medias

04:40 <Davidbak> ok

04:40 <Davidbak> yep there you are on github's hit parade, thanks

04:42 Kaizen_Kintsugi has joined #bitcoin-core-dev

04:42 promag_ has joined #bitcoin-core-dev

04:44 <Davidbak> btw, to slightly change the subject, but stay on tests: the project guidelines insist that every commit in a PR be independently buildable/testable correctly. So that means the test goes in the same commit as the bug fix, or a subsequent one. Now, a typical test pattern is to write the test first - see it fail - and then do the fix. With the approach here it is up to the individual PR reviewers to stage that on their

04:44 <Davidbak> local machines themselves, correct? (Or is there another way?)

04:45 promag has quit [Ping timeout: 252 seconds]

04:45 <Davidbak> (by the way - I am _not_ taking a position here on TDD - that's NOT what I mean by write first see it fail. I'm talking about verification that a bug fix PR really fixed a _bug_.

04:46 Kaizen_Kintsugi has quit [Ping timeout: 245 seconds]

04:48 <_aj_> davidbak: you can still do things that way, just don't have separate commits for the test and the change. i like to commit the test first and have it succeed for the old behaviour, then change the test and code, so that it still succeeds and the commit documents the effect the code change has on the tests

04:48 <_aj_> davidbak: you can also do a "git rebase -i" to reorder the commits in your own tree and check the test fails without the commit

04:49 <Davidbak> oh i know i can do that _locally_ i was wondering how to make it easier for the _other_ reviewers

04:49 <Davidbak> ah! hadn't thought of that! that's probably what people who are interested do. thanks!

04:52 <_aj_> oh #21496 is up for grabs, and was already mostly done

04:52 <gribble> https://github.com/bitcoin/bitcoin/issues/21496 | fuzz: execute each file in dir without fuzz engine by AnthonyRonning · Pull Request #21496 · bitcoin/bitcoin · GitHub

04:54 <Davidbak> closed though, how should I interpret that?

04:54 <sipa> it's closed, because it's a PR, not an issue

04:54 <_aj_> "up for grabs" tag means that it was closed due to no activity but still seemed like a good idea if someone else want to take the lead

04:55 AaronvanW has quit [Remote host closed the connection]

04:57 <Davidbak> plus #22763 seems to address it to, that's still open

04:57 <gribble> https://github.com/bitcoin/bitcoin/issues/22763 | fuzz: execute each file in dir without fuzz engine by prakash1512 · Pull Request #22763 · bitcoin/bitcoin · GitHub

04:58 <_aj_> oh yay!

05:01 <Davidbak> i'll look at "good first issues" again - got a bit scared off of it earlier in the week when I found one, looked at it, discovered two prs had attacked it months ago, gone nowhere, one with a comment that said "i don't like this idea anymore", and I mentioned it here and marcofalke agreed: not good first issue and removed the tag. So ... I was looking elsewhere ... but now i'll look at reaosnably active PRs to see about

05:01 <Davidbak> test coverage since that is something I can do at this stage. thanks a lot!

05:04 <Davidbak> (P.S. still wondering about my question above regarding `double-conversion` library for windows, don't want that to get lost in the chat log)

05:06 <fanquake> davidbak: remove it and try compiling

05:06 <fanquake> iirc it's used by qt

05:06 <Davidbak> yeah that was going to be my first step after asking about it ... so I'll do that and report back ...

05:10 c_arc has joined #bitcoin-core-dev

05:18 c_arc has joined #bitcoin-core-dev

05:25 c_arc has joined #bitcoin-core-dev

05:25 AaronvanW has joined #bitcoin-core-dev

05:30 c_arc has joined #bitcoin-core-dev

05:30 AaronvanW has quit [Ping timeout: 252 seconds]

05:34 c_arc has joined #bitcoin-core-dev

05:39 c_arc has joined #bitcoin-core-dev

05:43 c_arc has joined #bitcoin-core-dev

05:43 AaronvanW has joined #bitcoin-core-dev

05:51 c_arc has joined #bitcoin-core-dev

05:51 Kiminuo has joined #bitcoin-core-dev

05:52 <Kiminuo> Hi, what do the hashes here https://github.com/bitcoin/bitcoin/pull/22937#issuecomment-943439492 actually mean? Is there like a one sentence explanation of that?

05:54 <fanquake> Kiminuo it's the sha256 sum of the file

05:55 <fanquake> i.e the sha256sum of *-win64-setup-unsigned.exe for commit 5b7210c8745d9572fe94620f848d4ee1304c91a7 is 73d5ba8460a6785100524b5d7332639c43cc3f61f536e7fa88f64acb0a37d7ad

05:59 c_arc has joined #bitcoin-core-dev

05:59 smartin has joined #bitcoin-core-dev

05:59 AaronvanW has quit [Ping timeout: 252 seconds]

06:03 c_arc has joined #bitcoin-core-dev

06:08 c_arc has joined #bitcoin-core-dev

06:10 dviola has quit [Quit: WeeChat 3.3]

06:12 dviola has joined #bitcoin-core-dev

06:16 AaronvanW has joined #bitcoin-core-dev

06:18 Kaizen_Kintsugi has joined #bitcoin-core-dev

06:19 ghostkeeper has joined #bitcoin-core-dev

06:23 c_arc has joined #bitcoin-core-dev

06:24 ghostkeeper has quit [Ping timeout: 268 seconds]

06:24 goatpig has joined #bitcoin-core-dev

06:25 Kaizen_Kintsugi has quit [Ping timeout: 252 seconds]

06:29 c_arc has joined #bitcoin-core-dev

06:32 mekster669 has joined #bitcoin-core-dev

06:32 fanquake has quit [Ping timeout: 245 seconds]

06:32 fanquake has joined #bitcoin-core-dev

06:34 gribble has quit [Ping timeout: 245 seconds]

06:34 panpan has quit [Ping timeout: 245 seconds]

06:34 mekster66 has quit [Ping timeout: 245 seconds]

06:34 jnewbery has quit [Ping timeout: 245 seconds]

06:34 mekster669 is now known as mekster66

06:35 panpan has joined #bitcoin-core-dev

06:36 jnewbery has joined #bitcoin-core-dev

06:40 c_arc has joined #bitcoin-core-dev

06:44 c_arc has joined #bitcoin-core-dev

06:48 c_arc has joined #bitcoin-core-dev

06:57 <Kiminuo> fanquake: So the hash changed and the file is different. Should it be the same? Or are you interested in the hash?

06:57 <Kiminuo> *Or are you interested in the *new* hash?

06:58 <fanquake> I'm not sure what you are asking. Given either column is building a different commit. You'd expect the hashes to be different

07:00 <_aj_> FUZZ=rpc src/test/fuzz/fuzz </dev/null fails unconditionally on master for me (enumeratesigners rpc is missing from rpc.cpp). shouldn't some fuzz thing somewhere already be picking this up?

07:02 <Kiminuo> fanquake: Right. So the new hash can be verified by other people that they obtain the same hash, right? That's the idea behind GUIX. Is it not?

07:04 Kaizen_Kintsugi has joined #bitcoin-core-dev

07:04 <fanquake> Kiminuo: sure, others could build the same commits and see if their results match. The point of the bot is also just to check that the builds succed, and provide build logs to diff, and binaries you can test/compare.

07:05 <Kiminuo> Ah, I see. Thanks!

07:07 <fanquake> _aj_: odd

07:07 jarthur has joined #bitcoin-core-dev

07:09 Kaizen_Kintsugi has quit [Ping timeout: 252 seconds]

07:13 c_arc has joined #bitcoin-core-dev

07:19 c_arc has joined #bitcoin-core-dev

07:23 earnestly has joined #bitcoin-core-dev

07:27 c_arc has joined #bitcoin-core-dev

07:31 c_arc has joined #bitcoin-core-dev

07:33 Victorsueca has quit [Read error: Connection reset by peer]

07:44 c_arc has joined #bitcoin-core-dev

07:52 c_arc has joined #bitcoin-core-dev

08:01 c_arc has joined #bitcoin-core-dev

08:02 bitcoin-git has joined #bitcoin-core-dev

08:02 <bitcoin-git> bitcoin/master b39a477 Russell Yanofsky: refactor: Add fs::PathToString, fs::PathFromString, u8string, u8path funct...

08:02 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6419bdfeb130...1884ce2f4c2c

08:02 <bitcoin-git> bitcoin/master 6544ea5 Russell Yanofsky: refactor: Block unsafe fs::path std::string conversion calls

08:02 <bitcoin-git> bitcoin/master 1884ce2 W. J. van der Laan: Merge bitcoin/bitcoin#22937: refactor: Forbid calling unsafe fs::path(std:...

08:02 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

08:02 bitcoin-git has joined #bitcoin-core-dev

08:02 <bitcoin-git> [bitcoin] laanwj merged pull request #22937: refactor: Forbid calling unsafe fs::path(std::string) constructor and fs::path::string() method (master...pr/u8path) https://github.com/bitcoin/bitcoin/pull/22937

08:02 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

08:04 jarthur has quit [Quit: jarthur]

08:10 c_arc has joined #bitcoin-core-dev

08:12 Guest22 has joined #bitcoin-core-dev

08:15 Guest4411 has joined #bitcoin-core-dev

08:16 Guest4411 has quit [Client Quit]

08:16 Guest22 has quit [Client Quit]

08:23 c_arc has joined #bitcoin-core-dev

08:27 c_arc has joined #bitcoin-core-dev

08:34 c_arc has joined #bitcoin-core-dev

08:34 AaronvanW has quit [Remote host closed the connection]

08:38 yanmaani has quit [Ping timeout: 276 seconds]

08:39 kinlo has quit [Ping timeout: 264 seconds]

08:41 yanmaani has joined #bitcoin-core-dev

08:47 c_arc has joined #bitcoin-core-dev

08:49 kinlo has joined #bitcoin-core-dev

08:53 Kiminuo has quit [Quit: Client closed]

09:04 c_arc has joined #bitcoin-core-dev

09:05 Kaizen_Kintsugi has joined #bitcoin-core-dev

09:05 AaronvanW has joined #bitcoin-core-dev

09:09 bitcoin-git has joined #bitcoin-core-dev

09:09 <bitcoin-git> [bitcoin] darosior opened pull request #23284: doc: update release notes for 22539 (master...22539_releasenotes_update) https://github.com/bitcoin/bitcoin/pull/23284

09:09 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

09:09 Kaizen_Kintsugi has quit [Ping timeout: 252 seconds]

09:13 c_arc has joined #bitcoin-core-dev

09:17 c_arc has joined #bitcoin-core-dev

09:21 morcos has quit [Remote host closed the connection]

09:21 morcos has joined #bitcoin-core-dev

09:26 c_arc has joined #bitcoin-core-dev

09:30 c_arc has joined #bitcoin-core-dev

09:34 c_arc has joined #bitcoin-core-dev

09:38 c_arc has joined #bitcoin-core-dev

09:38 AaronvanW has quit [Ping timeout: 245 seconds]

09:43 ghostkeeper has quit [Ping timeout: 268 seconds]

09:57 c_arc has joined #bitcoin-core-dev

10:09 c_arc has joined #bitcoin-core-dev

10:17 c_arc has joined #bitcoin-core-dev

10:28 c_arc has joined #bitcoin-core-dev

10:32 jonasschnelli_ is now known as jonasschnelli

10:36 c_arc has joined #bitcoin-core-dev

10:38 yanmaani has quit [Ping timeout: 276 seconds]

10:45 c_arc has joined #bitcoin-core-dev

10:51 c_arc has joined #bitcoin-core-dev

10:51 yanmaani has joined #bitcoin-core-dev

10:56 c_arc has joined #bitcoin-core-dev

11:00 c_arc has joined #bitcoin-core-dev

11:06 Kaizen_Kintsugi has joined #bitcoin-core-dev

11:07 morcos_ has joined #bitcoin-core-dev

11:07 morcos has quit [Quit: ZNC 1.8.2+deb1+bionic2 - https://znc.in]

11:07 morcos_ is now known as morcos

11:10 Kaizen_Kintsugi has quit [Ping timeout: 252 seconds]

11:16 c_arc has joined #bitcoin-core-dev

11:20 c_arc has joined #bitcoin-core-dev

11:25 c_arc has joined #bitcoin-core-dev

11:29 c_arc has joined #bitcoin-core-dev

11:36 AaronvanW has joined #bitcoin-core-dev

11:40 c_arc has joined #bitcoin-core-dev

11:45 c_arc has joined #bitcoin-core-dev

11:47 jtrag has quit [Quit: <----- is PODAK (Passed out drunk at keyboard), and he has somehow managed to quit/disconnect...]

11:51 c_arc has joined #bitcoin-core-dev

11:58 c_arc has joined #bitcoin-core-dev

12:03 c_arc has joined #bitcoin-core-dev

12:03 bitdex_ has quit [Quit: = ""]

12:07 c_arc has joined #bitcoin-core-dev

12:10 AaronvanW has quit [Ping timeout: 265 seconds]

12:21 c_arc has joined #bitcoin-core-dev

12:21 mikehu44 has joined #bitcoin-core-dev

12:23 bitcoin-git has joined #bitcoin-core-dev

12:23 <bitcoin-git> bitcoin/master 5307351 Antoine Poinsot: doc: update release notes for 22539

12:23 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1884ce2f4c2c...ce19f4fd37c8

12:23 <bitcoin-git> bitcoin/master ce19f4f MarcoFalke: Merge bitcoin/bitcoin#23284: doc: update release notes for 22539

12:23 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

12:23 bitcoin-git has joined #bitcoin-core-dev

12:23 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #23284: doc: update release notes for 22539 (master...22539_releasenotes_update) https://github.com/bitcoin/bitcoin/pull/23284

12:23 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

12:27 c_arc has joined #bitcoin-core-dev

12:28 jtrag has joined #bitcoin-core-dev

12:31 Kaizen_Kintsugi has joined #bitcoin-core-dev

12:35 c_arc has joined #bitcoin-core-dev

12:35 Guyver2 has joined #bitcoin-core-dev

12:43 c_arc has joined #bitcoin-core-dev

12:45 goatpig has quit [Read error: Connection reset by peer]

12:48 jespada has joined #bitcoin-core-dev

12:52 bitcoin-git has joined #bitcoin-core-dev

12:52 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ce19f4fd37c8...4dbba3bac70f

12:52 <bitcoin-git> bitcoin/master d873db7 Antoine Poinsot: policy: document we intentionally don't lower the dust threshold for Tapro...

12:52 <bitcoin-git> bitcoin/master 4dbba3b W. J. van der Laan: Merge bitcoin/bitcoin#22863: policy: document dust threshold for Taproot o...

12:52 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

12:52 bitcoin-git has joined #bitcoin-core-dev

12:52 <bitcoin-git> [bitcoin] laanwj merged pull request #22863: policy: document dust threshold for Taproot outputs (master...dust_threshold_doc) https://github.com/bitcoin/bitcoin/pull/22863

12:52 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

12:57 c_arc has joined #bitcoin-core-dev

12:59 tla2k21 has quit [Ping timeout: 276 seconds]

13:03 c_arc has joined #bitcoin-core-dev

13:07 ghostkeeper has joined #bitcoin-core-dev

13:11 tla2k21 has joined #bitcoin-core-dev

13:12 ghostkeeper has quit [Ping timeout: 240 seconds]

13:13 ghostkeeper has joined #bitcoin-core-dev

13:13 bitcoin-git has joined #bitcoin-core-dev

13:13 <bitcoin-git> [bitcoin] hebasto opened pull request #23286: ci, refactor: Disable binaries for Android task explicitly (master...211015-android) https://github.com/bitcoin/bitcoin/pull/23286

13:13 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

13:18 c_arc has joined #bitcoin-core-dev

13:25 c_arc has joined #bitcoin-core-dev

13:27 dhruv has quit [Quit: leaving]

13:28 dhruv has joined #bitcoin-core-dev

13:32 c_arc has joined #bitcoin-core-dev

13:36 c_arc has joined #bitcoin-core-dev

13:53 c_arc has joined #bitcoin-core-dev

13:56 Kaizen_Kintsugi has quit [Remote host closed the connection]

13:56 Kaizen_Kintsugi has joined #bitcoin-core-dev

14:01 Kaizen_Kintsugi has quit [Ping timeout: 252 seconds]

14:05 c_arc has joined #bitcoin-core-dev

14:07 AaronvanW has joined #bitcoin-core-dev

14:18 Kaizen_Kintsugi has joined #bitcoin-core-dev

14:20 bitcoin-git has joined #bitcoin-core-dev

14:20 <bitcoin-git> [bitcoin] theStack opened pull request #23287: test: get and decode tx with a single `gettransaction` RPC call (master...202110-test-fetch_and_decode_tx_with_single_RPC_call) https://github.com/bitcoin/bitcoin/pull/23287

14:20 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

14:27 Talkless has joined #bitcoin-core-dev

14:31 c_arc has joined #bitcoin-core-dev

14:37 c_arc has joined #bitcoin-core-dev

14:39 AaronvanW has quit [Ping timeout: 246 seconds]

14:46 Talkless has quit [Quit: Konversation terminated!]

14:51 c_arc has joined #bitcoin-core-dev

14:52 gribble has joined #bitcoin-core-dev

14:59 c_arc has joined #bitcoin-core-dev

15:02 mikehu44 has quit [Ping timeout: 265 seconds]

15:08 mikehu44 has joined #bitcoin-core-dev

15:12 c_arc has joined #bitcoin-core-dev

15:15 mikehu44 has quit [Ping timeout: 252 seconds]

15:15 mikehu44 has joined #bitcoin-core-dev

15:16 prayank has joined #bitcoin-core-dev

15:18 <prayank> davidbak: if you are looking for a "good first review" #23268 is very easy to review and test. Just added dots in domains which fixes an issue and improves security. You can read the details in issue created by practicalswift, understand issue, try things and comment in pull request.

15:18 <gribble> https://github.com/bitcoin/bitcoin/issues/23268 | p2p: Use absolute FQDN for DNS seed domains by prayank23 · Pull Request #23268 · bitcoin/bitcoin · GitHub

15:23 c_arc has joined #bitcoin-core-dev

15:26 yanmaani has joined #bitcoin-core-dev

15:35 c_arc has joined #bitcoin-core-dev

15:42 c_arc has joined #bitcoin-core-dev

15:46 c_arc has joined #bitcoin-core-dev

15:49 yanmaani has quit [Remote host closed the connection]

15:52 yanmaani has joined #bitcoin-core-dev

15:56 <andytoshi> in this line https://github.com/bitcoin/bitcoin/blob/master/src/consensus/tx_verify.cpp#L164 we are add-assigning a size_t to an int64_t, which ubsan flags as an integer sign change

15:56 <andytoshi> should i add this as a suppression or change the code?

15:57 <andytoshi> there is no way this could possibly overflow in an earthly blockchain

15:59 <andytoshi> it looks like every assignment to this variable is from an unsigned source, i think i should just change it to uint64_t from int64_t

16:04 c_arc has joined #bitcoin-core-dev

16:06 bitcoin-git has joined #bitcoin-core-dev

16:06 <bitcoin-git> bitcoin/master 67bb6b5 Hennadii Stepanov: ci, refactor: Disable binaries for Android task explicitly

16:06 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4dbba3bac70f...e504e9a8ed50

16:06 <bitcoin-git> bitcoin/master e504e9a MarcoFalke: Merge bitcoin/bitcoin#23286: ci, refactor: Disable binaries for Android ta...

16:06 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

16:06 jtrag has quit [Quit: <----- is PODAK (Passed out drunk at keyboard), and he has somehow managed to quit/disconnect...]

16:06 bitcoin-git has joined #bitcoin-core-dev

16:06 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #23286: ci, refactor: Disable binaries for Android task explicitly (master...211015-android) https://github.com/bitcoin/bitcoin/pull/23286

16:06 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

16:08 <andytoshi> OTOH this originates in https://github.com/bitcoin/bitcoin/pull/8149/commits/2b1f6f9ccf36f1e0a2c9d99154e1642f796d7c2b where it looks like sipa was deliberately converting sigop counts from unsigned int to int64_ts

16:10 bitcoin-git has joined #bitcoin-core-dev

16:10 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e504e9a8ed50...02ccf1086ea0

16:10 <bitcoin-git> bitcoin/master 02ccf10 MarcoFalke: Merge bitcoin/bitcoin#23220: ci: Reduce Windows memory for faster scheduli...

16:10 <bitcoin-git> bitcoin/master 146831f MarcoFalke: ci: Reduce Windows memory for faster scheduling

16:10 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

16:10 <sipa> andytoshi: hmm, i don't remember why

16:11 bitcoin-git has joined #bitcoin-core-dev

16:11 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #23220: ci: Reduce Windows memory for faster scheduling (master...211007-mem1) https://github.com/bitcoin/bitcoin/pull/23220

16:11 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

16:15 c_arc has joined #bitcoin-core-dev

16:16 <andytoshi> i imagine it was just "this should be bigger than 32 bits on all systems, and also signed ints with no danger of overflowing are less footgunny than unsigned ones"

16:20 c_arc has joined #bitcoin-core-dev

16:23 sipsorcery has joined #bitcoin-core-dev

16:24 <sipa> quite possibly

16:28 c_arc has joined #bitcoin-core-dev

16:37 AaronvanW has joined #bitcoin-core-dev

16:45 c_arc has joined #bitcoin-core-dev

16:45 prayank has quit [Quit: irc thread exit]

16:50 c_arc has joined #bitcoin-core-dev

16:52 <Davidbak> @prayank - thanks, will look at that

16:56 c_arc has joined #bitcoin-core-dev

17:01 c_arc has joined #bitcoin-core-dev

17:08 c_arc has joined #bitcoin-core-dev

17:10 AaronvanW has quit [Ping timeout: 264 seconds]

17:20 c_arc has joined #bitcoin-core-dev

17:24 c_arc has joined #bitcoin-core-dev

17:28 c_arc has joined #bitcoin-core-dev

17:35 c_arc has joined #bitcoin-core-dev

17:42 sipsorcery has quit [Ping timeout: 265 seconds]

17:44 sipsorcery has joined #bitcoin-core-dev

17:49 c_arc has joined #bitcoin-core-dev

17:56 lukedashjr has joined #bitcoin-core-dev

17:59 luke-jr has quit [Ping timeout: 265 seconds]

17:59 lukedashjr is now known as luke-jr

18:03 c_arc has joined #bitcoin-core-dev

18:08 c_arc has joined #bitcoin-core-dev

18:16 c_arc has joined #bitcoin-core-dev

18:21 c_arc has joined #bitcoin-core-dev

18:27 Kaizen_Kintsugi has quit [Remote host closed the connection]

18:27 KaizenKintsugi has joined #bitcoin-core-dev

18:32 c_arc has joined #bitcoin-core-dev

18:36 c_arc has joined #bitcoin-core-dev

18:36 Guyver2 has left #bitcoin-core-dev [Closing Window]

18:36 roconnor has joined #bitcoin-core-dev

18:41 c_arc has joined #bitcoin-core-dev

18:45 c_arc has joined #bitcoin-core-dev

18:49 c_arc has joined #bitcoin-core-dev

18:53 c_arc has joined #bitcoin-core-dev

18:57 c_arc has joined #bitcoin-core-dev

19:04 c_arc has joined #bitcoin-core-dev

19:07 AaronvanW has joined #bitcoin-core-dev

19:11 rex4539 has joined #bitcoin-core-dev

19:16 ghostkeeper has quit []

19:21 c_arc has joined #bitcoin-core-dev

19:25 c_arc has joined #bitcoin-core-dev

19:29 bitcoin-git has joined #bitcoin-core-dev

19:29 <bitcoin-git> [bitcoin] achow101 opened pull request #23288: tests: remove usage of LegacyScriptPubKeyMan from some wallet tests (master...rm-testWallet-tests) https://github.com/bitcoin/bitcoin/pull/23288

19:29 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

19:33 c_arc has joined #bitcoin-core-dev

19:34 rex4539 has quit []

19:38 c_arc has joined #bitcoin-core-dev

19:40 AaronvanW has quit [Ping timeout: 260 seconds]

19:40 <yanmaani> Is there a way to totally clean out the bitcoin repository, more than doing make clean? mk clean still leaves some stuff, like ./configure

19:40 <yanmaani> short of rm -rf * && git clone, that is

19:43 <roconnor> make distclean may do what you want.

19:43 <roconnor> maybe make distclean-am

19:44 rex4539 has joined #bitcoin-core-dev

19:47 <yanmaani> roconnor: will that keep my changes to the source?

19:47 <sipa> git clean -dfx

19:47 <sipa> will delete all non-repository files

19:47 <sipa> it will not touch changes you've made to repository files

19:48 <sipa> (but still, commit them anyway)

19:48 rex4539 has quit [Client Quit]

19:52 c_arc has joined #bitcoin-core-dev

19:54 rex4539 has joined #bitcoin-core-dev

19:58 c_arc has joined #bitcoin-core-dev

19:59 <yanmaani> thanks

20:03 c_arc has joined #bitcoin-core-dev

20:03 Talkless has joined #bitcoin-core-dev

20:04 rex4539 has quit []

20:05 rex4539 has joined #bitcoin-core-dev

20:06 jarthur has joined #bitcoin-core-dev

20:10 rex4539 has quit [Remote host closed the connection]

20:11 rex4539 has joined #bitcoin-core-dev

20:11 rex4539 has quit [Client Quit]

20:16 c_arc has joined #bitcoin-core-dev

20:19 <yanmaani> from a fresh install, I can't build bitcoin core. I get the error:

20:19 <yanmaani> undefined reference to `__muloti4'

20:19 <yanmaani> compiling with clang. no sanitizers enabled.

20:19 <yanmaani> if I force it to use libc++, I get errors about boost::filesystem instead.

20:20 <yanmaani> is this a known issue?

20:21 <yanmaani> or is there something off with my build system?

20:21 <sipa> what kind of system?

20:24 <yanmaani> sipa: debian, clang, everything's pretty normal I think

20:25 <sipa> clean install?

20:25 <yanmaani> of the system?

20:26 <sipa> yes

20:26 <yanmaani> no this is my development machine

20:27 <yanmaani> I mean I suppose there must be something wrong, if it's not a known issue and bitcoin builds normally for everyone else.

20:31 c_arc has joined #bitcoin-core-dev

20:35 c_arc has joined #bitcoin-core-dev

20:39 <Davidbak> are you _sure_ sanitizers are off? this stackexchange q&a from 3 years ago - https://stackoverflow.com/questions/49793632/clang-fsanitize-undefined-with-128-integer-operations-undefined-reference-to - says it happens precisely with clang+libgcc+sanitizer. the linked bug says it still happens in 2021. the answer suggests linking with the "compiler-rt" runtime library instead (whatever that is)

20:45 <yanmaani> davidbak: looking in the makefile etc I find nothing. Are they on by default, is it possible to explicitly disable them?

20:47 <yanmaani> let's try with "compiler-rt". though I suspect this is just some stupid error in a totally unrelated thing

20:48 <Davidbak> i know nothing more than what it says in the docs at https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#sanitizers which suggests they're normally off.

20:48 smartin has quit [Quit: smartin]

20:53 c_arc has joined #bitcoin-core-dev

20:58 c_arc has joined #bitcoin-core-dev

21:02 c_arc has joined #bitcoin-core-dev

21:08 c_arc has joined #bitcoin-core-dev

21:13 yanmaani has quit [Ping timeout: 276 seconds]

21:15 yanmaani has joined #bitcoin-core-dev

21:19 c_arc has joined #bitcoin-core-dev

21:24 c_arc has joined #bitcoin-core-dev

21:28 c_arc has joined #bitcoin-core-dev

21:33 c_arc has joined #bitcoin-core-dev

21:37 AaronvanW has joined #bitcoin-core-dev

21:43 jtrag has joined #bitcoin-core-dev

21:46 bitcoin-git has joined #bitcoin-core-dev

21:46 <bitcoin-git> [bitcoin] jamesob opened pull request #23289: test: add stress tests for initialization (master...2021-10-stress-test-init) https://github.com/bitcoin/bitcoin/pull/23289

21:46 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

21:51 c_arc has joined #bitcoin-core-dev

21:55 c_arc has joined #bitcoin-core-dev

21:59 c_arc has joined #bitcoin-core-dev

22:02 gnaf has joined #bitcoin-core-dev

22:10 c_arc has joined #bitcoin-core-dev

22:11 AaronvanW has quit [Ping timeout: 264 seconds]

22:17 c_arc has joined #bitcoin-core-dev

22:18 bitdex has joined #bitcoin-core-dev

22:21 sipsorcery has quit [Ping timeout: 268 seconds]

22:27 c_arc has joined #bitcoin-core-dev

22:31 KaizenKintsugi has quit [Remote host closed the connection]

22:31 Kaizen_Kintsugi has joined #bitcoin-core-dev

22:32 AaronvanW has joined #bitcoin-core-dev

22:37 c_arc has joined #bitcoin-core-dev

22:37 earnestly has quit [Read error: Connection reset by peer]

22:41 c_arc has joined #bitcoin-core-dev

22:46 c_arc has joined #bitcoin-core-dev

22:54 c_arc has joined #bitcoin-core-dev

22:58 c_arc has joined #bitcoin-core-dev

22:58 sipsorcery has joined #bitcoin-core-dev

23:08 c_arc has joined #bitcoin-core-dev

23:12 c_arc has joined #bitcoin-core-dev

23:16 c_arc has joined #bitcoin-core-dev

23:22 belcher has quit [Ping timeout: 265 seconds]

23:28 c_arc has joined #bitcoin-core-dev

23:30 Kaizen_Kintsugi has quit [Remote host closed the connection]

23:31 Kaizen_Kintsugi has joined #bitcoin-core-dev

23:34 Kaizen_Kintsugi has quit [Remote host closed the connection]

23:35 sipsorcery has quit [Ping timeout: 252 seconds]

23:35 belcher has joined #bitcoin-core-dev

23:42 c_arc has joined #bitcoin-core-dev

23:46 c_arc has joined #bitcoin-core-dev

23:51 c_arc has joined #bitcoin-core-dev

23:55 c_arc has joined #bitcoin-core-dev

23:59 c_arc has joined #bitcoin-core-dev