bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<fanquake>
achow101: which architecture? newfstatat seems to be the other name for fstatat64
<achow101>
x86_64
<fanquake>
We can add an exception for that syscall to our list. However I'm wondering if this PR was merged without enough testing, and is just going to turn into a muddle of adding exceptions for a while. It has broken the Guix build as well.
<achow101>
I can run with --nosandbox, but that's kind of annoying to type all the time
<fanquake>
hold on. we already have newfstatat in our list of allowed syscalls..
<fanquake>
ah I see the issue. Will open a PR for testing
jamesob has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake opened pull request #23179: sandbox: add newfstatat to allowed filesystem syscalls (master...add_newfstatat_to_syscall_exceptions) https://github.com/bitcoin/bitcoin/pull/23179
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
sdfgsdfgDropBear has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<fanquake>
achow101: thanks for playing syscall whack-a-mole
<achow101>
feels like this should've been done before merging...
<sipa>
how did CI not catch this
<sipa>
?
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<achow101>
no idea
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
sdfgsdfgDropBear has quit [Quit: sdfgsdfgDropBear]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
kexkey has quit [Read error: Connection reset by peer]
kexkey has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
<phantomcircuit>
sipa, also in general bitcoind is the thing you're trying to secure with sandboxing, not the other way around
fdov1 has quit [Ping timeout: 250 seconds]
c_arc has joined #bitcoin-core-dev
fdov1 has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
sdfgsdfgDropBear has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
bitdex has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] PastaPastaPasta opened pull request #23181: refactor: remove references to deprecated values under std::allocator (master...btc-allocator) https://github.com/bitcoin/bitcoin/pull/23181
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Guest58 has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
Guest58 has quit [Quit: Client closed]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake opened pull request #23182: build: add python3.10 alias to AC_PATH_PROGS call in configure (master...python_3_10_configure) https://github.com/bitcoin/bitcoin/pull/23182
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
prayank has joined #bitcoin-core-dev
<prayank>
Why are my comments disabled on PR #23121 ?
<achow101>
do you see that on other issues or prs? what about other repos?
<prayank>
No it's only for this PR
<prayank>
Everything else works fine
<achow101>
that's really weird
<prayank>
No problem. I am testing few things and will share the review comments elsewhere if I can't write here.
prayank has quit [Quit: irc thread exit]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<meshcollider>
prayank: strange, are you able to comment via the "Review" button on the commits / files changed tabs?
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
sdfgsdfgDropBear has quit [Quit: sdfgsdfgDropBear]
sdfgsdfgDropBear has joined #bitcoin-core-dev
prayank has joined #bitcoin-core-dev
<prayank>
meshcollider: that might work. I can see "review changes" enabled. Will try in sometime.
c_arc has joined #bitcoin-core-dev
sdfgsdfgDropBear has quit [Quit: sdfgsdfgDropBear]
c_arc has joined #bitcoin-core-dev
RomanZ has quit [Quit: Leaving]
sdfgsdfgDropBear has joined #bitcoin-core-dev
sdfgsdfgDropBear has quit [Client Quit]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<laanwj>
fanquake: maybe enabling it by default for guix and the unit tests was too much, on the other hand, trial and error is the only way to find out what is used, unfortunately, so it helps doing this faster
<laanwj>
sipa: i think the reason for this to happen is that we link libc dynamically, and new libcs can always decide to start using new syscalls...
c_arc has joined #bitcoin-core-dev
gnaf has quit [Quit: Konversation terminated!]
<vasild>
laanwj: I am using cjdns on freebsd from ports. There is a useful script peerStats used to check which nodes are you connected to which is not installed by the port, so I call it via /usr/ports/net/cjdns/work/cjdns-cjdns-v21.1/tools/peerStats
mikehu44 has joined #bitcoin-core-dev
<vasild>
I added the routing manually with "route add -6 fc00::/8 fc00::1", not sure if this is supposed to be done automatically by cjdns or not
<prayank>
Is this a normal practice? When someone highlights issues with one of the maintainers, their comments are censored?
<laanwj>
censored? what?
<prayank>
What else would I call it?
<laanwj>
for what its worth we have only one level of censorship and that's banning people from the repository completely
<prayank>
It's only one PR and I can comment on everything
<laanwj>
there is no way to ban someone from a PR
<prayank>
Anyway I don't have energy for debate. Will share my review comments and log off.
<laanwj>
that's not debate, I'm literally telling you what is possible with github, if you don't believe, the the documentation
<laanwj>
you're going way overboard with your accusations you just casually make
<prayank>
Two questions for PR author: 1. Unconfirmed UTXO are discouraged in Core. Does this PR change default behaviour? Context: https://github.com/bitcoin-core/gui/issues/242 2. Why do you think it's not a bug if attacker can confirm a tx with less fee rate by replacing? It can be exploited if we had on chain DeFi but I am not sure what all projects are currently impacted
<prayank>
laanwj: What is the reason for comments being disabled on one PR suddenly? Too much coincidence sorry if it's a GitHub issue it's affecting me. I just want to contribute with peace.
<laanwj>
prayank: if *all* comments are closed for the issue you should see something like "Conversation was locked to maintainers only" or something like that, along with who did it and a reason, likely you're just running into a github bug, stop blaming us for everything in the universe
c_arc has joined #bitcoin-core-dev
prayank has quit [Quit: irc thread exit]
<vasild>
prayank: on github (that is not specific to bitcoin) it is possible to lock one PR for everybody (in which case "Conversation was locked..." is displayed). Or it is possible to ban one person from all PRs in a repository. But it is not possible to ban one person from one PR.
<laanwj>
right
sdfgsdfgDropBear has joined #bitcoin-core-dev
<achow101>
prayank: I suggest that you contact GitHub support.
sdfgsdfgDropBear has quit [Quit: sdfgsdfgDropBear]
c_arc has joined #bitcoin-core-dev
gleb7 has quit [Quit: Ping timeout (120 seconds)]
gleb79 has joined #bitcoin-core-dev
gleb79 is now known as gleb7
c_arc has joined #bitcoin-core-dev
jonatack55 has quit [Quit: Ping timeout (120 seconds)]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
<glozow>
prayank: I blocked you on my personal github account. It has nothing to do with the repo or maintainers. The help text for blocking a user says "Prevent this user from interacting with your repositories and sending you notifications." I didn't realize it would stop you from commenting on my PR in the Bitcoin Core repo. My apologies to everybody for the confusion.
<glozow>
Here are the reasons why I blocked you: every comment you've left on my PRs has been off-topic and unhelpful. On #23121, you commented that you didn't understand the changes, and then posted to the mailing list reporting a "bug." I no longer wanted to be notified of your interactions.
<glozow>
> Unconfirmed UTXO are discouraged in Core. Does this PR change default behaviour?
<glozow>
An unconfirmed UTXO exists if an unconfirmed transaction exists. This sentence doesn't make sense to me.
<glozow>
> Why do you think it's not a bug if attacker can confirm a tx with less fee rate by replacing?
<glozow>
An attacker cannot confirm a tx with less feerate by replacing.
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<michaelfolkson>
The ability for a PR author to block reviewers from commenting on their Core PR sounds like a can of worms (ignoring the names of the individuals involved)
<michaelfolkson>
That's another problem with GitHub, not the fault of the individuals
prayank has joined #bitcoin-core-dev
<michaelfolkson>
You can't have a robust review process where the PR author can block those who will oppose or NACK the PR
<prayank>
glowzow:
<prayank>
1. Blocked. I can't believe this. Okay how many PRs have I reviewed in which you are author? Can you share those offtopic and unhelpful comments that triggered you so much
<prayank>
2. This PR was already shared on mailing list by you in a thread about packages. I just created another thread after commenting the Importance of it and waiting for response. There was no response for 2 days on PR even after one more reviewer had some serious questions.
<prayank>
3. Unconfirmed UTXO are not considered safe to spend. If something doesn't make sense to you please don't block people on a public repository to avoid reviews.
<prayank>
4. Why can't attacker use the method described in the PR description and first comment?
<michaelfolkson>
Let
<michaelfolkson>
Anyone is free to block you, me or anybody else prayank
<michaelfolkson>
But that shouldn't impact on the review process
<prayank>
I don't care but it should not affect reviews
<prayank>
Right
<michaelfolkson>
If glozow wants to block you she should be free to from interacting with her generally on GitHub that's her prerogative
<prayank>
At least I learnt how to restrict users on one PR
<michaelfolkson>
It seems like the only way to address this without moving from GitHub is putting comments here and asking someone who isn't blocked to post on the PR which is not ideal (that's effectively what happened here)
TheRec_ has quit [Read error: Connection reset by peer]
TheRec has joined #bitcoin-core-dev
TheRec has quit [Changing host]
TheRec has joined #bitcoin-core-dev
<meshcollider>
Regardless of whether the comments are on GitHub or not, if there is reasonable objection to a PR then I'm sure the maintainers will become aware of it one way or another and won't merge it.
<meshcollider>
Interesting and good to know for future reference though
c_arc has joined #bitcoin-core-dev
<MarcoFalke>
Another one of the "Would be nice if GitHub allowed fine-grained permissions and settings", I guess
TheRec has quit [Read error: Connection reset by peer]
<MarcoFalke>
Also, on a related note: Already announced last week or so, but I locked all historic issues and pull requests (closed and no action for 3 years). If someone wants to comment on those, please ask on IRC or create a new GitHub issues with the question.
TheRec has joined #bitcoin-core-dev
TheRec has quit [Changing host]
TheRec has joined #bitcoin-core-dev
<MarcoFalke>
Leaving them open attracted too much low quality comments and spam
c_arc has joined #bitcoin-core-dev
<glozow>
I've unblocked prayank because I agree with not hampering the review process; that wasn't my intention. Would be nice if github had better documented / more fine-grained permissions.
<jnewbery>
MarcoFalke: +1. Thanks!
<glozow>
MarcoFalke: thanks!
<michaelfolkson>
prayank: Perhaps post more questions here than on the actual PR. Even if the author doesn't respond here someone else may be able to.
<michaelfolkson>
It is difficult to judge sometimes but basic questions should be here or on StackExchange rather than on the PR I think
c_arc has joined #bitcoin-core-dev
<prayank>
michaelfolkson: Do you really think I commented anything in this PR that does not make sense? I was not aware of all this else would have completely avoided and let others decide. I won't be reviewing any PR in future for this author in any repository. Also started contributing in Knots so it might help me do better things with less people and peace: https://github.com/bitcoinknots/bitcoin/discussions/39
<michaelfolkson>
It is just getting the right location for the question right. Nothing wrong with asking foundational questions (everyone had/has to) but it can disrupt review of the PR when a certain level of understanding is assumed
<michaelfolkson>
And I
saranshsharma has quit [Ping timeout: 250 seconds]
<michaelfolkson>
And I'm sure there are lots of examples where I haven't followed this advice but I try to
<vasild>
I seem to have 453 addresses in my addrman tagged as ipv4 but with an ipv6 address, e.g. "address": "2001:0:2851:fcb0:2088:8c84:c227:e21a", "network": "ipv4"
<vasild>
Am I the only one? I ran: bitcoin-cli getnodeaddresses 0 |jq 'map(select(.network == "ipv4" and (.address |contains(":"))))'
saranshsharma has joined #bitcoin-core-dev
yanmaani has joined #bitcoin-core-dev
hex17or has quit [Remote host closed the connection]
<jonatack>
returns 620 entries for me
<lightlike>
vasild: I see the same
<vasild>
I have no idea how could this happen, but it looks terribly bad
hex17or has joined #bitcoin-core-dev
<jonatack>
note, getnodeaddresses takes a network argument, so can also: ./src/bitcoin-cli getnodeaddresses 0 ipv4 | jq 'map(select(.address | contains(":")))'
<willcl_ark>
I have 0 entries out of 8228 like that on 22.0 FWIW
<willcl_ark>
oh whoops, i've got onlynet set for tor and i2p on that node, so ignore that
<jonatack>
right, running this gives an overview: ./src/bitcoin-cli -addrinfo
<jonatack>
in my case it involves 620 out of 56645 ipv4 addresses, not counting IsTerrible() ones, so a bit more than 1%
c_arc has joined #bitcoin-core-dev
<elichai2>
Is it possible to make the QT connect to a running bitcoind?
mikehu44 has joined #bitcoin-core-dev
<elichai2>
I assume not because there's no good separation yet
dunxen has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 250 seconds]
sdfgsdfgDropBear has quit [Quit: sdfgsdfgDropBear]
c_arc has joined #bitcoin-core-dev
<michaelfolkson>
elichai2: That's my understanding as well. You can't (yet) have a GUI running on a separate machine and connecting to bitcoind on a different machine
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #23184: Use stricter ToIntegral over LocaleIndependentAtoi where possible (master...2110-ToIntegral) https://github.com/bitcoin/bitcoin/pull/23184
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<michaelfolkson>
elichai2: I would guess you also can't boot up the GUI and have it connect to an already running bitcoind on the same machine
<elichai2>
yeah, too bad. that will probably change if and when the multi process project will finally get in :)
<lightlike>
yxkc
sdfgsdfgDropBear has joined #bitcoin-core-dev
<lightlike>
vasild: Not an expert on this at all, but could this be embedded ipv4 addresses? It seems that GetNetworkName(GetNetClass()) is "ipv4" for these addresses
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #23184: Use stricter ToIntegral over LocaleIndependentAtoi where possible (master...2110-ToIntegral) https://github.com/bitcoin/bitcoin/pull/23184
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<jonatack>
lightlike: maybe in CNetAddr::SetLegacyIPv6()
saranshsharma has quit [Ping timeout: 245 seconds]
prayank has quit [Quit: irc thread exit]
Guest57 has joined #bitcoin-core-dev
<lightlike>
jonatack: for the addrs I receive with vasild's command, CNetAddr::HasLinkedIPv4() is true, for me these mostly start with "2001:0:" and are classified as Teredo tunneled IPv4 (see IsRFC4380() in netaddress.cpp)
c_arc has joined #bitcoin-core-dev
saranshsharma has joined #bitcoin-core-dev
tla2k21 has quit [Ping timeout: 276 seconds]
mikehu44 has joined #bitcoin-core-dev
mikehu44 has quit [Client Quit]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Guyver2_ has joined #bitcoin-core-dev
saranshsharma has quit [Remote host closed the connection]
saranshsharma has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 246 seconds]
Guyver2_ is now known as Guyver2
c_arc has joined #bitcoin-core-dev
Henrik has joined #bitcoin-core-dev
Henrik has quit [Client Quit]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] brunoerg closed pull request #23135: test: Use asset_equal utils where possible in feature_nulldummy (master...2021-09-assert_equal) https://github.com/bitcoin/bitcoin/pull/23135
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
mikehu44 has quit [Ping timeout: 245 seconds]
c_arc has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
mikehu44_ has joined #bitcoin-core-dev
sdfgsdfgDropBear has quit [Quit: sdfgsdfgDropBear]
sdfgsdfgDropBear has joined #bitcoin-core-dev
mikehu44_ has quit [Ping timeout: 245 seconds]
mikehu44 has quit [Ping timeout: 252 seconds]
mikehu44 has joined #bitcoin-core-dev
mikehu44_ has joined #bitcoin-core-dev
<vasild>
lightlike: oh, well, this maybe explains
jespada has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<jonatack>
lightlike: yes, i see Teredo ones in the output, along with other HasLinkedIPv4() cases, many are also 2002::/16 i.e. IsRFC3964() IPv6 6to4 tunnelling
dunxen has quit [Remote host closed the connection]
<jonatack>
in my output, at least. Good to have looked into it.
saranshsharma has quit [Remote host closed the connection]
<laanwj>
if it's all wrapped addresses, it looks like we need to downconvert these to actual ipv4 (at least in the legacy path; in the addrv2 path it's not allowed at all) before they end up in the database
saranshsharma has joined #bitcoin-core-dev
davterra has joined #bitcoin-core-dev
Henrik has joined #bitcoin-core-dev
saranshsharma has quit [Ping timeout: 245 seconds]
mikehu44_ has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] instagibbs opened pull request #23188: wallet: fund transaction external input cleanups (master...fundtx-external-inputs_cleanups) https://github.com/bitcoin/bitcoin/pull/23188
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
saranshsharma has joined #bitcoin-core-dev
Guest57 has left #bitcoin-core-dev [#bitcoin-core-dev]
smartin has joined #bitcoin-core-dev
saranshsharma has quit [Ping timeout: 252 seconds]
<sipa>
laanwj: downconverting won't work; a teredo address isn't exchangeable for an ipv4 address (as in: the node you're connecting to must be using teredo in order for it to be reachable on the teredo ipv6 address, even though that address is 1 to 1 linked with an ipv4 one)
<sipa>
i think we should just remove support for these ipv6 wrapping systems... ipv6 is so widespread now that i don't think anyone still uses teredo
<vasild>
Is it some kind of meteorological event, similar to tornado?
mikehu44_ has joined #bitcoin-core-dev
<sipa>
it wad an early system for getting an ipv6 proxy, while your ISP only offered IPv4
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[gui] MarcoFalke opened pull request #446: RPCConsole: Throw when overflowing size_t type for array indices (master...2110-qtRpcCons) https://github.com/bitcoin-core/gui/pull/446
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Henrik has quit [Read error: Connection reset by peer]
<laanwj>
sipa: oh, i get it now...
<laanwj>
yes, makes more sense to just reject them then, the other option would be to regard them as IPv6 addresses as they're supposed to be treated as IPv6 addresses, but if it's not actually in use anymore it's just noise?
<sipa>
they are ipv6 addresses; it's for purposes of netgroup classification that they're treated as ipv4
<sipa>
(or should be)
<laanwj>
right
<sipa>
i guess it's a bug they're reported as ipv4 in the RPC output
<laanwj>
right it then seems a confusion between 'address type' and 'netgroup classification type'
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #23191: build: Disable -Wbraced-scalar-init, which is incompatible with -Wc++11-narrowing (master...2110-buildW) https://github.com/bitcoin/bitcoin/pull/23191
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<ryanofsky>
elichai2, re "Is it possible to make the QT connect to a running bitcoind" this is implemented and working in #19461
<bitcoin-git>
[bitcoin] CallMeMisterOwl opened pull request #23194: script: fixes #23073 Added new function to build_msvc/msvc-autogen.py (master...auto_gen_MSVC_issue) https://github.com/bitcoin/bitcoin/pull/23194
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
mikehu44 has quit [Ping timeout: 252 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] CallMeMisterOwl opened pull request #23195: doc: fixes #23073 Updated the Release Process (master...update_release_process) https://github.com/bitcoin/bitcoin/pull/23195
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
gene has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
<laanwj>
jamesob: in any case you can work around it by configuring with --without-seccomp
<jamesob>
laanwj: gotcha, thanks!
sdfgsdfgDropBear has quit [Quit: sdfgsdfgDropBear]
c_arc has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] laanwj opened pull request #23196: util: Make syscall sandbox compilable with kernel 4.4.0 (master...2021-10-syscall-sandbox2) https://github.com/bitcoin/bitcoin/pull/23196
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<laanwj>
jamesob: that should work too ^^
dviola has joined #bitcoin-core-dev
<jamesob>
laanjw: great, thanks
<jamesob>
incidentally, anyone know why clang-12 + lld would allow --enable-lto, but when configuring with gcc-9 + lld, configure reports that the linker doesn't support lto? Does use of gcc hardcode use of some specific linker?
tripleslash has joined #bitcoin-core-dev
<sipa>
jamesob: GCC LTO requires the linker to support "linker plugins", and telling the linker where to find the GCC linker plugin (because the linker needs to actually invoke compiler code at link time)
<sipa>
if you use a linker directly, LTO won't work
<sipa>
and presumably lld works magically well with clang or so
<jamesob>
ooh, okay. So I have lld installed as /usr/bin/ld, and presumably lld only knows about clang eh?
c_arc has joined #bitcoin-core-dev
<laanwj>
right, the linker is what needs to do (or invoke, through a plugin) the actual compilation in lto, all the other compiles only generate intermediate representation
c_arc has joined #bitcoin-core-dev
davterra has quit [Remote host closed the connection]
davterra has joined #bitcoin-core-dev
davterra has quit [Remote host closed the connection]
<cfields>
jamesob: lld apparently supports the gold plugin, you might just need to give it some help finding it. That's a pretty wonky combo, though :)
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<jamesob>
cfields: oh good call, I'll have to look into that
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
davterra has joined #bitcoin-core-dev
davterra has quit [Remote host closed the connection]
davterra has joined #bitcoin-core-dev
tralfaz has joined #bitcoin-core-dev
davterra has quit [Ping timeout: 246 seconds]
Talkless has quit [Quit: Konversation terminated!]
c_arc has joined #bitcoin-core-dev
dongcarl7 is now known as dongcarl
RomanZ has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
RomanZ has quit [Quit: Leaving]
c_arc has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] jonatack opened pull request #23197: p2p: fix CSubNet::ToString() UBSan and banman fuzz crash (master...fix-netaddress-UB-and-banman-fuzz-crash) https://github.com/bitcoin/bitcoin/pull/23197
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
promag_ has joined #bitcoin-core-dev
promag has quit [Read error: Connection reset by peer]
c_arc has joined #bitcoin-core-dev
Guest19 has joined #bitcoin-core-dev
Guest19 has quit [Client Quit]
tralfaz has quit [Remote host closed the connection]
<bitcoin-git>
[bitcoin] CallMeMisterOwl closed pull request #23194: build: Parse version information in msvc-autogen.py (master...auto_gen_MSVC_issue) https://github.com/bitcoin/bitcoin/pull/23194
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] CallMeMisterOwl opened pull request #23198: build: fixes #23073 Parse version information in msvc-autogen.py (master...auto_gen_issue) https://github.com/bitcoin/bitcoin/pull/23198
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
yanmaani has quit [Ping timeout: 276 seconds]
tralfaz has quit [Remote host closed the connection]
tralfaz has joined #bitcoin-core-dev
yanmaani has joined #bitcoin-core-dev
mekster66 has quit [Quit: mekster66]
mekster66 has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
kibizc[m] has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
smartin has quit [Quit: smartin]
c_arc has joined #bitcoin-core-dev
Victorsueca has joined #bitcoin-core-dev
Victorsueca has quit [Read error: Connection reset by peer]
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
<bitcoin-git>
[bitcoin] theStack opened pull request #23199: refactor: use `{Read,Write}BE32` helpers for BIP32 nChild (de)serialization (master...202110-refactor-use_be32_helpers_for_bip32_nchild) https://github.com/bitcoin/bitcoin/pull/23199
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] meshcollider opened pull request #23200: Fix intermittent failure in wallet_send.py and rpc_fundrawtransaction.py (master...202110_fix_external_tests) https://github.com/bitcoin/bitcoin/pull/23200
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] achow101 opened pull request #23201: wallet: Allow users to specify input weights when funding a transaction (master...ext-input-weight) https://github.com/bitcoin/bitcoin/pull/23201
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]