jamesob has quit [Quit: Connection closed for inactivity]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Kaizen_Kintsugi has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 252 seconds]
c_arc has joined #bitcoin-core-dev
copumpkin has quit [Remote host closed the connection]
c_arc has joined #bitcoin-core-dev
Kaizen_Kintsugi has joined #bitcoin-core-dev
sdfgsdfgs has quit [Changing host]
sdfgsdfgs has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 245 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
c_arc has joined #bitcoin-core-dev
<meshcollider>
Anyone have time to review #23093 ? It already has 2 ACKs
<gribble>
https://github.com/bitcoin/bitcoin/issues/23093 | Add ability to flush keypool and always flush when upgrading non-HD to HD by meshcollider · Pull Request #23093 · bitcoin/bitcoin · GitHub
copumpkin has joined #bitcoin-core-dev
jaybny2 has quit []
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
roconnor has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Victorsueca has quit [Ping timeout: 252 seconds]
c_arc has joined #bitcoin-core-dev
jarthur has quit [Quit: brb]
mikehu44 has quit [Ping timeout: 265 seconds]
mikehu44 has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<cfields>
theStack: IIRC I had plans to turn that into a zero-copy api for sending a message to multiple peers, but it didn't work out. It's probably worth re-evaluating. Is it preventing you from doing something?
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake opened pull request #23275: [22.x] Add historical & clean out 22.0 rel notess (22.x...clean_out_rel_notess) https://github.com/bitcoin/bitcoin/pull/23275
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<theStack>
so right now if you sent a fixed message to n peers, serialization takes O(n) instead of O(1), because you have to do it for every peer again and again
<theStack>
i hardly think this is a huge performance bottleneck or anything right now though; so not sure if it is worth to change anything
Kaizen_Kintsugi has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 252 seconds]
c_arc has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
yanmaani has quit [Remote host closed the connection]
<bitcoin-git>
bitcoin/master 22cc797 Samuel Dobson: Add newkeypool RPC to flush the keypool
<bitcoin-git>
bitcoin/master 2434b10 Samuel Dobson: Fix outdated keypool size default
<bitcoin-git>
bitcoin/master 6f6f7bb Samuel Dobson: Make legacy wallet upgrades from non-HD to HD always flush the keypool
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] laanwj merged pull request #23093: Add ability to flush keypool and always flush when upgrading non-HD to HD (master...202109_keypoolrefill) https://github.com/bitcoin/bitcoin/pull/23093
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Murch[m] has quit [Quit: Bridge terminating on SIGTERM]
vincenzopalazzo has quit [Quit: Bridge terminating on SIGTERM]
devrandom has quit [Quit: Bridge terminating on SIGTERM]
kvaciral[m] has quit [Quit: Bridge terminating on SIGTERM]
siv2r[m] has quit [Quit: Bridge terminating on SIGTERM]
merkle_noob[m] has quit [Quit: Bridge terminating on SIGTERM]
stick[m] has quit [Quit: Bridge terminating on SIGTERM]
Enki[m] has quit [Quit: Bridge terminating on SIGTERM]
kakolainen[m] has quit [Quit: Bridge terminating on SIGTERM]
vasanth2[m] has quit [Quit: Bridge terminating on SIGTERM]
kibizc[m] has quit [Quit: Bridge terminating on SIGTERM]
RCasatta[m] has quit [Quit: Bridge terminating on SIGTERM]
tutwidi[m] has quit [Quit: Bridge terminating on SIGTERM]
xor9[m] has quit [Quit: Bridge terminating on SIGTERM]
cdecker[m] has quit [Quit: Bridge terminating on SIGTERM]
kvaciral[m] has joined #bitcoin-core-dev
vincenzopalazzo has joined #bitcoin-core-dev
stick[m] has joined #bitcoin-core-dev
devrandom has joined #bitcoin-core-dev
Murch[m] has joined #bitcoin-core-dev
Enki[m] has joined #bitcoin-core-dev
siv2r[m] has joined #bitcoin-core-dev
merkle_noob[m] has joined #bitcoin-core-dev
kibizc[m] has joined #bitcoin-core-dev
vasanth2[m] has joined #bitcoin-core-dev
RCasatta[m] has joined #bitcoin-core-dev
tutwidi[m] has joined #bitcoin-core-dev
cdecker[m] has joined #bitcoin-core-dev
kakolainen[m] has joined #bitcoin-core-dev
xor9[m] has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] dongcarl opened pull request #23280: init: Coalesce Chainstate loading sequence between {,non-}unittest codepaths (master...2021-09-kernel-lib-v3) https://github.com/bitcoin/bitcoin/pull/23280
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<Talkless>
not sure how debian packages are managed, probably just binary compatibility break happend and bitcoind was not rebuilt?
<sipa>
Talkless: sounds like libleveldb had an ABI breaking change in a minor version... yuck
<sipa>
(and the debian bitcoind package was configured to use system leveldb, rather than the subtreed one)
ghost43 has quit [Quit: Leaving]
<Talkless>
sipa: welp, it's google. They don't care about these things, at least that vibe radiates in CppCon talks...
ghost43 has joined #bitcoin-core-dev
<sipa>
it'd be much easier if we just dropped support for using system leveldb
<sipa>
ABI compatibility in C++ libraries is inherently hard
<Talkless>
sipa: true, but some projects tries at best to deal with this stuff cleanly, like Qt. Meanwhile as you said, leveldb broke just in minor release :/
sipsorcery has quit [Ping timeout: 268 seconds]
<sipa>
if it was clear that such compatibility wasn't something promised by upstream, this probably means debian just shouldn't package it this way
Kaizen_Kintsugi has quit [Remote host closed the connection]
KaizenKintsugi has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
<Talkless>
sipa: IIRC Debian policy does not really like using "subdree" libraries. For example, libgd in PHP source is (was at least) better, allows antialiasing, while upstream libgd lacked behind, and of course, Debian used that original upstream source, resulting in horrible php-painted graphs, for example. Meanwhile it was fine on Ubuntu.
<sipa>
Talkless: i mean, they should just package it as separate packages libleveldb122 and libleveldb123, rather than just libleveldb, if compatibility isn't guaranteed
<jeremyrubin>
we landed on no meeting today right?
<Talkless>
sipa: Oh I see, right, they do use different package versions time to time. I guess this (patch-version-abi-brreak) might be one of these occasions.
jamesob has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<dongcarl>
jeremyrubin: I think so
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
smartin has quit [Quit: smartin]
KaizenKintsugi has quit [Remote host closed the connection]
Kaizen_Kintsugi has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Remote host closed the connection]
Kaizen_Kintsugi has joined #bitcoin-core-dev
<luke-jr>
meeting?
<luke-jr>
Talkless: we've told distros time and time again, they can't just treat Bitcoin consensus deps like normal deps :/
<luke-jr>
sipa: at least it refuses to run, rather than running incorrectly ☺
<luke-jr>
sipa: Core already doesn't have support for system LevelDB, BTW
<cfields>
we have it stubbed out a bit in the buildsystem, though. I'll open a PR to remove the stubs and make it harder for distros to make that decision.
<luke-jr>
cfields: please don't.
<luke-jr>
cfields: it is possible to do properly, just Debian is incompetent
<cfields>
luke-jr: you know we don't agree, i'm not discussing this with you. You can -1 the PR.
<luke-jr>
cfields: it's outright sabotage to intentionally break things for no benefit
<luke-jr>
nobody is going to change how they link LevelDB just because you try to sabotage it. all you'll do is make things more likely to go wrong.
<elichai2>
🍺🍻🍺
<shiza>
Debian knows how to maintain a safe package balance. Sid is meant to be broken.
gene has joined #bitcoin-core-dev
<luke-jr>
shiza: no, they don't.
<luke-jr>
if they did, ordinary leveldb version bumps would not affect their bitcoin packages
<luke-jr>
(exception if perhaps they studied the bump and made sure it was consensus-safe before deploying - but clearly this wasn't tested if it doesn't even run)
jarthur has quit [Quit: jarthur]
<shiza>
I didn't know consensus was a word at distros selecting which package versions to support.
<luke-jr>
shiza: LevelDB is consensus-critical code for Bitcoin. If it's being maintained without care for consensus, then it's not safe.
<luke-jr>
if LevelDB has a bug, that bug must NOT be fixed for Bitcoin.
<shiza>
We should just report the problem to the packager, that's all. Whenever Bitcoin is important, they'll assign it to a packager handling less packages, and chance for sloppy upgrades will be smaller.
Talkless has quit [Quit: Konversation terminated!]
<luke-jr>
better if they don't package it at all, than do so improperly
<shiza>
Much agreed!
Kaizen_Kintsugi has quit [Remote host closed the connection]
Kaizen_Kintsugi has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 245 seconds]
Kaizen_Kintsugi has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 252 seconds]
Kaizen_Kintsugi has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Remote host closed the connection]
Kaizen_Kintsugi has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Remote host closed the connection]
Kaizen_Kintsugi has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 252 seconds]
bitdex_ has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 276 seconds]
Kaizen_Kintsugi has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 252 seconds]
BlueMatt_ has joined #bitcoin-core-dev
BlueMatt has quit [Ping timeout: 252 seconds]
Kaizen_Kintsugi has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 245 seconds]
ghostkeeper has quit [Remote host closed the connection]
ghostkeeper has joined #bitcoin-core-dev
ghostkeeper has quit [Ping timeout: 265 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Kaizen_Kintsugi has joined #bitcoin-core-dev
dviola has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 252 seconds]
Kaizen_Kintsugi has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Remote host closed the connection]
ghostkeeper has joined #bitcoin-core-dev
Kaizen_Kintsugi has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 252 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Guest65 has joined #bitcoin-core-dev
<Guest65>
Hi all, quick question (sorry if this is trivially answered somewhere else) why is the new client version 22.0 as opposed to 0.22.0? Is that just an omission of the prefix in the git tag or has there been a change in versioning conventions?