bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Henrik has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc_ has joined #bitcoin-core-dev
c_arc has quit [Remote host closed the connection]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
panpan has joined #bitcoin-core-dev
ogola has joined #bitcoin-core-dev
sdfgsdfgDropBear has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
prayank has joined #bitcoin-core-dev
<prayank>
michaelfolkson: I don't have personal issues with anyone. Neither I know anyone enough to even have one. We are strangers from different culture and background interacting online and have similar goals. Trying to keep it professional, I will always share my honest opinion on things. I have appreciated things I like and will criticize things I don't like.
<prayank>
4 points I mentioned are good enough to be considered and I agree I should have discussed them earlier. Apologize if timing was incorrect or used wrong words.
AaronvanW has quit [Remote host closed the connection]
<meshcollider>
Review beg for #17211, it is finally close to merge
<gribble>
https://github.com/bitcoin/bitcoin/issues/17211 | Allow fundrawtransaction and walletcreatefundedpsbt to take external inputs by achow101 · Pull Request #17211 · bitcoin/bitcoin · GitHub
<meshcollider>
yanmaani: you may like to re-review ^
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<yanmaani>
meshcollider: thanks. nothing I saw was blocking at all but will take a look!
c_arc has joined #bitcoin-core-dev
luke-jr has quit [Read error: Connection reset by peer]
luke-jr has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<yanmaani>
done
<prayank>
yanmaani: crACK is for code review only
<yanmaani>
what does it ... mean? "Code review ACK"?
<prayank>
Reviewed code. Found no issues.
<prayank>
AFAIK
<yanmaani>
ohh didn't find it documented anywhere
<yanmaani>
> After conceptual agreement on the change, code review can be provided. A review begins with ACK BRANCH_COMMIT, where BRANCH_COMMIT is the top of the PR branch, followed by a description of how the reviewer did the review. The following language is used within pull request comments:
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake opened pull request #23168: build: no-longer fail default configure if BDB isn't available (master...dont_fail_no_bdb_default_configure) https://github.com/bitcoin/bitcoin/pull/23168
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
sdfgsdfgDropBear has quit [Quit: sdfgsdfgDropBear]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<jarolrod>
yanmaani: see #22966. While these shorthands are used, the consensus is to discourage placing any real meaning behind them. All these variations should just be treated as an ACK, and the reviewer is asked to elaborate.
<bitcoin-git>
[bitcoin] martinus opened pull request #23169: Fix `-Wmaybe-uninitialized` warnings found by building with `-flto` (master...2021-10-fix-Wmaybe-uninitialized-warnings) https://github.com/bitcoin/bitcoin/pull/23169
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
kabaum has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
common has quit [Remote host closed the connection]
common has joined #bitcoin-core-dev
<michaelfolkson>
yanmaani: The guidance in the docs (which ideally everyone should follow) is to write Code Review ACK commit_hash or ACK commit_hash Reviewed code by doing... rather than abbreviated crACK or whatever
<michaelfolkson>
Habits die hard though :)
prayank has quit [Read error: Connection reset by peer]
c_arc has joined #bitcoin-core-dev
prayank has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<vasild>
laanwj: so 10036/24/60 = ~7 incoming connections per minute
<vasild>
(I guess the listening port is 8333)
<vasild>
this is quite close to my observation of 5 per minute on !=8333 port, I would expect a bigger difference. Anyway 7 per minute does not classify as a dos attack (right?). I will probably open a PR to remove that prefer-port-8333 and see how people will like it.
<vincenzopalazzo>
Hello guys, I'm working on #23119 and I decided to slip the work in different PR, I would like to know if this approach is good for the review dev, and you preferer it all at once? My start PR is https://github.com/bitcoin/bitcoin/pull/23127
<laanwj>
vasild: and agree with the reasoning, it classifies as some kind of log pollution but definitely not a DoS, anything connected to the public internet should be able to handle that
<vasild>
yeah, and also avoiding !=8333 does not actually "protect" victim.com:80 - they would just get less connection attempts (5 vs 7 per minute from the data we have so far).
saranshsharma has quit [Remote host closed the connection]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<laanwj>
if it actually doesn't help i'd be in favor of removing the restriction, it always seemed kind of silly to restrict a protocol to a certain port, most protocols are free from this--the modern internet grew away from this one port = one service concept
<laanwj>
that said, it is a scary change
<laanwj>
well otoh you can say that browsers strongly prefer 80/443 so i dunno :)
<laanwj>
but for P2P, e.g. bittorrent doesn't have a preferred port
c_arc has joined #bitcoin-core-dev
<laanwj>
being specific about ports reduces flexibility and a P2P network needs all the flexibility it can get
c_arc has joined #bitcoin-core-dev
kexkey has quit [Ping timeout: 252 seconds]
kexkey has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] darosior opened pull request #23171: qa: test descriptors with mixed xpubs and const pubkeys (master...desc_test_mix) https://github.com/bitcoin/bitcoin/pull/23171
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
bitcoin/master d5cfb86 Andrew Chow: Allow Coin Selection be able to take external inputs
<bitcoin-git>
bitcoin/master 74c0d81 Shubhankar: test: use miniwallet in test_rpc() function in feature_rbf.py
<bitcoin-git>
bitcoin/master c6f710e MarcoFalke: Merge bitcoin/bitcoin#23052: test: use miniwallet in test_rpc function in ...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #23052: test: use miniwallet in test_rpc function in feature_rbf.py (master...master) https://github.com/bitcoin/bitcoin/pull/23052
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<prayank>
If yes, I will test it. Request others to test as well. It is important and I had once accidently deleted my blocks from mainnet because qt had different settings.
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Henrik has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
<jonatack>
vasild: is your cjdns node up?
<jonatack>
2021-10-04T12:42:54Z [addcon] connect() to [fcc7:be49:ccd1:dc91:3125:f0da:457d:8ce]:8333 failed: Network is unreachable (101)
<vasild>
yes
<vasild>
"Network is unreachable" sounds like your OS does not know how to reach that network, what does "netstat -nr" show?
<vasild>
it will also reply to pings, to test connectivity without involving bitcoind
<vasild>
in FreeBSD I had to manually add this routing: route add -6 fc00::/8 fc00::1
<vasild>
the linux command might be slightly different, e.g. use gateway fc00::1 to reach the fc00::/8 network
Henrik has joined #bitcoin-core-dev
<jonatack>
thanks! that could be, i am just getting started with it. fwiw, -cjdnsreachable=1 with cjdns not running made bitcoind appear to halt/become unresponsive, but only tried that once so far.
sdfgsdfgDropBear has joined #bitcoin-core-dev
<vasild>
I don't think it should try to connect to some fc00::/8 address by default only because -cjdnsreachable=1 is present. If it tries (e.g. due to addnode=fc...) and cjdns is not running, then connecting to that node will timeout, same as if the node alone is down.
AaronvanW has quit [Remote host closed the connection]
jonatack has quit [Ping timeout: 252 seconds]
AaronvanW has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
c_arc has joined #bitcoin-core-dev
<jonatack55>
vasild: i think i'm running bitcoind with a cjdns service at [fc32:17ea:e415:c3bf:9808:149d:b5a2:c9aa]:8333
<jonatack55>
getnetworkinfo networks returns cjdns reachable true, local_addresses returns that address after the other ones
<jonatack55>
and that local address reported by bitcoind is indeed the ipv6 address in cjdroute.conf, so looks good
sdfgsdfgDropBear has quit [Quit: sdfgsdfgDropBear]
vasild has quit [Ping timeout: 276 seconds]
vasild has joined #bitcoin-core-dev
Henrik has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Jaamg_ is now known as Jaamg
AaronvanW has joined #bitcoin-core-dev
Guyver2_ has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 245 seconds]
Guyver2_ is now known as Guyver2
c_arc has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] jamesob opened pull request #23174: validation: have LoadBlockIndex account for snapshot use (master...2021-10-au-loadblockindex) https://github.com/bitcoin/bitcoin/pull/23174
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 252 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
prayank has quit [Read error: Connection reset by peer]
c_arc has joined #bitcoin-core-dev
davterra has quit [Quit: Leaving]
<jonatack55>
yay, vasild and i are connected via bitcoind over cjdns
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
tralfaz has joined #bitcoin-core-dev
davterra has quit [Killed (NickServ (GHOST command used by tralfaz!~davterra@143.198.56.186))]
tralfaz is now known as davterra
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<laanwj>
i'd like to set up CJDNS again as well, but lost all my peers from last time i used it [which was years ago], back then i don't think they had public nodes you had to go on IRC and ask for peers :-)