Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen___ has joined #bitcoin-core-dev
Kaizen_K_ has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
bomb-on has quit [Quit: aллилѹіа!]
rex4539 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
jarthur has quit [Quit: jarthur]
vysn has quit [Ping timeout: 252 seconds]
rex4539 has quit [Ping timeout: 276 seconds]
gene has quit [Quit: gene]
jarthur has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
rex4539 has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
common has quit [Ping timeout: 252 seconds]
yanmaani1 is now known as yanmaani
rex4539 has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
arythmetic has quit [Remote host closed the connection]
arythmetic has joined #bitcoin-core-dev
arythmetic has quit [Ping timeout: 252 seconds]
common has joined #bitcoin-core-dev
rex4539 has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
contrapumpkin has joined #bitcoin-core-dev
copumpkin has quit [Ping timeout: 252 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4633199cc8a4...df562d698a38
<bitcoin-git> bitcoin/master fa6b7ad MarcoFalke: style: Add {} to if-bodies in node/miner
<bitcoin-git> bitcoin/master df562d6 fanquake: Merge bitcoin/bitcoin#23637: miner: Remove uncompiled MTP code
<bitcoin-git> bitcoin/master fa46ac4 MarcoFalke: miner: Remove uncompiled MTP code
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake merged pull request #23637: miner: Remove uncompiled MTP code (master...2111-minerOnlyMTP) https://github.com/bitcoin/bitcoin/pull/23637
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
arythmetic has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
grettke has quit [Quit: Textual IRC Client: www.textualapp.com]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
sudoforge has quit [Ping timeout: 252 seconds]
Kaizen___ has quit [Ping timeout: 268 seconds]
arythmetic has quit [Ping timeout: 252 seconds]
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
Kaizen___ has joined #bitcoin-core-dev
earnest has quit [Ping timeout: 256 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has quit [Ping timeout: 268 seconds]
Kaizen___ has quit [Ping timeout: 268 seconds]
sudoforge has joined #bitcoin-core-dev
Guest47 has joined #bitcoin-core-dev
arythmetic has joined #bitcoin-core-dev
TallTim has quit [Ping timeout: 250 seconds]
arythmetic has quit [Ping timeout: 252 seconds]
Guest47 has quit [Quit: Client closed]
TallTim has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
rex4539 has joined #bitcoin-core-dev
sdfgsdfg has quit [Quit: ZzzZ]
rex4539 has quit [Ping timeout: 276 seconds]
outfox has quit [Ping timeout: 252 seconds]
outfox has joined #bitcoin-core-dev
outfox has quit [Changing host]
outfox has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
Kaizen_K_ has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
rex4539 has joined #bitcoin-core-dev
Elzington_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
Elzington has quit [Ping timeout: 252 seconds]
brunoerg has quit [Ping timeout: 268 seconds]
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has quit [Ping timeout: 268 seconds]
rex4539 has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
arythmetic has joined #bitcoin-core-dev
arythmetic has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
sudoforge has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
arythmetic has joined #bitcoin-core-dev
arythmetic has quit [Ping timeout: 252 seconds]
sdfgsdfg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
bfsfhkacjzgcytf has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
Elzington_ has quit [Quit: Leaving]
arythmetic has joined #bitcoin-core-dev
arythmetic has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/df562d698a38...a377510e3a2a
<bitcoin-git> bitcoin/master a377510 MarcoFalke: Merge bitcoin/bitcoin#23643: rpc: remove info about mallocinfo needing gli...
<bitcoin-git> bitcoin/master 9a09d30 fanquake: rpc: remove info about mallocinfo needing glibc 2.10+
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23643: rpc: remove info about mallocinfo needing glibc 2.10+ (master...remove_glibc_10_warning) https://github.com/bitcoin/bitcoin/pull/23643
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
sdfgsdfg has quit [Quit: ZzzZ]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a377510e3a2a...af1067c4b732
<bitcoin-git> bitcoin/master 7b04a06 Samuel Dobson: Introduce wallet/rpc/util
<bitcoin-git> bitcoin/master af1067c MarcoFalke: Merge bitcoin/bitcoin#23640: MOVEONLY: Move helper functions from rpcwalle...
<bitcoin-git> bitcoin/master ff945e5 Samuel Dobson: MOVEONLY: Move utility functions from rpcwallet to wallet/rpc/util
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23640: MOVEONLY: Move helper functions from rpcwallet to wallet/rpc/util (master...202111_split_walletrpc_util) https://github.com/bitcoin/bitcoin/pull/23640
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
jarthur has quit [Quit: jarthur]
sdfgsdfg has joined #bitcoin-core-dev
goatpig has joined #bitcoin-core-dev
sdfgsdfg has quit [Quit: ZzzZ]
brunoerg has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] meshcollider opened pull request #23647: Split rpcwallet into multiple smaller parts (master...202111_split_walletrpc_total) https://github.com/bitcoin/bitcoin/pull/23647
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
arythmetic has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
arythmetic has quit [Ping timeout: 252 seconds]
vysn has joined #bitcoin-core-dev
arythmetic has joined #bitcoin-core-dev
Guest99 has joined #bitcoin-core-dev
Guest99 has quit [Client Quit]
_flood has quit [Ping timeout: 240 seconds]
arythmetic has quit [Ping timeout: 252 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/af1067c4b732...282cc0cda7a2
<bitcoin-git> bitcoin/master fa7da22 MarcoFalke: refactor: Fix implicit-signed-integer-truncation in cuckoocache.h
<bitcoin-git> bitcoin/master 282cc0c fanquake: Merge bitcoin/bitcoin#23626: refactor: Fix implicit-signed-integer-truncat...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake merged pull request #23626: refactor: Fix implicit-signed-integer-truncation in cuckoocache.h (master...2111-int) https://github.com/bitcoin/bitcoin/pull/23626
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Kaizen_K_ has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
mikehu44 has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
Kaizen_K_ has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
brunoerg has quit [Ping timeout: 252 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
mikehu44 has quit [Client Quit]
rex4539 has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
mikehu44 has joined #bitcoin-core-dev
sdfgsdfg has joined #bitcoin-core-dev
arythmetic has joined #bitcoin-core-dev
arythmetic has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/282cc0cda7a2...6acda4b00b3f
<bitcoin-git> bitcoin/master ffd0928 James O'Beirne: rpc: various fixups for dumptxoutset
<bitcoin-git> bitcoin/master 6acda4b W. J. van der Laan: Merge bitcoin/bitcoin#23155: rpc: various fixups for dumptxoutset
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] laanwj merged pull request #23155: rpc: various fixups for dumptxoutset (master...2021-10-au-rpc-fixes) https://github.com/bitcoin/bitcoin/pull/23155
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
mikehu44 has joined #bitcoin-core-dev
mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
Guyver2_ has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
mikehu44 has quit [Client Quit]
sdfgsdfg has quit [Quit: ZzzZ]
Guyver2 has quit [Ping timeout: 256 seconds]
Guyver2_ is now known as Guyver2
Cory has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
kexkey has quit [Ping timeout: 256 seconds]
kexkey has joined #bitcoin-core-dev
mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
brunoerg has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
smartin has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
dougefish has quit [Ping timeout: 252 seconds]
Guest70 has joined #bitcoin-core-dev
Guest70 has quit [Client Quit]
goatpig has quit [Ping timeout: 256 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
goatpig has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] dougEfresh opened pull request #23648: test: Add functional test for -maxuploadtarget with byte unit '1M' (master...test-byteunit-maxuploadtarget) https://github.com/bitcoin/bitcoin/pull/23648
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] dougEfresh closed pull request #23584: test: Adding functional test for -maxuploadtarget with byte unit 'M' (master...maxuploadtarget-functional-byteunit) https://github.com/bitcoin/bitcoin/pull/23584
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
earnest has joined #bitcoin-core-dev
mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
mikehu44 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] glozow opened pull request #23649: circular dependency followups (master...22677-followups) https://github.com/bitcoin/bitcoin/pull/23649
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Ping timeout: 252 seconds]
mikehu44 has quit [Ping timeout: 252 seconds]
mikehu44 has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 256 seconds]
mikehu44 has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
b10c has joined #bitcoin-core-dev
arythmetic has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
arythmetic has quit [Ping timeout: 252 seconds]
mudsip has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
brunoerg has quit [Ping timeout: 252 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6acda4b00b3f...0bd7ca9a036e
<bitcoin-git> bitcoin/master fab0d99 MarcoFalke: style: Remove whitespace
<bitcoin-git> bitcoin/master 0bd7ca9 MarcoFalke: Merge bitcoin/bitcoin#23642: refactor: Call type-solver earlier in decodes...
<bitcoin-git> bitcoin/master 3333070 MarcoFalke: refactor: Call type-solver earlier in decodescript
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #23642: refactor: Call type-solver earlier in decodescript (master...2112-rpcRefDec) https://github.com/bitcoin/bitcoin/pull/23642
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
flooded is now known as _flood
Zayn has joined #bitcoin-core-dev
Zayn has left #bitcoin-core-dev [#bitcoin-core-dev]
sdfgsdfg has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Remote host closed the connection]
Kaizen_Kintsugi has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
<laanwj> dongcarl: it depends on translatability of the error message; if it's general enough: say, someone with basic knowledge of bitcoin internals can understand it, it should be translated
<laanwj> dongcarl: on the other hand if it's a message about some internal failure scenario then it shouldn't be, it would just confuse and demotivate translators and result in sub-par error messages
<laanwj> but that's the reason to have the *option* of passing a translation string in
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] KambizAsadzadeh opened pull request #23650: Added some safety features from permissions. (master...master) https://github.com/bitcoin/bitcoin/pull/23650
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
arythmetic has joined #bitcoin-core-dev
arythmetic has quit [Ping timeout: 252 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [gui] KambizAsadzadeh opened pull request #496: Added some safety features from permissions. (master...master) https://github.com/bitcoin-core/gui/pull/496
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Kaizen_Kintsugi_ has quit [Ping timeout: 252 seconds]
<laanwj> i just realized we don't mention in the code comments (nor dev docs of the structures) anywhere that ATMP stands for AcceptToMemoryPool
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
sav_ has joined #bitcoin-core-dev
<sipa> ow
<ryanofsky> Could I get #23497 added to https://github.com/bitcoin/bitcoin/projects/8 now that #21206 is off?
<gribble> https://github.com/bitcoin/bitcoin/issues/23497 | Add `src/node/` and `src/wallet/` code to `node::` and `wallet::` namespaces by ryanofsky · Pull Request #23497 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/21206 | refactor: Make CWalletTx sync state type-safe by ryanofsky · Pull Request #21206 · bitcoin/bitcoin · GitHub
<laanwj> ryanofsky: added
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
littlesh has joined #bitcoin-core-dev
arythmetic has joined #bitcoin-core-dev
sdfgsdfg has quit [Quit: ZzzZ]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> bitcoin/master fa815f8 MarcoFalke: Replace addrman.h include with forward decl in net.h
<bitcoin-git> bitcoin/master fa551b3 MarcoFalke: Remove GetAdjustedTime from init.cpp
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0bd7ca9a036e...26a1147ce560
<bitcoin-git> bitcoin/master 26a1147 MarcoFalke: Merge bitcoin/bitcoin#23636: Remove GetAdjustedTime from init.cpp
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #23650: Added some safety features from permissions. (master...master) https://github.com/bitcoin/bitcoin/pull/23650
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #23636: Remove GetAdjustedTime from init.cpp (master...2111-noTimeInit) https://github.com/bitcoin/bitcoin/pull/23636
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
sudoforge has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
adiabat has quit [Remote host closed the connection]
adiabat has joined #bitcoin-core-dev
dougefish has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
mudsip has quit []
goatpig has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
gnaf has joined #bitcoin-core-dev
Elzington has joined #bitcoin-core-dev
<ryanofsky> laanwj: Thanks!
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
sav_ has quit [Quit: Leaving]
brunoerg has quit [Ping timeout: 252 seconds]
Kaizen_Kintsugi has quit [Remote host closed the connection]
Kaizen_Kintsugi has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
Kaizen___ has joined #bitcoin-core-dev
Kaize____ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
Kaizen_K_ has quit [Ping timeout: 268 seconds]
Kaizen___ has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
Aaronvan_ has quit [Ping timeout: 256 seconds]
___nick___ has joined #bitcoin-core-dev
gnaf has quit [Quit: Konversation terminated!]
bomb-on has quit [Quit: aллилѹіа!]
___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
AaronvanW has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
yanmaani has quit [Remote host closed the connection]
yanmaani has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23652: doc: Document optional result fields in getpeerinfo (master...2112-docOptPeer) https://github.com/bitcoin/bitcoin/pull/23652
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bomb-on has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] sipa opened pull request #23653: Generalize/simplify VectorReader into SpanReader (master...202112_spanreader) https://github.com/bitcoin/bitcoin/pull/23653
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Remote host closed the connection]
ZeroMaster has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
sav has joined #bitcoin-core-dev
sav is now known as Guest5350
vysn has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
gnaf has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
Guyver2_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 256 seconds]
Guyver2_ is now known as Guyver2
brunoerg has quit [Ping timeout: 252 seconds]
Bullitje has joined #bitcoin-core-dev
Bullitje has quit [Read error: Connection reset by peer]
Bullitje has joined #bitcoin-core-dev
bomb-on has quit [Quit: aллилѹіа!]
Guyver2_ has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 252 seconds]
Guyver2_ is now known as Guyver2
bomb-on has joined #bitcoin-core-dev
MatanHamilis has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
gene has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
jarthur has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23654: fuzz: Rework rpc fuzz target (master...2112-fuzzRpc) https://github.com/bitcoin/bitcoin/pull/23654
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Guest5350 has quit [Quit: Leaving]
sav has joined #bitcoin-core-dev
Kaize____ has quit [Ping timeout: 268 seconds]
sav is now known as Guest5157
Guest5157 has quit [Client Quit]
Talkless has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Herbsman has quit [Remote host closed the connection]
Herbsman has joined #bitcoin-core-dev
gnaf has quit [Quit: Konversation terminated!]
brunoerg has quit [Ping timeout: 252 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> bitcoin/master c1b99c0 S3RK: Return used destinations from ScriptPubKeyMan::MarkUnusedAddresses
<bitcoin-git> bitcoin/master 03840c2 S3RK: Add CWallet::IsInternalScriptPubKeyMan
<bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/26a1147ce560...bce58bbb3d7b
<bitcoin-git> bitcoin/master 456e350 S3RK: wallet: resolve ambiguity of two ScriptPubKey managers providing same scri...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] laanwj merged pull request #22929: wallet: Automatically add receiving destinations to the address book (master...fix_19856) https://github.com/bitcoin/bitcoin/pull/22929
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
tru3nrg has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/bce58bbb3d7b...0b30bdd519ae
<bitcoin-git> bitcoin/master 5c3033d Hennadii Stepanov: Add thread safety annotations to CBlockPolicyEstimator public functions
<bitcoin-git> bitcoin/master 5ee5b69 Hennadii Stepanov: refactor: Add non-thread-safe CBlockPolicyEstimator::_removeTx helper
<bitcoin-git> bitcoin/master 8c277b1 Hennadii Stepanov: refactor: Make m_cs_fee_estimator non-recursive
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #22014: refactor: Make m_cs_fee_estimator non-recursive (master...210521-fees) https://github.com/bitcoin/bitcoin/pull/22014
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<laanwj> #startmeeting
<core-meetingbot> Meeting started Thu Dec 2 19:00:12 2021 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
<core-meetingbot> Available commands: action commands idea info link nick
<hebasto> hi
<b10c> hi
<kvaciral[m]> hi
<sipa> hi
<laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball
<laanwj> morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
<laanwj> one proposedmeetingtopic: Warn when we have only _old_ peers? (b10c)
<lightlike> hi
<jamesob> hi
<laanwj> any last minute topics?
<laanwj> #topic High priority for review
<core-meetingbot> topic: High priority for review
<meshcollider> hi
<laanwj> https://github.com/bitcoin/bitcoin/projects/8 9 blockers, 1 chasing concept ACK
<laanwj> anything to add/remove or that is almost ready for merge?
<MarcoFalke> can i haz #19499 pls ?
<gribble> https://github.com/bitcoin/bitcoin/issues/19499 | p2p: Make timeout mockable and type safe, speed up test by MarcoFalke · Pull Request #19499 · bitcoin/bitcoin · GitHub
<jamesob> MarcoFalke: oh cool, will review
<laanwj> MarcoFalke: added
<MarcoFalke> thx
<laanwj> would it make sense to add #23443? it's a blocker for erlay and the next step
<gribble> https://github.com/bitcoin/bitcoin/issues/23443 | p2p: Erlay support signaling by naumenkogs · Pull Request #23443 · bitcoin/bitcoin · GitHub
<sipa> won't hurt to add it i guess
<laanwj> ok, will do
dougefish has quit [Quit: dougefish]
<laanwj> does anyone have other suggestions? or wants to discuss an existing high prio PR?
dougefish has joined #bitcoin-core-dev
<laanwj> if not, let's move on to the next topic
<laanwj> #topic Warn when we have only _old_ peers? (b10c)
<core-meetingbot> topic: Warn when we have only _old_ peers? (b10c)
<b10c> I've posted a few comments about why F2Pool initially didn't include P2TR spends in their blocks to the ML: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2021-November/019608.html
<b10c> TLDR: buggy patches to their peer selection. An unmaintained heuristic filtered newer Bitcoin Core peers. But, (IMO) unpublished patches are out of scope for the Bitcoin Core project.
<b10c> However, with currently only ~50% of nodes upgraded, it could still be relevant to warn node operators about e.g. only being connected to peers old that don't relay P2TR spends.
<sipa> a first question is: how would this even be detectable
___nick___ has quit [Ping timeout: 256 seconds]
<b10c> Something like this could be a feature we want before the next soft-fork affecting transaction relay.
<b10c> sipa: right
<b10c> Bump PROTOCOL_VERSION for soft-fork tx relay? service flag e.g. TAPROOT_RELAY? Flag in the version message indicate soft-fork readiness?
<sipa> but this isn't about softforks
<sipa> it's about any change in relay policy
<sipa> though, at least the past few years, the only invasive changes to relay policy (in bitcoin core at least) have been due to softforks, i think
<b10c> and the next question would be: How to warn node operators (besides logging to debug.log)? getnodealerts/getnodewarnings RPC?
<sipa> i think the best approach (assuming there was a way to detect it), would be to add more outgoing connections and/or rotate them faster
<laanwj> we've become kind fo careful about warnings that are not relevant to most users
<sipa> we kind of do something like that when we believe we're only connected to consensus-incompatible peers already
tru3nrg has quit [Quit: Connection closed]
<sipa> but detecting is kind of ugly, i think... because it goes to concerns like should we try to inform our peers about the entirety of our relay policy?
<sipa> and i'm not sure the problem is big enough of a concern to even get into that
<sipa> relay policy is just policy, after all
<b10c> hmm agree, if it would only be for soft-forks maybe a simple flag would be enough. but gets messy with the entirety of policy
brunoerg has joined #bitcoin-core-dev
<lightlike> has this also been an issue in normal circumstances? The mailing list post talks about some artifical addnode scenario, extra automtic outbounds wouldn't help with that.
<laanwj> i do think some heuristic would make sense when broadcasting, e.g. when you broadcast a transaction and no peer relays it back to you
mamilis has joined #bitcoin-core-dev
<sipa> laanwj: that would be useful!
mamilis has quit [Client Quit]
<sipa> though, that may not be sufficient for this case even
<b10c> that would help in the sender case, not in the miner case
<sipa> as it would only make the original tx broadcasters notice, not intermediaries
<b10c> lightlike: I haven't heard about any other case
Guest92 has joined #bitcoin-core-dev
<sipa> given that the first P2TR spends actually reached miners fine within a few blocks kind of shows there were no relay problems (that we know of)
<sipa> and if it's just unfortunate local configuration on the miners side, i don't think this would do much, given what lightlike said
<laanwj> peers witholding certain transactions from you is a subset of the general eclipse problem
Guest92 has quit [Client Quit]
<laanwj> if you're worried about that, especially as a miner you'd likely want to make sure you connect to a few trusted peers (preferably over overlay networks)
brunoerg has quit [Ping timeout: 268 seconds]
<sipa> b10c: oh i see, your assumption was that it would be warning operators, not just trying to fix things automatically
<sipa> i think the only reliable way to warn operators is by shutting down...
<b10c> that is definitely reliable for a mining pool, but also a DoS vector
<sipa> indeed
<laanwj> shutting down based on a heuristic about connected peers seems kind of drastic
<sipa> yes, i only mentioned it in jest
<laanwj> you can do that of course (a watchdog kind of script), but i see no reason to build that into bitcoin core
<b10c> one idea was a RPC interface (e.g. getnodewarnings) to hook into from your monitoring stack
<b10c> to at least have something well defined
<laanwj> but if you have monitoring software, why not call getpeerinfo
<MarcoFalke> there is already getblockchaininfo()[warnings]
<sipa> yeah...
<laanwj> i suppose all the information you need to decide about node versions is there
<laanwj> it's never more than a heuristic, untrusted nodes can lie about versions, version bits, etc
<laanwj> service bits*
<b10c> cool, thanks! This discussion was helpful for me. Maybe a heuristic for a sender if his transaction got relayed back to him... Everything else might be to ambitious and messy
<sipa> yeah i don't really have any good ideas
<b10c> not relayed*
<laanwj> (which is also what makes it somewhat scary as a built-in warning; i remember the spurious new-unsupported-version warnings with the block version bits when miners started using them for... other things)
<laanwj> right
<laanwj> any other topics?
<laanwj> closing the meeting, thanks everyone for attending
<laanwj> #endmeeting
<core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
<core-meetingbot> Meeting ended Thu Dec 2 19:30:19 2021 UTC.
<gene> thanks for the meeting all
Guest50 has joined #bitcoin-core-dev
<b10c> thanks!
pescador has joined #bitcoin-core-dev
Guest50 has quit [Quit: Client closed]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
<cfields> whoops, missed the meeting.
Kaizen_Kintsugi has quit [Remote host closed the connection]
Talkless has quit [Quit: Konversation terminated!]
Kaizen_Kintsugi has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
<laanwj> heh
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 268 seconds]
Kaizen_K_ has quit [Ping timeout: 268 seconds]
pescador has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
Elzington_ has joined #bitcoin-core-dev
Elzington has quit [Ping timeout: 252 seconds]
vysn has joined #bitcoin-core-dev
_flood has quit [Ping timeout: 252 seconds]
Kaizen_Kintsugi has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
flooded has joined #bitcoin-core-dev
flooded is now known as _flood
jarthur has quit [Read error: Connection reset by peer]
jarthur has joined #bitcoin-core-dev
smartin has quit [Remote host closed the connection]
smartin has joined #bitcoin-core-dev
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
Kaizen_Kintsugi has quit [Remote host closed the connection]
Kaizen_Kintsugi has joined #bitcoin-core-dev
sdfgsdfg has joined #bitcoin-core-dev
mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
brunoerg has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] Baumgartl opened pull request #23658: contrib: add check for wget command in install_db4.sh (master...contrib-patches) https://github.com/bitcoin/bitcoin/pull/23658
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Kaizen_Kintsugi has quit [Remote host closed the connection]
Kaizen_Kintsugi has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
Kaizen_Kintsugi has quit [Ping timeout: 268 seconds]
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has quit [Ping timeout: 268 seconds]
ZeroMaster has quit [Remote host closed the connection]
Kaizen_K_ has joined #bitcoin-core-dev
ZeroMaster has joined #bitcoin-core-dev
Kaizen_Kintsugi has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
AaronvanW has quit [Remote host closed the connection]
<jamesob> was there some merge causing unrebased PRs to start failing? seeing a lot of unrelated "TypeError: generatetoaddress() missing 1 required keyword-only argument: 'invalid_call'" failures in the functional tests for new PRs
littlesh has quit [Quit: Going offline, see ya! (www.adiirc.com)]
<sipa> i'm seeing that too
sdfgsdfg has quit [Quit: ZzzZ]
<jamesob> fix incoming
brunoerg has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] jamesob opened pull request #23659: test: fix: remove outdated TestNode.generate calls (master...2021-12-fix-listtransactions-generate) https://github.com/bitcoin/bitcoin/pull/23659
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Ping timeout: 256 seconds]
Guest38 has joined #bitcoin-core-dev
rex4539 has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
AaronvanW has joined #bitcoin-core-dev
Guest38 has quit [Quit: Client closed]
pinheadmz_ has quit [Quit: ZNC 1.8.2+deb1+bionic2 - https://znc.in]
pinheadmz has joined #bitcoin-core-dev
BUSY has quit [Remote host closed the connection]
smartin has quit [Ping timeout: 256 seconds]
Kaizen_K_ has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
rex4539 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
d4TuR4 has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]