00:05
AaronvanW has quit [Remote host closed the connection]
00:14
brunoerg has joined #bitcoin-core-dev
00:18
brunoerg has quit [Ping timeout: 240 seconds]
00:18
weylin_ has quit [Remote host closed the connection]
00:19
weylin_ has joined #bitcoin-core-dev
00:21
Kaizen_K_ has quit [Remote host closed the connection]
00:22
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
00:23
Jackielove4u has quit [Quit: Connection closed for inactivity]
00:23
weylin_ has quit [Ping timeout: 240 seconds]
00:23
Kaizen_K_ has joined #bitcoin-core-dev
00:26
Kaizen_Kintsugi_ has quit [Ping timeout: 265 seconds]
00:28
Kaizen_K_ has quit [Ping timeout: 240 seconds]
00:28
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
00:33
Kaizen_Kintsugi_ has quit [Ping timeout: 252 seconds]
00:34
TheRec_ has quit [Ping timeout: 252 seconds]
00:34
<
fanquake >
dougefish wumpus: that's currently known, and part of #23340
00:35
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
00:36
Kaizen_K_ has joined #bitcoin-core-dev
00:39
Kaizen_Kintsugi_ has quit [Ping timeout: 265 seconds]
00:40
Kaizen_K_ has quit [Ping timeout: 265 seconds]
00:46
achow101 has quit [Quit: Bye]
00:46
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
00:47
brunoerg has joined #bitcoin-core-dev
00:47
achow101 has joined #bitcoin-core-dev
00:51
brunoerg has quit [Ping timeout: 240 seconds]
00:57
bitcoin-git has joined #bitcoin-core-dev
00:57
<
bitcoin-git >
bitcoin/master faef7e9 MarcoFalke: doc: Merge release note snippets
00:57
<
bitcoin-git >
bitcoin/master 6223e55 fanquake: Merge bitcoin/bitcoin#23685: doc: Merge release note snippets
00:57
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
00:57
bitcoin-git has joined #bitcoin-core-dev
00:57
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
01:04
mikehu44 has joined #bitcoin-core-dev
01:06
mikehu44 has quit [Client Quit]
01:07
weylin_ has joined #bitcoin-core-dev
01:11
weylin_ has quit [Ping timeout: 256 seconds]
01:13
weylin_ has joined #bitcoin-core-dev
01:17
weylin_ has quit [Ping timeout: 252 seconds]
01:22
brunoerg has joined #bitcoin-core-dev
01:27
brunoerg has quit [Ping timeout: 252 seconds]
01:43
sudoforge has joined #bitcoin-core-dev
01:50
Kaizen_Kintsugi_ has quit [Ping timeout: 252 seconds]
01:51
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
01:55
Kaizen_Kintsugi_ has quit [Ping timeout: 265 seconds]
01:58
brunoerg has joined #bitcoin-core-dev
02:03
brunoerg has quit [Ping timeout: 240 seconds]
02:04
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
02:10
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
02:11
weylin_ has joined #bitcoin-core-dev
02:15
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
02:16
Kaizen_K_ has joined #bitcoin-core-dev
02:17
TheRec has joined #bitcoin-core-dev
02:17
TheRec has joined #bitcoin-core-dev
02:19
Kaizen_Kintsugi_ has quit [Ping timeout: 265 seconds]
02:23
bomb-on has quit [Quit: aллилѹіа!]
02:43
Guest72 has joined #bitcoin-core-dev
02:43
Guest72 has quit [Client Quit]
02:49
TheRec has quit [Ping timeout: 265 seconds]
02:50
brunoerg has joined #bitcoin-core-dev
02:54
brunoerg has quit [Ping timeout: 252 seconds]
02:54
Kaizen_K_ has quit [Remote host closed the connection]
02:55
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
03:00
weylin_ has quit [Ping timeout: 240 seconds]
03:10
bitdex has joined #bitcoin-core-dev
03:23
brunoerg has joined #bitcoin-core-dev
03:28
brunoerg has quit [Ping timeout: 265 seconds]
03:42
mikehu44 has joined #bitcoin-core-dev
03:46
mikehu44 has quit [Ping timeout: 252 seconds]
03:47
mikehu44 has joined #bitcoin-core-dev
03:59
mikehu44 has quit [Ping timeout: 240 seconds]
04:00
mikehu44 has joined #bitcoin-core-dev
04:04
TheRec has joined #bitcoin-core-dev
04:04
TheRec has quit [Changing host]
04:04
TheRec has joined #bitcoin-core-dev
04:12
jarthur_ has quit [Ping timeout: 265 seconds]
04:20
rex4539 has quit [Remote host closed the connection]
04:20
rex4539 has joined #bitcoin-core-dev
04:28
jarthur has joined #bitcoin-core-dev
04:30
brunoerg has joined #bitcoin-core-dev
04:35
brunoerg has quit [Ping timeout: 268 seconds]
04:35
sudoforge has quit [Quit: 404]
04:38
TheRec has quit [Read error: Connection reset by peer]
04:39
TheRec has joined #bitcoin-core-dev
04:39
TheRec has quit [Changing host]
04:39
TheRec has joined #bitcoin-core-dev
04:46
dviola has quit [Quit: WeeChat 3.3]
04:52
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
04:52
Victorsueca has quit [Read error: Connection reset by peer]
04:53
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
04:54
Kaizen_K_ has joined #bitcoin-core-dev
04:54
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
04:55
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
04:55
Kaizen_K_ has quit [Remote host closed the connection]
04:56
Kaizen_K_ has joined #bitcoin-core-dev
04:56
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
04:57
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
04:57
Kaizen_K_ has quit [Remote host closed the connection]
04:58
Kaizen_K_ has joined #bitcoin-core-dev
04:58
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
04:58
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
04:59
Kaizen_K_ has quit [Remote host closed the connection]
04:59
Kaizen_K_ has joined #bitcoin-core-dev
05:00
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
05:00
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
05:01
cmirror has quit [Remote host closed the connection]
05:01
Kaizen_K_ has quit [Remote host closed the connection]
05:01
cmirror has joined #bitcoin-core-dev
05:01
Kaizen_K_ has joined #bitcoin-core-dev
05:01
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
05:02
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
05:02
Kaizen_K_ has quit [Remote host closed the connection]
05:03
Kaizen_K_ has joined #bitcoin-core-dev
05:03
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
05:04
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
05:04
brunoerg has joined #bitcoin-core-dev
05:04
Kaizen_K_ has quit [Remote host closed the connection]
05:05
Kaizen_K_ has joined #bitcoin-core-dev
05:05
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
05:05
Guest75 has joined #bitcoin-core-dev
05:05
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
05:06
Guest75 has quit [Client Quit]
05:06
Kaizen_K_ has quit [Remote host closed the connection]
05:06
Kaizen_K_ has joined #bitcoin-core-dev
05:07
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
05:07
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
05:07
Kaizen_K_ has quit [Remote host closed the connection]
05:08
Kaizen_K_ has joined #bitcoin-core-dev
05:08
brunoerg has quit [Ping timeout: 252 seconds]
05:12
Kaizen_Kintsugi_ has quit [Ping timeout: 265 seconds]
05:21
Elzington has quit [Quit: Leaving]
05:24
vasild has quit [Remote host closed the connection]
05:24
vasild has joined #bitcoin-core-dev
05:25
jarthur has quit [Quit: jarthur]
05:40
sdfgsdfg has quit [Quit: ZzzZ]
05:44
sdfgsdfg has joined #bitcoin-core-dev
05:53
brunoerg has joined #bitcoin-core-dev
05:57
brunoerg has quit [Ping timeout: 240 seconds]
06:11
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
06:11
Kaizen_K_ has quit [Remote host closed the connection]
06:12
Kaizen_K_ has joined #bitcoin-core-dev
06:12
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
06:13
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
06:13
Kaizen_K_ has quit [Remote host closed the connection]
06:13
Kaizen_K_ has joined #bitcoin-core-dev
06:14
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
06:14
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
06:15
Kaizen_K_ has quit [Remote host closed the connection]
06:15
Kaizen_K_ has joined #bitcoin-core-dev
06:17
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
06:18
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
06:21
Kaizen_K_ has quit [Ping timeout: 265 seconds]
06:25
lukedashjr has joined #bitcoin-core-dev
06:27
luke-jr has quit [Ping timeout: 256 seconds]
06:27
lukedashjr is now known as luke-jr
06:46
brunoerg has joined #bitcoin-core-dev
06:50
brunoerg has quit [Ping timeout: 265 seconds]
06:51
sdfgsdfg has quit [Quit: ZzzZ]
06:58
earnest has quit [Ping timeout: 240 seconds]
07:03
saranshsharma has joined #bitcoin-core-dev
07:06
Elzington has joined #bitcoin-core-dev
07:08
saranshsharma has quit [Ping timeout: 252 seconds]
07:19
Kaizen_K_ has joined #bitcoin-core-dev
07:21
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
07:22
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
07:24
Kaizen_K_ has quit [Ping timeout: 265 seconds]
07:36
brunoerg has joined #bitcoin-core-dev
07:40
brunoerg has quit [Ping timeout: 240 seconds]
07:54
bitcoin-git has joined #bitcoin-core-dev
07:54
<
bitcoin-git >
bitcoin/master e4fa28a Sebastian Falbesoner: test: fix test interface_bitcoin_cli.py for descriptor wallets
07:54
<
bitcoin-git >
bitcoin/master 877f3aa MarcoFalke: Merge bitcoin/bitcoin#23686: test: fix `interface_bitcoin_cli.py --descrip...
07:54
<
bitcoin-git >
bitcoin/master 035767f Sebastian Falbesoner: test: add interface_bitcoin_cli.py --descriptors to test_runner.py
07:55
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
07:55
bitcoin-git has joined #bitcoin-core-dev
07:55
<
bitcoin-git >
[bitcoin] MarcoFalke merged pull request #23686: test: fix `interface_bitcoin_cli.py --descriptors` and add to test runner (master...202112-test-fix-interface_bitcoin_cli-with-descriptors)
https://github.com/bitcoin/bitcoin/pull/23686
07:55
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
08:01
bitcoin-git has joined #bitcoin-core-dev
08:01
<
bitcoin-git >
bitcoin/master 08dcc59 MarcoFalke: Merge bitcoin/bitcoin#23688: test: remove unneeded sync_all() calls in wal...
08:01
<
bitcoin-git >
bitcoin/master 0ba98ed Sebastian Falbesoner: test: remove unneeded sync_all() calls in wallet_listtransactions.py
08:01
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
08:01
bitcoin-git has joined #bitcoin-core-dev
08:01
<
bitcoin-git >
[bitcoin] MarcoFalke merged pull request #23688: test: remove unneeded sync_all() calls in wallet_listtransactions.py (master...2021-test-remove_sync_all_calls_in_wallet_listtransactions)
https://github.com/bitcoin/bitcoin/pull/23688
08:01
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
08:03
mikehu44 has joined #bitcoin-core-dev
08:05
bitcoin-git has joined #bitcoin-core-dev
08:05
<
bitcoin-git >
bitcoin/master fa37e79 MarcoFalke: wallet: Replace confusing getAdjustedTime() with GetTime()
08:05
<
bitcoin-git >
bitcoin/master 42b2502 MarcoFalke: Merge bitcoin/bitcoin#23644: wallet: Replace confusing getAdjustedTime() w...
08:05
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
08:06
bitcoin-git has joined #bitcoin-core-dev
08:06
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
08:06
grettke has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
08:11
bitcoin-git has joined #bitcoin-core-dev
08:11
<
bitcoin-git >
bitcoin/master 5767208 brianddk: correct rpc address_type helptext
08:11
<
bitcoin-git >
bitcoin/master 9a53ba4 MarcoFalke: Merge bitcoin/bitcoin#23676: rpc: correct `getnewaddress`/`getrawchangeadd...
08:11
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
08:11
bitcoin-git has joined #bitcoin-core-dev
08:11
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
08:13
gnaf has joined #bitcoin-core-dev
08:23
bitcoin-git has joined #bitcoin-core-dev
08:23
<
bitcoin-git >
bitcoin/master 31ba1af Pieter Wuille: Remove unused (and broken) functionality in SpanReader
08:23
<
bitcoin-git >
bitcoin/master b7e6330 MarcoFalke: Merge bitcoin/bitcoin#23687: Remove unused (and broken) functionality in S...
08:23
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
08:23
bitcoin-git has joined #bitcoin-core-dev
08:23
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
08:26
Kaizen_K_ has joined #bitcoin-core-dev
08:26
brunoerg has joined #bitcoin-core-dev
08:26
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
08:27
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
08:28
bitcoin-git has joined #bitcoin-core-dev
08:28
<
bitcoin-git >
bitcoin/master 89ea2b3 MarcoFalke: Merge bitcoin/bitcoin#20583: rpc: Add missing BlockUntilSyncedToCurrentCha...
08:28
<
bitcoin-git >
bitcoin/master fa5362a MarcoFalke: rpc: Add missing BlockUntilSyncedToCurrentChain to wallet RPCs
08:28
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
08:28
bitcoin-git has joined #bitcoin-core-dev
08:28
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
08:29
Kaizen_K_ has quit [Remote host closed the connection]
08:30
Kaizen_K_ has joined #bitcoin-core-dev
08:30
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
08:31
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
08:31
brunoerg has quit [Ping timeout: 240 seconds]
08:32
Guyver2 has joined #bitcoin-core-dev
08:34
Kaizen_K_ has quit [Ping timeout: 240 seconds]
09:00
objdefined[m] has quit [Quit: You have been kicked for being idle]
09:03
dermoth has quit [Ping timeout: 256 seconds]
09:05
sdfgsdfg has joined #bitcoin-core-dev
09:13
bitcoin-git has joined #bitcoin-core-dev
09:13
<
bitcoin-git >
bitcoin/master d6d402b fanquake: build: remove x-prefix comparisons
09:13
<
bitcoin-git >
bitcoin/master 61b82a8 MarcoFalke: Merge bitcoin/bitcoin#23593: build: remove x-prefix's from comparisons
09:13
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
09:13
bitcoin-git has joined #bitcoin-core-dev
09:13
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
09:15
dermoth has joined #bitcoin-core-dev
09:17
brunoerg has joined #bitcoin-core-dev
09:17
bitcoin-git has joined #bitcoin-core-dev
09:17
<
bitcoin-git >
bitcoin/master 084c81c MarcoFalke: Merge bitcoin/bitcoin#23547: Bugfix: RPC/mining: Fail properly in estimate...
09:17
<
bitcoin-git >
bitcoin/master cd8d156 Luke Dashjr: Bugfix: RPC/mining: Fail properly in estimatesmartfee if smart fee data is...
09:17
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
09:17
bitcoin-git has joined #bitcoin-core-dev
09:17
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
09:18
earnest has joined #bitcoin-core-dev
09:21
brunoerg has quit [Ping timeout: 265 seconds]
09:31
Kaizen_K_ has joined #bitcoin-core-dev
09:33
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
09:34
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
09:35
Kaizen_K_ has quit [Remote host closed the connection]
09:36
Kaizen_K_ has joined #bitcoin-core-dev
09:36
dermoth has quit [Ping timeout: 252 seconds]
09:37
bitcoin-git has joined #bitcoin-core-dev
09:37
<
bitcoin-git >
bitcoin/master 0c85dc3 Martin Zumsande: p2p: Don't use timestamps from inbound peers
09:37
<
bitcoin-git >
bitcoin/master e457513 fanquake: Merge bitcoin/bitcoin#23631: p2p: Don't use timestamps from inbound peers ...
09:37
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
09:38
bitcoin-git has joined #bitcoin-core-dev
09:38
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
09:38
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
09:47
bitcoin-git has joined #bitcoin-core-dev
09:47
<
bitcoin-git >
bitcoin/master 29e9833 Shorya: Fixes Bug in Transaction generation in ComplexMempool benchmark
09:47
<
bitcoin-git >
bitcoin/master abc26fa MarcoFalke: Merge bitcoin/bitcoin#22856: test: Fix bug in transaction generation in Co...
09:47
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
09:47
bitcoin-git has joined #bitcoin-core-dev
09:47
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
09:48
dermoth has joined #bitcoin-core-dev
09:49
rex4539 has quit [Ping timeout: 276 seconds]
09:50
bitcoin-git has joined #bitcoin-core-dev
09:50
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
09:51
rex4539 has joined #bitcoin-core-dev
09:57
rex4539 has quit [Remote host closed the connection]
10:06
AaronvanW has joined #bitcoin-core-dev
10:09
<
vasild >
jonatack: MarcoFalke: I stared for some time in #17161 but I don't see where the bug is. In some places its access may be out of sync with the actual on disk state but in those cases a read error (not found) from disk is handled/expected
10:09
brunoerg has joined #bitcoin-core-dev
10:14
brunoerg has quit [Ping timeout: 265 seconds]
10:23
grettke has joined #bitcoin-core-dev
10:28
rex4539 has joined #bitcoin-core-dev
10:30
dermoth has quit [Ping timeout: 252 seconds]
10:36
grettke has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
10:36
grettke has joined #bitcoin-core-dev
10:37
rex4539 has quit [Remote host closed the connection]
10:38
rex4539 has joined #bitcoin-core-dev
10:43
dermoth has joined #bitcoin-core-dev
10:49
yanmaani1 is now known as yanmaani
10:59
dermoth has quit [Ping timeout: 265 seconds]
11:02
brunoerg has joined #bitcoin-core-dev
11:06
<
jonatack >
vasild: oh nice, thanks for looking. I stared a bit at it yesterday and tentatively ended up covering ReadBlockFromDisk() with a thread safety lock annotation, plan to re-look further today
11:07
brunoerg has quit [Ping timeout: 240 seconds]
11:07
<
vasild >
I think there is no need to cover ReadFromDisk() with cs_main - the code already expects that it may fail.
11:08
<
vasild >
and behaves the same if nStatus does not have HAVE_DATE
11:11
rex4539 has quit [Ping timeout: 276 seconds]
11:12
dermoth has joined #bitcoin-core-dev
11:39
bitcoin-git has joined #bitcoin-core-dev
11:39
<
bitcoin-git >
bitcoin/master 1ed5681 Sebastian Falbesoner: rpc: add missing scantxoutset examples
11:39
<
bitcoin-git >
bitcoin/master 6ac8c4f W. J. van der Laan: Merge bitcoin/bitcoin#23634: rpc: add missing scantxoutset examples
11:39
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
11:39
bitcoin-git has joined #bitcoin-core-dev
11:39
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
11:42
bitcoin-git has joined #bitcoin-core-dev
11:42
<
bitcoin-git >
bitcoin/master 78a6bc6 Hennadii Stepanov: build, qt: Use Android NDK r23 LTS
11:42
<
bitcoin-git >
bitcoin/master 6db7e43 fanquake: Merge bitcoin/bitcoin#23677: build, qt: Use Android NDK r23 LTS
11:42
Jackielove4u has joined #bitcoin-core-dev
11:42
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
11:43
bitcoin-git has joined #bitcoin-core-dev
11:43
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
11:46
sdfgsdfg has quit [Quit: ZzzZ]
11:49
<
jonatack >
seeing OOM in the CI bench unit tests
11:49
<
fanquake >
yes it's an issue after #22856
11:53
<
MarcoFalke >
Hmm, sorry for that. OOM explains why my firefox crashed.
11:55
brunoerg has joined #bitcoin-core-dev
12:00
brunoerg has quit [Ping timeout: 265 seconds]
12:02
bomb-on has joined #bitcoin-core-dev
12:10
Guest82 has joined #bitcoin-core-dev
12:11
brunoerg has joined #bitcoin-core-dev
12:12
brunoerg has quit [Remote host closed the connection]
12:14
Guest82 has quit [Client Quit]
12:18
<
laanwj >
so should we revert 22856?
12:20
<
MarcoFalke >
Odd that I can only reproduce this in the CI env
12:20
<
laanwj >
i reviewed that PR and didn't see anythign that clearly introdcues an OOM issue it must be something subtle
12:22
<
MarcoFalke >
It might be the change from vin.size() to vout.size()
12:22
<
MarcoFalke >
Maybe if the benchmark runs longer it will explode?
12:22
dougefish has quit [Ping timeout: 252 seconds]
12:22
<
MarcoFalke >
There is some auto-scaling, which might only hit in some envs
12:25
<
jonatack >
had the impression it was hung in the bench section when running the unit tests locally in debian (and ctrl-C'ed to exit) before seeing the CI failures
12:26
bitcoin-git has joined #bitcoin-core-dev
12:26
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
12:27
<
laanwj >
running the bitcoin_bench completely crashed my dev machine
12:28
<
laanwj >
so yes, i can reproduce :-)
12:28
<
MarcoFalke >
Probably good advice to not run the tests for now
12:28
<
MarcoFalke >
Maybe this is not an OOM after all?
12:30
brunoerg has joined #bitcoin-core-dev
12:34
brunoerg has quit [Ping timeout: 268 seconds]
12:39
<
sanket1729 >
According to 'descriptors.md', The checksum for a descriptor without one can be computed using the getdescriptorinfo RPC.
12:40
<
sanket1729 >
But the descriptor it outputs removes all private keys
12:41
<
sanket1729 >
oops, I think I messed up something. Ignore the above
12:42
<
MarcoFalke >
yeah, maybe best to revert wholesale
12:42
<
sanket1729 >
There is a separate checksum field in the output of getdescriptorinfo that has checksum of the original input if it contained private keys
12:43
<
MarcoFalke >
laanwj: Are you going to push the revert directly or want a pull opened?
12:49
bitcoin-git has joined #bitcoin-core-dev
12:49
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
12:58
dougefish has joined #bitcoin-core-dev
13:05
brunoerg has joined #bitcoin-core-dev
13:09
brunoerg has quit [Ping timeout: 240 seconds]
13:25
bitcoin-git has joined #bitcoin-core-dev
13:25
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
13:28
bitcoin-git has joined #bitcoin-core-dev
13:28
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
13:33
yanmaani has quit [Remote host closed the connection]
13:34
yanmaani has joined #bitcoin-core-dev
13:40
brunoerg has joined #bitcoin-core-dev
13:43
Guyver2 has left #bitcoin-core-dev [Closing Window]
13:51
bitdex has quit [Quit: = ""]
13:53
bitcoin-git has joined #bitcoin-core-dev
13:53
<
bitcoin-git >
bitcoin/master faa185b MarcoFalke: Revert "Fixes Bug in Transaction generation in ComplexMempool benchmark"
13:53
<
bitcoin-git >
bitcoin/master 95fe477 MarcoFalke: Merge bitcoin/bitcoin#23693: Revert "Fixes Bug in Transaction generation i...
13:53
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
13:53
bitcoin-git has joined #bitcoin-core-dev
13:53
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
13:55
Kaizen_K_ has quit [Ping timeout: 240 seconds]
13:55
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
14:00
rex4539 has joined #bitcoin-core-dev
14:01
<
MarcoFalke >
ok, it is not an OOM
14:07
saranshsharma has joined #bitcoin-core-dev
14:09
<
MarcoFalke >
Well, the integer overflow could lead to OOM maybe
14:13
saranshsharma has quit [Remote host closed the connection]
14:14
saranshsharma has joined #bitcoin-core-dev
14:16
saranshsharma has quit [Remote host closed the connection]
14:16
saranshsharma has joined #bitcoin-core-dev
14:20
saranshsharma has quit [Remote host closed the connection]
14:20
saranshsharma has joined #bitcoin-core-dev
14:22
saranshsharma has quit [Remote host closed the connection]
14:23
saranshsharma has joined #bitcoin-core-dev
14:23
saranshsharma has quit [Remote host closed the connection]
14:24
saranshsharma has joined #bitcoin-core-dev
14:26
brunoerg has quit [Remote host closed the connection]
14:27
bitcoin-git has joined #bitcoin-core-dev
14:27
<
bitcoin-git >
bitcoin/master 2ee406c josibake: test: add functional test for deprecatedrpc=fees
14:27
<
bitcoin-git >
bitcoin/master 07ade7d josibake: doc: add release note for fee field deprecation
14:27
<
bitcoin-git >
bitcoin/master 35d928c josibake: rpc: deprecate fee fields from mempool entries
14:27
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
14:28
bitcoin-git has joined #bitcoin-core-dev
14:28
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
14:30
saranshsharma has quit [Ping timeout: 256 seconds]
14:35
saranshsharma has joined #bitcoin-core-dev
14:40
saranshsharma has quit [Ping timeout: 265 seconds]
14:42
saranshsharma has joined #bitcoin-core-dev
14:42
brunoerg has joined #bitcoin-core-dev
14:43
ajonas_ has quit []
14:44
ajonas has joined #bitcoin-core-dev
14:47
saranshsharma has quit [Ping timeout: 240 seconds]
14:47
brunoerg has quit [Ping timeout: 252 seconds]
14:56
Kaizen_K_ has joined #bitcoin-core-dev
14:58
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
14:59
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
15:01
Kaizen_K_ has quit [Ping timeout: 240 seconds]
15:03
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
15:05
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
15:08
mikehu44 has quit [Ping timeout: 256 seconds]
15:09
Kaizen_Kintsugi_ has quit [Ping timeout: 265 seconds]
15:12
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
15:17
brunoerg has joined #bitcoin-core-dev
15:21
brunoerg has quit [Ping timeout: 240 seconds]
15:28
jtrag has joined #bitcoin-core-dev
15:48
brunoerg has joined #bitcoin-core-dev
16:00
jtrag has quit [Remote host closed the connection]
16:00
jtrag has joined #bitcoin-core-dev
16:01
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
16:01
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
16:02
bitcoin-git has joined #bitcoin-core-dev
16:02
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
16:16
jtrag_alt has joined #bitcoin-core-dev
16:18
rex4539 has quit [Ping timeout: 276 seconds]
16:20
jtrag has quit [Ping timeout: 268 seconds]
16:30
arythmetic has joined #bitcoin-core-dev
16:33
gene has joined #bitcoin-core-dev
16:35
jtrag has joined #bitcoin-core-dev
16:36
gleb7 has quit [Ping timeout: 268 seconds]
16:37
<
jeremyrubin >
laanwj: very weird
16:37
<
jeremyrubin >
the test is indeed pretty brittle since the point is just to make a big messy graph
16:37
<
jeremyrubin >
maybe the tweaks make the graph grow unboundedly?
16:39
jtrag_alt has quit [Ping timeout: 240 seconds]
16:45
jarthur has joined #bitcoin-core-dev
16:47
arythmetic has quit [Remote host closed the connection]
16:52
emcy has quit [Quit: Leaving]
16:53
emcy has joined #bitcoin-core-dev
16:57
emcy has quit [Client Quit]
16:58
emcy has joined #bitcoin-core-dev
16:58
emcy has quit [Remote host closed the connection]
17:00
emcy has joined #bitcoin-core-dev
17:00
emcy has quit [Client Quit]
17:01
emcy has joined #bitcoin-core-dev
17:07
gene has quit [Remote host closed the connection]
17:08
gene has joined #bitcoin-core-dev
17:21
gene has quit [Remote host closed the connection]
17:21
gene has joined #bitcoin-core-dev
17:22
jtrag_alt has joined #bitcoin-core-dev
17:23
arythmetic has joined #bitcoin-core-dev
17:26 ___nick___ has joined #bitcoin-core-dev
17:26
jtrag has quit [Ping timeout: 265 seconds]
17:27
arythmetic has quit [Ping timeout: 240 seconds]
17:46
bitcoin-git has joined #bitcoin-core-dev
17:46
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
17:48 ___nick___ has joined #bitcoin-core-dev
17:49
bitcoin-git has joined #bitcoin-core-dev
17:49
<
bitcoin-git >
bitcoin/master 275e939 Jon Atack: mining, refactor: add m_mempool.cs thread safety lock assertions
17:49
<
bitcoin-git >
bitcoin/master eaf1c56 MarcoFalke: Merge bitcoin/bitcoin#23692: mining, refactor: add m_mempool.cs thread saf...
17:49
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
17:50
bitcoin-git has joined #bitcoin-core-dev
17:50
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
17:52
jtrag has joined #bitcoin-core-dev
17:56
jtrag_alt has quit [Ping timeout: 256 seconds]
18:00
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
18:01
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
18:01
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
18:02
Kaizen_K_ has joined #bitcoin-core-dev
18:03
gene has quit [Remote host closed the connection]
18:04
gene has joined #bitcoin-core-dev
18:06
Talkless has joined #bitcoin-core-dev
18:06
Kaizen_K_ has quit [Ping timeout: 252 seconds]
18:07
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
18:08
jtrag_alt has joined #bitcoin-core-dev
18:11
jtrag has quit [Ping timeout: 252 seconds]
18:12
Kaizen_K_ has joined #bitcoin-core-dev
18:12
Kaizen_Kintsugi_ has quit [Ping timeout: 265 seconds]
18:12
gleb7 has joined #bitcoin-core-dev
18:15
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
18:17
Kaizen_K_ has quit [Ping timeout: 256 seconds]
18:20
Kaizen_Kintsugi_ has quit [Ping timeout: 265 seconds]
18:23
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
18:28
gene has quit [Ping timeout: 276 seconds]
18:29
gene has joined #bitcoin-core-dev
18:30
gene has quit [Remote host closed the connection]
18:30
arythmetic has joined #bitcoin-core-dev
18:31
gene has joined #bitcoin-core-dev
18:32
arythmetic has quit [Remote host closed the connection]
18:32
arythmetic has joined #bitcoin-core-dev
18:42
Elzington has quit [Quit: Leaving]
18:47
brunoerg has quit [Remote host closed the connection]
18:48
kexkey has quit [Ping timeout: 265 seconds]
18:50
kexkey has joined #bitcoin-core-dev
18:56
jonatack has quit [Ping timeout: 252 seconds]
19:00
jtrag_alt is now known as jtrag
19:03
brunoerg has joined #bitcoin-core-dev
19:04
rex4539 has joined #bitcoin-core-dev
19:07
brunoerg has quit [Ping timeout: 240 seconds]
19:09
gene has quit [Remote host closed the connection]
19:09
jtrag_alt has joined #bitcoin-core-dev
19:09
gene has joined #bitcoin-core-dev
19:13
jtrag has quit [Ping timeout: 256 seconds]
19:17
Talkless has quit [Quit: Konversation terminated!]
19:18
gene has quit [Remote host closed the connection]
19:19
gene has joined #bitcoin-core-dev
19:21
common has quit [Quit: Leaving]
19:24
Kaizen_K_ has joined #bitcoin-core-dev
19:26
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
19:27
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
19:28
Kaizen_K_ has quit [Remote host closed the connection]
19:29
Kaizen_K_ has joined #bitcoin-core-dev
19:32
Kaizen_Kintsugi_ has quit [Ping timeout: 265 seconds]
19:38
brunoerg has joined #bitcoin-core-dev
19:43
brunoerg has quit [Ping timeout: 240 seconds]
19:48 ___nick___ has joined #bitcoin-core-dev
19:53
bitcoin-git has joined #bitcoin-core-dev
19:53
<
bitcoin-git >
bitcoin/master 1dcba99 Andrew Toth: Coinbase receivedby rpcs release notes
19:53
<
bitcoin-git >
bitcoin/master bce20c3 Andrew Toth: Include coinbase transactions in receivedby wallet rpcs
19:53
<
bitcoin-git >
bitcoin/master b569675 Andrew Toth: Test including coinbase transactions in receivedby wallet rpcs
19:53
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
19:53
bitcoin-git has joined #bitcoin-core-dev
19:53
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
19:54
jtrag_alt is now known as jtrag
19:59
sdfgsdfg has joined #bitcoin-core-dev
20:04
gene has quit [Remote host closed the connection]
20:05
gene has joined #bitcoin-core-dev
20:05
TracaChang has joined #bitcoin-core-dev
20:08
jtrag_alt has joined #bitcoin-core-dev
20:09
gene has quit [Remote host closed the connection]
20:11
jtrag has quit [Ping timeout: 268 seconds]
20:12
jtrag_alt is now known as Bob
20:12
Bob is now known as jtrag_alt
20:12
jtrag_alt has quit [Quit: <----- is PODAK (Passed out drunk at keyboard), and he has somehow managed to quit/disconnect...]
20:13
brunoerg has joined #bitcoin-core-dev
20:14
gene has joined #bitcoin-core-dev
20:16
jonatack has joined #bitcoin-core-dev
20:17
brunoerg has quit [Ping timeout: 240 seconds]
20:21
jonatack has quit [Ping timeout: 240 seconds]
20:21
Kaizen_K_ has quit [Ping timeout: 265 seconds]
20:27
EPiSKiNG- has quit [Quit: EPiSKiNG-]
20:30
EPiSKiNG- has joined #bitcoin-core-dev
20:35
gene has quit [Remote host closed the connection]
20:36
gene has joined #bitcoin-core-dev
20:48 ___nick___ has joined #bitcoin-core-dev
20:54
common has joined #bitcoin-core-dev
20:57
TracaChang has quit [Quit: Leaving]
21:04 ___nick___ has quit [Ping timeout: 240 seconds]
21:05
brunoerg has joined #bitcoin-core-dev
21:05
gene has quit [Remote host closed the connection]
21:09
jonatack has joined #bitcoin-core-dev
21:10
brunoerg has quit [Ping timeout: 265 seconds]
21:10
gene has joined #bitcoin-core-dev
21:15
sudoforge has joined #bitcoin-core-dev
21:21
brunoerg has joined #bitcoin-core-dev
21:23
sdfgsdfg has quit [Quit: ZzzZ]
21:47
brunoerg has quit [Remote host closed the connection]
21:51
brunoerg has joined #bitcoin-core-dev
22:02
brunoerg has quit [Remote host closed the connection]
22:19
brunoerg has joined #bitcoin-core-dev
22:19
kexkey has quit [Ping timeout: 256 seconds]
22:23
brunoerg has quit [Ping timeout: 240 seconds]
22:27
Victorsueca has joined #bitcoin-core-dev
22:29
emcy has quit [Read error: Connection reset by peer]
22:29
emcy has joined #bitcoin-core-dev
22:44
sdfgsdfg has joined #bitcoin-core-dev
22:51
brunoerg has joined #bitcoin-core-dev
22:52
kexkey has joined #bitcoin-core-dev
22:57
brunoerg has quit [Ping timeout: 265 seconds]
23:39
sdfgsdfg has quit [Quit: ZzzZ]
23:42
brunoerg has joined #bitcoin-core-dev
23:44
jtrag has joined #bitcoin-core-dev
23:47
brunoerg has quit [Ping timeout: 252 seconds]
23:58
yanmaani has quit [Ping timeout: 276 seconds]