#bitcoin-core-dev on 2021-12-15 — searchable irc log

00:21 sdfgsdfg has quit [Quit: ZzzZ]

00:27 rex4539 has joined #bitcoin-core-dev

00:31 sdfgsdfg has joined #bitcoin-core-dev

00:32 jtrag has quit [Ping timeout: 250 seconds]

00:33 rex4539 has quit [Ping timeout: 276 seconds]

00:36 yanmaani has quit [Ping timeout: 276 seconds]

00:46 dviola has quit [Ping timeout: 260 seconds]

00:58 rex4539 has joined #bitcoin-core-dev

01:04 rex4539 has quit [Ping timeout: 276 seconds]

01:06 zonemix has quit [Ping timeout: 260 seconds]

01:10 arythmetic has quit [Remote host closed the connection]

01:14 yanmaani has joined #bitcoin-core-dev

01:16 zonemix has joined #bitcoin-core-dev

01:25 bitdex has joined #bitcoin-core-dev

01:32 rex4539 has joined #bitcoin-core-dev

01:37 rex4539 has quit [Ping timeout: 276 seconds]

01:38 paulo has quit [Quit: ZNC 1.8.2 - https://znc.in]

01:38 meshcollider has quit [Quit: :wave:]

01:47 jtrag has joined #bitcoin-core-dev

01:53 rex4539 has joined #bitcoin-core-dev

02:07 mikehu44 has joined #bitcoin-core-dev

02:11 ozawa has joined #bitcoin-core-dev

02:12 mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]

02:19 meshcollider has joined #bitcoin-core-dev

02:22 yanmaani has quit [Ping timeout: 276 seconds]

02:23 paulo has joined #bitcoin-core-dev

02:27 jtrag has quit [Quit: Fuck y'all I'm out dis bitch! ✌️ out yo!]

02:27 Guest64873 has joined #bitcoin-core-dev

02:27 Guest64873 has left #bitcoin-core-dev [#bitcoin-core-dev]

02:37 sdfgsdfg has quit [Quit: ZzzZ]

02:53 An0rak has joined #bitcoin-core-dev

02:57 rex4539 has quit [Ping timeout: 276 seconds]

03:00 roconnor has joined #bitcoin-core-dev

03:01 yanmaani has joined #bitcoin-core-dev

03:26 masta`` has quit [Remote host closed the connection]

03:29 Guest1690 has joined #bitcoin-core-dev

03:31 arythmetic has joined #bitcoin-core-dev

03:36 arythmetic has quit [Ping timeout: 252 seconds]

03:37 earnestly has quit [Ping timeout: 268 seconds]

03:37 Guest1690 has quit [Quit: Client closed]

03:44 paulo has quit [Remote host closed the connection]

03:44 meshcollider has quit [Remote host closed the connection]

03:47 jtrag has joined #bitcoin-core-dev

04:02 sdfgsdfg has joined #bitcoin-core-dev

04:05 sdfgsdfg has quit [Client Quit]

04:17 rex4539 has joined #bitcoin-core-dev

04:21 meshcollider has joined #bitcoin-core-dev

04:22 rex4539 has quit [Ping timeout: 276 seconds]

04:24 paulo has joined #bitcoin-core-dev

04:25 jb55 has quit [Ping timeout: 265 seconds]

04:30 sdfgsdfg has joined #bitcoin-core-dev

04:43 roconnor has quit [Ping timeout: 252 seconds]

04:48 zonemix has quit [Remote host closed the connection]

04:49 zonemix has joined #bitcoin-core-dev

04:54 zonemix has quit [Ping timeout: 252 seconds]

04:55 roconnor has joined #bitcoin-core-dev

05:01 cmirror has joined #bitcoin-core-dev

05:04 nanotube has joined #bitcoin-core-dev

05:06 ozawa has quit [Quit: Connection closed]

05:10 zonemix has joined #bitcoin-core-dev

05:45 rex4539 has joined #bitcoin-core-dev

05:51 rex4539 has quit [Ping timeout: 276 seconds]

06:13 zonemix has quit [Ping timeout: 260 seconds]

06:13 rex4539 has joined #bitcoin-core-dev

06:31 wesely has joined #bitcoin-core-dev

06:32 sdfgsdfg has quit [Quit: ZzzZ]

06:32 wesely36 has joined #bitcoin-core-dev

06:32 wesely36 has quit [Client Quit]

06:33 shijie has joined #bitcoin-core-dev

06:33 shijie has quit [Client Quit]

06:36 sdfgsdfg has joined #bitcoin-core-dev

06:43 zonemix has joined #bitcoin-core-dev

06:48 zonemix has quit [Ping timeout: 256 seconds]

06:59 wesely has quit [Ping timeout: 256 seconds]

07:07 yanmaani has quit [Ping timeout: 276 seconds]

07:08 bitcoin-git has joined #bitcoin-core-dev

07:08 <bitcoin-git> [bitcoin] fanquake opened pull request #23778: release: Guix 1.4.0 & GCC 10 (master...release_use_gcc_10) https://github.com/bitcoin/bitcoin/pull/23778

07:08 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

07:37 zonemix has joined #bitcoin-core-dev

07:41 boxframes has quit [Remote host closed the connection]

07:41 zonemix has quit [Ping timeout: 250 seconds]

07:56 zonemix has joined #bitcoin-core-dev

07:58 yanmaani has joined #bitcoin-core-dev

08:08 Guest58 has joined #bitcoin-core-dev

08:08 Guest58 has quit [Client Quit]

08:14 dermoth has quit [Ping timeout: 252 seconds]

08:26 dermoth has joined #bitcoin-core-dev

08:31 yanmaani has quit [Ping timeout: 276 seconds]

08:35 jonatack has quit [Ping timeout: 260 seconds]

08:36 yanmaani has joined #bitcoin-core-dev

08:37 Guyver2 has joined #bitcoin-core-dev

08:42 yanmaani has quit [Ping timeout: 276 seconds]

08:48 vasild has quit [Ping timeout: 276 seconds]

08:51 meshcollider has quit [Changing host]

08:51 meshcollider has joined #bitcoin-core-dev

08:56 bitcoin-git has joined #bitcoin-core-dev

08:56 <bitcoin-git> bitcoin/master 207f1c8 josibake: refactor: make AddrMan::Good return bool

08:56 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9015d118425d...40fdb9ece979

08:56 <bitcoin-git> bitcoin/master caac999 josibake: refactor: remove dependence on AddrManTest

08:56 <bitcoin-git> bitcoin/master f961c47 josibake: refactor: check Good() in tried_collisions test

08:56 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

08:56 bitcoin-git has joined #bitcoin-core-dev

08:56 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #23713: refactor, test: refactor addrman_tried_collisions test to directly check for collisions (master...josibake-addrman-collisions-refactor) https://github.com/bitcoin/bitcoin/pull/23713

08:56 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

09:03 zonemix has quit [Ping timeout: 252 seconds]

09:03 RobYatty is now known as RoyBatty

09:04 RoyBatty has quit [Changing host]

09:04 RoyBatty has joined #bitcoin-core-dev

09:13 vasild has joined #bitcoin-core-dev

09:20 zonemix has joined #bitcoin-core-dev

09:20 yanmaani has joined #bitcoin-core-dev

09:29 b10c has joined #bitcoin-core-dev

09:36 sdfgsdfg has quit [Quit: ZzzZ]

09:52 befalou has joined #bitcoin-core-dev

10:01 bitcoin-git has joined #bitcoin-core-dev

10:01 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/40fdb9ece979...7006496a5c03

10:01 <bitcoin-git> bitcoin/master fad6761 MarcoFalke: Fix implicit integer sign changes in strencodings

10:01 <bitcoin-git> bitcoin/master fa5865a MarcoFalke: Reduce size of strencodings decode tables

10:01 <bitcoin-git> bitcoin/master 7006496 MarcoFalke: Merge bitcoin/bitcoin#23756: refactor: Fix implicit integer sign changes i...

10:01 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

10:01 bitcoin-git has joined #bitcoin-core-dev

10:01 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #23756: refactor: Fix implicit integer sign changes in strencodings (master...2111-int) https://github.com/bitcoin/bitcoin/pull/23756

10:01 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

10:04 kexkey_ has quit [Ping timeout: 240 seconds]

10:05 kexkey has joined #bitcoin-core-dev

10:09 bitcoin-git has joined #bitcoin-core-dev

10:09 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/7006496a5c03...b67115dd044d

10:09 <bitcoin-git> bitcoin/master d0c6e61 James O'Beirne: validation: don't modify genesis during snapshot load

10:09 <bitcoin-git> bitcoin/master 0fd599a James O'Beirne: validation: have LoadBlockIndex account for snapshot use

10:09 <bitcoin-git> bitcoin/master 2283b9c James O'Beirne: test: add tests for LoadBlockIndex when using multiple chainstates

10:09 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

10:09 bitcoin-git has joined #bitcoin-core-dev

10:09 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #23174: validation: have LoadBlockIndex account for snapshot use (master...2021-10-au-loadblockindex) https://github.com/bitcoin/bitcoin/pull/23174

10:09 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

10:09 zonemix_ has joined #bitcoin-core-dev

10:11 zonemix has quit [Ping timeout: 260 seconds]

10:12 saranshsharma has joined #bitcoin-core-dev

10:21 zonemix_ has quit [Ping timeout: 252 seconds]

10:22 saranshsharma has quit [Remote host closed the connection]

10:23 saranshsharma has joined #bitcoin-core-dev

10:28 earnestly has joined #bitcoin-core-dev

10:29 sdfgsdfg has joined #bitcoin-core-dev

10:36 yanmaani has quit [Ping timeout: 276 seconds]

10:38 bitcoin-git has joined #bitcoin-core-dev

10:38 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b67115dd044d...965ffe2bed04

10:38 <bitcoin-git> bitcoin/master 6fc5c77 Igor Cota: build, qt: use static QAndroidPlatformIntegrationPlugin

10:38 <bitcoin-git> bitcoin/master 27f353d Igor Cota: build, android: Fix Android GUI not loading on Qt 5.15

10:38 <bitcoin-git> bitcoin/master 965ffe2 fanquake: Merge bitcoin/bitcoin#23757: [build] Android: fix GUI not loading on Qt 5....

10:38 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

10:38 bitcoin-git has joined #bitcoin-core-dev

10:38 <bitcoin-git> [bitcoin] fanquake merged pull request #23757: [build] Android: fix GUI not loading on Qt 5.15 (master...qt-515-android) https://github.com/bitcoin/bitcoin/pull/23757

10:38 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

10:53 zonemix has joined #bitcoin-core-dev

10:54 mikehu44 has joined #bitcoin-core-dev

10:55 paairs has quit [Ping timeout: 240 seconds]

10:57 paairs has joined #bitcoin-core-dev

11:00 zonemix has quit [Ping timeout: 260 seconds]

11:03 bitcoin-git has joined #bitcoin-core-dev

11:03 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/965ffe2bed04...2d0bdb208964

11:03 <bitcoin-git> bitcoin/master faa6c3d MarcoFalke: net: Drop only invalid entries when reading banlist.json

11:03 <bitcoin-git> bitcoin/master 2d0bdb2 W. J. van der Laan: Merge bitcoin/bitcoin#22362: Drop only invalid entries when reading banlis...

11:03 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

11:03 bitcoin-git has joined #bitcoin-core-dev

11:03 <bitcoin-git> [bitcoin] laanwj merged pull request #22362: Drop only invalid entries when reading banlist.json (master...2106-addrdb) https://github.com/bitcoin/bitcoin/pull/22362

11:03 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

11:13 zonemix has joined #bitcoin-core-dev

11:14 yanmaani has joined #bitcoin-core-dev

11:19 jarthur has quit [Quit: jarthur]

11:37 bitcoin-git has joined #bitcoin-core-dev

11:37 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #20273: Extend support for nested commands to bitcoin-cli (master...2020/10/client_rpc_nested) https://github.com/bitcoin/bitcoin/pull/20273

11:37 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

11:38 masta`` has joined #bitcoin-core-dev

11:38 bitcoin-git has joined #bitcoin-core-dev

11:38 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16883: WIP: Qt: add QML based mobile GUI (master...qt-mobile) https://github.com/bitcoin/bitcoin/pull/16883

11:38 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

11:43 saranshsharma has quit [Remote host closed the connection]

11:48 saranshsharma has joined #bitcoin-core-dev

11:48 saranshsharma has quit [Remote host closed the connection]

11:48 saranshsharma has joined #bitcoin-core-dev

11:56 boxframes has joined #bitcoin-core-dev

12:03 bitcoin-git has joined #bitcoin-core-dev

12:03 <bitcoin-git> [bitcoin] josibake opened pull request #23780: refactor, test: update `addrman_tests.cpp` to use output from `AddrMan::Good()` (master...josibake-addrman-test-refactors) https://github.com/bitcoin/bitcoin/pull/23780

12:03 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

12:04 saranshsharma has quit [Remote host closed the connection]

12:04 saranshsharma has joined #bitcoin-core-dev

12:05 sdfgsdfg has quit [Quit: ZzzZ]

12:06 saranshsharma has quit [Remote host closed the connection]

12:09 yanmaani has quit [Ping timeout: 276 seconds]

12:09 bitcoin-git has joined #bitcoin-core-dev

12:09 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/2d0bdb208964...60b5795133a2

12:09 <bitcoin-git> bitcoin/master fa663a4 MarcoFalke: Use mockable time for peer connection time

12:09 <bitcoin-git> bitcoin/master fad9438 MarcoFalke: scripted-diff: Rename touched member variables

12:09 <bitcoin-git> bitcoin/master fad7ead MarcoFalke: refactor: Use type-safe std::chrono in net

12:09 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

12:09 bitcoin-git has joined #bitcoin-core-dev

12:09 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #23758: net: Use type-safe mockable time for peer connection time (master...2112-timeMockp2p) https://github.com/bitcoin/bitcoin/pull/23758

12:09 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

12:10 bitcoin-git has joined #bitcoin-core-dev

12:10 <bitcoin-git> [bitcoin] hebasto opened pull request #23781: test: Fix `system_tests/run_command` on Windows (master...211215-bptest) https://github.com/bitcoin/bitcoin/pull/23781

12:10 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

12:18 zonemix has quit [Ping timeout: 250 seconds]

12:19 zonemix has joined #bitcoin-core-dev

12:35 bomb-on has joined #bitcoin-core-dev

12:40 bitcoin-git has joined #bitcoin-core-dev

12:40 <bitcoin-git> [bitcoin] seaona opened pull request #23782: test: include two more interruptions points (master...2021-12-feature-init-test-interruptions) https://github.com/bitcoin/bitcoin/pull/23782

12:40 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

12:48 arythmetic has joined #bitcoin-core-dev

12:49 yanmaani has joined #bitcoin-core-dev

13:06 yanmaani has quit [Ping timeout: 276 seconds]

13:07 yanmaani has joined #bitcoin-core-dev

13:10 bitcoin-git has joined #bitcoin-core-dev

13:10 <bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/60b5795133a2...b8cc75435a0b

13:10 <bitcoin-git> bitcoin/master 71d3338 HiLivin: qt: prevent negative values of progressPerHour

13:10 <bitcoin-git> bitcoin/master b8cc754 Hennadii Stepanov: Merge bitcoin-core/gui#508: Prevent negative values of progressPerHour

13:10 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

13:11 bitcoin-git has joined #bitcoin-core-dev

13:11 <bitcoin-git> [gui] hebasto merged pull request #508: Prevent negative values of progressPerHour (master...master) https://github.com/bitcoin-core/gui/pull/508

13:11 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

13:18 bitdex has quit [Quit: = ""]

13:26 yanmaani1 has joined #bitcoin-core-dev

13:27 yanmaani has quit [Ping timeout: 276 seconds]

13:29 zonemix has quit [Ping timeout: 252 seconds]

13:31 befalou has quit [Quit: befalou]

13:37 Guyver2 has quit [Remote host closed the connection]

13:41 jonatack has joined #bitcoin-core-dev

13:57 littlesh has joined #bitcoin-core-dev

14:02 arythmetic has quit [Remote host closed the connection]

14:10 saranshsharma has joined #bitcoin-core-dev

14:15 saranshsharma has quit [Ping timeout: 265 seconds]

14:21 zonemix has joined #bitcoin-core-dev

14:27 masta`` has quit [Read error: Connection reset by peer]

14:27 roconnor has quit [Quit: Konversation terminated!]

14:58 harding has quit [Ping timeout: 252 seconds]

14:58 harding has joined #bitcoin-core-dev

14:59 arythmetic has joined #bitcoin-core-dev

15:07 mikehu44 has quit [Ping timeout: 245 seconds]

15:11 bitcoin-git has joined #bitcoin-core-dev

15:11 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b8cc75435a0b...c09b41dc665b

15:11 <bitcoin-git> bitcoin/master c09b41d MarcoFalke: Merge bitcoin/bitcoin#23769: Disallow copies of CChain

15:11 <bitcoin-git> bitcoin/master fada66f MarcoFalke: Disallow copies of CChain

15:11 <bitcoin-git> bitcoin/master faf2614 MarcoFalke: style: Use 4 spaces for indendation, not 5

15:11 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

15:12 bitcoin-git has joined #bitcoin-core-dev

15:12 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #23769: Disallow copies of CChain (master...2112-chainNoCopy) https://github.com/bitcoin/bitcoin/pull/23769

15:12 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

15:13 jtrag has quit [Ping timeout: 252 seconds]

15:15 yanmaani1 has quit [Ping timeout: 276 seconds]

15:17 gleb74 has quit [Ping timeout: 240 seconds]

15:25 bitcoin-git has joined #bitcoin-core-dev

15:25 <bitcoin-git> [bitcoin] theStack opened pull request #23784: bitcoin-tx: Require that input amount is provided for witness transactions (master...bitcoin-tx_check_witness_input_amount) https://github.com/bitcoin/bitcoin/pull/23784

15:25 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

15:31 bitcoin-git has joined #bitcoin-core-dev

15:31 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13608: WIP: bitcoin-tx: Require that input amount is provided for witness transactions (master...bitcoin-tx-sign-amount) https://github.com/bitcoin/bitcoin/pull/13608

15:31 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

15:40 kexkey has quit [Ping timeout: 256 seconds]

15:42 kexkey has joined #bitcoin-core-dev

15:46 jtrag has joined #bitcoin-core-dev

15:51 Guyver2 has joined #bitcoin-core-dev

16:04 jtrag has quit [Quit: Fuck y'all I'm out dis bitch! ✌️ out yo!]

16:07 mikehu44 has joined #bitcoin-core-dev

16:20 mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]

16:21 ___nick___ has joined #bitcoin-core-dev

16:29 daedin has joined #bitcoin-core-dev

16:33 hsdjkfhfshfsi has quit [Quit: Leaving]

16:37 jtrag has joined #bitcoin-core-dev

16:44 An0rak has quit []

16:45 gleb74 has joined #bitcoin-core-dev

16:48 bitcoin-git has joined #bitcoin-core-dev

16:48 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #23785: 2112 move c man (master...2112-moveCMan) https://github.com/bitcoin/bitcoin/pull/23785

16:48 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

17:09 <luke-jr> bleh, now DrahtBot is just spamming :/

17:11 haakon_ has quit [Ping timeout: 250 seconds]

17:23 jb55 has joined #bitcoin-core-dev

17:28 nat has quit [Quit: ZNC 1.8.2 - https://znc.in]

17:29 daedin has quit [Ping timeout: 240 seconds]

17:29 nat has joined #bitcoin-core-dev

17:36 dougefish_ has quit [Quit: dougefish_]

17:36 <jamesob> dongcarl: what's next for libbitcoinkernel?

17:38 dougefish has joined #bitcoin-core-dev

17:38 jtrag is now known as Guest3856

17:39 daedin has joined #bitcoin-core-dev

17:39 jtrag has joined #bitcoin-core-dev

17:39 Guest3856 has quit [Ping timeout: 260 seconds]

17:48 <darosior> Interested too ^

17:56 arythmetic has quit [Remote host closed the connection]

17:57 arythmetic has joined #bitcoin-core-dev

17:59 Talkless has quit [Quit: Konversation terminated!]

18:01 arythmetic has quit [Ping timeout: 252 seconds]

18:02 Talkless has joined #bitcoin-core-dev

18:09 daedin has quit [Ping timeout: 250 seconds]

18:18 mikehu44 has joined #bitcoin-core-dev

18:18 mikehu44 has quit [Client Quit]

18:21 luke-jr has quit [Read error: Connection reset by peer]

18:24 luke-jr has joined #bitcoin-core-dev

18:30 esats has joined #bitcoin-core-dev

18:32 arythmetic has joined #bitcoin-core-dev

18:38 esats has quit [Ping timeout: 256 seconds]

18:50 yanmaani1 has joined #bitcoin-core-dev

18:58 esats has joined #bitcoin-core-dev

19:03 Evel-Knievel has quit []

19:05 esats has quit [Quit: Client closed]

19:10 esats has joined #bitcoin-core-dev

19:10 sirdigby727 has joined #bitcoin-core-dev

19:15 vasild has quit [Remote host closed the connection]

19:15 vasild has joined #bitcoin-core-dev

19:15 esats has quit [Ping timeout: 256 seconds]

19:15 jtrag has quit [Quit: Fuck y'all I'm out dis bitch! ✌️ out yo!]

19:19 chris23lngr has joined #bitcoin-core-dev

19:20 jtrag has joined #bitcoin-core-dev

19:20 <chris23lngr> hey everyone, i have some questions on bitcoin. Can anyone help?

19:22 chris23lngr has quit [Client Quit]

19:22 bitcoin-git has joined #bitcoin-core-dev

19:22 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15861: Restore warning for individual unknown version bits, as well as unknown version schemas (master...restore_vbits_warning) https://github.com/bitcoin/bitcoin/pull/15861

19:22 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

19:22 jb55 has quit [Ping timeout: 256 seconds]

19:28 esats has joined #bitcoin-core-dev

19:29 bitcoin-git has joined #bitcoin-core-dev

19:29 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #23731: [RFC] wallet: Always prefer bech32(m) change by default (master...2112-walletChangeChange) https://github.com/bitcoin/bitcoin/pull/23731

19:29 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

19:40 zonemix has quit [Remote host closed the connection]

19:41 Talkless has quit [Quit: Konversation terminated!]

19:43 bitcoin-git has joined #bitcoin-core-dev

19:43 <bitcoin-git> [bitcoin] laanwj pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/c09b41dc665b...216f4ca9e7cc

19:43 <bitcoin-git> bitcoin/master ba26169 glozow: [unit test] context-free package checks

19:43 <bitcoin-git> bitcoin/master 9b2fdca glozow: [packages] add static IsChildWithParents function

19:43 <bitcoin-git> bitcoin/master d59ddc5 glozow: [packages/doc] define and document package rules

19:43 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

19:43 bitcoin-git has joined #bitcoin-core-dev

19:43 <bitcoin-git> [bitcoin] laanwj merged pull request #22674: validation: mempool validation and submission for packages of 1 child + parents (master...package-child-with-parents) https://github.com/bitcoin/bitcoin/pull/22674

19:43 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

19:45 sdfgsdfg has joined #bitcoin-core-dev

19:48 esats has quit [Quit: Client closed]

19:49 ___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]

19:50 masta`` has joined #bitcoin-core-dev

19:51 ___nick___ has joined #bitcoin-core-dev

19:51 ___nick___ has quit [Client Quit]

19:52 zonemix has joined #bitcoin-core-dev

19:53 ___nick___ has joined #bitcoin-core-dev

19:56 zonemix has quit [Ping timeout: 250 seconds]

20:05 Evel-Knievel has joined #bitcoin-core-dev

20:05 shiza is now known as pink_sarco

20:06 bairen has quit [Remote host closed the connection]

20:07 andrewtoth_ has quit [Remote host closed the connection]

20:08 yanmaani1 has quit [Ping timeout: 276 seconds]

20:08 andrewtoth_ has joined #bitcoin-core-dev

20:08 bairen has joined #bitcoin-core-dev

20:10 andrewtoth_ has quit [Remote host closed the connection]

20:12 bairen has quit [Remote host closed the connection]

20:17 bitcoin-git has joined #bitcoin-core-dev

20:17 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #23789: wallet: Strictly match in TransactionChangeType to improve privacy [skip ci] [ci skip] (master...2112-walletChangeChange) https://github.com/bitcoin/bitcoin/pull/23789

20:17 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

20:20 ___nick___ has quit [Ping timeout: 265 seconds]

20:25 tla2k21 has quit [Ping timeout: 276 seconds]

20:30 <ariard> yeah maybe a bit quick to land #22674 with only one ack on tip, i'll have a post-merge look :)

20:30 <gribble> https://github.com/bitcoin/bitcoin/issues/22674 | validation: mempool validation and submission for packages of 1 child + parents by glozow · Pull Request #22674 · bitcoin/bitcoin · GitHub

20:31 rex4539 has quit [Quit: No Ping reply in 180 seconds.]

20:31 <ariard> though i'm too blame to not review back faster

20:31 vasild has quit [Remote host closed the connection]

20:34 yanmaani1 has joined #bitcoin-core-dev

20:34 yanmaani1 is now known as yanmaani

20:35 rex4539 has joined #bitcoin-core-dev

20:36 jb55 has joined #bitcoin-core-dev

20:36 tla2k21 has joined #bitcoin-core-dev

20:37 kexkey has quit [Ping timeout: 260 seconds]

20:39 kexkey has joined #bitcoin-core-dev

20:43 emzy has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]

20:53 <laanwj> lots of previous ACKs though

20:54 <laanwj> if you only look at acks on tip you're punishing people for actually listing to nits

20:56 bitcoin-git has joined #bitcoin-core-dev

20:56 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/216f4ca9e7cc...fee16b15fa34

20:56 <bitcoin-git> bitcoin/master 66a20a5 Hennadii Stepanov: build, qt: Drop support for `i686-linux-android` host

20:56 <bitcoin-git> bitcoin/master fee16b1 W. J. van der Laan: Merge bitcoin/bitcoin#23744: build, qt: Drop support for i686-linux-androi...

20:56 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

20:56 bitcoin-git has joined #bitcoin-core-dev

20:56 <bitcoin-git> [bitcoin] laanwj merged pull request #23744: build, qt: Drop support for i686-linux-android host (master...211211-android32) https://github.com/bitcoin/bitcoin/pull/23744

20:56 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

20:57 sdfgsdfg has quit [Quit: ZzzZ]

20:58 zonemix has joined #bitcoin-core-dev

20:59 emzy has joined #bitcoin-core-dev

20:59 kcalvinalvin has quit [Quit: ZNC 1.7.4 - https://znc.in]

21:00 kcalvinalvin has joined #bitcoin-core-dev

21:01 vasild has joined #bitcoin-core-dev

21:02 zonemix has quit [Ping timeout: 252 seconds]

21:03 andrewtoth_ has joined #bitcoin-core-dev

21:06 <MarcoFalke> Maybe the merge script could include previous ACKs if they are "close enough" to the tip?

21:10 <laanwj> yes, though that's hard to judge programmatically

21:16 <MarcoFalke> or just a list of all stale ACKs without "judgement"

21:18 <laanwj> right

21:18 <luke-jr> but then if something bad gets merged, someone who ACK'd a version without it might not appreciate the "blame"

21:19 <luke-jr> perhaps just list them with " (stale)" on the end or smth

21:19 <luke-jr> might be nice to include the commit hash they did ACK too, but then it gets long

21:19 <MarcoFalke> right, I mean a separate section with stale ACKs

21:20 sirdigby727 has quit [Quit: Connection closed for inactivity]

21:22 sdfgsdfg has joined #bitcoin-core-dev

21:28 littlesh has quit [Quit: Going offline, see ya! (www.adiirc.com)]

21:29 nat has quit [Quit: ZNC 1.8.2 - https://znc.in]

21:29 yanmaani has quit [Remote host closed the connection]

21:30 nat has joined #bitcoin-core-dev

21:31 yanmaani has joined #bitcoin-core-dev

21:31 emzy has quit [Ping timeout: 250 seconds]

21:32 emzy has joined #bitcoin-core-dev

21:38 nat has quit [Quit: ZNC 1.8.2 - https://znc.in]

21:39 nat has joined #bitcoin-core-dev

21:41 masta`` has quit [Read error: Connection reset by peer]

21:57 yanmaani has quit [Ping timeout: 276 seconds]

22:02 zonemix has joined #bitcoin-core-dev

22:07 arythmetic has quit [Remote host closed the connection]

22:15 yanmaani has joined #bitcoin-core-dev

22:31 roconnor has joined #bitcoin-core-dev

22:34 Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]

22:41 rex4539 has quit [Ping timeout: 276 seconds]

22:42 yanmaani has quit [Ping timeout: 276 seconds]

22:47 ozawa has joined #bitcoin-core-dev

22:49 sdfgsdfg has quit [Quit: ZzzZ]

23:02 sdfgsdfg has joined #bitcoin-core-dev

23:07 rex4539 has joined #bitcoin-core-dev

23:13 rex4539 has quit [Ping timeout: 276 seconds]

23:19 zonemix has quit [Remote host closed the connection]

23:19 zonemix has joined #bitcoin-core-dev

23:21 bomb-on has quit [Quit: aллилѹіа!]

23:25 rex4539 has joined #bitcoin-core-dev

23:26 zonemix has quit [Ping timeout: 250 seconds]

23:30 rex4539 has quit [Ping timeout: 276 seconds]

23:33 <jeremyrubin> TBH i think we should allow addressing nits in follow up PRs

23:33 <jeremyrubin> i don't think unsquashed fixup commits are a worse burden on the code than the risk of uncareful re-reviews

23:34 <jeremyrubin> might be a minority on that opinion though

23:37 <lightlike> Isn't that allowed already? It seems to happen regularly with larger PRs that nits are addressed in follow-ups.

23:39 zonemix has joined #bitcoin-core-dev

23:42 roconnor has quit [Ping timeout: 250 seconds]

23:42 rex4539 has joined #bitcoin-core-dev

23:44 zonemix has quit [Ping timeout: 256 seconds]

23:49 rex4539 has quit [Ping timeout: 276 seconds]

23:53 yanmaani has joined #bitcoin-core-dev

23:56 zonemix has joined #bitcoin-core-dev

23:59 yanmaani has quit [Ping timeout: 276 seconds]