<bitcoin-git>
bitcoin/master 2f356a0 Hennadii Stepanov: scripted-diff: Drop Darwin version for better maintainability
<bitcoin-git>
bitcoin/master 1b76b18 fanquake: Merge bitcoin/bitcoin#23585: scripted-diff: Drop Darwin version for better...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake merged pull request #23585: scripted-diff: Drop Darwin version for better maintainability (master...211124-darwin) https://github.com/bitcoin/bitcoin/pull/23585
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Kaizen_Kintsugi_ has quit [Ping timeout: 252 seconds]
masta`` has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
jtrag_ has joined #bitcoin-core-dev
jtrag is now known as Guest8327
Guest8327 has quit [Ping timeout: 252 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 265 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #23723: test: Replace hashlib.new with named constructor (master...2112-testNoNew) https://github.com/bitcoin/bitcoin/pull/23723
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #23723: test: Replace hashlib.new with named constructor (master...2112-testNoNew) https://github.com/bitcoin/bitcoin/pull/23723
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
mikehu44 has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild_ has quit [Ping timeout: 276 seconds]
vasild has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
arythmetic has quit [Remote host closed the connection]
noonien has joined #bitcoin-core-dev
saranshsharma has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
arythmetic has joined #bitcoin-core-dev
<laanwj>
hebasto: awesome!
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
saranshsharma has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] 0xB10C opened pull request #23724: build: add systemtap's sys/sdt.h as depends for GUIX builds with USDT tracepoints (master...2021-12-usdt-depends) https://github.com/bitcoin/bitcoin/pull/23724
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Kaizen_Kintsugi_ has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
arythmetic has quit [Remote host closed the connection]
arythmetic has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] theStack opened pull request #23725: test: fix `feature_coinstatsindex.py --descriptors` and add to test runner (master...202112-test-fix-feature_coinstatsindex-with-descriptors) https://github.com/bitcoin/bitcoin/pull/23725
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Guest52 has joined #bitcoin-core-dev
weylin_ has joined #bitcoin-core-dev
Guest52 has quit [Client Quit]
weylin_ has quit [Ping timeout: 252 seconds]
brunoerg has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
gene has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
cercatrova has joined #bitcoin-core-dev
arythmetic has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
weylin_ has joined #bitcoin-core-dev
cercatrova has quit [Quit: Client closed]
cercatrova has joined #bitcoin-core-dev
Guest344 has joined #bitcoin-core-dev
Guest344 has quit [Client Quit]
mikehu44 has quit [Ping timeout: 252 seconds]
mikehu44 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Talkless has joined #bitcoin-core-dev
Guest7 has joined #bitcoin-core-dev
<Guest7>
Dear all I am new here
<Guest7>
I hope everybody is doing great
<Guest7>
I am trying to create a new crypto currency with the bitcoin source code
<Guest7>
Maybe I can learn from you guys too
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 265 seconds]
<sipa>
Guest7: you're welcome to hang out here of course, but discussions about anything but development of the bitcoin core implementation here is off topic
brunoerg has quit [Ping timeout: 265 seconds]
<Guest7>
thank you
brunoerg has joined #bitcoin-core-dev
<gene>
perhaps you would be more interested in drive chains Guest7
<gene>
if you're not just a sock puppet, that is
brunoerg has quit [Ping timeout: 265 seconds]
<gene>
ah, now a DOS, thanks troll fucks
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
masta_ has joined #bitcoin-core-dev
cercatrova has quit [Quit: Leaving]
masta`` has quit [Ping timeout: 265 seconds]
masta_ is now known as masta``
Kaizen_Kintsugi_ has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
gene has quit [Quit: gene]
gene has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
<MarcoFalke>
Calling getnewaddress of type bech32 should succeed on any wallet.dat (even unupgraded ones from 2009), right?
<meshcollider>
Hi all :) This is just a quick announcement that I have decided to step down as maintainer.
<meshcollider>
I have really enjoyed begin able to help in this role for the last three years, but it does take time, and I am coming into the final months of my PhD so I need to focus on my thesis.
<meshcollider>
I feel like development on the wallet has stabilised a lot compared to three years ago, and I don't think this will create a noticeable burden on the other maintainers like fanquake, MarcoFalke and laanwj who already do a great job across the whole project.
<meshcollider>
Thanks to all of you for the privilege of being able to serve in the role for the last three years, and for the amazing work you all do. This isn't goodbye, I just need to take the time away for the next few months, and then work out what's next.
<meshcollider>
That's all from me! :)
<laanwj>
great, now we have to look for a wallet maintainer. again :)
<jamesob>
Thanks for everything meshcollider, and congratulations on nearing the end of your PhD!
<MarcoFalke>
meshcollider: Sad to hear that, but thank you for your work. You were the best wallet maintainer ever. ;)
<gene>
good luck on your thesis meshcollider
<sipa>
MarcoFalke: did we ever have another one? ;)
<laanwj>
meshcollider: thanks for all your work, good luck with your thesis!
<achow101>
meshcollider: thanks for all the work that you've done, and good luck with your phd
brunoerg has joined #bitcoin-core-dev
<MarcoFalke>
sipa: No ;)
<dongcarl>
good luck meshcollider!
<meshcollider>
Thank you!
<sipa>
meshcollider: thank you for everything you've done, good luck, and hopefully you'll be back in a more active role later, whatever that may be!
<MarcoFalke>
Still I think the wallet wouldn't be where it is now without meshcollider
<kvaciral[m]>
meshcollider: thanks for your work and good luck with the thesis!!
<jnewbery>
Thank you for all of your work meshcollider! Good luck with the PhD, and hopefully see you around the repo sometime in the future :)
<fjahr>
Thank you meshcollider!
<jarolrod>
meshcollider: ❤️
<kanzure>
thanks meshcollider
<jonatack>
meshcollider: thank you for all you have done and best wishes & good luck for your PhD!
<meshcollider>
I appreciate all the kind words :)
<cfields_>
meshcollider: yes, many thanks :)
sirdigby727 has joined #bitcoin-core-dev
<meshcollider>
Please still feel free to review-request me on important things, I obviously won't be completely gone for the next few months
<laanwj>
meshcollider: thanks, that's good to know!
<MarcoFalke>
Is it time for the "next one to say something will be wallet maintainer"?
<laanwj>
hehe
<achow101>
so who do i go to to get wallet things merged now?
brunoerg has quit [Ping timeout: 240 seconds]
<dongcarl>
achow101: you're it
<MarcoFalke>
achow101: Congratulations, welcome as maintainer!
<achow101>
ah shit
<meshcollider>
:P
<laanwj>
achow101 would be somewhat the obvious candidate, but no need to decide on this today
<achow101>
I'm not opposed to wallet maintainership, but I'm not certain how useful that would be given many wallet prs are mine
nanotube has quit [Quit: *poof*]
<meshcollider>
Honestly the bottleneck is review not merging anyway, it is very easy for fanquake or marco to merge wallet PRs (they do anyway)
brunoerg has quit [Ping timeout: 268 seconds]
nanotube has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
<laanwj>
i do think it's useful to have dedicated maintainers for certain expertise areas which review PRs and merge, sure, any of us can do it but the code base is sufficiently large that specialized knowledge is useful
brunoerg has quit [Ping timeout: 256 seconds]
<gene>
I can spend more time reviewing wallet parts of the code base, but I'm a long way from maintainer-level knowledge
<laanwj>
besides, if you can review and merge other people's wallet PRs we can review and merge your PRs achow101, being wallet maintainer doesn't make it any worse i think
<achow101>
true
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
arythmetic has joined #bitcoin-core-dev
weylin_ has quit [Remote host closed the connection]
arythmetic has quit [Ping timeout: 252 seconds]
weylin_ has joined #bitcoin-core-dev
Guest7 has quit [Quit: Client closed]
weylin_ has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
roconnor has joined #bitcoin-core-dev
<jamesob>
Has any thought been put into the question of how best to make use of the optional compact block filters to do faster rescanning? I.e. should we abstract away the particular scan mechanism when calling `rescanblockchain` (use filters when available), or should we have something more explicit? Was trying to find a related issue but couldn't, so may create one if none exists.
<achow101>
jamesob: I always assumed we would just use them if they're available. no need to expose to the user
<jamesob>
Obviously #23549 is open, but that isn't the whole story in terms of the end-use of applying block filters for faster rescans
<sipa>
does 23549 work without having the filters?
<jamesob>
achow101: makes sense to me... but I guess is there any risk in using the filters - e.g. I didn't follow this very closely but I know there was some minor snafu with the basic filter type miss some taproot outputs
<jamesob>
*missing
<sipa>
jamesob: that was a bug in the client side code btcd had, not in the filters themselves
<jamesob>
sipa: nope
<jamesob>
sipa: oh okay, gotcha
brunoerg has joined #bitcoin-core-dev
<sipa>
jamesob: i think it should always work, just slower if you don't have the filter
<jamesob>
and then another interesting question is whether we'd want to do things like automatic block fetching to allow rescans on pruned nodes using the new `getblockfrompeer` call
<sipa>
that RPC is pointless for it, as it needs the user selecting a peer to fetch from
<sipa>
the actual block fetching logic should just have a way to be told to redownload a block
<jamesob>
ah right, that sounds better
<sipa>
(which imho should have been done instead of spending time on adding that RPC, but it doesn't actually hurt)
<sipa>
regarding faster rescanning, i think there is some lower-hanging fruit, like (a) rescanning all wallets at startup in parallel rather than one by one and (b) building a set of scriptPubKeys to look for and using that for (legacy wallet) rescanning, instead of calling IsMine for each (especially with achow101's migrate-to-descriptor code, i think there should be a way of computing that set for
<sipa>
legacy wallets too)
<sipa>
i haven't paid much attention the actual code; how does scanblocks work for legacy wallets?
brunoerg has quit [Ping timeout: 265 seconds]
<achow101>
sipa: scanblocks is not a wallet rpc
<sipa>
oh, duh
<sipa>
i knew that
dermoth has quit [Ping timeout: 265 seconds]
<jamesob>
sipa: yeah, scanblocks takes essentially the same args as scantxoutset
Talkless has quit [Quit: Konversation terminated!]
<jamesob>
sipa: dumb question, but when you say "legacy" wallet you're essentially saying "non-descriptor wallet", right?
cercatrova has quit [Quit: Leaving]
<sipa>
jamesob: yes
___nick___ has joined #bitcoin-core-dev
<sipa>
jamesob: because for descriptor wallets it's easy to build a set of scriptPubKey that count as "IsMine" to the wallet, but for legacy wallets there traditionally isn't (instead, you give it the scriptPubKey, and it performs pattern matching etc on it based on the contents of keys/scripts in the wallet)