sdfgsdfg has quit [*.net *.split]
jtrag has quit [*.net *.split]
b10c has quit [*.net *.split]
dermoth has quit [*.net *.split]
jespada has quit [*.net *.split]
jamesob has quit [*.net *.split]
x88x88x has quit [*.net *.split]
infernix has quit [*.net *.split]
dongcarl has quit [*.net *.split]
stickies-v has quit [*.net *.split]
BUSY has quit [*.net *.split]
baldur has quit [*.net *.split]
Victorsueca has quit [*.net *.split]
Jackielove4u has quit [*.net *.split]
hendi has quit [*.net *.split]
ogola has quit [*.net *.split]
uasf has quit [*.net *.split]
koolazer has quit [*.net *.split]
TallTim has quit [*.net *.split]
raj_ has quit [*.net *.split]
willcl_ark has quit [*.net *.split]
gnusha has quit [*.net *.split]
gleb74 has quit [*.net *.split]
Alina-malina has quit [*.net *.split]
M0xb10c[m] has quit [*.net *.split]
RCasatta[m] has quit [*.net *.split]
TheRec has quit [*.net *.split]
berndj has quit [*.net *.split]
emcy has quit [*.net *.split]
jrawsthorne has quit [*.net *.split]
EPiSKiNG- has quit [*.net *.split]
jarolrod has quit [*.net *.split]
achow101 has quit [*.net *.split]
S3RK has quit [*.net *.split]
stickies-v has joined #bitcoin-core-dev
gleb74 has joined #bitcoin-core-dev
TallTim has joined #bitcoin-core-dev
emcy has joined #bitcoin-core-dev
jarolrod has joined #bitcoin-core-dev
raj has joined #bitcoin-core-dev
b10c has joined #bitcoin-core-dev
jrawsthorne has joined #bitcoin-core-dev
TheRec has joined #bitcoin-core-dev
achow101 has joined #bitcoin-core-dev
ogola has joined #bitcoin-core-dev
Jackielove4u has joined #bitcoin-core-dev
emcy has quit [Remote host closed the connection]
hendi has joined #bitcoin-core-dev
zonemix has quit [Ping timeout: 268 seconds]
TheRec has quit [Changing host]
TheRec has joined #bitcoin-core-dev
uasf has joined #bitcoin-core-dev
berndj has joined #bitcoin-core-dev
x88x88x has joined #bitcoin-core-dev
willcl_ark has joined #bitcoin-core-dev
Alina-malina has joined #bitcoin-core-dev
gnusha has joined #bitcoin-core-dev
S3RK has joined #bitcoin-core-dev
sdfgsdfg has joined #bitcoin-core-dev
koolazer has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
emcy has joined #bitcoin-core-dev
M0xb10c[m] has joined #bitcoin-core-dev
RCasatta[m] has joined #bitcoin-core-dev
jtrag has joined #bitcoin-core-dev
zonemix has joined #bitcoin-core-dev
Victorsueca has joined #bitcoin-core-dev
infernix has joined #bitcoin-core-dev
emcy has quit [Quit: Leaving]
emcy has joined #bitcoin-core-dev
EPiSKiNG- has joined #bitcoin-core-dev
jb55 has quit [Ping timeout: 256 seconds]
roconnor has joined #bitcoin-core-dev
rex4539 has joined #bitcoin-core-dev
BUSY has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
<jeremyrubin> well it's always kind of a negotiation of if the nits need to be addressed here or later. part of the joy of having a guideline on how to handle is that there's a default answer.
<jeremyrubin> I think we may even get better quality code, because right now i don't nit things i don't want to bother the author to fix given the costs of re-review
<sipa> occasionally i don't bother leaving nits on the PRs directly, but make a follow-up PR myself after it's merged.
<jeremyrubin> i think that's reasonable -- no nits, but just fix it yourself as a follow up. they who nit-it fix-it?
<luke-jr> I planned to do that with NAT-PMP but never got around to it :x
ozawa has quit [Quit: Connection closed]
b10c has quit [Quit: Connection closed for inactivity]
rex4539 has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
luke-jr has quit [Read error: Connection reset by peer]
luke-jr has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
jtrag has quit [Ping timeout: 250 seconds]
ozawa has joined #bitcoin-core-dev
zonemix has quit [Read error: Connection reset by peer]
zonemix_ has joined #bitcoin-core-dev
<ariard> laanwj: yeah sad with the premature merge of 22674, commit e12fafd was added on the last push and not previously reviewed, you have a good chunk of context with implications for the rest of package relay support imho :(
<ariard> nice if past reviewers can re-look on that
<laanwj> okay, sorry
<laanwj> yes i screwed up well it's the last PR i'll merge for a while
jtrag has joined #bitcoin-core-dev
<laanwj> and reverting e12fafd would make sense then (better to do it as a new PR)
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] laanwj opened pull request #23793: validation: Revert "de-duplicate package transactions already in mempool" (master...2021-12-revert-package-dedup) https://github.com/bitcoin/bitcoin/pull/23793
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<laanwj> there
earnestly has quit [Ping timeout: 250 seconds]
<laanwj> oh, it isn't possible to revert it by itself, revert the entire PR then?
<laanwj> ok: it introduces MempoolAcceptResult::ResultType::MEMPOOL_ENTRY which is used in the commit after it, but that's only tests, could remove or comment out the test for now
rex4539 has joined #bitcoin-core-dev
<laanwj> done that
zonemix_ has quit [Remote host closed the connection]
zonemix has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
zonemix has quit [Remote host closed the connection]
zonemix has joined #bitcoin-core-dev
zonemix has quit [Remote host closed the connection]
zonemix has joined #bitcoin-core-dev
tla2k21 has quit [Remote host closed the connection]
zonemix has quit [Ping timeout: 240 seconds]
tla2k21 has joined #bitcoin-core-dev
zonemix has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
ozawa has quit [Quit: Connection closed]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
rex4539 has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
mikehu44 has joined #bitcoin-core-dev
jtrag has quit [Ping timeout: 268 seconds]
mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
zonemix has quit [Ping timeout: 268 seconds]
zonemix has joined #bitcoin-core-dev
zonemix has quit [Ping timeout: 240 seconds]
jtrag has joined #bitcoin-core-dev
rex4539 has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
zonemix has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> bitcoin/master 71115a5 seaona: test: include two more interruptions points
<bitcoin-git> bitcoin/master 98c362a MarcoFalke: Merge bitcoin/bitcoin#23782: test: include two more interruptions points
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fee16b15fa34...98c362a4d3d8
<bitcoin-git> bitcoin/master 618f4d2 seaona: test: re-organized array according to order of logs and included 2 more in...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23782: test: include two more interruptions points (master...2021-12-feature-init-test-interruptions) https://github.com/bitcoin/bitcoin/pull/23782
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
freesprung has quit [Ping timeout: 260 seconds]
freesprung has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> bitcoin/master 4807f73 w0xlt: refactor: Implement restorewallet() logic in the wallet section
<bitcoin-git> bitcoin/master abbb7ec w0xlt: refactor: Move restorewallet() RPC logic to the wallet section
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/98c362a4d3d8...a30642926a5e
<bitcoin-git> bitcoin/master 62fa61f w0xlt: refactor: remove the wallet folder if the restore fails
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23721: wallet, refactor: Move restorewallet() logic to the wallet section (master...restore_wallet_gui) https://github.com/bitcoin/bitcoin/pull/23721
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a30642926a5e...ce463cf45053
<bitcoin-git> bitcoin/master ce463cf MarcoFalke: Merge bitcoin/bitcoin#23750: rpcwallet: mention labels are disabled for ra...
<bitcoin-git> bitcoin/master 65efbba Antoine Poinsot: rpcwallet: mention labels are deactivated for ranged descriptors
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23750: rpcwallet: mention labels are disabled for ranged descriptors (master...no_label_range_descriptors) https://github.com/bitcoin/bitcoin/pull/23750
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
gleb74 has quit [Quit: Ping timeout (120 seconds)]
gleb74 has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ce463cf45053...df6e961c417b
<bitcoin-git> bitcoin/master e4a8d56 Martin Zumsande: doc: add explanations for assert in index and magic numbers in test
<bitcoin-git> bitcoin/master df6e961 MarcoFalke: Merge bitcoin/bitcoin#23777: doc: follow-ups from #23365 (index backwards ...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23777: doc: follow-ups from #23365 (index backwards search) (master...202112_index_followups) https://github.com/bitcoin/bitcoin/pull/23777
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
jtrag has quit [Ping timeout: 256 seconds]
rex4539 has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
jtrag has joined #bitcoin-core-dev
rex4539 has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 276 seconds]
jtrag has quit [Ping timeout: 268 seconds]
jarthur has quit [Quit: jarthur]
jarthur has joined #bitcoin-core-dev
jarthur has quit [Client Quit]
jtrag has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
zonemix has quit [Ping timeout: 240 seconds]
vasild has quit [Ping timeout: 276 seconds]
Guyver2 has joined #bitcoin-core-dev
zonemix has joined #bitcoin-core-dev
zonemix has quit [Ping timeout: 240 seconds]
jtrag has quit [Ping timeout: 240 seconds]
vasild has joined #bitcoin-core-dev
zonemix has joined #bitcoin-core-dev
geyaeb has quit [Ping timeout: 276 seconds]
geyaeb has joined #bitcoin-core-dev
saranshsharma has joined #bitcoin-core-dev
nat has quit [Quit: ZNC 1.8.2 - https://znc.in]
nat has joined #bitcoin-core-dev
nathanael has quit [Quit: connection reset by purr]
nathanael has joined #bitcoin-core-dev
kexkey has quit [Ping timeout: 252 seconds]
kexkey has joined #bitcoin-core-dev
boxframes has quit [Remote host closed the connection]
boxframes has joined #bitcoin-core-dev
boxframes has quit [Remote host closed the connection]
zonemix has quit [Ping timeout: 245 seconds]
saranshsharma has quit [Remote host closed the connection]
saranshsharma has joined #bitcoin-core-dev
saranshsharma has quit [Remote host closed the connection]
dr-orlovsky has joined #bitcoin-core-dev
zonemix has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
earnestly has joined #bitcoin-core-dev
Victorsueca has quit [Ping timeout: 250 seconds]
Victorsueca has joined #bitcoin-core-dev
jonatack has quit [Remote host closed the connection]
jonatack has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 240 seconds]
Guyver2 has joined #bitcoin-core-dev
zonemix has quit [Ping timeout: 268 seconds]
bomb-on has quit [Quit: aллилѹіа!]
zonemix has joined #bitcoin-core-dev
zonemix has quit [Ping timeout: 240 seconds]
bomb-on has joined #bitcoin-core-dev
zonemix has joined #bitcoin-core-dev
willcl_ark has quit [Ping timeout: 256 seconds]
mikehu44 has joined #bitcoin-core-dev
jtrag has joined #bitcoin-core-dev
saranshsharma has joined #bitcoin-core-dev
willcl_ark has joined #bitcoin-core-dev
saranshsharma has quit [Ping timeout: 268 seconds]
arythmetic has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
jtrag has quit [Ping timeout: 240 seconds]
rex4539 has quit [Remote host closed the connection]
rex4539 has joined #bitcoin-core-dev
nat has quit [Quit: ZNC 1.8.2 - https://znc.in]
nat has joined #bitcoin-core-dev
zonemix has quit [Ping timeout: 252 seconds]
jtrag has joined #bitcoin-core-dev
zonemix has joined #bitcoin-core-dev
noonien has quit [Quit: The Lounge - https://thelounge.chat]
noonien has joined #bitcoin-core-dev
<MarcoFalke> PSA: Due to "activity" on archived issues and pull requests, I'll be locking everything up to Dec 31st 2019.
<MarcoFalke> Please open a new issue or leave a question on IRC if something relevant to a locked issue or pull request comes p
<MarcoFalke> *up
dr-orlovsky has quit [Ping timeout: 240 seconds]
dr-orlovsky has joined #bitcoin-core-dev
<MarcoFalke> Preemptively locking helps against spam attacks on archived threds. Also, it reduces harrassment of people's inbox that left a comment on a thread more than two years ago.
<MarcoFalke> *threads
<jnewbery> MarcoFalke: ACK. Seems like a good policy. Please thank drahtbot for beings so active on issue/pr management :)
<MarcoFalke> Drahty will get some nice carrots for new years
jamesob has joined #bitcoin-core-dev
<sipa> MarcoFalke: sounds good to me
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/df6e961c417b...6b212cbbb9d7
<bitcoin-git> bitcoin/master aeeccd9 Martin Zumsande: test: Fix intermittent issue in p2p_addr_relay.py
<bitcoin-git> bitcoin/master 261dddb Martin Zumsande: test: Combine addr generation helper functions
<bitcoin-git> bitcoin/master 6b212cb MarcoFalke: Merge bitcoin/bitcoin#23720: test: Refactor addr_relay.py addr generation,...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23720: test: Refactor addr_relay.py addr generation, increase mocktime (master...202112_test_addrrelay) https://github.com/bitcoin/bitcoin/pull/23720
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> bitcoin/master fa3d62c MarcoFalke: Move FindForkInGlobalIndex from BlockManager to CChainState
<bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/6b212cbbb9d7...8c0bd871fcf6
<bitcoin-git> bitcoin/master facd213 MarcoFalke: Move m_failed_blocks to ChainstateManager
<bitcoin-git> bitcoin/master fa47b5c MarcoFalke: Move AcceptBlockHeader to ChainstateManager
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23785: refactor: Move stuff to ChainstateManager (master...2112-moveCMan) https://github.com/bitcoin/bitcoin/pull/23785
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
sdfgsdfg has quit [Quit: ZzzZ]
jtrag has quit [Ping timeout: 240 seconds]
bomb-on has quit [Quit: aллилѹіа!]
jtrag has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
zonemix has quit [Ping timeout: 256 seconds]
jtrag has quit [Quit: 💙]
zonemix has joined #bitcoin-core-dev
jtrag has joined #bitcoin-core-dev
jtrag has quit [Client Quit]
jtrag has joined #bitcoin-core-dev
jespada has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
jespada has joined #bitcoin-core-dev
jtrag is now known as Guest7615
jtrag_ has joined #bitcoin-core-dev
jtrag_ is now known as jtrag
Guest7615 has quit [Ping timeout: 240 seconds]
mikehu44 has quit [Ping timeout: 240 seconds]
<laanwj> MarcoFalke: ACK, assuming you mean closed issues and PRs
<MarcoFalke> jup, closed ones
<laanwj> great!
b10c has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23795: refactor: Remove implicit-integer-sign-change suppressions in validation (master...2112-refValSup) https://github.com/bitcoin/bitcoin/pull/23795
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
b10c has quit [Changing host]
b10c has joined #bitcoin-core-dev
saranshsharma has joined #bitcoin-core-dev
saranshsharma has quit [Remote host closed the connection]
<glozow> MarcoFalke: ACK, will bring carrots for Drahty
jtrag_ has joined #bitcoin-core-dev
jtrag is now known as Guest2357
jtrag_ is now known as jtrag
Guest2357 has quit [Ping timeout: 256 seconds]
evbo has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] theStack opened pull request #23796: test: check that pruneblockchain RPC fails for future block or timestamp (master...202112-test-add_pruneblockchain_test_coverage) https://github.com/bitcoin/bitcoin/pull/23796
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
joshuajbouw has quit [Ping timeout: 250 seconds]
andrewtoth_ has quit [Remote host closed the connection]
jtrag_ has joined #bitcoin-core-dev
jtrag is now known as Guest1840
andrewtoth has joined #bitcoin-core-dev
Guest1840 has quit [Ping timeout: 240 seconds]
zonemix has quit [Remote host closed the connection]
zonemix has joined #bitcoin-core-dev
zonemix has quit [Ping timeout: 240 seconds]
masta`` has joined #bitcoin-core-dev
b10c_ has joined #bitcoin-core-dev
zonemix has joined #bitcoin-core-dev
b10c has quit []
b10c_ is now known as b10c
bomb-on has joined #bitcoin-core-dev
b10c has quit [Changing host]
b10c has joined #bitcoin-core-dev
jtrag__ has joined #bitcoin-core-dev
jtrag_ has quit [Ping timeout: 240 seconds]
zonemix has quit [Remote host closed the connection]
zonemix has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
andrewtoth_ has joined #bitcoin-core-dev
andrewtoth has quit [Ping timeout: 276 seconds]
jb55 has joined #bitcoin-core-dev
Trinity96 has joined #bitcoin-core-dev
Trinity96 has quit [Client Quit]
zonemix has quit [Remote host closed the connection]
zonemix has joined #bitcoin-core-dev
zonemix has quit [Ping timeout: 268 seconds]
bomb-on has quit [Read error: Connection reset by peer]
bomb-on_ has joined #bitcoin-core-dev
zonemix has joined #bitcoin-core-dev
zonemix has quit [Ping timeout: 240 seconds]
arythmetic has quit [Remote host closed the connection]
arythmetic has joined #bitcoin-core-dev
<laanwj> #startmeeting
<core-meetingbot> Meeting started Thu Dec 16 19:00:02 2021 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
<core-meetingbot> Available commands: action commands idea info link nick
<achow101> hi
<laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball
<hebasto> hi
<laanwj> morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
<kvaciral[m]> hi
<jb55> hi
<jamesob> hi
<jamesob> wow, thursday already
<laanwj> welcome to what i guess is the last general IRC meeting of 2021
<michaelfolkson> hi
<luke-jr> hi
<ariard> hi
<sipa> hi
<fjahr> hi
<b10c> hi
<lightlike> hi
<laanwj> there haven't been any pre-proposed meeting topics (use #proposedmeetingtopic during any time of the week)
<laanwj> any last minute one?
<achow101> suggested topic: wallet maintainer
<jonatack> hi
<luke-jr> achow101: are you volunteering? :P
<achow101> yes
<laanwj> jamesob: yeah time flies when you're having-- well, time flies anyway
<cfields_> hi
<jamesob> laanwj: haha
<jb55> achow101 it is then, that was easy
<luke-jr> laanwj: lol
arythmetic has quit [Ping timeout: 240 seconds]
<michaelfolkson> That was too easy. NACK to achow101
<laanwj> #topic Wallet maintainer
<core-meetingbot> topic: Wallet maintainer
<MarcoFalke> jamesob is having a rebase party (fun)
<michaelfolkson> jokez
<luke-jr> x.x
<jamesob> MarcoFalke: how did you know?? ;)
arythmetic has joined #bitcoin-core-dev
zonemix has joined #bitcoin-core-dev
<luke-jr> I need to have a rebase party too soon :x
<MarcoFalke> jamesob: I can hear your keyboard
<jamesob> lol
<laanwj> hahaha
<jamesob> nope, that's just PTSD from _actually_ hearing my keyboard two years ago
<luke-jr> ._.
<jb55> rebase party sounds fun but I might have too many conflicts
<cfields_> lol
<MarcoFalke> achow101: Looks like there are no objections. Just promise to merge no bugs, ok?
<laanwj> ok, on topic, ack to achow101 wallet maintainer
<cfields_> ack
<jb55> ack
<michaelfolkson> ACK
<ariard> ack
<fjahr> ack
<luke-jr> should probably post to ML first, but SGTM
<jamesob> ack achow
<laanwj> no, this is a project decision, not a ML decision
<luke-jr> (or not since it's just a Core internal thing idk)
<b10c> ach ackow101
<laanwj> luke-jr: right
<sipa> ack
<jonatack> ACK modulo no bugs :p
<luke-jr> laanwj: right, but some people might not be here
<jamesob> b10c: god bless you
<achow101> MarcoFalke: those aren't bugs, they're features :p
<MarcoFalke> jup bitcoin-core-dev is only for releases
<laanwj> luke-jr: we'll not immediately assign it so other people have time to comment
<kvaciral[m]> ack
<MarcoFalke> There will also be a pull request, which people can comment on
<laanwj> it's not an actual decision in the meeting just an oppertunity to bring up objections
<laanwj> right
<luke-jr> MarcoFalke: good point
<MarcoFalke> I expect that pull to be open for a week at least, maybe longer because holidays?
<laanwj> yeah
<achow101> i'll open it after the meeting then
<sipa> sgtm
<laanwj> oh github has something new, if you click projects you get "projects (beta)" which doesn't actually have the projects... was afraid for a moment they were all gone
<laanwj> #topic High priority for review
<core-meetingbot> topic: High priority for review
<MarcoFalke> can I haz ACK/NACK on #23411 ?
<gribble> https://github.com/bitcoin/bitcoin/issues/23411 | refactor: Avoid integer overflow in ApplyStats when activating snapshot by MarcoFalke · Pull Request #23411 · bitcoin/bitcoin · GitHub
<jamesob> will look
<achow101> #22558 for me
<gribble> https://github.com/bitcoin/bitcoin/issues/22558 | psbt: Taproot fields for PSBT by achow101 · Pull Request #22558 · bitcoin/bitcoin · GitHub
<laanwj> https://github.com/bitcoin/bitcoin/projects/8 7 blockers, 1 chasing concept ACK
<jonatack> review beg for #22932, up since 3 months, has (drum roll...) one concept ack (thanks promag!)
<gribble> https://github.com/bitcoin/bitcoin/issues/22932 | Guard CBlockIndex::nStatus by cs_main, require GetBlockPos/GetUndoPos to hold cs_main by jonatack · Pull Request #22932 · bitcoin/bitcoin · GitHub
<laanwj> MarcoFalke: achow101: added
<jamesob> jonatack: will look
<jonatack> jamesob: thank you
<laanwj> jonatack: some people seem to be confused why it's necessary, was my conclusion from the comments
zonemix has quit [Ping timeout: 256 seconds]
<fjahr> I would like to re-add #21726 but I am still working on a rebase, so I can ask again but it should be ready later tonight
<jonatack> laanwj: good point. I rewrote the OP to state the issue, the fixes, and how to review/test it
<gribble> https://github.com/bitcoin/bitcoin/issues/21726 | Improve Indices on pruned nodes via prune blockers by fjahr · Pull Request #21726 · bitcoin/bitcoin · GitHub
<MarcoFalke> I've removed #21702 from hi-prio
<gribble> https://github.com/bitcoin/bitcoin/issues/21702 | Implement BIP-119 Validation (CheckTemplateVerify) by JeremyRubin · Pull Request #21702 · bitcoin/bitcoin · GitHub
<laanwj> jonatack: thanks!
<michaelfolkson> #22674 will be reverted? If it is that will need to go back into high prio
<gribble> https://github.com/bitcoin/bitcoin/issues/22674 | validation: mempool validation and submission for packages of 1 child + parents by glozow · Pull Request #22674 · bitcoin/bitcoin · GitHub
<laanwj> fjahr: added
<jamesob> MarcoFalke: just on the basis that you think e.g. ML discussion, "consensus gathering" is needed first?
<fjahr> laanwj: thanks!
<MarcoFalke> also removed #21160
<gribble> https://github.com/bitcoin/bitcoin/issues/21160 | net/net processing: Move tx inventory into net_processing by jnewbery · Pull Request #21160 · bitcoin/bitcoin · GitHub
<ariard> michaelfolkson: i think that's good enough if past reviwers re-ack, will review back this evening
<MarcoFalke> jamesob: No, see my comment on the pull
<michaelfolkson> ariard: Ok
<MarcoFalke> hi-prio for review doesn't make a lot of sense when the pull can't be reviewed due to needing rebase
<laanwj> MarcoFalke: i guess jnewbery isn't going to get around to it for the forseeable future? should we mark it up for grabs?
<sipa> Let's perhaps leave that question up to him.
<jonatack> (correction, the pull i mentioned has two concept acks by promag and MarcoFalke)
<laanwj> sipa: yes, good point
<laanwj> any other PRs? any other topics?
<laanwj> michaelfolkson: the idea is to revert one of the commits, not the entire PR
<luke-jr> achow101: please don't drop BDB support any time soon tho :P
<laanwj> michaelfolkson: see #23793
<jamesob> death to BDB
<gribble> https://github.com/bitcoin/bitcoin/issues/23793 | validation: Revert "de-duplicate package transactions already in mempool" by laanwj · Pull Request #23793 · bitcoin/bitcoin · GitHub
<sipa> i wish BDB a painful, but very slow, death
<laanwj> michaelfolkson: but according to achow101 it's unreachable anyway
<luke-jr> XD
<laanwj> in any case reverting the entire seems unnecessary, most of the commits did have extensive review, it was only that one that didn't
jtrag__ is now known as jtrag
<ariard> yeah it's not used currently, submitpackage rpc hasn't been yet introduced afaik, though critical path for future package relay support
<achow101> if it were reachable, i would recommend revert because there's a crashing bug, but it's not reachable, so meh
<michaelfolkson> laanwj: Gotcha, thanks. Have you ever thought of giving advance warning that you're intending to merge something? I've always wondered that
<michaelfolkson> Something like "I think this is ready for merge. Intending to merge in say 3 days"
<laanwj> michaelfolkson: i do that sometimes
<michaelfolkson> Ah ok
<luke-jr> these issues are rare enough that reverting when there's a problem is probably a better approach IMO
<laanwj> i made mistake here
<michaelfolkson> It has secondary effect of being like "last orders" or "last chance to review before merging"
<MarcoFalke> laanwj: I think mistakes are impossible to avoid in general
<laanwj> luke-jr: it only makes sense for extensive or somewhat controversial PRs, not for run of the mill ones
<MarcoFalke> I've merged silent merge conflicts twice in the last week or so
<michaelfolkson> But maybe it has downsides, I don't know. I guess the author would generally prefer immediate merging to avoid need for more rebases
<luke-jr> laanwj: right
<MarcoFalke> They are just too hard to catch while merging
<jamesob> merge-freezes and plenty of testing before releases are the only saving graces afaict
<laanwj> MarcoFalke: yes that happens often enough to me too, usually my local build catches them but it's impossible to run for every platform combo
<MarcoFalke> I'll experiment with DrahtBot re-running the CI on weekends
<MarcoFalke> There is less "real" traffic on weekends
<laanwj> that would be useful
<luke-jr> btw, any reason not to set `greedy` in Cirrus CI stuff?
<sipa> greedy?
<luke-jr> and bump up the -j
<MarcoFalke> luke-jr: Sure, go for it
<luke-jr> sipa: lets the VM use more CPU if it's idle
<sipa> oh, cool
<luke-jr> MarcoFalke: k
<MarcoFalke> sipa: If there is idle CPU on the host it will consume it, even if less CPU was requested
<laanwj> thanks to ariard for doing another review round and catching it anyhow
<sipa> got it... the only reason you wouldn't want greedy is when you're doing benchmarks i assume...
<MarcoFalke> Oh, and we should be cautious about OOM
<luke-jr> hmm
<MarcoFalke> If there is too many CPUs running msan, it will crash the whole VM
<laanwj> benchmarks and too-tight timeouts
<MarcoFalke> memory isn't assigned in greedy
<sipa> right
<luke-jr> MarcoFalke: how about bumping that one job to 8 CPUs / 32 GB RAM?
<MarcoFalke> There is a pool of CPUs that can be used. If one task uses a lot, then other tasks will be scheduled later
<MarcoFalke> Most efficient scheduling (I think) is to use least amount of CPU per task, but many tasks in parallel
<hebasto> ^ agree
<MarcoFalke> Or, if someone has a credit card with unlimited money, we could use that
<MarcoFalke> Maybe 40k-110k per year or so
<luke-jr> could turn off greedy for that one task then I guess
<sipa> Well there is a constant cost (at least cloning repo / configure scripts) which don't run multithreaded.
<sipa> Which puts a limit on how much splitting things up makes sense.
zonemix has joined #bitcoin-core-dev
<MarcoFalke> sipa: Jup, that's why the least amount of number of CPUs is the most efficient (highest total CPU usage)
<laanwj> multithreaded configure sounds pretty cursed
<luke-jr> laanwj: eh, in theory it sounds easy (in practice, tho..)
<laanwj> think of the dependency graph :-)
<sipa> Yes, and in theory, there is no difference between theory and practice; in practice however...
<luke-jr> XD
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] luke-jr opened pull request #23797: ci: Use Cirrus "greedy" flag to use idle CPU time when available (master...cirrus_greedy) https://github.com/bitcoin/bitcoin/pull/23797
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<MarcoFalke> Most of the time only one CPU is used: https://cirrus-ci.com/task/4949915049656320
<MarcoFalke> So I am not sure how much greedy helps us
<laanwj> hehe
<luke-jr> MarcoFalke: I guess we'll see when Cirrus does the PR's CI
<laanwj> right
<sipa> For the functional tests, I've found that (with enough RAM) running more tests in parallel than your number of CPU cores is beneficial.
<luke-jr> hmm, maybe -j60 or something for the tests would be more time-saving?
zonemix has quit [Ping timeout: 240 seconds]
<sipa> Because the tests spend a lot of time waiting.
<MarcoFalke> another option would be to use self-hosted machines (#21652)
<gribble> https://github.com/bitcoin/bitcoin/issues/21652 | [WIP NOMERGE DRAFT] ci: Switch more tasks to self-hosted by MarcoFalke · Pull Request #21652 · bitcoin/bitcoin · GitHub
<MarcoFalke> luke-jr: No, there is one unit test that takes a long time. It will block a single CPU
<luke-jr> I've found if I forget to specify -j64, builds take a looong time :x
<jonatack> -j 4 or 5 here :D
<MarcoFalke> sipa: Right, CI uses 2x or 4x the -j of the number of CPUs available
<b10c> where / who runs the self hosted CI runners?
<laanwj> jonatack: same
<MarcoFalke> b10c: Drahty right now
<hebasto> b10c: bitcoinbuilds.org
<MarcoFalke> sipa: For example https://cirrus-ci.com/task/4949915049656320 has two CPUs and "MAKEJOBS:-j4" env var
<MarcoFalke> hebasto: That is a separate CI system
<sipa> It has 2 CPUs, or 2 CPU threads?
<hebasto> MarcoFalke: right
<MarcoFalke> 2 CPU threads
<sipa> As in: how many entries would /proc/cpuinfo show?
<sipa> Ok.
<MarcoFalke> aka vCPU
<MarcoFalke> For example https://cirrus-ci.com/task/6075814956498944 is run by Drahty
<sipa> For make I wouldn't go above the actual thread count. But for the functional_test runner you can go significantly above it.
<MarcoFalke> env var: "worker:DrahtBot-small-cpx21-ci-bb-001"
<michaelfolkson> c-lightning has been having CI problems due to tests taking up a lot of memory https://btctranscripts.com/c-lightning/2021-11-29-developer-call/#ci-problems. Core tests generally use less memory and so haven't experienced same problems?
<laanwj> jonatack: i have way too many computers but not one with >8 cores or enough memory for -j64 :)
<jonatack> sipa: added the "-j60 tip for running the functional tests to https://jonatack.github.io/articles/how-to-compile-bitcoin-core-and-run-the-tests (near the end) but increased -j for this never worked well for me
<luke-jr> michaelfolkson: eh, Cirrus allows up to 32 GB RAM O.o
<MarcoFalke> sipa: I think there is no downside using a higher -j (if you have enough memory)
<jonatack> laanwj: yes, those purisms don't have many
<jonatack> sipa: (with 32go RAM)
<sipa> jonattack: well, benchmark on your own system which amount works best. I imagine it's a complex function of cpu / diskspeed etc.
<luke-jr> laanwj: mine is only 16 cores, but they're SMT4
<laanwj> jonatack: right, neither do ARM and RV boards for that matter
<b10c> MarcoFalke: thanks, so hetzner cloud (based on cpx21)
<MarcoFalke> b10c: heh, right
<_aj_> jonatack: test_runner.py -j 24 # works pretty well for me with 16GB; usually get one spurious failure though
<laanwj> luke-jr: ye that helps
<jonatack> i do have to use timeout-factor tho, otherwise a few tests time out frequently (rpc_misc mostly, then feature_blockfilterindex_prune and feature_assumevalid)
<sipa> I/O speed matters a lot too.
<laanwj> the way around that is to mount /tmp as tmpfs
<jonatack> maybe my disk encryption doesn't help matters
<jonatack> aj: nice
<laanwj> or at least, whatever temp directory you use for the functional tests
<_aj_> jonatack: (/tmp is on ssd)
<luke-jr> laanwj: I have a zram :p
<luke-jr> not sure I can recommend it though, as it seems Linux is buggy
<luke-jr> (the zram's ext4 fs gets corrupted sometimes)
<MarcoFalke> I also use tmpfs for /tmp
<laanwj> TIL about zram
<sipa> same
<laanwj> i guess that concludes the topic? let's see what #23797 does
<gribble> https://github.com/bitcoin/bitcoin/issues/23797 | ci: Use Cirrus "greedy" flag to use idle CPU time when available by luke-jr · Pull Request #23797 · bitcoin/bitcoin · GitHub
<luke-jr> also handy for putting swap on
<luke-jr> (haven't noticed any swap-zram issues, so I'm guessing the mentioned bugs are probably ext4)
<laanwj> i don't think it makes sense to do a meeting next week (dec 23th) or after (dec 30th), so next one will be jan 6
<sipa> yeah, agree
<michaelfolkson> Cool. Next week's Core PR review club is on multiprocess if anyone wants to use that as an excuse to play around with the multiprocess stuff :)
<laanwj> michaelfolkson: thanks for the heads up
<laanwj> #endmeeting
<core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
<core-meetingbot> Meeting ended Thu Dec 16 19:51:16 2021 UTC.
<evbo> thank you
lukedashjr has joined #bitcoin-core-dev
evbo has quit [Remote host closed the connection]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 opened pull request #23798: contrib: add achow101 to trusted keys (master...wallet-maintainer-key) https://github.com/bitcoin/bitcoin/pull/23798
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
zonemix has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 256 seconds]
lukedashjr has quit [Ping timeout: 256 seconds]
luke-jr has joined #bitcoin-core-dev
zonemix has quit [Ping timeout: 256 seconds]
zonemix has joined #bitcoin-core-dev
zonemix has quit [Remote host closed the connection]
zonemix has joined #bitcoin-core-dev
zonemix has quit [Ping timeout: 268 seconds]
Talkless has quit [Quit: Konversation terminated!]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] sipa opened pull request #23799: Let test_runner.py start multiple jobs per timeslot (master...202112_multitesturn) https://github.com/bitcoin/bitcoin/pull/23799
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
zonemix has joined #bitcoin-core-dev
zonemix has quit [Remote host closed the connection]
zonemix has joined #bitcoin-core-dev
zonemix has quit [Ping timeout: 268 seconds]
zonemix has joined #bitcoin-core-dev
zonemix has quit [Remote host closed the connection]
zonemix has joined #bitcoin-core-dev
zonemix has quit [Ping timeout: 240 seconds]
<jb55> I ran the functional test suite for the first time today, all is good except feature_dbcrash.py seems to hang, is this a known issue?
<sipa> On what kind of system? I don't see any problems.
<jb55> linux (nixos). hmm ok now I need to figure out how to debug this...
sdfgsdfg has joined #bitcoin-core-dev
zonemix has joined #bitcoin-core-dev
jtrag_ has joined #bitcoin-core-dev
jtrag is now known as Guest6729
zonemix has quit [Ping timeout: 256 seconds]
jtrag_ is now known as jtrag
Guest6729 has quit [Ping timeout: 256 seconds]
rex4539 has quit []
zonemix has joined #bitcoin-core-dev
zonemix has quit [Ping timeout: 268 seconds]
<jb55> sipa: ah it wasn't hanging, it looks like the test goes through 40 iterations and each iteration takes over a minute.
<sipa> Slow disk I/O?
<jb55> it's a new SSD, every other test ran quickly
<jb55> Iteration 16, generating 2500 transactions - looks like this is taking about a minute each iteration...
<jb55> will see if --perf helps here...
rex4539 has joined #bitcoin-core-dev
rex4539 has quit [Client Quit]
zonemix has joined #bitcoin-core-dev
zonemix has quit [Ping timeout: 256 seconds]
zonemix has joined #bitcoin-core-dev
zonemix has quit [Ping timeout: 268 seconds]
<luke-jr> gitian builds please * [new tag] v21.2.knots20210629 -> v21.2.knots20210629
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
_andrewtoth_ has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
adiabat has joined #bitcoin-core-dev
boxframes has joined #bitcoin-core-dev
zonemix has joined #bitcoin-core-dev
andrewtoth_ has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
zonemix has quit [Ping timeout: 256 seconds]
yanmaani has joined #bitcoin-core-dev
zonemix has joined #bitcoin-core-dev
jtrag has quit [Quit: 💙]
zonemix has quit [Remote host closed the connection]
zonemix has joined #bitcoin-core-dev