ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] luke-jr closed pull request #24629: Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last pruned block (master...bugfix_rpc_prunebc_retval) https://github.com/bitcoin/bitcoin/pull/24629
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] luke-jr reopened pull request #24629: Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last pruned block (master...bugfix_rpc_prunebc_retval) https://github.com/bitcoin/bitcoin/pull/24629
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
freesprung has quit [Ping timeout: 250 seconds]
freesprung has joined #bitcoin-core-dev
hashfunc569 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
lucasdcf_ has quit [Read error: Connection reset by peer]
zeropoint has quit [Quit: leaving]
lucasdcf_ has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 252 seconds]
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 240 seconds]
bitdex has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
bomb-on has quit [Quit: aллилѹіа!]
brunoerg has joined #bitcoin-core-dev
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
kexkey has joined #bitcoin-core-dev
zxrqmz88 has quit [Quit: Quit]
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
luke-jr has quit [Read error: Connection reset by peer]
ghost43 has quit [Remote host closed the connection]
luke-jr has joined #bitcoin-core-dev
ghost43 has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
arowser has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
luke-jr has quit [Read error: Connection reset by peer]
MarcoFalke_ has joined #bitcoin-core-dev
notmandatory_ has joined #bitcoin-core-dev
qubenix_ has joined #bitcoin-core-dev
adiabat_ has joined #bitcoin-core-dev
jb55_ has joined #bitcoin-core-dev
jb55 has quit [*.net *.split]
MarcoFalke has quit [*.net *.split]
qubenix has quit [*.net *.split]
notmandatory has quit [*.net *.split]
adiabat has quit [*.net *.split]
MarcoFalke_ is now known as MarcoFalke
qubenix_ is now known as qubenix
luke-jr has joined #bitcoin-core-dev
luke-jr has quit [Read error: Connection reset by peer]
luke-jr has joined #bitcoin-core-dev
lukedashjr has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 240 seconds]
lukedashjr is now known as luke-jr
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 240 seconds]
bitdex has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 240 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
hashfunc569 has quit [Ping timeout: 240 seconds]
arowser has quit [Ping timeout: 240 seconds]
bitdex has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
ghost43 has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
ghost43 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Willtech has quit [Read error: Connection reset by peer]
Willtech has joined #bitcoin-core-dev
ghost43_ has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
manbruhpig has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
<manbruhpig>
Hello, I am completely clueless when it comes to doing this sort of stuff. But is it at all possible to chat privately with a bitcoin core dev?
<manbruhpig>
It's regarding something pretty important
lucasdcf_ has quit [Read error: Connection reset by peer]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Guyver2 has joined #bitcoin-core-dev
ghost43_ has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
AaronvanW has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
ghost43 has quit [Ping timeout: 240 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #20751: [fuzzing] Use subprocess.Popen call directly, remove use of thread pool. (master...2020-12-22-fuzz-test-runner) https://github.com/bitcoin/bitcoin/pull/20751
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
ghost43 has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
bitcoin/master fa9086d MarcoFalke: test: Limit scope of id global which is shared between subtests
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
bitcoin/master 44dbf91 fanquake: Merge bitcoin/bitcoin#24627: test: Limit scope of id global which is share...
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake merged pull request #24627: test: Limit scope of id global which is shared between subtests (master...2203-gid-🥒) https://github.com/bitcoin/bitcoin/pull/24627
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
kexkey has quit [Ping timeout: 252 seconds]
kexkey has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Willtech has quit [Remote host closed the connection]
<fanquake>
What has everyone found after there first 5 days of testing rc2 ?
gnaf has quit [Read error: Connection reset by peer]
<hebasto>
running rc2 in GUI mode on Ubuntu 22.04 every time reminds me about #22708 :)
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] theStack opened pull request #24637: test: use MiniWallet for mempool_package_onemore.py (master...20220322-test-use_MiniWallet_for_mempool_packages_onemore) https://github.com/bitcoin/bitcoin/pull/24637
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
jonatack has quit [Quit: Ping timeout (120 seconds)]
gnaf has quit [Quit: Konversation terminated!]
gnaf has joined #bitcoin-core-dev
gnaf has quit [Client Quit]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake closed pull request #23507: Refactor: Improve API design of `ScriptToUniv`, `TxToUniv` etc to return the `UniValue` instead of mutating a parameter/reference (master...ret_UniValue_instead_of_pass_by_ref) https://github.com/bitcoin/bitcoin/pull/23507
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
gnaf has joined #bitcoin-core-dev
flooded is now known as _flood
bitdex has quit [Remote host closed the connection]
shesek has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 256 seconds]
shesek has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
dviola has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
common has quit [Read error: Connection reset by peer]
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
<michaelfolkson>
I think I'm getting confused on some of the supposedly non-wallet functional tests. Something like rpc_createmultisig.py seems like partially a wallet test to me
<michaelfolkson>
I get that if the Core wallet is disabled this test running with Miniwallet is better than it being skipped. But if the Core wallet isn't disabled it is surely better to use (and test) the Core wallet than use Miniwallet?
<sipa>
createmultisig is not a wallet RPC
<MarcoFalke>
michaelfolkson: Oh, actually you might be right. addmultisig is run if the bdb wallet is compiled
<MarcoFalke>
But then passing --legacy-wallet or --descriptor-wallet doesn't make sense
<MarcoFalke>
(I think)
<MarcoFalke>
The test should automatically check if bdb is available and run addmultisig if so
<MarcoFalke>
I am assuming that creating a bdb-descriptor wallet or legacy-sqlite wallet is impossible, correct me if that is wrong on current master
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
<michaelfolkson>
sipa: It is not in the wallet RPCs category, right. But creating a multisig address seems like wallet functionality to me
<michaelfolkson>
Hazy boundaries
<sipa>
createmultisig is a utility RPC, which computes a multisig address given the constituent keys; it's unrelated to the wallet
<sipa>
it's also very old and pretty pointless these days (even more so than when it was introduced)
<michaelfolkson>
Ok thanks
<michaelfolkson>
MarcoFalke: I'm unsure, I thought you could still create those wallets with flags, they're just not the defaults anymore. But I'll check
<MarcoFalke>
I mean if they were, we'd need to run the wallet tests 4 times?
<michaelfolkson>
sipa: Maybe the createmultisig RPC should be deprecated if it is pointless? (I know the project is extremely conservative in terms of deprecating anything in case anyone is using it)
Guyver2 has quit [Remote host closed the connection]
<michaelfolkson>
Certainly possible someone out there is using it
<sipa>
I think that would be reasonable. `deriveaddresses` can do everything it can do.
<sipa>
IIRC
<michaelfolkson>
Ok I'll set up a good first issue to deprecate it. Others can NACK it if they disagree with it being deprecated. We can get rid of the functional test entirely if we deprecate the RPC
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
<michaelfolkson>
Maybe not good first issue, just an issue
<lightlike>
my understanding is that the goal is to completely separate non-wallet tests from designated wallet tests. and not have mixed tests with the rationale that more indirect testing of the wallet can't hurt, even if it's not the main point of the test.
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
ghost43_ has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto opened pull request #24639: guix: Drop code for the unsupported `i686-linux-gnu` host (master...220322-guix686) https://github.com/bitcoin/bitcoin/pull/24639
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<michaelfolkson>
lightlike: Doesn't the first part of your statement contradict with the second part? I think it was a bunch of tests were being skipped that shouldn't necessarily be skipped because they needed the Core wallet and it was disabled
ghost43 has quit [Ping timeout: 240 seconds]
<michaelfolkson>
I agree that more indirect testing of the wallet can't hurt (and could be beneficial) but you get that from using the Core wallet when it is available rather than always using MiniWallet
<sipa>
I think it's just that tests should only be interacting with the Bitcoin Core wallet if they're trying to test the Bitcoin Core wallet. But there are lots of tests that need a wallet for something, but not for the thing being tested. Those should use MiniWallet.
<lightlike>
michaelfolkson: sorry, I phrased the second part ambigously. I thought that the plan was NOT to have indirect testing with the rationale "it can't hurt", and instead chose to have a stricter separation, even if it that means no indirect testing. Otherwise, why migrate all these tests to the Miniwallet?
<sipa>
Using the Core wallet when available and MiniWallet otherwise would need a ton of complexity for no reason.
<michaelfolkson>
lightlike: The reason would be allowing more tests to run when the Core wallet is disabled. But yeah if you read sipa above (and below) an additional motivation seems to be clear separation (in which case use MiniWallet when not testing the Core wallet)
willcl_ark has quit [Quit: issued !quit command]
gnaf has quit [Ping timeout: 260 seconds]
willcl_ark has joined #bitcoin-core-dev
<sipa>
@michaelfolkson: The Bitcoin Core wallet is interacted with for two reasons in the functional tests: (a) for testing the Bitcoin Core wallet or (b) because a test needs *a* wallet-like thing to construct transactions for the purpose of testing some non-wallet component of Bitcoin Core.
<sipa>
In case the Bitcoin Core wallet is disabled, (a) is pointless; there just isn't anything to be tested.
<sipa>
The purpose of this effort is making sure that (b) can run without Bitcoin Core wallet, so that we don't lose test coverage of those non-wallet components.
willcl_ark has quit [Quit: Reconnecting]
willcl_ark has joined #bitcoin-core-dev
<michaelfolkson>
sipa: I won't argue (because I think you're right!) but there is an argument to indirectly use the Core wallet for things in non-wallet tests and then maybe you stumble on problems that aren't tested by the `wallet_` tests
willcl_ark has quit [Changing host]
willcl_ark has joined #bitcoin-core-dev
<sipa>
Sure, perhaps. But that'd be so much effort that if that is truly a concern, we should just add more (a) tests that actually use the wallet.
<michaelfolkson>
Presumably it is only the `wallet_` tests that are supposed to test the wallet and everything without `wallet_` in front of it aren't supposed to test the wallet
<michaelfolkson>
sipa: Right
<sipa>
The thing is also that the (b) tests generally don't do anything particularly complicated/interesting with the wallet.
<sipa>
They generally just create some boring transactions.
<sipa>
Because the test needs some.
willcl_ark has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] luke-jr opened pull request #24640: Bugfix: RPC/blockchain: Correct description of getblockchaininfo's pruneheight result (master...fix_rpcdoc_gbci_pruneheight_desc) https://github.com/bitcoin/bitcoin/pull/24640
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
willcl_ark has joined #bitcoin-core-dev
arowser has joined #bitcoin-core-dev
gnaf has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
ghost43_ has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
yanmaani has quit [Ping timeout: 240 seconds]
yanmaani has joined #bitcoin-core-dev
arowser has quit [Remote host closed the connection]
shesek has quit [Remote host closed the connection]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Guyver2 has joined #bitcoin-core-dev
emcy has quit [Remote host closed the connection]
emcy has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
noonien has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
dviola has joined #bitcoin-core-dev
ghost43_ has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
yanmaani1 has joined #bitcoin-core-dev
yanmaani has quit [Ping timeout: 240 seconds]
<dongcarl>
When fuzzing, the initialize_ function only gets run once, and the FUZZ_TARGET function gets run multiple times?
<sipa>
Correct.
<dongcarl>
sipa: 👍
Talkless has joined #bitcoin-core-dev
jonatack has quit [Quit: Connection closed]
ghost43 has joined #bitcoin-core-dev
ghost43_ has quit [Remote host closed the connection]
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
vysn has joined #bitcoin-core-dev
<luke-jr>
weird, Assume() breaks the context for member calls
<luke-jr>
have to use this->…
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
sipsorcery has quit [Remote host closed the connection]
sipsorcery has joined #bitcoin-core-dev
zeropoint has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
<jeremyrubin>
ctv meeting beginning shortly
vysn has quit [Ping timeout: 240 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
kexkey has quit [Ping timeout: 250 seconds]
kexkey has joined #bitcoin-core-dev
jb55_ is now known as jb55
AaronvanW has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
zxrqmz88 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 256 seconds]
kexkey has quit [Ping timeout: 250 seconds]
kexkey has joined #bitcoin-core-dev
zxrqmz88 has quit [Quit: Quit]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
Kaizen_K_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] achow101 opened pull request #24644: wallet: add tracepoints and algorithm information to coin selection (master...tracepoints-coin-selection) https://github.com/bitcoin/bitcoin/pull/24644
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
hashfuncf39 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]