<bitcoin-git>
bitcoin/master aee29c5 brunoerg: test: wait for the expected basic block filter index in `interface_rest`
<bitcoin-git>
bitcoin/master 7184fb8 MacroFake: Merge bitcoin/bitcoin#26143: test: wait for the expected basic block filte...
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26143: test: wait for the expected basic block filter index in `interface_rest` (master...2022-10-fix-rest-test) https://github.com/bitcoin/bitcoin/pull/26143
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26144: [24.x] wallet: Fix nNextResend data race in ResubmitWalletTransactions (24.x...2209-wallet-race-💆) https://github.com/bitcoin/bitcoin/pull/26144
jonatack has joined #bitcoin-core-dev
<kouloumos>
hebasto: regarding the sanity check for the translation updates, should I comment directly on the PR with my findings?
realies has quit [Quit: Ping timeout (120 seconds)]
realies has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 268 seconds]
Guest5045 has joined #bitcoin-core-dev
Guest5045 has quit [Client Quit]
pablomartin has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 252 seconds]
dougefish_ has joined #bitcoin-core-dev
dougefish has quit [Read error: Connection reset by peer]
pablomartin has joined #bitcoin-core-dev
realies has quit [Quit: Ping timeout (120 seconds)]
realies has joined #bitcoin-core-dev
kexkey has quit [Ping timeout: 250 seconds]
kexkey has joined #bitcoin-core-dev
pablomartin has quit [Quit: Leaving]
_apex2_ has joined #bitcoin-core-dev
_apex2_ has quit [Ping timeout: 250 seconds]
<hebasto>
kouloumos: the best way is to improve translations directly on Transifex. Those improvements will be pulled into that PR shortly.
<hebasto>
kouloumos: a suggestion for the testing guide -- as GUI shortcuts can be translated, in localized GUI it would be nice to verify that there are no conflicts between <Alt>+<Key> shortcuts
<bitcoin-git>
bitcoin/master a8a9ed6 Martin Zumsande: init: Abort if i2p/cjdns are chosen via -onlynet but unreachable
<bitcoin-git>
bitcoin/master 68209a7 Martin Zumsande: rpc: make addpeeraddress work with cjdns addresses
<bitcoin-git>
bitcoin/master 97f865b fanquake: Merge bitcoin/bitcoin#25989: init: abort if i2p/cjdns are chosen via -only...
<bitcoin-git>
[bitcoin] fanquake merged pull request #25989: init: abort if i2p/cjdns are chosen via -onlynet but are unreachable (master...202208_onlynet_init) https://github.com/bitcoin/bitcoin/pull/25989
<kouloumos>
hebasto: Just to verify that my understanding is correct - Your suggestion is to test that the localize GUI shortcuts are doing what they are supposed to do, in case of a wrong translation? Or the conflict you are referring to might be something system specific?
<hebasto>
kouloumos: conflicts could be translation-specific
<hebasto>
eg Alt+C and Alt+K in English could become Alt+F and Alt+F in translated GUI
<hebasto>
when a certain view in the GUI is active, it gets more obvious :)
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26145: [24.x] init: abort if i2p/cjdns are chosen via -onlynet but are unreachable (24.x...202208_onlynet_init) https://github.com/bitcoin/bitcoin/pull/26145
<kouloumos>
Ok I now understand the issue. I wasn't aware of this shortcut-underlining feature, very impressive.
<bitcoin-git>
bitcoin/master b1f44ec fanquake: Merge bitcoin/bitcoin#25737: rpc: treat univalue type check error as RPC_T...
<bitcoin-git>
[bitcoin] fanquake merged pull request #25737: rpc: treat univalue type check error as RPC_TYPE_ERROR, not RPC_MISC_ERROR (master...2022_rpc_remove_type_check) https://github.com/bitcoin/bitcoin/pull/25737
vasild has quit [Ping timeout: 258 seconds]
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26147: [24.x] rpc: treat univalue type check error as RPC_TYPE_ERROR, not RPC_MISC_ERROR (24.x...2022_rpc_remove_type_check) https://github.com/bitcoin/bitcoin/pull/26147
<kouloumos>
hebasto: what do you think is be the best way for people to report this kind of ambiguity? I am trying to think of alternatives to not bloat the testing issue with this kind of screenshots. Is it better to send them in that issue that you just share?
<hebasto>
that issue, or directly fix on Transifex
<hebasto>
also an issue can be opened on Transifex to notice transaltors
<fanquake>
by "that issue", do you mean an issue opened for rc1 testing?
<hebasto>
no need to bloat rc1 testing issue with screenshots...
<hebasto>
kouloumos: to be clear, such issues are translators' responsibility
<kouloumos>
That makes sense, thanks. So opening an issue there sounds a better approach than even dealing with https://github.com/bitcoin-core/gui/issues/126. I'll just need to add a bit of guidance on that flow cause, as a new user, it took me a bit of time to find my way through transifex.
<kouloumos>
Still, good suggestion for the testing guide, "a GUI tour in search of ambiguities"
<bitcoin-git>
[bitcoin] fanquake merged pull request #26145: [24.x] init: abort if i2p/cjdns are chosen via -onlynet but are unreachable (24.x...202208_onlynet_init) https://github.com/bitcoin/bitcoin/pull/26145
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
AaronvanW has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] dergoegge opened pull request #26151: refactor: Guard TxRequestTracker by its own lock instead of cs_main (master...2022-09-txrequest-cs_main-split) https://github.com/bitcoin/bitcoin/pull/26151
kcalvinalvin has quit [Ping timeout: 255 seconds]
kcalvinalvin has joined #bitcoin-core-dev
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] Xekyo opened pull request #26152: Bump unconfirmed ancestor transactions to target feerate (master...2022-09-ancestor-aware-funding) https://github.com/bitcoin/bitcoin/pull/26152
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
hashfunc has joined #bitcoin-core-dev
brunoerg has quit []
andrewtoth has quit [Remote host closed the connection]
andrewtoth has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
andrewtoth has quit [Ping timeout: 258 seconds]
Guest6381 has joined #bitcoin-core-dev
Guest6381 has quit [Client Quit]
_apex2_ has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
amovfx_ has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 260 seconds]
sipsorcery has quit [Ping timeout: 260 seconds]
hashfunc has quit [Remote host closed the connection]
_apex2_ has quit [Ping timeout: 264 seconds]
sipsorcery has joined #bitcoin-core-dev
amovfx_ has quit [Remote host closed the connection]
bitdex has quit [Ping timeout: 258 seconds]
amovfx has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
velgin has joined #bitcoin-core-dev
kouloumos has quit [Quit: Connection closed for inactivity]
velgin has quit [Client Quit]
andrewtoth has joined #bitcoin-core-dev
sipsorcery has quit [Remote host closed the connection]
sipsorcery has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] sipa opened pull request #26153: Reduce wasted pseudorandom bytes in ChaCha20 + various improvements (master...202209_chacha20) https://github.com/bitcoin/bitcoin/pull/26153
jespada has quit [Ping timeout: 244 seconds]
jespada has joined #bitcoin-core-dev
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Remote host closed the connection]