brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 276 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 240 seconds]
flooded has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 255 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 245 seconds]
brunoerg has quit [Ping timeout: 256 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
jarthur has quit [Quit: jarthur]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
kevkevin has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
kevkevin has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] jonatack opened pull request #29202: Remove no-longer-needed NOLINTNEXTLINE since C++20 upgrade (master...2024-01-rm-unneeded-NOLINTNEXTLINE) https://github.com/bitcoin/bitcoin/pull/29202
<jon_atack>
I wonder if there is an issue with the test-each-commit tidy CI check. It was red for a failing unit test in an intermediairy commit, but after the author force-pushed an update for the last 2 commits of the PR that didn't update the commit with test failure, the CI was green. See https://github.com/bitcoin/bitcoin/pull/29198#issuecomment-1880180224
<_aj_>
jon_atack: the each-commit test isn't listed in the 13-successful-checks? is it the 1-workflow-awaiting-approval maybe?
<bitcoin-git>
[bitcoin] fanquake merged pull request #28610: wallet: Migrate entire address book entries to watchonly and solvables too (master...migrate-avoidreuse) https://github.com/bitcoin/bitcoin/pull/28610
<bitcoin-git>
[bitcoin] hebasto opened pull request #29203: build: Drop `ALLOW_HOST_PACKAGES` support in depends (master...240108-allow) https://github.com/bitcoin/bitcoin/pull/29203
<bitcoin-git>
[bitcoin] furszy opened pull request #29204: test: wallet migration, add coverage for tx extra data (master...2023_test_wallet_txs_comments_migration) https://github.com/bitcoin/bitcoin/pull/29204
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
bob_x2 has quit [Remote host closed the connection]
<bitcoin-git>
[bitcoin] fanquake opened pull request #29205: build: always set `-g -O2` in `CORE_CXXFLAGS` (master...core_cxxflags_always_O2) https://github.com/bitcoin/bitcoin/pull/29205
<bitcoin-git>
[bitcoin] yancyribbens opened pull request #29206: test: Add algo assert to bnb_search_test (master...add-algo-assert-to-bnb-tests) https://github.com/bitcoin/bitcoin/pull/29206
not_reserved has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
_flood has quit [Ping timeout: 256 seconds]
Talkless has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 246 seconds]
flooded has quit [Ping timeout: 256 seconds]
not_reserved has quit [Quit: Client closed]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
Guyver2 has left #bitcoin-core-dev [Closing Window]
freesprung512 has quit [Ping timeout: 252 seconds]
freesprung512 has joined #bitcoin-core-dev
GregTonoski has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
freesprung512 has quit [Ping timeout: 256 seconds]
GregTonoski has quit [Quit: Client closed]
GregTonoski has joined #bitcoin-core-dev
freesprung512 has joined #bitcoin-core-dev
GregTonoski has quit [Quit: Client closed]
GregTonoski has joined #bitcoin-core-dev
<GregTonoski>
#proposedmeetingtopic SPAM threats and protection in Bitcoin Core
GregTonoski has quit [Quit: Client closed]
GregTonoski has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 256 seconds]
flooded has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
<sr_gi[m]>
brunoerg: I came across #27114 and considered giving it a review but I'm really missing context here. Why would you want to whitelist an outbound connection? (the issue being linked has a broken reference to the code so I'm really missing the point)
<instagibbs>
sr_gi[m] if you follow the other issue that was closed, looks like it's so you don't DoS ban a node you connect to intentionally
<sr_gi[m]>
instagibbs: but that's a bit odd, isn't it? Outbounds are picked at random, so whitelisting a random peer does not seem like a good practice to begin with. If you happen to want to whitelist a manually added outbound that would be different, but then the anti DoS motivation doesn't make much sense (you are not going to DoS yourself)
<brunoerg>
Hi
<sr_gi[m]>
I could see this being somewhat useful if we were talking about manual outbound for any other case but anti DoS, that is, you want to whitelist with forcerelay for instance, or mempool
<sr_gi[m]>
brunoerg: Thanks! I think adding this to the PR description as motivation would be helpful, both for future reference reasons but also for reviewers that may find themselves in the same spot I'm atm
<brunoerg>
Sure, will add! Thank you!
GregTonoski has quit [Quit: Client closed]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
preimage has quit [Quit: WeeChat 4.1.1]
DarrylTheFish has joined #bitcoin-core-dev
DarrylTheFish has quit [Changing host]
DarrylTheFish has joined #bitcoin-core-dev
DarrylTheFish has quit [Remote host closed the connection]