ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/71f0f2273f62...ae2658caacc1
<bitcoin-git> bitcoin/master 141df0a Cory Fields: crypto: disable asan for sha256_sse4 with clang and -O0
<bitcoin-git> bitcoin/master ae2658c merge-script: Merge bitcoin/bitcoin#30097: crypto: disable asan for sha256_sse4 with cla...
<bitcoin-git> [bitcoin] fanquake merged pull request #30097: crypto: disable asan for sha256_sse4 with clang and -O0 (master...sha2asan) https://github.com/bitcoin/bitcoin/pull/30097
Victor has joined #bitcoin-core-dev
Victor is now known as Guest7319
lbia has quit [Ping timeout: 252 seconds]
lbia has joined #bitcoin-core-dev
Guest7319 has quit [Quit: Client closed]
<bitcoin-git> [bitcoin] fanquake opened pull request #30120: Update libsecp256k1 subtree to current master (master...secp256k1_0_5_0) https://github.com/bitcoin/bitcoin/pull/30120
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ae2658caacc1...dd42a5ddea6a
<bitcoin-git> bitcoin/master 684da97 Jon Atack: p2p, bugfix: detect addnode cjdns peers in GetAddedNodeInfo()
<bitcoin-git> bitcoin/master d0b0474 Jon Atack: test: add GetAddedNodeInfo() CJDNS regression unit test
<bitcoin-git> bitcoin/master dd42a5d merge-script: Merge bitcoin/bitcoin#30085: p2p: detect addnode cjdns peers in GetAddedNo...
<bitcoin-git> [bitcoin] fanquake merged pull request #30085: p2p: detect addnode cjdns peers in GetAddedNodeInfo() (master...2024-05-fix-cjdns-detection-in-GetAddedNodeInfo) https://github.com/bitcoin/bitcoin/pull/30085
Victor165532 has joined #bitcoin-core-dev
Victor165532 has quit [Client Quit]
preimage has quit [Quit: WeeChat 4.2.2]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 260 seconds]
lbia has quit [Ping timeout: 246 seconds]
lbia has joined #bitcoin-core-dev
lbia has quit [Ping timeout: 255 seconds]
dermoth has quit [Ping timeout: 246 seconds]
dermoth has joined #bitcoin-core-dev
salvatoshi has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
aleggg has quit [Remote host closed the connection]
aleggg has joined #bitcoin-core-dev
hen has joined #bitcoin-core-dev
hen has quit [Client Quit]
earnest has joined #bitcoin-core-dev
earnest is now known as Guest8692
freesprung5126 has quit [Ping timeout: 256 seconds]
Guest8692 has quit [Ping timeout: 250 seconds]
Guyver2 has left #bitcoin-core-dev [Closing Window]
freesprung5126 has joined #bitcoin-core-dev
dunxen has joined #bitcoin-core-dev
Lockesmith has quit [Remote host closed the connection]
Lockesmith has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 260 seconds]
bitdex has joined #bitcoin-core-dev
Lockesmith has quit [Remote host closed the connection]
Lockesmith has joined #bitcoin-core-dev
gnaf has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] laanwj closed pull request #29874: test: Add large aligned vmov check for mingw (master...2024-04-forbidden-vmov-check) https://github.com/bitcoin/bitcoin/pull/29874
lbia has joined #bitcoin-core-dev
gnaf has quit [Ping timeout: 268 seconds]
lbia has quit [Ping timeout: 260 seconds]
aleggg has quit [Remote host closed the connection]
lbia has joined #bitcoin-core-dev
aleggg has joined #bitcoin-core-dev
BrandonOdiwuor has joined #bitcoin-core-dev
dunxen has quit [Ping timeout: 240 seconds]
dunxen has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
gnaf has joined #bitcoin-core-dev
dunxen has quit [Ping timeout: 240 seconds]
earnest has joined #bitcoin-core-dev
earnest is now known as Guest4233
Guest4233 has quit [Ping timeout: 250 seconds]
bitdex has quit [Quit: = ""]
<bitcoin-git> [bitcoin] furszy opened pull request #30122: bench: enable wallet creation benchmarks on all platforms (master...2024_bench_enable_wallet_create) https://github.com/bitcoin/bitcoin/pull/30122
gue65 has joined #bitcoin-core-dev
gue65 has quit [Ping timeout: 250 seconds]
cygnet3 has joined #bitcoin-core-dev
blackheb has joined #bitcoin-core-dev
Guest97 has joined #bitcoin-core-dev
blackheb has quit [Quit: Client closed]
Guest97 has quit [Client Quit]
blackhen has joined #bitcoin-core-dev
blackhen has quit [Client Quit]
abubakarsadiq has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 260 seconds]
gmaxwell has joined #bitcoin-core-dev
<achow101> #startmeeting
<jonatack> hi
<TheCharlatan> hi
<pinheadmz> hi
<hebasto> hi
<achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild
<willcl-ark> hi
<vasild> hi
<cfields> hi
<brunoerg> hi
<furszy> hi
<dergoegge> hi
<achow101> There is one preproposed meeting topic this week. Any last minute ones to add to the list?
<sr_gi[m]> hi
<b10c> hi
Emc99 has joined #bitcoin-core-dev
<Murch[m]> hi
<achow101> #topic package relay updates (glozow)
<glozow> #30000 was merged (yay!). The priority PR is still #28984. On the p2p side, I opened #30110 as the next step. #30111 splits out the first 4 commits which are concerned with thread safety and should be reviewed very carefully. The rest of #30110 consists of more mechanical refactoring + tests.
<gribble> https://github.com/bitcoin/bitcoin/issues/30000 | p2p: index TxOrphanage by wtxid, allow entries with same txid by glozow · Pull Request #30000 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/28984 | Cluster size 2 package rbf by instagibbs · Pull Request #28984 · bitcoin/bitcoin · GitHub
<kanzure> hi
<gribble> https://github.com/bitcoin/bitcoin/issues/30110 | refactor: TxDownloadManager by glozow · Pull Request #30110 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/30111 | locks: introduce mutex for tx download, flush rejection filters on UpdatedBlockTip by glozow · Pull Request #30111 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/30110 | refactor: TxDownloadManager by glozow · Pull Request #30110 · bitcoin/bitcoin · GitHub
<josie> hi
<sipa> hi
<glozow> And #28984 has #20072 as the first few refactoring commits
<gmaxwell> hi
<gribble> https://github.com/bitcoin/bitcoin/issues/28984 | Cluster size 2 package rbf by instagibbs · Pull Request #28984 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/20072 | ci: Build Arm64 on Travis without functional tests by fjahr · Pull Request #20072 · bitcoin/bitcoin · GitHub
<glozow> sorry I meant #30072
<gribble> https://github.com/bitcoin/bitcoin/issues/30072 | refactor prep for package rbf by instagibbs · Pull Request #30072 · bitcoin/bitcoin · GitHub
<achow101> so #30072 should go first?
<gribble> https://github.com/bitcoin/bitcoin/issues/30072 | refactor prep for package rbf by instagibbs · Pull Request #30072 · bitcoin/bitcoin · GitHub
<_aj_> hi
<glozow> Yeah it's the first few commits of package RBF
<glozow> Oh also, I figured I'd ping on #29873 which seems to have some conceptual support, would be nice to get that in so we can do #29496
<gribble> https://github.com/bitcoin/bitcoin/issues/29873 | policy: restrict all TRUC (v3) transactions to 25KvB by glozow · Pull Request #29873 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/29496 | policy: bump TX_MAX_STANDARD_VERSION to 3 by glozow · Pull Request #29496 · bitcoin/bitcoin · GitHub
<glozow> (also feel free to bikeshed on the 25k number)
<glozow> That's all from me.
<achow101> #topic cluster mempool updates (sdaftuar)
<sdaftuar> hi -- so i think last week i mentioned i had been working on an esoteric issue. unfortunately i've still been working on it for the past week so i can just quickly update what that is
<sdaftuar> one thing that sipa and i have been discussing is whether we cna come up with some sort of "quality metric" for linearizations. there are a couple of reasons you might want this:
pablomartin has joined #bitcoin-core-dev
<sdaftuar> a) having tests to ensure that our code does what we expect (eg regression tests so we don't break things in the future)
<sdaftuar> b) having an understanding of what guarantees we provide to users
<sdaftuar> so as a natural place to start, we can think about guarantees ancestor feerate based mining provides. however, it turns out that it seems to guarantee surprisingly little, and coming up with general properties that should hold up is quite hard
<sdaftuar> anyway, i don't have a good answer to this question yet but will continue to think about it, and probably set my sights lower for what tests we can include
<sdaftuar> that's it from me
<stickies-v> hi
<sipa> i'll probably open a PR today with low-level cluster linearization code
<achow101> yay
<sdaftuar> \o/
<sdaftuar> that would immediately become the PR to review please :)
<achow101> #topic legacy wallet removal updates (achow101)
<achow101> #26606 has been getting plenty of review and seems to be close. there's a few residual comments that need to be addressed, but those should be fairly trivial
<gribble> https://github.com/bitcoin/bitcoin/issues/26606 | wallet: Implement independent BDB parser by achow101 · Pull Request #26606 · bitcoin/bitcoin · GitHub
<achow101> once again, if you have legacy wallets, testing them with the parser would be appreciated
<achow101> #topic Ad-hoc high priority for review
<achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4
<glozow> Not sure if this should be in the project board, but I would appreciate some review on #29899.
<gribble> https://github.com/bitcoin/bitcoin/issues/29899 | [26.x] archive 26.1 release notes + backports by glozow · Pull Request #29899 · bitcoin/bitcoin · GitHub
<achow101> glozow: added
<glozow> thanks!
<sr_gi[m]> I've recently opened https://github.com/bitcoin/bitcoin/pull/30116. Given Erlay was listed in high review prio, I guess that should also go there
<achow101> sr_gi[m]: that board is for whatever you personally feel should be slightly prioritized
<vasild> maflcko: would be nice if you remove your stale NACK from https://github.com/bitcoin/bitcoin/pull/29421#issuecomment-1985212820
<achow101> sr_gi[m]: should #28765 be closed?
<gribble> https://github.com/bitcoin/bitcoin/issues/28765 | p2p: Fill reconciliation sets (Erlay) by naumenkogs · Pull Request #28765 · bitcoin/bitcoin · GitHub
<sipa> i think we don't want to two ~identical PRs open simultaneously
<sr_gi[m]> I think so. I talked to Gleb and looks like he had no time to work on it atm, and he was happy that I picked it up
<Chris_Stewart_5> hi
<bitcoin-git> [bitcoin] achow101 closed pull request #28765: p2p: Fill reconciliation sets (Erlay) (master...2023-11-erlay2.1) https://github.com/bitcoin/bitcoin/pull/28765
<achow101> closed, and added #30116 to the board
<gribble> https://github.com/bitcoin/bitcoin/issues/30116 | p2p: Fill reconciliation sets (Erlay) attempt 2 by sr-gi · Pull Request #30116 · bitcoin/bitcoin · GitHub
<abubakarsadiq> hi
<sr_gi[m]> ty
<achow101> #topic moderators (achow101)
<achow101> The proposed moderation guidelines have been public for a couple weeks now, and there's been a bit of feedback. I think it's at the point that we can move forward with putting them into effect and electing/appointing/volunteering some moderators
<achow101> There is a meta repo where the guidelines will live, as well as any meta discussion: https://github.com/bitcoin-core/meta. the discussion about the guidelines has taken place there as well.
<bitcoin-git> [bitcoin] ryanofsky pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/dd42a5ddea6a...75118a608fc2
<bitcoin-git> bitcoin/master 4202c17 Matthew Zipkin: test: refactor interface_rpc.py
<bitcoin-git> bitcoin/master 09416f9 Matthew Zipkin: test: cover JSONRPC 2.0 requests, batches, and notifications
<bitcoin-git> bitcoin/master df6e375 Matthew Zipkin: rpc: Avoid copies in JSONRPCReplyObj()
<bitcoin-git> [bitcoin] ryanofsky merged pull request #27101: Support JSON-RPC 2.0 when requested by client (master...jsonrpc-2.0) https://github.com/bitcoin/bitcoin/pull/27101
<achow101> 2 weeks ago, willcl-ark and pinheadmz volunteered to be moderators, and I think there was general agreement for them. I think we can start with them, if there are no objections?
<darosior> hi
<darosior> +1 for both
<cfields> +1
<hebasto> ACK on willcl-ark and pinheadmz
<brunoerg> +1
<abubakarsadiq> +1
<sipa> +1
<ajonas> +1
<dergoegge> +1
<b10c> +2
<josie> +1
<josie> b10c: lol
* pinheadmz blushing
<pinheadmz> json 2.0 merged too plenty of free time now
<vasild> +1
<achow101> as always, we can make changes if necessary, this isn't something that's set in stone
<sr_gi[m]> ACK on both
Chris_Stewart_5 has quit [Ping timeout: 264 seconds]
<jonatack> guidelines suggestion: "pull requests will be *aggressively* moderated" -> s/aggressively/actively/
<achow101> Any other topics to discuss?
<jonatack> +1 on willcl-ark and pinheadmz
Chris_Stewart_5 has joined #bitcoin-core-dev
<achow101> #endmeeting
Emc99 has quit [Quit: Client closed]
<achow101> jonatack: i believe the word choice was intentional, as in people shouldn't be surprised if their comment gets deleted
<jonatack> achow101: I think "actively" suggests it too, just less aggressively :)
<_aj_> could use "zealously", to be a bit less "let's have a fight about it"
<laanwj> +1
bugs_ has joined #bitcoin-core-dev
<vasild> to me that first paragraph about aggressive moderation brings some bitter/negative feelings, like "you are enering enemy territory here!"
<achow101> jonatack: i suppose so. changed it
<jonatack> achow101: ty
<jonatack> thankfully on the bips repo it's been limited so far
<jonatack> (the need for moderation)
<achow101> jonatack: well there is still spam that we've been deleting
<achow101> but not so much brigading currently, although the taproot assets and ordinals bips prs have attracted that in the past
<jonatack> same, deleting. and twice reminded people to focus on technical review.
<jonatack> perhaps reworking bip 2 will help clarify the repo scope.
Guyver2 has joined #bitcoin-core-dev
preimage has joined #bitcoin-core-dev
Emc99 has joined #bitcoin-core-dev
Emc99 has quit [Client Quit]
Guyver2 has left #bitcoin-core-dev [Closing Window]
<bitcoin-git> [bitcoin] ryanofsky pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/75118a608fc2...2f53f2273da0
<bitcoin-git> bitcoin/master 0d114e3 Martin Zumsande: blockstorage: Add Assume for fKnown / snapshot chainstate
<bitcoin-git> bitcoin/master fdae638 Martin Zumsande: doc: Improve doc for functions involved in saving blocks to disk
<bitcoin-git> bitcoin/master 064859b Martin Zumsande: blockstorage: split up FindBlockPos function
<bitcoin-git> [bitcoin] ryanofsky merged pull request #29975: blockstorage: Separate reindexing from saving new blocks (master...202404_blockstorage_split_reindex) https://github.com/bitcoin/bitcoin/pull/29975
dunxen has joined #bitcoin-core-dev
dunxen has quit [Remote host closed the connection]
pablomartin has quit [Ping timeout: 256 seconds]
gnaf has quit [Quit: Konversation terminated!]
gnaf has joined #bitcoin-core-dev
lbia has quit [Ping timeout: 256 seconds]
lbia has joined #bitcoin-core-dev
the_mariner1 has joined #bitcoin-core-dev
the_mariner has quit [Ping timeout: 268 seconds]
the_mariner has joined #bitcoin-core-dev
the_mariner1 has quit [Ping timeout: 256 seconds]
bugs_ has quit [Quit: Leaving]
Talkless has joined #bitcoin-core-dev
conman has quit [Ping timeout: 272 seconds]
Guest70 has joined #bitcoin-core-dev
Guest70 has quit [Client Quit]
gnaf has quit [Quit: Konversation terminated!]
<bitcoin-git> [bitcoin] theStack opened pull request #30125: test: improve BDB parser (handle internal/overflow pages, support all page sizes) (master...complete_bdb-ro_python_parser2) https://github.com/bitcoin/bitcoin/pull/30125
sohrab_ has quit [Ping timeout: 268 seconds]
the_mariner1 has joined #bitcoin-core-dev
mcey has quit [Remote host closed the connection]
mcey_ has joined #bitcoin-core-dev
the_mariner has quit [Ping timeout: 256 seconds]
the_mariner1 is now known as the_mariner
mcey_ has quit [Remote host closed the connection]
mcey_ has joined #bitcoin-core-dev
the_mariner1 has joined #bitcoin-core-dev
the_mariner has quit [Ping timeout: 260 seconds]
the_mariner has joined #bitcoin-core-dev
the_mariner1 has quit [Ping timeout: 256 seconds]
willcl-ark has quit [Quit: left]
willcl-ark has joined #bitcoin-core-dev
willcl-ark has joined #bitcoin-core-dev
theStack has quit [Remote host closed the connection]
stevenroose has quit [Ping timeout: 268 seconds]
stevenroose has joined #bitcoin-core-dev
real_or_random has quit [Read error: Connection reset by peer]
Novo has quit [Ping timeout: 256 seconds]
w0xlt has quit [Ping timeout: 256 seconds]
lightningbot has quit [Killed (NickServ (GHOST command used by lightningbot`))]
Novo_ has joined #bitcoin-core-dev
sugarpuff_ has joined #bitcoin-core-dev
abubakarsadiq_ has joined #bitcoin-core-dev
Sjors[m]1 has joined #bitcoin-core-dev
josie_ has joined #bitcoin-core-dev
valwal has quit [Read error: Connection reset by peer]
bw_____ has quit [Read error: Connection reset by peer]
Sjors[m] has quit [Ping timeout: 246 seconds]
jkczyz has quit [Read error: Connection reset by peer]
sugarpuff has quit [Read error: Connection reset by peer]
amiti_ has quit [Write error: Connection reset by peer]
abubakarsadiq has quit [Ping timeout: 268 seconds]
Earnestly has quit [Ping timeout: 268 seconds]
sugarpuff_ is now known as sugarpuff
abubakarsadiq_ is now known as abubakarsadiq
jkczyz_ has joined #bitcoin-core-dev
valwal_ has joined #bitcoin-core-dev
real_or_random has joined #bitcoin-core-dev
amiti__ has joined #bitcoin-core-dev
w0xlt has joined #bitcoin-core-dev
bw_____ has joined #bitcoin-core-dev
mekster669493 has quit [Quit: Ping timeout (120 seconds)]
Earnestly has joined #bitcoin-core-dev
josie has quit [Ping timeout: 246 seconds]
lightningbot has joined #bitcoin-core-dev
sample has quit [Ping timeout: 268 seconds]
mekster669493 has joined #bitcoin-core-dev
the_mariner1 has joined #bitcoin-core-dev
the_mariner has quit [Ping timeout: 240 seconds]
the_mariner1 is now known as the_mariner
sample has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
<bitcoin-git> [bitcoin-maintainer-tools] laanwj opened pull request #166: Improved check-dnsseeds.py implementation (main...2024-05-new-dnsseeds) https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/166
<bitcoin-git> [bitcoin] sipa opened pull request #30126: Low-level cluster linearization code (master...202405_clusterlin) https://github.com/bitcoin/bitcoin/pull/30126
<bitcoin-git> [bitcoincore.org] dependabot[bot] opened pull request #1023: Bump rexml from 3.2.5 to 3.2.8 (master...dependabot/bundler/rexml-3.2.8) https://github.com/bitcoin-core/bitcoincore.org/pull/1023
preimage has quit [Quit: WeeChat 4.2.2]
sohrab has joined #bitcoin-core-dev
lbia has quit [Ping timeout: 260 seconds]
lbia has joined #bitcoin-core-dev
emcy__ has joined #bitcoin-core-dev
mcey_ has quit [Ping timeout: 256 seconds]
darosior has quit [Quit: Ping timeout (120 seconds)]
darosior has joined #bitcoin-core-dev
h329_ has joined #bitcoin-core-dev
h329_ has quit [Quit: Client closed]
S3RK_ has joined #bitcoin-core-dev
cygnet3 has quit [Quit: Leaving]
S3RK has quit [Ping timeout: 256 seconds]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
bitdex has joined #bitcoin-core-dev
sohrab has quit [Ping timeout: 268 seconds]
sohrab has joined #bitcoin-core-dev