ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
VonNaturAustreVe has quit [Read error: Connection reset by peer]
bitdex has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 260 seconds]
zeropoint has quit [Quit: leaving]
Torr has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
qxs has quit [Remote host closed the connection]
qxs has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] BenWestgate closed pull request #30147: contrib: Fixup verify-binaries OS platform parsing (master...30145-parse-os-version-correctly) https://github.com/bitcoin/bitcoin/pull/30147
Torr has quit [Quit: Torr]
lbia has quit [Ping timeout: 260 seconds]
aleggg has quit [Remote host closed the connection]
aleggg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] BenWestgate reopened pull request #30147: contrib: Fixup verify-binaries OS platform parsing (master...30145-parse-os-version-correctly) https://github.com/bitcoin/bitcoin/pull/30147
Guest51 has joined #bitcoin-core-dev
Guest51 has quit [Client Quit]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
bitdex has quit [Ping timeout: 260 seconds]
puchka has quit [Ping timeout: 252 seconds]
puchka has joined #bitcoin-core-dev
runnerelektrode has quit [Ping timeout: 260 seconds]
runnerelektrode has joined #bitcoin-core-dev
uasf has joined #bitcoin-core-dev
BlueMattMtrxBot has quit [Ping timeout: 260 seconds]
BlueMattMtrxBot has joined #bitcoin-core-dev
bitcoin-git has quit [Ping timeout: 260 seconds]
uasf_ has quit [Ping timeout: 260 seconds]
bitcoin-git has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 240 seconds]
puchka has joined #bitcoin-core-dev
salvatoshi has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
pablomartin4btc has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 268 seconds]
Guyver2 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6f36624147df...ef44726918c0
<bitcoin-git> bitcoin/master 21b8a14 Hennadii Stepanov: depends: Fetch miniupnpc sources from an alternative website
<bitcoin-git> bitcoin/master ef44726 merge-script: Merge bitcoin/bitcoin#30151: depends: Fetch miniupnpc sources from an alte...
<bitcoin-git> [bitcoin] fanquake merged pull request #30151: depends: Fetch miniupnpc sources from an alternative website (master...240522-upnp-dl) https://github.com/bitcoin/bitcoin/pull/30151
pablomartin4btc has quit [Ping timeout: 268 seconds]
Guest79 has joined #bitcoin-core-dev
Guest79 has quit [Client Quit]
lbia has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] dergoegge opened pull request #30156: fuzz: More accurate coverage reports (master...2024-05-cov-reset-counters) https://github.com/bitcoin/bitcoin/pull/30156
pablomartin4btc has joined #bitcoin-core-dev
adil1 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] glozow pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ef44726918c0...83ae1bac9d3e
<bitcoin-git> bitcoin/master 8c27149 brunoerg: net: rpc: return peer's mapped AS in getrawaddrman
<bitcoin-git> bitcoin/master 1e54d61 brunoerg: test: add coverage for `mapped_as` from `getrawaddrman`
<bitcoin-git> bitcoin/master 83ae1ba glozow: Merge bitcoin/bitcoin#30062: net: add ASMap info in `getrawaddrman` RPC
<bitcoin-git> [bitcoin] glozow merged pull request #30062: net: add ASMap info in `getrawaddrman` RPC (master...2024-04-asmap-getrawaddrman) https://github.com/bitcoin/bitcoin/pull/30062
puchka has quit [Ping timeout: 256 seconds]
<bitcoin-git> [bitcoin] ismaelsadeeq opened pull request #30157: Fee Estimation via Fee rate Forecasters (master...new-fee-estimator) https://github.com/bitcoin/bitcoin/pull/30157
puchka has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 268 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/83ae1bac9d3e...f15778536ad4
<bitcoin-git> bitcoin/master 9f4ff1e Ava Chow: windeploy: Renew certificate
<bitcoin-git> bitcoin/master f157785 merge-script: Merge bitcoin/bitcoin#30149: contrib: Renew Windows code signing certifica...
<bitcoin-git> [bitcoin] fanquake merged pull request #30149: contrib: Renew Windows code signing certificate (master...2024-win-cert-renew) https://github.com/bitcoin/bitcoin/pull/30149
puchka has joined #bitcoin-core-dev
adil1 has quit [Quit: adil1]
mudsip has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
pablomartin4btc has quit [Ping timeout: 268 seconds]
mudsip has quit []
abubakarsadiq has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
Emc99 has joined #bitcoin-core-dev
<achow101> #startmeeting
<glozow> hi
<achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild
<dergoegge> hi
<stickies-v> hi
<hebasto> hi
<cfields> hi
<lightlike> hi
<willcl-ark> Hi
<furszy> hi
<TheCharlatan> hi
<achow101> There are no preproposed meeting topics this week. Any last minute ones to add?
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f15778536ad4...e163d864d380
<LarryRuane> hi
<bitcoin-git> bitcoin/master 6629d1d furszy: test: improve robustness of connect_nodes()
<pinheadmz> Hi
<bitcoin-git> bitcoin/master e163d86 Ava Chow: Merge bitcoin/bitcoin#30118: test: improve robustness of connect_nodes()
<virtu> hi
<bitcoin-git> [bitcoin] achow101 merged pull request #30118: test: improve robustness of connect_nodes() (master...2024_test_improve_connect_nodes) https://github.com/bitcoin/bitcoin/pull/30118
<instagibbs> achow101 meeting foul
<b10c> hi
<glozow> wow extreme multi-tasking
marcofleon has joined #bitcoin-core-dev
<sipa> hi
<ajonas> Hi
<sdaftuar> hi
<josie_> hi
<achow101> lol
<achow101> #topic package relay updates (glozow)
<fjahr> hi
<glozow> Things moving with TRUCs/BIP431/v3. #29873 looks really close. Just working on some comments on the BIP (which now has a number!) as well.
<gribble> https://github.com/bitcoin/bitcoin/issues/29873 | policy: restrict all TRUC (v3) transactions to 10kvB by glozow · Pull Request #29873 · bitcoin/bitcoin · GitHub
<glozow> After that, we just do #29496 to flip the switch
<gribble> https://github.com/bitcoin/bitcoin/issues/29496 | policy: bump TX_MAX_STANDARD_VERSION to 3 by glozow · Pull Request #29496 · bitcoin/bitcoin · GitHub
<marcofleon> hi
<instagibbs> \o/
<abubakarsadiq> hi
<glozow> for package RBF, #30072 looks close, and #28984 is still the priority.
<glozow> On the p2p side, I'm still soliciting review on the locks PR #30111
<gribble> https://github.com/bitcoin/bitcoin/issues/30072 | refactor prep for package rbf by instagibbs · Pull Request #30072 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/28984 | Cluster size 2 package rbf by instagibbs · Pull Request #28984 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/30111 | locks: introduce mutex for tx download, flush rejection filters on UpdatedBlockTip by glozow · Pull Request #30111 · bitcoin/bitcoin · GitHub
<glozow> That's all from me
<achow101> #topic cluster mempool updates (sdaftuar)
<sdaftuar> My cluster mempool update today is pretty short: last week, sipa opened PR #30126 which introduces the low-level cluster linearization code that the cluster mempool branch will ultimately build on.
<gribble> https://github.com/bitcoin/bitcoin/issues/30126 | Low-level cluster linearization code by sipa · Pull Request #30126 · bitcoin/bitcoin · GitHub
<sdaftuar> \o/I plan to rebase my draft PR #28676 on sipa's branch soon to make sure everything works as part of my own review. In the meantime I'll encourage everyone interested in cluster mempool to review sipa's PR.
<gribble> https://github.com/bitcoin/bitcoin/issues/28676 | [WIP] Cluster mempool implementation by sdaftuar · Pull Request #28676 · bitcoin/bitcoin · GitHub
<achow101> \o/
<achow101> so #30126 is current priority to review?
<gribble> https://github.com/bitcoin/bitcoin/issues/30126 | Low-level cluster linearization code by sipa · Pull Request #30126 · bitcoin/bitcoin · GitHub
<sdaftuar> yes!
<glozow> \o/
upekkha has quit []
<cfields> I started reviewing there. It's pretty dense 😬
<fanquake> not #29625, given that's the lowest common dep?
<gribble> https://github.com/bitcoin/bitcoin/issues/29625 | Several randomness improvements by sipa · Pull Request #29625 · bitcoin/bitcoin · GitHub
upekkha has joined #bitcoin-core-dev
<sipa> Regarding 30126, I'm aware it's heavy and non-trivial algorithmic code, and I've tried to explain a lot of what is going on in commits and comments, but I'm very happy to address comments of the form "this is not clear to me, please elaborate in comments".
<instagibbs> fanquake I was going to suggest splitting off the minimal randomness changes to its own PR if anything
<sipa> As for 29625, if it doesn't make progress quickly, I'll rebase 30126 to be independent (it can use chacha20 rng instead of xoroshiro128 for now).
<sdaftuar> fanquake: i think maybe we can get different reviewers to focus on #29625 than the people i expect will be reviewing #30126?
<gribble> https://github.com/bitcoin/bitcoin/issues/30126 | Low-level cluster linearization code by sipa · Pull Request #30126 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/29625 | Several randomness improvements by sipa · Pull Request #29625 · bitcoin/bitcoin · GitHub
<glozow> It seems like #29625 would knock off a good chunk, and already has an ack. I'm happy to start there?
<gribble> https://github.com/bitcoin/bitcoin/issues/29625 | Several randomness improvements by sipa · Pull Request #29625 · bitcoin/bitcoin · GitHub
<sdaftuar> glozow: great :)
<sipa> I'd like to see 29625 make progress, because it's independently a pretty useful improvement I think (mostly for testing/fuzzing).
<sipa> But I don't think people who care about 30126 should treat it as a dependency; I can disentangle them.
preimage has joined #bitcoin-core-dev
<glozow> Does the choice of rng change much?
<sipa> It just felt that a cryptographic RNG feels like complete overkill for tweaking a search algorithm, but it's possible that it doesn't actually measurably change performance.
<sipa> Maybe I'll benchmark that, and if it doesn't matter, disentangle them.
<instagibbs> would be appreciated
<cfields> sipa: I wonder if some of the new structures in 30126 should be split into their own PRs for the sake of more targeted review? BitSet for ex.
<sipa> cfields: happy to do that; they're nicely self-contained
<glozow> thanks sipa
<achow101> #topic legacy wallet removal updates (achow101)
<achow101> #26606 was merged, so #26596 is the next priority pr
<gribble> https://github.com/bitcoin/bitcoin/issues/26606 | wallet: Implement independent BDB parser by achow101 · Pull Request #26606 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/26596 | wallet: Migrate legacy wallets to descriptor wallets without requiring BDB by achow101 · Pull Request #26596 · bitcoin/bitcoin · GitHub
<achow101> This is more of a wallet logic PR so understanding how BDB works is not required
<achow101> #topic Ad-hoc high priority for review
<achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4
<achow101> Or any other topics to discuss?
<brunoerg> hi
<glozow> Would still like a review on #29899 😅
<gribble> https://github.com/bitcoin/bitcoin/issues/29899 | [26.x] archive 26.1 release notes + backports by glozow · Pull Request #29899 · bitcoin/bitcoin · GitHub
pablomartin has quit [Ping timeout: 260 seconds]
sohrab has quit [Ping timeout: 264 seconds]
<stickies-v> will look at that now
<_aj_> #28417 would be good to get merged
<gribble> https://github.com/bitcoin/bitcoin/issues/28417 | contrib/signet/miner updates by ajtowns · Pull Request #28417 · bitcoin/bitcoin · GitHub
<achow101> _aj_: will look
<achow101> #endmeeting
<Murch[m]> hi
<sipa> hi Murch[m]
Emc99 has quit [Quit: Client closed]
<Murch[m]> Optech Recap being on Tuesday is throwing off my sense of time :p
sohrab has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 260 seconds]
SpellChecker has joined #bitcoin-core-dev
marcofleon has quit [Quit: Connection closed]
<bitcoin-git> [bitcoin] ryanofsky pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e163d864d380...6300438a2e0b
<bitcoin-git> bitcoin/master d7707d9 Cory Fields: rpc: avoid copying into UniValue
<bitcoin-git> bitcoin/master 6300438 Ryan Ofsky: Merge bitcoin/bitcoin#30115: rpc: avoid copying into UniValue
<bitcoin-git> [bitcoin] ryanofsky merged pull request #30115: rpc: avoid copying into UniValue (master...easy-univalue-moves) https://github.com/bitcoin/bitcoin/pull/30115
Guest68 has joined #bitcoin-core-dev
Guest68 has quit [Client Quit]
Guest68 has joined #bitcoin-core-dev
Guest68 has quit [Client Quit]
pablomartin has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] sipa opened pull request #30160: util: add BitSet (master...202405_bitset) https://github.com/bitcoin/bitcoin/pull/30160
salvatoshi has quit [Ping timeout: 260 seconds]
<bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/6300438a2e0b...867f6af803dc
<bitcoin-git> bitcoin/master d578e2e glozow: [policy] explicitly require non-v3 for CPFP carve out
<bitcoin-git> bitcoin/master a29f1df glozow: [policy] restrict all v3 transactions to 10kvB
<bitcoin-git> bitcoin/master 154b2b2 glozow: [fuzz] V3_MAX_VSIZE and effective ancestor/descendant size limits
<bitcoin-git> [bitcoin] achow101 merged pull request #29873: policy: restrict all TRUC (v3) transactions to 10kvB (master...2024-04-truc-25k) https://github.com/bitcoin/bitcoin/pull/29873
Guest94 has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 260 seconds]
Guest94 has quit [Quit: Client closed]
zeropoint has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/867f6af803dc...915d7276e406
<bitcoin-git> bitcoin/master 855dd8d Matthew Zipkin: system: use %LOCALAPPDATA% as default datadir on windows
<bitcoin-git> bitcoin/master 84900ac Matthew Zipkin: doc: add release-notes-27064.md
<bitcoin-git> bitcoin/master 915d727 Ava Chow: Merge bitcoin/bitcoin#27064: system: use %LOCALAPPDATA% as default datadir...
<bitcoin-git> [bitcoin] achow101 merged pull request #27064: system: use %LOCALAPPDATA% as default datadir on windows (master...windows-local-datadir) https://github.com/bitcoin/bitcoin/pull/27064
abubakarsadiq has quit [Quit: Connection closed for inactivity]
dviola has quit [Quit: WeeChat 4.2.2]
<bitcoin-git> [bitcoin] achow101 pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/915d7276e406...413844f1c2a3
<bitcoin-git> bitcoin/master de95953 Fabian Jahr: rpc: Optimize serialization disk space of dumptxoutset
<bitcoin-git> bitcoin/master c14ed7f Fabian Jahr: assumeutxo: Add test for changed coin size value
<bitcoin-git> bitcoin/master 4d8e5ed Fabian Jahr: assumeutxo: Add documentation on dumptxoutset serialization format
<bitcoin-git> [bitcoin] achow101 merged pull request #29612: rpc: Optimize serialization and enhance metadata of dumptxoutset output (master...2024-03-pr26045-reopen) https://github.com/bitcoin/bitcoin/pull/29612
the_mariner1 has joined #bitcoin-core-dev
the_mariner has quit [Ping timeout: 260 seconds]
the_mariner has joined #bitcoin-core-dev
the_mariner1 has quit [Ping timeout: 252 seconds]
sohrab has quit [Ping timeout: 260 seconds]
kevkevin has quit [Remote host closed the connection]
edilmedeiros has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
preimage has quit [Ping timeout: 260 seconds]
<bitcoin-git> [bitcoin] sipa opened pull request #30161: util: add RingBuffer (master...202405_ringbuffer) https://github.com/bitcoin/bitcoin/pull/30161
vysn has joined #bitcoin-core-dev
cygnet3 has joined #bitcoin-core-dev
the_mariner1 has joined #bitcoin-core-dev
the_mariner has quit [Ping timeout: 256 seconds]
the_mariner1 is now known as the_mariner
preimage has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] theStack opened pull request #30162: test: MiniWallet: respect passed feerate for padded txs (using `target_weight`) (master...202405-test-MiniWallet_target_weight_improvements) https://github.com/bitcoin/bitcoin/pull/30162
sohrab has joined #bitcoin-core-dev
the_mariner1 has joined #bitcoin-core-dev
the_mariner has quit [Ping timeout: 272 seconds]
the_mariner has joined #bitcoin-core-dev
the_mariner1 has quit [Ping timeout: 252 seconds]
edilmedeiros has quit [Read error: Connection reset by peer]
bitdex has quit [Quit: = ""]
kevkevin has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
kevkevin has quit [Remote host closed the connection]
preimage has quit [Quit: WeeChat 4.2.2]
kevkevin has joined #bitcoin-core-dev
the_mariner1 has joined #bitcoin-core-dev
the_mariner has quit [Ping timeout: 260 seconds]
the_mariner1 is now known as the_mariner
<bitcoin-git> [bitcoincore.org] laanwj opened pull request #1024: Revert "Remove bitcoin.pdf" (master...2024-05-bitcoin-pdf) https://github.com/bitcoin-core/bitcoincore.org/pull/1024
kevkevin has quit [Remote host closed the connection]
Flow has quit [Quit: WeeChat 4.2.1]
Flow has joined #bitcoin-core-dev
Flow has quit [Quit: WeeChat 4.2.1]
Flow has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
Torr has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
setavenger has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 272 seconds]
edilmedeiros has joined #bitcoin-core-dev
puchka has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto opened pull request #30164: [PoC] ci: Add FreeBSD GitHub Actions job (master...240523-freebsd-ci) https://github.com/bitcoin/bitcoin/pull/30164
b_101 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoincore.org] achow101 pushed 2 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/6825a895fd94...780d6232e544
<bitcoin-git> bitcoincore.org/master 2f67650 laanwj: Revert "Remove bitcoin.pdf"
<bitcoin-git> bitcoincore.org/master 780d623 Ava Chow: Merge bitcoin-core/bitcoincore.org#1024: Revert "Remove bitcoin.pdf"
<bitcoin-git> [bitcoincore.org] achow101 merged pull request #1024: Revert "Remove bitcoin.pdf" (master...2024-05-bitcoin-pdf) https://github.com/bitcoin-core/bitcoincore.org/pull/1024
<hebasto> \o/
<_aj_> nice
mailman has joined #bitcoin-core-dev
vysn has quit [Remote host closed the connection]
puchka has quit [Ping timeout: 252 seconds]
mailman has quit [Killed (ozone (No Spam))]
puchka has joined #bitcoin-core-dev
zeropoint has quit [Quit: leaving]
kevkevin has quit [Remote host closed the connection]
mailman has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
qxs has quit [Ping timeout: 260 seconds]
kevkevin has quit [Ping timeout: 272 seconds]