#bitcoin-core-dev on 2024-05-31 — searchable irc log

2023-05-25 14:25 ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt

00:42 PaperSword has quit [Quit: PaperSword]

00:42 PaperSword has joined #bitcoin-core-dev

00:43 PaperSword has quit [Client Quit]

00:55 edilmedeiros has quit [Ping timeout: 240 seconds]

01:03 <bitcoin-git> [bitcoin] achow101 closed pull request #30188: Fix typos in 36 files | Almost only documentation (master...cyon_fix_typos) https://github.com/bitcoin/bitcoin/pull/30188

01:15 brunoerg has quit [Remote host closed the connection]

01:16 brunoerg has joined #bitcoin-core-dev

01:35 zeropoint has quit [Quit: leaving]

01:40 edilmedeiros has joined #bitcoin-core-dev

01:44 edilmedeiros has quit [Ping timeout: 260 seconds]

02:14 edilmedeiros has joined #bitcoin-core-dev

02:20 edilmedeiros has quit [Ping timeout: 264 seconds]

02:33 brunoerg has quit [Remote host closed the connection]

02:34 edilmedeiros has joined #bitcoin-core-dev

02:39 edilmedeiros has quit [Ping timeout: 268 seconds]

02:42 brunoerg has joined #bitcoin-core-dev

02:47 edilmedeiros has joined #bitcoin-core-dev

02:47 brunoerg has quit [Ping timeout: 260 seconds]

03:14 edilmedeiros has quit [Ping timeout: 272 seconds]

03:16 tecnecio has joined #bitcoin-core-dev

03:19 brunoerg has joined #bitcoin-core-dev

03:24 brunoerg has quit [Ping timeout: 256 seconds]

03:26 edilmedeiros has joined #bitcoin-core-dev

03:34 edilmedeiros has quit [Ping timeout: 268 seconds]

03:41 brunoerg has joined #bitcoin-core-dev

03:46 hernanmarino_ has quit [Read error: Connection reset by peer]

03:46 brunoerg has quit [Ping timeout: 268 seconds]

03:48 hernanmarino has joined #bitcoin-core-dev

03:48 adil has joined #bitcoin-core-dev

04:01 cmirror has quit [Remote host closed the connection]

04:01 cmirror has joined #bitcoin-core-dev

04:02 edilmedeiros has joined #bitcoin-core-dev

04:08 edilmedeiros has quit [Ping timeout: 260 seconds]

04:22 edilmedeiros has joined #bitcoin-core-dev

04:27 edilmedeiros has quit [Ping timeout: 256 seconds]

04:29 Guest45 has joined #bitcoin-core-dev

04:34 Guest45 has quit [Quit: Client closed]

04:39 edilmedeiros has joined #bitcoin-core-dev

04:46 edilmedeiros has quit [Ping timeout: 268 seconds]

04:49 edilmedeiros has joined #bitcoin-core-dev

04:53 edilmedeiros has quit [Ping timeout: 264 seconds]

05:03 brunoerg has joined #bitcoin-core-dev

05:08 brunoerg has quit [Ping timeout: 268 seconds]

05:22 edilmedeiros has joined #bitcoin-core-dev

05:28 edilmedeiros has quit [Ping timeout: 240 seconds]

05:42 edilmedeiros has joined #bitcoin-core-dev

05:46 edilmedeiros has quit [Ping timeout: 252 seconds]

06:14 edilmedeiros has joined #bitcoin-core-dev

06:19 Earnestly has quit [Ping timeout: 272 seconds]

06:20 edilmedeiros has quit [Ping timeout: 260 seconds]

06:25 brunoerg has joined #bitcoin-core-dev

06:26 Guest6 has joined #bitcoin-core-dev

06:27 Guest6 has quit [Client Quit]

06:32 adil has quit [Quit: adil]

06:34 edilmedeiros has joined #bitcoin-core-dev

06:35 brunoerg has quit [Ping timeout: 268 seconds]

06:41 edilmedeiros has quit [Ping timeout: 255 seconds]

06:42 marsupialSoup has joined #bitcoin-core-dev

06:47 marsupialSoup has quit [Ping timeout: 272 seconds]

06:55 edilmedeiros has joined #bitcoin-core-dev

07:00 pablomartin has joined #bitcoin-core-dev

07:07 Earnestly has joined #bitcoin-core-dev

07:10 edilmedeiros has quit [Ping timeout: 264 seconds]

07:18 salvatoshi has joined #bitcoin-core-dev

07:26 jon_atack has quit [Read error: Connection reset by peer]

07:26 <bitcoin-git> [bitcoin] zoupingshi opened pull request #30208: chore: fix some comments (master...master) https://github.com/bitcoin/bitcoin/pull/30208

07:27 jonatack has joined #bitcoin-core-dev

07:28 <bitcoin-git> [bitcoin] maflcko closed pull request #30208: chore: fix some comments (master...master) https://github.com/bitcoin/bitcoin/pull/30208

07:36 adil1 has joined #bitcoin-core-dev

07:38 edilmedeiros has joined #bitcoin-core-dev

07:44 edilmedeiros has quit [Ping timeout: 255 seconds]

07:45 pablomartin4btc has joined #bitcoin-core-dev

07:48 pablomartin has quit [Ping timeout: 268 seconds]

07:58 edilmedeiros has joined #bitcoin-core-dev

08:03 edilmedeiros has quit [Ping timeout: 268 seconds]

08:03 adil1 has quit [Ping timeout: 260 seconds]

08:07 Guyver2 has joined #bitcoin-core-dev

08:16 edilmedeiros has joined #bitcoin-core-dev

08:26 edilmedeiros has quit [Ping timeout: 252 seconds]

08:42 brunoerg has joined #bitcoin-core-dev

08:48 brunoerg has quit [Ping timeout: 260 seconds]

08:55 edilmedeiros has joined #bitcoin-core-dev

09:01 edilmedeiros has quit [Ping timeout: 252 seconds]

09:05 mcey has quit [Ping timeout: 264 seconds]

09:05 mcey has joined #bitcoin-core-dev

09:15 edilmedeiros has joined #bitcoin-core-dev

09:19 brunoerg has joined #bitcoin-core-dev

09:19 mcey has quit [Read error: Connection reset by peer]

09:20 edilmedeiros has quit [Ping timeout: 256 seconds]

09:20 mcey has joined #bitcoin-core-dev

09:25 brunoerg has quit [Ping timeout: 264 seconds]

09:31 executor has joined #bitcoin-core-dev

09:41 <bitcoin-git> [bitcoincore.org] fanquake opened pull request #1025: Bitcoin Core 27.1 (master...announce_27_1) https://github.com/bitcoin-core/bitcoincore.org/pull/1025

09:45 brunoerg has joined #bitcoin-core-dev

09:48 edilmedeiros has joined #bitcoin-core-dev

09:55 edilmedeiros has quit [Ping timeout: 272 seconds]

10:07 mcey_ has joined #bitcoin-core-dev

10:10 mcey has quit [Ping timeout: 264 seconds]

10:10 emcy__ has joined #bitcoin-core-dev

10:12 kevkevin has joined #bitcoin-core-dev

10:13 mcey_ has quit [Ping timeout: 260 seconds]

10:14 mcey has joined #bitcoin-core-dev

10:14 mcey has quit [Remote host closed the connection]

10:14 mcey has joined #bitcoin-core-dev

10:16 emcy__ has quit [Ping timeout: 260 seconds]

10:17 brunoerg has quit [Remote host closed the connection]

10:18 brunoerg has joined #bitcoin-core-dev

10:23 mcey has quit [Ping timeout: 260 seconds]

10:24 brunoerg_ has joined #bitcoin-core-dev

10:25 edilmedeiros has joined #bitcoin-core-dev

10:26 brunoerg has quit [Ping timeout: 260 seconds]

10:27 brunoerg_ has quit [Remote host closed the connection]

10:28 brunoerg has joined #bitcoin-core-dev

10:30 edilmedeiros has quit [Ping timeout: 256 seconds]

10:32 brunoerg has quit [Remote host closed the connection]

10:35 <fanquake> Pushed up some bins for 27.1rc1: https://bitcoincore.org/bin/bitcoin-core-27.1/test.rc1/

10:40 edilmedeiros has joined #bitcoin-core-dev

10:41 <laanwj> i'm kind of lost with all the time functions in util/time.h, do we have a steady_clock (monotonic time) function that's mockable? i need this for testing timeout functionality

10:42 brunoerg has joined #bitcoin-core-dev

10:43 <laanwj> seems `Now<SteadyMilliseconds>()` is what's used in `InterruptableRecv` in netbase, this is what i need, but it doesn't seem mockable?

10:44 edilmedeiros has quit [Ping timeout: 252 seconds]

10:46 brunoerg has quit [Ping timeout: 264 seconds]

10:50 <laanwj> how would one go about mocking a c++ chrono clock in the first place

10:54 <dergoegge> afaik we don't support steady clock mocking

10:56 <dergoegge> this would probably require a similar construct to NodeClock (which is our mockable chrono::system_clock)

10:56 Talkless has joined #bitcoin-core-dev

11:01 Guyver2 has left #bitcoin-core-dev [Closing Window]

11:02 kevkevin has quit [Remote host closed the connection]

11:02 Talkless has quit [Quit: Konversation terminated!]

11:03 <laanwj> dergoegge: thanks, will look into that!

11:05 Talkless has joined #bitcoin-core-dev

11:08 Talkless has quit [Client Quit]

11:09 <laanwj> will adopt that approach, or, i could switch to using the system clock too, but that doesn't seem right for network timeouts, it makes no sense if a ntp update causes the port mapping renew to fail

11:14 edilmedeiros has joined #bitcoin-core-dev

11:20 edilmedeiros has quit [Ping timeout: 272 seconds]

11:32 lbia has quit [Ping timeout: 255 seconds]

11:33 edilmedeiros has joined #bitcoin-core-dev

11:34 pablomartin4btc has quit [Remote host closed the connection]

11:34 kevkevin has joined #bitcoin-core-dev

11:34 pablomartin4btc has joined #bitcoin-core-dev

11:38 edilmedeiros has quit [Ping timeout: 252 seconds]

11:39 kevkevin has quit [Ping timeout: 256 seconds]

11:57 edilmedeiros has joined #bitcoin-core-dev

11:58 <dergoegge> laanwj: happy to review a mocked steady clock PR, it would be great to have

12:03 edilmedeiros has quit [Ping timeout: 255 seconds]

12:14 lbia has joined #bitcoin-core-dev

12:16 edilmedeiros has joined #bitcoin-core-dev

12:18 pyth__ has joined #bitcoin-core-dev

12:20 pyth_ has quit [Ping timeout: 260 seconds]

12:21 mcey has joined #bitcoin-core-dev

12:21 edilmedeiros has quit [Ping timeout: 272 seconds]

12:31 SpellChecker_ has quit [Remote host closed the connection]

12:32 SpellChecker has joined #bitcoin-core-dev

12:34 pablomartin4btc_ has joined #bitcoin-core-dev

12:36 pablomartin4btc has quit [Ping timeout: 240 seconds]

12:37 pablomartin4btc has joined #bitcoin-core-dev

12:40 edilmedeiros has joined #bitcoin-core-dev

12:40 pablomartin4btc_ has quit [Ping timeout: 256 seconds]

12:40 pablomartin4btc_ has joined #bitcoin-core-dev

12:43 pablomartin4btc has quit [Ping timeout: 260 seconds]

12:46 edilmedeiros has quit [Ping timeout: 268 seconds]

12:59 edilmedeiros has joined #bitcoin-core-dev

13:03 edilmedeiros has quit [Ping timeout: 240 seconds]

13:06 bentyn has joined #bitcoin-core-dev

13:08 bentyn has quit [Client Quit]

13:10 bentyn has joined #bitcoin-core-dev

13:14 bentyn has quit [Changing host]

13:14 bentyn has joined #bitcoin-core-dev

13:16 edilmedeiros has joined #bitcoin-core-dev

13:18 pablomartin4btc has joined #bitcoin-core-dev

13:19 <bentyn> Hello Everyone can someone send me some tBTC to mj7vxwtKdXmGeVMtGbnsoJHs4qfBV9mZq2

13:20 pablomartin4btc_ has quit [Ping timeout: 252 seconds]

13:21 pablomartin4btc_ has joined #bitcoin-core-dev

13:21 edilmedeiros has quit [Ping timeout: 264 seconds]

13:22 vasild has quit [Remote host closed the connection]

13:23 vasild has joined #bitcoin-core-dev

13:24 pablomartin4btc has quit [Ping timeout: 252 seconds]

13:32 pablomartin4btc has joined #bitcoin-core-dev

13:34 pablomartin4btc_ has quit [Ping timeout: 268 seconds]

13:38 <executor> bentyn: do people really send money to strangers?

13:39 <laanwj> better to use signet for testing, then you can use https://signetfaucet.com/ to request coins instead of having to ask in the dev channel

13:40 <laanwj> well there was a time when i sent people testnet coins when they asked, but can't be bothered now, sorry, testnet3 is dead anyway

13:40 _andrewtoth_ has joined #bitcoin-core-dev

13:41 edilmedeiros has joined #bitcoin-core-dev

13:44 <bentyn> thx for the advice

13:44 pablomartin4btc has quit [Read error: Connection reset by peer]

13:45 pablomartin4btc has joined #bitcoin-core-dev

13:46 mcey_ has joined #bitcoin-core-dev

13:46 abubakarsadiq has joined #bitcoin-core-dev

13:49 mcey has quit [Ping timeout: 268 seconds]

13:49 lbia has quit [Ping timeout: 255 seconds]

13:50 <bitcoin-git> [bitcoin] dergoegge opened pull request #30211: fuzz: Make FuzzedSock fuzz friendlier (master...2024-05-fix-fuzzsock) https://github.com/bitcoin/bitcoin/pull/30211

13:57 lbia has joined #bitcoin-core-dev

14:02 bugs_ has joined #bitcoin-core-dev

14:04 <bitcoin-git> [bitcoin] willcl-ark opened pull request #30212: rename TransactionErrors: MISSING_INPUTS and ALREADY_IN_CHAIN (master...clarify-missing-inputs-err) https://github.com/bitcoin/bitcoin/pull/30212

14:04 edilmedeiros has quit [Ping timeout: 268 seconds]

14:16 _andrewtoth_ has quit [Remote host closed the connection]

14:17 _andrewtoth_ has joined #bitcoin-core-dev

14:17 preimage has joined #bitcoin-core-dev

14:17 qxs has quit [Ping timeout: 260 seconds]

14:18 executor has quit [Quit: Leaving]

14:20 qxs has joined #bitcoin-core-dev

14:22 bomb-on has quit [Quit: aллилѹіа!]

14:23 bomb-on has joined #bitcoin-core-dev

14:28 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/62f7f59ff495...3ac1465cd9da

14:28 <bitcoin-git> bitcoin/master b018bd7 fanquake: depends: qt 5.15.14

14:28 <bitcoin-git> bitcoin/master 0a3631f fanquake: depends: fix Qt macOS build with Clang 18

14:28 <bitcoin-git> bitcoin/master 3ac1465 merge-script: Merge bitcoin/bitcoin#30198: depends: qt 5.15.14 and fix macOS build with ...

14:28 <bitcoin-git> [bitcoin] fanquake merged pull request #30198: depends: qt 5.15.14 and fix macOS build with Clang 18 (master...qt_5_15_14) https://github.com/bitcoin/bitcoin/pull/30198

14:30 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3ac1465cd9da...457e1846d2bf

14:30 <bitcoin-git> bitcoin/master a27e1ce fanquake: depends: consolidate dependency docs

14:30 <bitcoin-git> bitcoin/master 457e184 merge-script: Merge bitcoin/bitcoin#30204: depends: consolidate dependency docs

14:30 <bitcoin-git> [bitcoin] fanquake merged pull request #30204: depends: consolidate dependency docs (master...depends_docs) https://github.com/bitcoin/bitcoin/pull/30204

14:32 edilmedeiros has joined #bitcoin-core-dev

14:35 lbia has quit [Ping timeout: 252 seconds]

14:35 bentyn has quit [Quit: Client closed]

14:36 lbia has joined #bitcoin-core-dev

14:38 edilmedeiros has quit [Ping timeout: 264 seconds]

14:39 <bitcoin-git> [bitcoin] Sjors opened pull request #30213: net: have GetReceivedMessage() return bytes (master...2024/05/transport-sans-netmsg) https://github.com/bitcoin/bitcoin/pull/30213

14:45 kevkevin has joined #bitcoin-core-dev

14:46 gnaf has joined #bitcoin-core-dev

14:47 Talkless has joined #bitcoin-core-dev

14:50 kevkevin has quit [Ping timeout: 260 seconds]

14:53 <bitcoin-git> [bitcoin] ryanofsky opened pull request #30214: refactor: Improve assumeutxo state representation (master...pr/cstate) https://github.com/bitcoin/bitcoin/pull/30214

14:53 Talkless has quit [Quit: Konversation terminated!]

14:57 kevkevin has joined #bitcoin-core-dev

15:06 edilmedeiros has joined #bitcoin-core-dev

15:12 edilmedeiros has quit [Ping timeout: 272 seconds]

15:18 pablomartin4btc has quit [Ping timeout: 255 seconds]

15:25 edilmedeiros has joined #bitcoin-core-dev

15:30 edilmedeiros has quit [Ping timeout: 264 seconds]

15:32 <bitcoin-git> [bitcoin] fanquake closed pull request #29971: refactor: refactored platform assignment into get_platform function (master...fix/platform-consistency) https://github.com/bitcoin/bitcoin/pull/29971

15:43 Chris_Stewart_5 has joined #bitcoin-core-dev

15:43 twistedline has quit [Remote host closed the connection]

15:44 edilmedeiros has joined #bitcoin-core-dev

15:45 twistedline has joined #bitcoin-core-dev

15:47 zeropoint has joined #bitcoin-core-dev

15:48 edilmedeiros has quit [Ping timeout: 268 seconds]

15:52 <bitcoin-git> [bitcoin] fanquake opened pull request #30215: doc: JSON-RPC request Content-Type is application/json (master...29946_fixedup) https://github.com/bitcoin/bitcoin/pull/30215

15:52 <bitcoin-git> [bitcoin] fanquake closed pull request #29946: JSON-RPC request Content-Type is application/json (master...jsonrpc_content_type) https://github.com/bitcoin/bitcoin/pull/29946

15:55 edilmedeiros has joined #bitcoin-core-dev

15:56 abubakarsadiq has quit [Quit: Connection closed for inactivity]

16:01 edilmedeiros has quit [Ping timeout: 264 seconds]

16:02 salvatoshi has quit [Ping timeout: 256 seconds]

16:14 edilmedeiros has joined #bitcoin-core-dev

16:20 edilmedeiros has quit [Ping timeout: 255 seconds]

16:42 tecnecio has quit [Read error: Connection reset by peer]

16:44 <gnaf> linkrot signet/faucet bip 325 https://github.com/bitcoin/bitcoin/pull/18267 or use a faucet sidechain for testing https://liquidtestnet.com/faucet

16:48 edilmedeiros has joined #bitcoin-core-dev

16:54 edilmedeiros has quit [Ping timeout: 256 seconds]

16:56 edilmedeiros has joined #bitcoin-core-dev

16:57 <gnaf> signetfaucet with cloudflare error, and when signetfaucet works without receiving testnet coins

17:01 edilmedeiros has quit [Ping timeout: 260 seconds]

17:08 brunoerg has joined #bitcoin-core-dev

17:12 brunoerg has quit [Ping timeout: 255 seconds]

17:12 brunoerg has joined #bitcoin-core-dev

17:14 edilmedeiros has joined #bitcoin-core-dev

17:19 edilmedeiros has quit [Ping timeout: 255 seconds]

17:21 <gnaf> without the captcha stuff https://signetfaucet.bublina.eu.org/

17:23 brunoerg has quit [Ping timeout: 255 seconds]

17:32 edilmedeiros has joined #bitcoin-core-dev

17:35 _andrewtoth_ has quit [Ping timeout: 260 seconds]

17:37 edilmedeiros has quit [Ping timeout: 252 seconds]

17:39 _andrewtoth_ has joined #bitcoin-core-dev

17:46 edilmedeiros has joined #bitcoin-core-dev

17:55 brunoerg has joined #bitcoin-core-dev

18:01 brunoerg has quit [Ping timeout: 272 seconds]

18:10 gnaf has quit [Quit: Konversation terminated!]

18:16 brunoerg has joined #bitcoin-core-dev

18:52 <bitcoin-git> [bitcoin] Sjors closed pull request #30213: net: have GetReceivedMessage() return bytes (master...2024/05/transport-sans-netmsg) https://github.com/bitcoin/bitcoin/pull/30213

19:11 puchka has quit [Ping timeout: 268 seconds]

19:12 puchka has joined #bitcoin-core-dev

19:17 f has joined #bitcoin-core-dev

19:17 f has quit [Remote host closed the connection]

19:18 f has joined #bitcoin-core-dev

19:23 f has quit [K-Lined]

19:27 gnaf has joined #bitcoin-core-dev

19:33 gnaf has quit [Quit: Konversation terminated!]

19:41 kevkevin has quit [Remote host closed the connection]

19:47 kevkevin has joined #bitcoin-core-dev

19:50 lbia has quit [Ping timeout: 264 seconds]

19:51 Torr has joined #bitcoin-core-dev

19:52 kevkevin has quit [Ping timeout: 240 seconds]

19:53 lbia has joined #bitcoin-core-dev

20:09 edilmedeiros has quit [Ping timeout: 252 seconds]

20:18 sohrab has quit [Quit: WeeChat 3.8]

20:24 kevkevin has joined #bitcoin-core-dev

20:26 _andrewtoth_ has quit [Ping timeout: 260 seconds]

20:38 edilmedeiros has joined #bitcoin-core-dev

20:41 jon_atack has joined #bitcoin-core-dev

20:43 jonatack has quit [Ping timeout: 256 seconds]

20:45 edilmedeiros has quit [Ping timeout: 268 seconds]

20:47 kevkevin has quit [Remote host closed the connection]

20:47 kevkevin has joined #bitcoin-core-dev

20:57 edilmedeiros has joined #bitcoin-core-dev

21:03 Talkless has joined #bitcoin-core-dev

21:03 edilmedeiros has quit [Ping timeout: 252 seconds]

21:16 edilmedeiros has joined #bitcoin-core-dev

21:21 edilmedeiros has quit [Ping timeout: 268 seconds]

21:28 preimage has quit [Quit: WeeChat 4.2.2]

21:34 edilmedeiros has joined #bitcoin-core-dev

21:38 edilmedeiros has quit [Ping timeout: 264 seconds]

21:48 bugs_ has quit [Quit: Leaving]

21:51 Talkless has quit [Quit: Konversation terminated!]

21:59 edilmedeiros has joined #bitcoin-core-dev

22:05 edilmedeiros has quit [Ping timeout: 252 seconds]

22:05 PaperSword has joined #bitcoin-core-dev

22:19 kevkevin has quit [Remote host closed the connection]

22:33 edilmedeiros has joined #bitcoin-core-dev

22:38 edilmedeiros has quit [Ping timeout: 268 seconds]

22:38 kevkevin has joined #bitcoin-core-dev

22:50 edilmedeiros has joined #bitcoin-core-dev

22:56 edilmedeiros has quit [Ping timeout: 268 seconds]

23:02 edilmedeiros has joined #bitcoin-core-dev

23:07 edilmedeiros has quit [Ping timeout: 268 seconds]

23:17 PaperSword has quit [Remote host closed the connection]

23:18 PaperSword has joined #bitcoin-core-dev

23:20 edilmedeiros has joined #bitcoin-core-dev

23:24 edilmedeiros has quit [Ping timeout: 268 seconds]

23:35 hernanmarino has quit [Quit: ZNC 1.8.2+deb2 - https://znc.in]

23:35 hernanmarino has joined #bitcoin-core-dev

23:53 edilmedeiros has joined #bitcoin-core-dev