hel has quit [Read error: Connection reset by peer]
hel has joined #bitcoin-core-dev
SatoshiCl has joined #bitcoin-core-dev
SatoshiCl has quit [Ping timeout: 250 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
tarotfied has quit [Read error: Connection reset by peer]
mailman has joined #bitcoin-core-dev
mailman has quit [Client Quit]
saffi has joined #bitcoin-core-dev
dviola has joined #bitcoin-core-dev
saffi has quit [Quit: Connection closed]
mailman has joined #bitcoin-core-dev
mailman has quit [Quit: Client closed]
salvatoshi has joined #bitcoin-core-dev
lbia has quit [Ping timeout: 260 seconds]
lbia has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
lbia has quit [Ping timeout: 240 seconds]
PaperSword has quit [Ping timeout: 264 seconds]
lbia has joined #bitcoin-core-dev
dermoth has quit [Ping timeout: 260 seconds]
dermoth has joined #bitcoin-core-dev
Zenton has quit [Remote host closed the connection]
nicky has quit [Ping timeout: 250 seconds]
bitdex has quit [Quit: = ""]
<laanwj>
<saffi> "I was going through this PR..." <- i don't know, tbh i don't see much difference in readability
pablomartin has joined #bitcoin-core-dev
<laanwj>
everyone who's able to meaningfully contribute to the test cases won't have difficulty reading != as "not equal" but maybe i'm missing something
<laanwj>
for non-native English speakers, the symbol may be quicker to parse than the word
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Guyver2 has left #bitcoin-core-dev [Closing Window]
cygnet3 has joined #bitcoin-core-dev
Guest2 has joined #bitcoin-core-dev
Guest2 has quit [Client Quit]
<dodo>
is that pytest?
<dodo>
fwiw, in unittest there is assertEqual and assertNotEqual, maybe that motivated it to follow python idioms
<dodo>
dunno about pytest, but i find it surprising that such helper functions even have to exist..
<dodo>
though unittest syntax is derived from java afaik.oO
<dodo>
oh ok.. some homegrown test system..
bugs_ has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
sohrab has quit [Ping timeout: 260 seconds]
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
brunoerg has joined #bitcoin-core-dev
brunoerg_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
puchka has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg_ has quit [Ping timeout: 264 seconds]
Guest45 has joined #bitcoin-core-dev
Guest45 has quit [Client Quit]
puchka has joined #bitcoin-core-dev
sohrab has joined #bitcoin-core-dev
preimage has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
jonatack has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
salvatoshi has quit [Ping timeout: 240 seconds]
the_mariner has joined #bitcoin-core-dev
the_mariner has quit [Ping timeout: 255 seconds]
bugs_ has quit [Quit: Leaving]
brunoerg has quit [Remote host closed the connection]
the_mariner has joined #bitcoin-core-dev
zeropoint has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
Torr has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
twistedline_ has quit []
ghost43 has quit [Remote host closed the connection]
vasild has quit [Remote host closed the connection]
qxs has quit [Remote host closed the connection]
twistedline has joined #bitcoin-core-dev
qxs has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
ghost43 has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 240 seconds]
pablomartin has quit [Ping timeout: 240 seconds]
ryanofsky_ has left #bitcoin-core-dev [#bitcoin-core-dev]
ryanofsky has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
mcey has quit [Ping timeout: 260 seconds]
mcey has joined #bitcoin-core-dev
puchka has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
VonNaturAustreVe has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
jonatack has quit [Ping timeout: 264 seconds]
saffi has joined #bitcoin-core-dev
preimage has quit [Quit: WeeChat 4.2.2]
<saffi>
laanwj but assertion gives better error messages
<saffi>
and if the above pr gets approved for the consistency of code it would be better to use assertions for other symbols as well
<saffi>
this thing provide better diagnostics when tests fail. This small change can significantly enhance the clarity and robustness of your test suite.
saffi has quit [Quit: Connection closed]
<laanwj>
if you're looking to contribute to the tests, i think something like fixing one of the flakey CI tests, or improving test coverage, would be much more welcome than these kind of search/replace jobs
saffi has joined #bitcoin-core-dev
<saffi>
but feels like you are right its better for non english people and in many other ways
<saffi>
sure I would take a look into those thank you for pointing in the direction and the guidance laanwj