ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
puchka has quit [Ping timeout: 240 seconds]
puchka has joined #bitcoin-core-dev
zeropoint has quit [Quit: leaving]
jon_atack has quit [Ping timeout: 255 seconds]
puchka has quit [Ping timeout: 264 seconds]
puchka has joined #bitcoin-core-dev
TheRec has joined #bitcoin-core-dev
TheRec has quit [Changing host]
TheRec has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
marsupialSoup has joined #bitcoin-core-dev
marsupialSoup has quit [Ping timeout: 264 seconds]
Torr has quit [Quit: Torr]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
conman has quit [Quit: Konversation terminated!]
bitdex has joined #bitcoin-core-dev
BrandonOdiwuor has quit [Ping timeout: 250 seconds]
willcl-ark has quit [Ping timeout: 255 seconds]
conman has joined #bitcoin-core-dev
willcl-ark has joined #bitcoin-core-dev
willcl-ark has quit [Changing host]
willcl-ark has joined #bitcoin-core-dev
michaelfolkson2 has quit [*.net *.split]
andytoshi has quit [*.net *.split]
Anth0mk- has quit [*.net *.split]
FelixWeis__ has quit [*.net *.split]
jonasschnelli has quit [*.net *.split]
TheCharlatan has quit [*.net *.split]
katsu has quit [*.net *.split]
andytoshi has joined #bitcoin-core-dev
FelixWeis__ has joined #bitcoin-core-dev
michaelfolkson has joined #bitcoin-core-dev
Anth0mk has joined #bitcoin-core-dev
TheCharlatan has joined #bitcoin-core-dev
katsu_ has joined #bitcoin-core-dev
jonasschnelli has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 260 seconds]
SpellChecker_ has joined #bitcoin-core-dev
Guest20 has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 260 seconds]
SpellChecker has quit [Ping timeout: 260 seconds]
Guest20 has quit [Client Quit]
bitdex has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 272 seconds]
jonatack has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fjahr opened pull request #30267: assumeutxo: Check snapshot base block is not in invalid chain (master...2024-06-invalid-snapshot-block) https://github.com/bitcoin/bitcoin/pull/30267
JTL has quit [Ping timeout: 268 seconds]
BrandonOdiwuor has joined #bitcoin-core-dev
katsu_ is now known as katsu
JTL has joined #bitcoin-core-dev
dermoth_ has joined #bitcoin-core-dev
dermoth has quit [Remote host closed the connection]
bitdex has quit [Ping timeout: 260 seconds]
bitdex has joined #bitcoin-core-dev
dermoth_ is now known as dermoth
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 268 seconds]
<darosior> Does anyone planned on commenting on the disclosure policy but haven't yet? https://gist.github.com/darosior/eb71638f20968f0dc896c4261a127be6
<willcl-ark> The policy looks good to me, thanks darosior! No comments on the policy itself, but regarding the discussion about EOL not being that clear to users; have we discussed before including EOL dates in debug.log, or in the case of the GUI perhaps even a popup/alert type thing? Obviously we will never push auto-updates, but alerting users that a release-process-released version is/is
<willcl-ark> approaching EOL could be helpful at drawing more attention to it and prompting users who otherwise might forget, to upgrade.
mcey has joined #bitcoin-core-dev
emcy__ has quit [Ping timeout: 268 seconds]
<sipa> willcl-ark: i think that would be confusing; it is not individial releases that go EOL, it's branches (24.x, 25.x, ...), see also https://github.com/bitcoin-core/bitcoincore.org/pull/1026
<sipa> because at any point a critical vulnerability in 27.0 e.g. could be discovered, leading to the release of 27.1; that does not mean anything became EOL, but you may still need to upgrade
<bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b1ba1b178f50...ba5dd9629855
<bitcoin-git> bitcoin/master d1581c6 Sebastian Falbesoner: test: doc: fix units in tx size standardness test (s/vbytes/weight units)
<bitcoin-git> bitcoin/master ba5dd96 glozow: Merge bitcoin/bitcoin#30254: test: doc: fix units in tx-size standardness ...
<bitcoin-git> [bitcoin] glozow merged pull request #30254: test: doc: fix units in tx-size standardness test (s/vbytes/weight units) (master...202406-test-doc-fix_tx-size_units) https://github.com/bitcoin/bitcoin/pull/30254
BrandonOdiwuor has quit [Ping timeout: 250 seconds]
Guest92 has joined #bitcoin-core-dev
Guest92 has quit [Client Quit]
jon_atack has quit [Ping timeout: 256 seconds]
jonatack has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
jonatack has quit [Ping timeout: 268 seconds]
SpellChecker_ has quit [Ping timeout: 260 seconds]
puchka has quit [Ping timeout: 255 seconds]
SpellChecker has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] glozow pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/ba5dd9629855...e6e4c18a9be2
<bitcoin-git> bitcoin/master c17550b Sebastian Falbesoner: test: MiniWallet: fix tx padding (`target_weight`) for large sizes, improv...
<bitcoin-git> bitcoin/master b2f0a9f Sebastian Falbesoner: test: add framework functional test for MiniWallet's tx padding
<bitcoin-git> bitcoin/master 39d135e Sebastian Falbesoner: test: MiniWallet: respect fee_rate for target_weight, use in mempool_limit...
<bitcoin-git> [bitcoin] glozow merged pull request #30162: test: MiniWallet: respect passed feerate for padded txs (using `target_weight`) (master...202405-test-MiniWallet_target_weight_improvements) https://github.com/bitcoin/bitcoin/pull/30162
bitdex has quit [Quit: = ""]
pyth_ has joined #bitcoin-core-dev
pyth has quit [Ping timeout: 246 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e6e4c18a9be2...0fbb8043ce0d
<bitcoin-git> bitcoin/master 0000276 MarcoFalke: test: Remove redundant verack check
<bitcoin-git> bitcoin/master 0fbb804 merge-script: Merge bitcoin/bitcoin#30252: test: Remove redundant verack check
<bitcoin-git> [bitcoin] fanquake merged pull request #30252: test: Remove redundant verack check (master...2406-test-connect-sync) https://github.com/bitcoin/bitcoin/pull/30252
<willcl-ark> sipa: I understand that, and I'm certainly not suggesting any alert-style "Your software is EOL" or "critical bug, upgrade now!" messaging system :) Nor that this could replace alerting users via conventional channels that they should upgrade due to a critial bug (or similar)
<willcl-ark> Rather, if we know from the release date of v25(.0) in May 2023 that this branch (and all 25.x releases) will reach maintenance end in 12 months, and EOL say 12 months after that, i.e. May 2025, then this date _could_ be hardcoded into the 25.x releases and display a reminder to the user that their software is reaching/has reached EOL.
<bitcoin-git> [bitcoin] fanquake pushed 6 commits to 27.x: https://github.com/bitcoin/bitcoin/compare/fccd32efe6e2...1088a98f5aad
<bitcoin-git> bitcoin/27.x ba35920 Hennadii Stepanov: build: Fix building `fuzz` binary on on SunOS / illumos
<bitcoin-git> bitcoin/27.x f2e05cd Hennadii Stepanov: depends: Update Boost download link
<bitcoin-git> bitcoin/27.x fcf1241 fanquake: doc: update release notes for v27.1 final
<bitcoin-git> [bitcoin] fanquake merged pull request #30222: [27.1] Finalize (27.x...27_1_rc2_or_rel) https://github.com/bitcoin/bitcoin/pull/30222
<bitcoin-git> [bitcoin] fanquake pushed tag v27.1: https://github.com/bitcoin/bitcoin/compare/v27.1
lbia has quit [Ping timeout: 255 seconds]
<_aj_> willcl-ark: ie, at branch-off 25.x gets a generic 'EOL_ESTIMATE' set for +20 months away, at which point a warning is added "software is likely no longer supported, consider upgrading to new major version" ? without any corresponding "hey your software is definitely still fine" assertion prior to that...
<_aj_> willcl-ark: feel a bit like it misses the point that if you're not updating from 25.0 to 25.1 you're not getting any benefit from 25.x not being EOL though
Zenton has quit [Remote host closed the connection]
<bitcoin-git> [leveldb-subtree] theuni opened pull request #41: Ignore clang's self-assignment check (bitcoin-fork...ignore-self-assign) https://github.com/bitcoin-core/leveldb-subtree/pull/41
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0fbb8043ce0d...5bc9b644a4b6
<bitcoin-git> bitcoin/master ab98e6f brunoerg: test: add coverage for errors for `combinerawtransaction` RPC
<bitcoin-git> bitcoin/master 5bc9b64 merge-script: Merge bitcoin/bitcoin#30264: test: add coverage for errors for `combineraw...
<bitcoin-git> [bitcoin] fanquake merged pull request #30264: test: add coverage for errors for `combinerawtransaction` (master...2024-06-test-combinerawtransaction) https://github.com/bitcoin/bitcoin/pull/30264
lbia has joined #bitcoin-core-dev
marsupialSoup has joined #bitcoin-core-dev
lbia has quit [Ping timeout: 256 seconds]
lbia has joined #bitcoin-core-dev
lbia has quit [Max SendQ exceeded]
lbia has joined #bitcoin-core-dev
preimage has joined #bitcoin-core-dev
lbia has quit [Max SendQ exceeded]
lbia has joined #bitcoin-core-dev
lbia has quit [Max SendQ exceeded]
jespada_ has joined #bitcoin-core-dev
jespada has quit [Ping timeout: 240 seconds]
zeropoint has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 255 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/5bc9b644a4b6...337f9d44c28b
<bitcoin-git> bitcoin/master 9946618 fanquake: guix: use clang-toolchain-18 for macOS build
<bitcoin-git> bitcoin/master e9a44fa fanquake: depends: remove FORCE_USE_SYSTEM_CLANG
<bitcoin-git> bitcoin/master f9994b0 fanquake: depends: remove native LLVM package
<bitcoin-git> [bitcoin] fanquake merged pull request #30201: depends: remove `FORCE_USE_SYSTEM_CLANG` (master...remove_force_use_system_clang) https://github.com/bitcoin/bitcoin/pull/30201
brunoerg has quit [Ping timeout: 256 seconds]
rolf has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
rolf has quit [Client Quit]
mudsip has quit [Client Quit]
BrandonOdiwuor has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
SpellChecker has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] theuni opened pull request #30268: utils: add missing VecDeque include (master...vecdeque-missing-include) https://github.com/bitcoin/bitcoin/pull/30268
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
lbia has joined #bitcoin-core-dev
<achow101> willcl-ark: I think it would be a bit confusing to do that
<achow101> We definitely should add standard text to the release notes that says what version is going EOL with that release being made
<achow101> I think that actually would be enough for preannouncement - the standard text could say, e.g. "As of this release, X.y is now EOL. Any medium and high severity vulnerabilities will be disclosed in 2 weeks"
Robotico has joined #bitcoin-core-dev
Robotico has quit [Remote host closed the connection]
preimage is now known as lattice
jonatack has joined #bitcoin-core-dev
marsupialSoup has quit [Ping timeout: 260 seconds]
Talkless has joined #bitcoin-core-dev
marsupialSoup has joined #bitcoin-core-dev
marsupialSoup has quit [Ping timeout: 260 seconds]
<Murch[m]> darosior: The disclosure policy looks reasonable to me, looking forward to reading the disclosures. Thanks for working on that
marsupialSoup has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 255 seconds]
jonatack has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 264 seconds]
jonatack has joined #bitcoin-core-dev
marsupialSoup has quit [Ping timeout: 255 seconds]
marsupialSoup has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
puchka has joined #bitcoin-core-dev
Talkless has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/337f9d44c28b...2251460f3efc
<bitcoin-git> bitcoin/master 09ef322 TheCharlatan: [[refactor]] Check CTxMemPool options in constructor
<bitcoin-git> bitcoin/master 2251460 Ava Chow: Merge bitcoin/bitcoin#28830: [refactor] Check CTxMemPool options in ctor
<bitcoin-git> [bitcoin] achow101 merged pull request #28830: [refactor] Check CTxMemPool options in ctor (master...mempoolArgs) https://github.com/bitcoin/bitcoin/pull/28830
puchka has quit [Quit: leaving]
BrandonOdiwuor has quit [Quit: Client closed]
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/2251460f3efc...1bcc91a52c61
<bitcoin-git> bitcoin/master e208fb5 tdb3: cli: Sanitize ports in rpcconnect and rpcport
<bitcoin-git> bitcoin/master 24bc46c tdb3: cli: Add warning for duplicate port definition
<bitcoin-git> bitcoin/master 1bcc91a Ava Chow: Merge bitcoin/bitcoin#29521: cli: Detect port errors in rpcconnect and rpc...
<bitcoin-git> [bitcoin] achow101 merged pull request #29521: cli: Detect port errors in rpcconnect and rpcport (master...20240229_rpcconnectinvalidportdetection) https://github.com/bitcoin/bitcoin/pull/29521
___nick___ has quit [Ping timeout: 256 seconds]
marsupialSoup has quit [Ping timeout: 240 seconds]
marsupialSoup has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/1bcc91a52c61...891e4bf37407
<bitcoin-git> bitcoin/master 32c8041 Martin Zumsande: bench: add benchmark for checkblockindex
<bitcoin-git> bitcoin/master d5a631b Martin Zumsande: validation: improve performance of CheckBlockIndex
<bitcoin-git> bitcoin/master 5bc2077 Martin Zumsande: validation: allow to specify frequency for -checkblockindex
<bitcoin-git> [bitcoin] achow101 merged pull request #28339: validation: improve performance of CheckBlockIndex (master...202308_speedup_checkblockindex) https://github.com/bitcoin/bitcoin/pull/28339
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/891e4bf37407...91e0beede285
<bitcoin-git> bitcoin/master 59a6df6 Pieter Wuille: util: add BitSet
<bitcoin-git> bitcoin/master 47f705b Pieter Wuille: tests: add fuzz tests for BitSet
<bitcoin-git> bitcoin/master 91e0bee Ava Chow: Merge bitcoin/bitcoin#30160: util: add BitSet
<bitcoin-git> [bitcoin] achow101 merged pull request #30160: util: add BitSet (master...202405_bitset) https://github.com/bitcoin/bitcoin/pull/30160
lattice has quit [Quit: WeeChat 4.2.2]
bugs_ has quit [Quit: Leaving]
jonatack has quit [Ping timeout: 264 seconds]
marsupialSoup has quit [Ping timeout: 268 seconds]
mcey_ has joined #bitcoin-core-dev
emcy__ has joined #bitcoin-core-dev
mcey has quit [Ping timeout: 260 seconds]
mcey_ has quit [Ping timeout: 240 seconds]