ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
test_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 268 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
kevkevin has joined #bitcoin-core-dev
zeropoint has quit [Quit: leaving]
<cfields> @sipa how attatched are you to the logging in random.cpp ?
<cfields> for context: I'm working on an instantiated logger for the kernel, which so far has actually proven to be not so painful.
<cfields> but random is pretty low-level and annoying.
<cfields> specifically the "Feeding %i bytes of environment data into RNG" messages that stem from ProcRand
<cfields> (I'm looking at current master, but I don't believe your refactor changes much wrt logging)
<cfields> @sipa: the other problematic one is RandFailure(), which is reachable (in the old code) only by GetStrongRandBytes. That in turn is only called in 3 places (key.cpp and wallet). Would you be ok with returning [[nodiscard]] false to the callers there instead?
<cfields> (imo that's nicer than an abort() in random code), but arguably it's enabling a footgun
freesprung51269 has quit [Ping timeout: 252 seconds]
freesprung51269 has joined #bitcoin-core-dev
adil has joined #bitcoin-core-dev
adil has quit [Client Quit]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
kevkevin has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
kevkevin has quit [Ping timeout: 256 seconds]
cmirror has joined #bitcoin-core-dev
conman has quit [Ping timeout: 255 seconds]
cman has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
jon_atack has joined #bitcoin-core-dev
mcey_ has quit [Read error: Connection reset by peer]
jonatack has quit [Ping timeout: 264 seconds]
mcey has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
freesprung51269 has quit [Ping timeout: 255 seconds]
kevkevin has quit [Ping timeout: 268 seconds]