kevkevin has quit [Remote host closed the connection]
test_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 268 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
kevkevin has joined #bitcoin-core-dev
zeropoint has quit [Quit: leaving]
<cfields>
@sipa how attatched are you to the logging in random.cpp ?
<cfields>
for context: I'm working on an instantiated logger for the kernel, which so far has actually proven to be not so painful.
<cfields>
but random is pretty low-level and annoying.
<cfields>
specifically the "Feeding %i bytes of environment data into RNG" messages that stem from ProcRand
<cfields>
(I'm looking at current master, but I don't believe your refactor changes much wrt logging)
<cfields>
@sipa: the other problematic one is RandFailure(), which is reachable (in the old code) only by GetStrongRandBytes. That in turn is only called in 3 places (key.cpp and wallet). Would you be ok with returning [[nodiscard]] false to the callers there instead?
<cfields>
(imo that's nicer than an abort() in random code), but arguably it's enabling a footgun
freesprung51269 has quit [Ping timeout: 252 seconds]
freesprung51269 has joined #bitcoin-core-dev
adil has joined #bitcoin-core-dev
adil has quit [Client Quit]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
kevkevin has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
kevkevin has quit [Ping timeout: 256 seconds]
cmirror has joined #bitcoin-core-dev
conman has quit [Ping timeout: 255 seconds]
cman has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
jon_atack has joined #bitcoin-core-dev
mcey_ has quit [Read error: Connection reset by peer]
jonatack has quit [Ping timeout: 264 seconds]
mcey has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
freesprung51269 has quit [Ping timeout: 255 seconds]
real_or_random has quit [Ping timeout: 246 seconds]
moneyball_____ has quit [Ping timeout: 255 seconds]
fanquake has quit [Ping timeout: 255 seconds]
Novo__ has quit [Ping timeout: 255 seconds]
setavenger has quit [Ping timeout: 255 seconds]
stickies-v has quit [Ping timeout: 256 seconds]
zone117x has quit [Ping timeout: 256 seconds]
maxedw has quit [Ping timeout: 256 seconds]
kevkevin has joined #bitcoin-core-dev
jesseposner has quit [Ping timeout: 246 seconds]
elichai2 has quit [Ping timeout: 264 seconds]
RubenSomsen has quit [Ping timeout: 264 seconds]
jarolrod___ has quit [Ping timeout: 256 seconds]
schmidty has quit [Ping timeout: 256 seconds]
lightlike has quit [Ping timeout: 272 seconds]
FelixWeis__ has quit [Ping timeout: 256 seconds]
amiti___ has quit [Ping timeout: 256 seconds]
valwal__ has quit [Ping timeout: 256 seconds]
eragmus_ has quit [Ping timeout: 256 seconds]
jqq_ has quit [Ping timeout: 268 seconds]
bw_______ has quit [Ping timeout: 255 seconds]
larryruane_ has quit [Ping timeout: 255 seconds]
gleb has quit [Ping timeout: 255 seconds]
hugohn____ has quit [Ping timeout: 264 seconds]
arik__ has quit [Ping timeout: 256 seconds]
fjahr has quit [Ping timeout: 256 seconds]
hebasto has quit [Ping timeout: 256 seconds]
ajonas has quit [Ping timeout: 272 seconds]
LarryRuane has quit [Ping timeout: 272 seconds]
strat_ has quit [Ping timeout: 256 seconds]
sugarpuff has quit [Ping timeout: 268 seconds]
runnerelektrode_ has quit [Ping timeout: 268 seconds]
chris132 has quit [Ping timeout: 268 seconds]
<bitcoin-git>
[bitcoin] hebasto opened pull request #30333: Update libsecp256k1 subtree to current master (master...240625-secp-update) https://github.com/bitcoin/bitcoin/pull/30333
<bitcoin-git>
[bitcoin] fanquake opened pull request #30334: Update libsecp256k1 subtree to latest master (master...update_secp256k1_subtree) https://github.com/bitcoin/bitcoin/pull/30334
kevkevin has quit [Ping timeout: 260 seconds]
bomb-on has quit [Read error: Connection reset by peer]
bomb-on has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto closed pull request #30333: Update libsecp256k1 subtree to current master (master...240625-secp-update) https://github.com/bitcoin/bitcoin/pull/30333
moneyball_____ has joined #bitcoin-core-dev
jesseposner has joined #bitcoin-core-dev
kouloumos has joined #bitcoin-core-dev
schmidty has joined #bitcoin-core-dev
real_or_random has joined #bitcoin-core-dev
elichai2 has joined #bitcoin-core-dev
sugarpuff has joined #bitcoin-core-dev
stickies-v has joined #bitcoin-core-dev
zone117x has joined #bitcoin-core-dev
eragmus_ has joined #bitcoin-core-dev
jkczyz has joined #bitcoin-core-dev
chris132 has joined #bitcoin-core-dev
runnerelektrode_ has joined #bitcoin-core-dev
hugohn____ has joined #bitcoin-core-dev
fanquake has joined #bitcoin-core-dev
LarryRuane has joined #bitcoin-core-dev
maxedw has joined #bitcoin-core-dev
arik__ has joined #bitcoin-core-dev
glozow has joined #bitcoin-core-dev
jarolrod___ has joined #bitcoin-core-dev
strat_ has joined #bitcoin-core-dev
lightlike has joined #bitcoin-core-dev
gleb has joined #bitcoin-core-dev
amiti___ has joined #bitcoin-core-dev
valwal__ has joined #bitcoin-core-dev
hebasto has joined #bitcoin-core-dev
fjahr has joined #bitcoin-core-dev
dergoegge has joined #bitcoin-core-dev
RubenSomsen has joined #bitcoin-core-dev
rodarmor has joined #bitcoin-core-dev
jqq_ has joined #bitcoin-core-dev
FelixWeis__ has joined #bitcoin-core-dev
larryruane_ has joined #bitcoin-core-dev
Novo__ has joined #bitcoin-core-dev
kermit4 has joined #bitcoin-core-dev
setavenger has joined #bitcoin-core-dev
bw_______ has joined #bitcoin-core-dev
ajonas has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 246 seconds]
<bitcoin-git>
[bitcoin] brunoerg opened pull request #30339: test: add coverage for `node` field of `getaddednodeinfo` RPC (master...2024-06-test-getaddednodeinfo-peer-) https://github.com/bitcoin/bitcoin/pull/30339
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 256 seconds]
Talkless has quit [Remote host closed the connection]
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 256 seconds]
kevkevin has quit [Remote host closed the connection]
_andrewtoth_ has quit [Ping timeout: 260 seconds]
abubakarsadiq has quit [Quit: Connection closed for inactivity]