achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
jespada_ has quit [Ping timeout: 245 seconds]
zeropoint has quit [Quit: leaving]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 276 seconds]
jonatack has quit [Read error: Connection reset by peer]
robszarka has quit [Quit: Leaving]
szarka has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
pyth has joined #bitcoin-core-dev
pyth has quit [Remote host closed the connection]
jonatack has quit [Read error: Connection reset by peer]
saikasyap has joined #bitcoin-core-dev
saikasyap has quit [Quit: Client closed]
ThePlebRoad has joined #bitcoin-core-dev
ThePlebRoad has joined #bitcoin-core-dev
ThePlebRoad is now known as entropyx
entropyx is now known as ThePlebRoad
saikasyap has joined #bitcoin-core-dev
ThePlebRoad is now known as entropyx
entropyx has quit [Changing host]
entropyx has joined #bitcoin-core-dev
entropyx has quit [Ping timeout: 248 seconds]
saikasyap has quit [Quit: Client closed]
saikasyap has joined #bitcoin-core-dev
Guest71 has joined #bitcoin-core-dev
Guest26 has joined #bitcoin-core-dev
saikasyap has quit [Quit: Client closed]
Guest26 has quit [Quit: Client closed]
Guest71 has quit [Quit: Client closed]
kevkevin has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 272 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
entropyx has joined #bitcoin-core-dev
entropyx has quit [Changing host]
entropyx has joined #bitcoin-core-dev
Cory37 has quit [Quit: Client closed]
Cory37 has joined #bitcoin-core-dev
TallTim_ has joined #bitcoin-core-dev
andytoshi has quit [Ping timeout: 252 seconds]
tarotfied has quit [Ping timeout: 272 seconds]
TallTim has quit [Ping timeout: 276 seconds]
andytoshi has joined #bitcoin-core-dev
tarotfied has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
andytoshi has quit [Ping timeout: 252 seconds]
andytoshi has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
saikasyap has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] jb55 opened pull request #32454: tracing: fix invalid argument in mempool_monitor (master...fix-mempool-monitor) https://github.com/bitcoin/bitcoin/pull/32454
sliv3r__ has quit [Ping timeout: 244 seconds]
___nick___ has joined #bitcoin-core-dev
saikasyap has quit [Quit: Client closed]
sliv3r__ has joined #bitcoin-core-dev
___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
saturday- has joined #bitcoin-core-dev
Saturday7 has quit [Ping timeout: 276 seconds]
<vasild> "< kanzure> for a future topic perhaps consideration of a private login-only issue tracker (but open registration) to downregulate public social media linkbrigading effects" <-- that is not open source ethos
Cory38 has joined #bitcoin-core-dev
Cory37 has quit [Quit: Client closed]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ad5cd129f3cc...5b8752198e97
<bitcoin-git> bitcoin/master 31c5ebc William Casarin: tracing: fix invalid argument in mempool_monitor
<bitcoin-git> bitcoin/master 5b87521 merge-script: Merge bitcoin/bitcoin#32454: tracing: fix invalid argument in mempool_moni...
<bitcoin-git> [bitcoin] fanquake merged pull request #32454: tracing: fix invalid argument in mempool_monitor (master...fix-mempool-monitor) https://github.com/bitcoin/bitcoin/pull/32454
<bitcoin-git> [bitcoin] l0rinc opened pull request #32457: bench: replace benchmark block with more representative one (413567 → 784588) (master...l0rinc/bench-block-413567-to-784000) https://github.com/bitcoin/bitcoin/pull/32457
<laanwj> i guess that's one of the few good things about mailing lists, the contents are public, everyone can subscribe but it puts up a technical barrier against hit-and-run brigading
<vasild> agree
Christoph_ has quit [Quit: Christoph_]
brunoerg has quit [Remote host closed the connection]
jespada has joined #bitcoin-core-dev
zumbi has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake closed pull request #32445: build: let CMake determine the year (master...cmake_determine_year) https://github.com/bitcoin/bitcoin/pull/32445
brunoerg has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
<pinheadmz> the barrier between users and developers is the issue. users switching to knots right now probably feel like they have better access to luke than anyone else. thats why the discussion blew up on the pull request(s) and why i think in the future we should either expect it and pull way back on the moderation, or hold that github free-for-all in a slightly different place that anyone can access with a web browser and a click
bitdex has quit [Quit: = ""]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
entropyx has quit [Ping timeout: 260 seconds]
entropyx has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake opened pull request #32458: guix: move `*-check.py` scripts under contrib/guix/ (master...move_release_scripts) https://github.com/bitcoin/bitcoin/pull/32458
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5b8752198e97...b070ce16966f
<bitcoin-git> bitcoin/master 7343a18 Hennadii Stepanov: depends: Avoid using helper variables in toolchain file
<bitcoin-git> bitcoin/master b070ce1 merge-script: Merge bitcoin/bitcoin#31360: depends: Avoid using helper variables in tool...
<bitcoin-git> [bitcoin] fanquake merged pull request #31360: depends: Avoid using helper variables in toolchain file (master...241124-vars) https://github.com/bitcoin/bitcoin/pull/31360
jespada has quit [Read error: Connection reset by peer]
jespada has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] Sjors opened pull request #32459: qt: drop unused watch-only functionality (master...2025/05/qt-watch-only) https://github.com/bitcoin/bitcoin/pull/32459
<kanzure> vasild: open source applies to source code licensing not issues; anyone can privately submit an 'issue' to anyone- there is no licensing restriction requiring them to publish the issue in a place for everyone to comment about the issue. if you want to maximize issue visibility then i suggest you propose a license that would require that?
saikasyap has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake opened pull request #32460: fs: remove `_POSIX_C_SOURCE` defining (master...posix_c_source) https://github.com/bitcoin/bitcoin/pull/32460
brunoerg has joined #bitcoin-core-dev
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Read error: Connection reset by peer]
brunoerg has quit [Remote host closed the connection]
jon_atack has joined #bitcoin-core-dev
Cory38 has quit [Quit: Client closed]
Cory38 has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 276 seconds]
Guyver2 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
zeropoint has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/b070ce16966f...9a05b45da60d
<bitcoin-git> bitcoin/master fa5f3e6 MarcoFalke: vcpkg: Remove bdb
<bitcoin-git> bitcoin/master fa62a01 MarcoFalke: remove dead flush()
<bitcoin-git> bitcoin/master ffff949 MarcoFalke: remove NotifyWatchonlyChanged
<bitcoin-git> [bitcoin] fanquake merged pull request #32438: refactor: Removals after bdb removal (master...2505-bdb-remove) https://github.com/bitcoin/bitcoin/pull/32438
TallTim_ is now known as TallTim
Christoph_ has quit [Quit: Christoph_]
jespada_ has joined #bitcoin-core-dev
jespada has quit [Ping timeout: 265 seconds]
roconnor has joined #bitcoin-core-dev
<roconnor> what's the analogus command for sethdseed for descriptor wallets / how do you import a descriptor with a specific hdseed?
Guyver2 has left #bitcoin-core-dev [Closing Window]
Christoph_ has joined #bitcoin-core-dev
<achow101> roconnor: there isn't really an analogus command. I think the closest is createwalletdescriptor, but you have to convert the seed to xprv
<achow101> otherwise you have to importdescriptors the descriptor that you want.
Christoph_ has quit [Client Quit]
<bitcoin-git> [bitcoin] ismaelsadeeq opened pull request #32463: test: fix an incorrect `feature_fee_estimation.py` subtest (master...05-2025-fix-incorrect-fee-estimator-test) https://github.com/bitcoin/bitcoin/pull/32463
saikasyap has quit [Quit: Client closed]
Guest64 has joined #bitcoin-core-dev
Guest64 has quit [Client Quit]
badkat has quit [Ping timeout: 244 seconds]
Cory38 has quit [Quit: Client closed]
Cory38 has joined #bitcoin-core-dev
<roconnor> achow101: so the gethdkeys on a descriptor wallet can only have 1 hdkey in practice?
<roconnor> or will createwalletdescriptor will let you create a new entry hdkey if you give it an xpub?
<achow101> ah, no it doesn't let you add a hdkey
<achow101> you have to import with importdescriptors
<achow101> there's #29136 to import a hd key without having to construct a descriptor
<corebot> https://github.com/bitcoin/bitcoin/issues/29136 | wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor by achow101 · Pull Request #29136 · bitcoin/bitcoin · GitHub
<roconnor> "Add a BIP 32 HD key to the wallet that can be used with 'createwalletdescriptor"
<roconnor> BTW, is there tooling to convert an xpub into a fingerprint?
<roconnor> Or maybe you just look at the output of gethdkeys. :)
<achow101> just look at gethdkeys?
<roconnor> yeah the output of gethdkeys is like
<roconnor> "xpub": "xpub661MyMwAqRbcG2yweGQUJ76UuYKz9k9Agrbc5vwoRzhxLcr7Vr8mbSiePf7rLf2yYVUrihHNM7aKWd53nr5qvUKfizGu6AGTt5mTDs3t8Ym",
<roconnor> "desc": "pkh([4e1b376f/44h/0h/0h]xpub6CV8XzCZK5zmt8ZUiv25TAJcQDSxqYjCYBqaj2kCX81iVEyyFDYDHegxESceJtAQgWGNw8HfEJXsAaX47BXXBx7GN1JM8CHAQQLMXtnZNZz/0/*)#pagjn5ue",
<roconnor> so clearly 4e1b376f is the fingerprint.
<roconnor> (this is just test wallet data, not real)
<achow101> I usually just use bip32.org
<achow101> but not for real keys
<achow101> but generally you shouln't need the fingerprint
<roconnor> maybe...
<roconnor> how do fingerprints work with respect to importdescriptors / createwalletdescriptor ?
<achow101> for the most part, what you are being given by gethdkeys or listdescriptors is a public descriptor that can be imported into a watchonly wallet
<achow101> the fingerprint + derivation path is there because of hardened derivation
<achow101> but you can import a descriptor with an xprv with a full derivation path
<achow101> e.g. if you import wpkh(xprv/84h/0h/0h/0/*), you'll see a public descriptor of wpkh([fingerprint/84h/0h/0h]xpub/0/*)
<achow101> but the one with the xprv is the one actually stored in the wallet
<roconnor> Oh I see.
<roconnor> createwalletdescriptor doesn't actually take a descriptor argument.
<roconnor> it creates one.
<achow101> it does not, it makes descriptors that follow the default templates
<roconnor> got it.
<roconnor> how do watch only wallets and public descriptors work? The hardened derivation paths seem problematic.
Talkless has joined #bitcoin-core-dev
<achow101> roconnor: that's why the public descriptors have the fingerprint + dervivation path in front of the xpub
<achow101> the xpub is derived at that path
<achow101> we derive to the last hardened child, make that the xpub, put its origin info, and follow with the rest of the derivation path
<roconnor> oh. ... don't you lose like what HD level you are at?
<achow101> how so?
<roconnor> maybe I don't know what "put its origin info" means.
<achow101> origin info is fingerprint + derivation path
brunoerg has quit [Ping timeout: 276 seconds]
<roconnor> oh I see now
<roconnor> I wasn't understanding the descriptor format correctly.
<roconnor> I thought [4e1b376f/44h/0h/0h] was part of the path, but it is more like a comment.
<roconnor> achow101: thanks for walking me through all this.
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9a05b45da60d...6c6ef58b0b22
<bitcoin-git> bitcoin/master 1ee698f Sebastian Falbesoner: test: refactor: negate signature-s using libsecp256k1
<bitcoin-git> bitcoin/master 6c6ef58 Ava Chow: Merge bitcoin/bitcoin#32436: test: refactor: negate signature-s using libs...
<bitcoin-git> [bitcoin] achow101 merged pull request #32436: test: refactor: negate signature-s using libsecp256k1 (master...202505-test-negate-signature_s-with-libsecp) https://github.com/bitcoin/bitcoin/pull/32436
PaperSword1 has joined #bitcoin-core-dev
PaperSword has quit [Ping timeout: 252 seconds]
PaperSword1 is now known as PaperSword
brunoerg has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
PaperSword1 has joined #bitcoin-core-dev
PaperSword has quit [Ping timeout: 244 seconds]
PaperSword1 is now known as PaperSword
jon_atack has quit [Read error: Connection reset by peer]
jonatack has joined #bitcoin-core-dev
PaperSword1 has joined #bitcoin-core-dev
PaperSword has quit [Ping timeout: 260 seconds]
PaperSword1 is now known as PaperSword
<bitcoin-git> [bitcoin] achow101 pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/6c6ef58b0b22...19b1e177d673
<bitcoin-git> bitcoin/master a5f52cf Antoine Poinsot: qa: timelock coinbase transactions created in functional tests
<bitcoin-git> bitcoin/master 9c94069 Antoine Poinsot: contrib: timelock coinbase transactions in signet miner
<bitcoin-git> bitcoin/master c76dbe9 Antoine Poinsot: qa: timelock coinbase transactions created in fuzz targets
<bitcoin-git> [bitcoin] achow101 merged pull request #32155: miner: timelock the coinbase to the mined block's height (master...2502_height_in_cb_locktime) https://github.com/bitcoin/bitcoin/pull/32155
Holz_ has joined #bitcoin-core-dev
Holz has quit [Ping timeout: 252 seconds]
Talkless has quit [Quit: Konversation terminated!]
bugs_ has quit [Quit: Leaving]
jespada_ has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
robszarka has joined #bitcoin-core-dev
szarka has quit [Ping timeout: 276 seconds]