dermoth has quit [Read error: Connection reset by peer]
pseudoramdom has quit [Ping timeout: 276 seconds]
dermoth has joined #bitcoin-core-dev
pseudoramdom has joined #bitcoin-core-dev
pseudoramdom has quit [Ping timeout: 245 seconds]
<bitcoin-git>
[bitcoin] achow101 opened pull request #32475: wallet: Use `util::Error` throughout `AddWalletDescriptor` instead of returning `nullptr` for some errors (master...addwalletdescriptor-util-error) https://github.com/bitcoin/bitcoin/pull/32475
zeropoint has quit [Quit: leaving]
pyth has quit [Remote host closed the connection]
<gmaxwell>
I'd like to better understand why the two comments of k98kurz on #32406 are marked off-topic. They are facially related to the substand and effect of the PR. Their points, if not wrong, would be important considerations. Their errors are not that obvious and I don't see them addressed prior to the comments being made, and I at least thought them worthy of a brief response (which I provided).
<gmaxwell>
The poster sounds polite and is clearly reading and considering other reasoning. Absent any background (like is this a known troll?) I would probably rank them the worst comments to remove in terms of contributing vs fanning conspiracies.
<gmaxwell>
substance and effect*
pyth has joined #bitcoin-core-dev
pyth has quit [Remote host closed the connection]
dermoth has quit [Ping timeout: 276 seconds]
dermoth has joined #bitcoin-core-dev
pseudoramdom has joined #bitcoin-core-dev
pseudoramdom has quit [Ping timeout: 260 seconds]
Guest65 has joined #bitcoin-core-dev
Guest65 has quit [Client Quit]
Guest24 has joined #bitcoin-core-dev
Guest24 has quit [Client Quit]
saikasyap has joined #bitcoin-core-dev
pseudoramdom has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
pseudoramdom has quit [Ping timeout: 248 seconds]
pseudoramdom has joined #bitcoin-core-dev
saikasyap has quit [Quit: Client closed]
jonatack has quit [Ping timeout: 252 seconds]
luke-jr_ has quit [Read error: Connection reset by peer]
luke-jr_ has joined #bitcoin-core-dev
greypw1495085720 has quit [Quit: Ping timeout (120 seconds)]
greypw1495085720 has joined #bitcoin-core-dev
entropyx has quit [Read error: Connection reset by peer]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 245 seconds]
jonatack has joined #bitcoin-core-dev
Murch[m] has quit [Ping timeout: 276 seconds]
laanwj has quit [Ping timeout: 276 seconds]
pseudoramdom has quit [Ping timeout: 272 seconds]
laanwj has joined #bitcoin-core-dev
Murch[m] has joined #bitcoin-core-dev
pseudoramdom has joined #bitcoin-core-dev
pseudoramdom has quit [Ping timeout: 276 seconds]
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Quit: Christoph_]
kevkevin has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
pseudoramdom has joined #bitcoin-core-dev
pseudoramdom has quit [Ping timeout: 260 seconds]
Guest3736 has joined #bitcoin-core-dev
pseudoramdom has joined #bitcoin-core-dev
pseudoramdom has quit [Ping timeout: 272 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
<bitcoin-git>
[bitcoin] maflcko opened pull request #32476: refactor: Remove unused HaveKey and HaveWatchOnly (master...2505-bdb-removal-2) https://github.com/bitcoin/bitcoin/pull/32476
Guyver2 has joined #bitcoin-core-dev
dpfeifer has joined #bitcoin-core-dev
dpfeifer has quit [Client Quit]
purpleKarrot has joined #bitcoin-core-dev
purpleKarrot has quit [Changing host]
purpleKarrot has joined #bitcoin-core-dev
purpleKarrot has quit [Client Quit]
purpleKarrot has joined #bitcoin-core-dev
purpleKarrot has quit [Client Quit]
Guest3736 has quit [Quit: WeeChat 4.1.1]
<vasild>
< gmaxwell> I'd like to better understand why the two comments of k98kurz on #32406 are marked off-topic ...
<vasild>
IMO the current handling of OP_RETURN on Bitcoin Core side is technically sound, but a PR (as in public relationship) nightmare. That's logical - we are developers, not PR people...
pseudoramdom has joined #bitcoin-core-dev
pseudoramdom has quit [Ping timeout: 272 seconds]
Christoph_ has quit [Quit: Christoph_]
Guest40 has joined #bitcoin-core-dev
Guest40 has quit [Quit: Client closed]
<_aj_>
there are plenty of coins out there that prioritise PR over technical soundness *shrug*
Guest7 has joined #bitcoin-core-dev
seaner has joined #bitcoin-core-dev
edouardparis_ has quit [Remote host closed the connection]
Guest60 has joined #bitcoin-core-dev
<gmaxwell>
_aj_: that's only a point that's relevant when there is a conflict between the two!
<gmaxwell>
In any case, it was a question-- presumably it has an answer. Might be a good one? dunno!
Guest53 has joined #bitcoin-core-dev
Guest53 has quit [Client Quit]
Guest7 has quit [Quit: Client closed]
Guest60 has quit [Quit: Client closed]
<_aj_>
yeah, i don't know the answer to that; the github moderation tools are pretty bad, and aiui the handful of people that have access to them for our repo aren't experts at using them, don't really like using them, and aren't confident they'll be supported when they do use them :-/
Christoph_ has joined #bitcoin-core-dev
<gmaxwell>
the discomfort with use can itself cause trouble. In any case I'm not trying to throw rocks, first I'd like to understand. And if then I disagreed then I'd like to convince. :P Though this is now the third time in this incident where I'm finding that efforts to diffuse public tensions are (potentially) frustrated by what appear to be unforced errors. and, lol, that's part of the fun too, but
<gmaxwell>
its important to figure out if they were errors in fact and then just try to avoid future repetitions.
<gmaxwell>
yeah I'll follow up later. Trying to have an informal direct discussion, and not directly invite disruptive elements to join the 'discussion' which appears to be the primary activity there.
<pinheadmz>
gmaxwell i only see two marked-as-off-topic comments in 32406, FractalEncrypt and 1440000bytes
<pinheadmz>
i was moderating the first PR more agressively when the brigading started but the second PR I pretty much let everything fly unless it was indisputably a personal attack or spam
<pinheadmz>
the main moderaiton problems we had with comments on the first PR is questions like "is concept NACK a technical argument with no other substance?" and are comments like "no more spam on bitcoin" duplicates since they add no new information
<pinheadmz>
all the more reason IMO to open disucssion for policy changes in an issue ir github discussion before a PR is open. Let all sides post their position statements, and then there wont be need for reiteration on the actual PR
Guyver2 has left #bitcoin-core-dev [Closing Window]
PaperSword has quit [Remote host closed the connection]
<willcl-ark>
gmaxwell: yes those two comments were indeed mistakenly hidden, and have since been un-hidden. Thanks for reporting.
<gmaxwell>
willcl-ark: so just a misake? Totally fine with me.
<gmaxwell>
pinheadmz: yeah I wouldn't have commented on a usless "no moar spam" comment. I mean, I think it's a problem but it's one that can't really be fixed on github. (needs to be solved with more friction to participate, so that most participants know commenting in that way isn't helpful).
purpleKarrot has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
bitcoin/master 772ba7f enoch: test: Fix nTimes typo in feature_pruning test
<bitcoin-git>
bitcoin/master 2aa63d5 enoch: test: Use uninvolved pruned node in feature_pruning undo test
<bitcoin-git>
bitcoin/master bac43b9 merge-script: Merge bitcoin/bitcoin#32312: test: Fix feature_pruning test after nTime ty...
<bitcoin-git>
[bitcoin] glozow merged pull request #32312: test: Fix feature_pruning test after nTime typo fix (master...test_pruning_fix) https://github.com/bitcoin/bitcoin/pull/32312
<gmaxwell>
sipa: should I keep running the spanning forrest loop finder? or put it on pause until you have new code for me to test?
<sipa>
gmaxwell: probably not useful to keep finding more example
<gmaxwell>
maybe interesting to get some examples with whatever metric you move to? for use as test vectors? (and maybe examples setup to generally be more sensible as test vectors)
jarthur has joined #bitcoin-core-dev
<gmaxwell>
in any case I've stood down the search.
<gmaxwell>
sipa: I have 18 cluster size 2 results, fwiw, most of which you haven't seen yet.
<bitcoin-git>
[bitcoin] maflcko opened pull request #32488: fuzz: Properly setup wallet in wallet_fees target (master...2505-fuzz-fix) https://github.com/bitcoin/bitcoin/pull/32488
catnip has joined #bitcoin-core-dev
catnip has quit [Client Quit]
catnip has joined #bitcoin-core-dev
catnip has quit [Client Quit]
<bitcoin-git>
[bitcoin] l0rinc closed pull request #32084: doc: document workaround and fallback for macOS fuzzing (master...l0rinc/libfuzzer-nosan-mac) https://github.com/bitcoin/bitcoin/pull/32084
<sipa>
gmaxwell: sounds like enough
<sipa>
if you feel like looking for something, perhaps more chunks=1 ones?
<sipa>
but really, not urgent or important at this point
pseudoramdom has quit [Ping timeout: 248 seconds]
Cory38 has quit [Quit: Client closed]
Cory38 has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
jarthur has quit [Quit: jarthur]
<bitcoin-git>
[bitcoin] achow101 opened pull request #32489: wallet: Add `exportwatchonlywallet` RPC to export a watchonly version of a wallet (master...export-watchonly-wallet) https://github.com/bitcoin/bitcoin/pull/32489
pablomartin has joined #bitcoin-core-dev
purpleKarrot has quit [Quit: purpleKarrot]
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
kevkevin_ has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
Cory38 has quit [Quit: Client closed]
Cory38 has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
seaner has joined #bitcoin-core-dev
Cory38 has quit [Quit: Client closed]
Cory38 has joined #bitcoin-core-dev
seaner has quit [Ping timeout: 272 seconds]
Cory38 has quit [Quit: Client closed]
Cory38 has joined #bitcoin-core-dev
robszarka has joined #bitcoin-core-dev
szarka has quit [Ping timeout: 276 seconds]
luke-jr has joined #bitcoin-core-dev
luke-jr_ has quit [Ping timeout: 245 seconds]
kevkevin has joined #bitcoin-core-dev
<bitcoin-git>
[gui] achow101 opened pull request #872: gui: Menu action to export a watchonly wallet (master...export-watchonly-wallet-gui) https://github.com/bitcoin-core/gui/pull/872
jarthur has joined #bitcoin-core-dev
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
kevkevin has quit [Remote host closed the connection]