#bitcoin-core-dev on 2025-05-07 — searchable irc log

2025-01-16 14:22 achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt

00:04 jespada_ has quit [Ping timeout: 268 seconds]

00:10 brunoerg has quit [Read error: No route to host]

00:11 brunoerg has joined #bitcoin-core-dev

00:16 joetor5 has quit [Quit: joetor5]

00:28 bitdex has quit [Ping timeout: 264 seconds]

00:41 Harlan28 has joined #bitcoin-core-dev

00:42 Harlan28 has quit [Client Quit]

00:46 thorseldon has joined #bitcoin-core-dev

00:47 <bitcoin-git> [qa-assets] murchandamus opened pull request #225: Add Murch’s inputs May 2025 (main...2025-05-murch-inputs) https://github.com/bitcoin-core/qa-assets/pull/225

00:59 <bitcoin-git> [bitcoin] davidgumberg opened pull request #32431: deps: Bump lief to 0.16.5 (master...5-6-25-lief-noci) https://github.com/bitcoin/bitcoin/pull/32431

01:14 thorseldon has quit [Quit: Client closed]

01:14 pyth has joined #bitcoin-core-dev

01:19 bitdex has joined #bitcoin-core-dev

01:25 pyth has quit [Remote host closed the connection]

01:28 dzxzg2 has quit [Remote host closed the connection]

01:32 joetor5 has joined #bitcoin-core-dev

01:32 joetor5 has quit [Client Quit]

01:36 pyth has joined #bitcoin-core-dev

01:37 entropyx has joined #bitcoin-core-dev

01:44 pyth has quit [Remote host closed the connection]

02:10 entropyx has quit [Ping timeout: 276 seconds]

02:28 <bitcoin-git> [bitcoin] w0xlt opened pull request #32432: wallet, rpc: Change `OutputType` items from `string` into compile-time constants `string_view` (master...outputtype_const) https://github.com/bitcoin/bitcoin/pull/32432

04:00 entropyx has joined #bitcoin-core-dev

04:01 cmirror has quit [Remote host closed the connection]

04:01 cmirror has joined #bitcoin-core-dev

04:45 zeropoint has quit [Quit: leaving]

05:28 gmaxwell has quit [Ping timeout: 248 seconds]

05:28 gmaxwell has joined #bitcoin-core-dev

05:32 Holz has quit [Ping timeout: 248 seconds]

06:02 joetor5 has joined #bitcoin-core-dev

06:15 Holz has joined #bitcoin-core-dev

06:32 robszarka has joined #bitcoin-core-dev

06:36 szarka has quit [Ping timeout: 268 seconds]

06:41 joetor5 has left #bitcoin-core-dev [#bitcoin-core-dev]

06:43 joetor5 has joined #bitcoin-core-dev

06:43 joetor5 has quit [Changing host]

06:43 joetor5 has joined #bitcoin-core-dev

06:46 joetor5 has quit [Remote host closed the connection]

08:01 <bitcoin-git> [bitcoin] maflcko opened pull request #32434: lint: Remove string exclusion from locale check (master...2505-lint-loc) https://github.com/bitcoin/bitcoin/pull/32434

08:06 OYENRAZOR369 has joined #bitcoin-core-dev

08:06 OYENRAZOR62 has joined #bitcoin-core-dev

08:07 OYENRAZOR23 has joined #bitcoin-core-dev

08:10 OYENRAZOR23 has quit [Client Quit]

08:10 OYENRAZOR62 has quit [Client Quit]

08:10 OYENRAZOR369 has quit [Client Quit]

08:45 thorseldon has joined #bitcoin-core-dev

08:45 thorseldon has quit [Client Quit]

09:05 pablomartin has quit [Ping timeout: 268 seconds]

09:05 pablomartin has joined #bitcoin-core-dev

09:18 pablomartin has quit [Ping timeout: 276 seconds]

09:25 pablomartin has joined #bitcoin-core-dev

10:13 Sjors[m] has quit [Ping timeout: 248 seconds]

10:14 Sjors[m] has joined #bitcoin-core-dev

10:44 <bitcoin-git> [bitcoin] theStack opened pull request #32436: test: refactor: negate signature-s using libsecp256k1 (master...202505-test-negate-signature_s-with-libsecp) https://github.com/bitcoin/bitcoin/pull/32436

10:52 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/59d3e4ed34eb...6d5edfcc585b

10:52 <bitcoin-git> bitcoin/master fa48040 MarcoFalke: fuzz: Remove unused TimeoutExpired catch in fuzz runner

10:52 <bitcoin-git> bitcoin/master 6d5edfc merge-script: Merge bitcoin/bitcoin#32388: fuzz: Remove unused TimeoutExpired catch in f...

10:52 <bitcoin-git> [bitcoin] fanquake merged pull request #32388: fuzz: Remove unused TimeoutExpired catch in fuzz runner (master...2504-fuzz-timeout) https://github.com/bitcoin/bitcoin/pull/32388

10:54 <bitcoin-git> [bitcoin] fanquake opened pull request #32437: crypto: disable ASan for sha256_sse4 with Clang (master...extend_asan_sse4) https://github.com/bitcoin/bitcoin/pull/32437

11:01 jespada has joined #bitcoin-core-dev

11:42 mudsip has joined #bitcoin-core-dev

11:45 mudsip has quit [Client Quit]

12:23 bitdex has quit [Quit: = ""]

12:52 brunoerg has quit [Read error: Connection reset by peer]

12:52 brunoerg_ has joined #bitcoin-core-dev

13:00 Cory37 has quit [Quit: Client closed]

13:00 Cory37 has joined #bitcoin-core-dev

13:04 Guest4 has joined #bitcoin-core-dev

13:05 Guest4 has quit [Client Quit]

13:09 jonatack has joined #bitcoin-core-dev

13:11 jon_atack has quit [Ping timeout: 252 seconds]

13:14 adil has joined #bitcoin-core-dev

13:18 adil has quit [Client Quit]

13:26 pablomartin4btc has joined #bitcoin-core-dev

13:49 robszarka has quit [Quit: Leaving]

13:50 szarka has joined #bitcoin-core-dev

13:53 OYENRAZOR369 has joined #bitcoin-core-dev

13:53 Guyver2 has joined #bitcoin-core-dev

13:54 Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]

13:54 OYENRAZOR369 has quit [Client Quit]

14:01 bugs_ has joined #bitcoin-core-dev

14:05 brunoerg_ has quit [Ping timeout: 268 seconds]

14:08 brunoerg has joined #bitcoin-core-dev

14:13 mcey_ has joined #bitcoin-core-dev

14:17 emcy__ has quit [Ping timeout: 276 seconds]

14:19 <bitcoin-git> [bitcoin] fanquake pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/6d5edfcc585b...efac285a0d70

14:19 <bitcoin-git> bitcoin/master 04a7a7a Ava Chow: build, wallet, doc: Remove BDB

14:19 <bitcoin-git> bitcoin/master 810476f Ava Chow: test: Remove unused options and variables, correct comments

14:19 <bitcoin-git> bitcoin/master 84f671b Ava Chow: test: Run multisig script limit test

14:19 <bitcoin-git> [bitcoin] fanquake merged pull request #28710: Remove the legacy wallet and BDB dependency (master...rm-legacy-wallet) https://github.com/bitcoin/bitcoin/pull/28710

14:32 <theStack> oh nice, bd-be-gone 🚀

14:32 <brunoerg> 🚀

14:32 Cory37 has quit [Quit: Client closed]

14:32 Cory37 has joined #bitcoin-core-dev

14:37 <pinheadmz> I've got a ci failure I cant reproduce, not just locally but also running the ci step. rerunning the ci test failed again so there is consistency, but i dunno what to try next to debug.

14:37 <pinheadmz> the test passes in other platforms in the suite

14:37 <pinheadmz> https://cirrus-ci.com/task/4944237076152320

14:43 maflcko_ has quit [Quit: ZNC 1.8.2+deb2ubuntu0.1 - https://znc.in]

14:45 maflcko has joined #bitcoin-core-dev

14:45 <maflcko> pinheadmz: So you ran both CI tasks locally?

14:46 <pinheadmz> correct

14:46 <pinheadmz> then ssh'd into the image and ran the failing test multiple times again

14:48 <sliv3r__> I just ran the test locally and I got the same error as CI

14:49 <maflcko> isn't the test racy? You first connect and send, then start the timer. Shouldn't the timer start before that?

14:50 pablomartin4btc has quit [Ping timeout: 276 seconds]

14:50 <pinheadmz> ah, thanks ;-)

14:50 <maflcko> haven't tried, but you may be able to reproduce locally by replacing "start = time.time()" with "time.sleep(1);start = time.time();"

14:51 <maflcko> (ususally if there is a race you can easily reproduce it with a single sleep in the right place)

14:55 <sliv3r__> oh just left a comment in the pr saying same as maflcko :/ yeah that solves the error

14:59 donal has joined #bitcoin-core-dev

14:59 <pinheadmz> that all makes sense

14:59 <pinheadmz> sliv3r__ the original test fails reliably for you?

15:02 <sliv3r__> pinheadmz sometimes fails, sometimes not

15:03 <sliv3r__> ok nevermind moving the starter before the send doesn't fix it

15:04 <sliv3r__> it was a coincidence that the executions I made were working, I managed to make it fail now

15:04 <pinheadmz> what about before conn.connect() ?

15:05 <sliv3r__> needed 6 executions but failed at the end

15:06 <pinheadmz> hah ok ill change the approach

15:07 <sliv3r__> just tried to see, before http.client... worked 15times in a row

15:22 zeropoint has joined #bitcoin-core-dev

15:29 <bitcoin-git> [bitcoin] maflcko opened pull request #32438: refactor: Removals after bdb removal (master...2505-bdb-remove) https://github.com/bitcoin/bitcoin/pull/32438

15:38 Guest4 has joined #bitcoin-core-dev

15:38 Guest11 has joined #bitcoin-core-dev

15:39 Guest4 has quit [Client Quit]

15:39 Guest11 has quit [Client Quit]

15:50 jespada has quit [Read error: Connection reset by peer]

15:52 jespada has joined #bitcoin-core-dev

16:02 pyth has joined #bitcoin-core-dev

16:09 joetor5 has joined #bitcoin-core-dev

16:10 joetor5 has quit [Changing host]

16:10 joetor5 has joined #bitcoin-core-dev

16:11 donal has quit [Quit: Client closed]

16:12 brunoerg_ has joined #bitcoin-core-dev

16:13 brunoer__ has joined #bitcoin-core-dev

16:14 brunoerg_ has quit [Read error: Connection reset by peer]

16:15 brunoerg has quit [Ping timeout: 276 seconds]

16:23 Cory37 has quit [Quit: Client closed]

16:23 Cory37 has joined #bitcoin-core-dev

16:24 <bitcoin-git> [bitcoin] fanquake opened pull request #32439: guix: accomodate migration to codeberg (master...guix_codeberg_migrate) https://github.com/bitcoin/bitcoin/pull/32439

16:24 <bitcoin-git> [bitcoin] kevkevinpal opened pull request #32440: test: remove bdb assert in tool_wallet.py (master...removeBDBAssert) https://github.com/bitcoin/bitcoin/pull/32440

16:25 <fanquake> anything guix related might be a bit rough the next few days. looks like they are going to be migrating infrastructure

16:32 saikasyap has joined #bitcoin-core-dev

16:33 joetor5 has quit [Ping timeout: 245 seconds]

16:33 joetor5 has joined #bitcoin-core-dev

16:35 joetor5 has quit [Changing host]

16:35 joetor5 has joined #bitcoin-core-dev

16:37 joetor5 has quit [Remote host closed the connection]

16:37 saikasyap has quit [Quit: Client closed]

16:37 saikasyap has joined #bitcoin-core-dev

16:55 Cory37 has quit [Quit: Client closed]

16:55 Cory37 has joined #bitcoin-core-dev

16:57 pablomartin4btc has joined #bitcoin-core-dev

16:58 joetor5 has joined #bitcoin-core-dev

16:58 joetor5 has quit [Changing host]

16:58 joetor5 has joined #bitcoin-core-dev

16:59 pseudoramdom has joined #bitcoin-core-dev

17:02 pablomartin4btc has quit [Ping timeout: 272 seconds]

17:02 saikasyap has quit [Quit: Client closed]

17:02 pyth has quit [Remote host closed the connection]

17:02 pablomartin4btc has joined #bitcoin-core-dev

17:17 mcassano has joined #bitcoin-core-dev

17:22 Talkless has joined #bitcoin-core-dev

17:32 Cory37 has quit [Quit: Client closed]

17:32 Cory37 has joined #bitcoin-core-dev

17:40 <Murch[m]> gmaxwell: The dynamic where the opposition has to be against everything the governing party is doing seems to be a much bigger factor in a two-party system.

17:41 mcassano has quit [Quit: Client closed]

17:41 mcassano has joined #bitcoin-core-dev

17:44 pseudoramdom has quit [Remote host closed the connection]

17:46 mcassano has quit [Ping timeout: 240 seconds]

17:54 dzxzg has joined #bitcoin-core-dev

17:59 danoprey has joined #bitcoin-core-dev

18:05 cotsuka has quit [Remote host closed the connection]

18:06 cotsuka has joined #bitcoin-core-dev

18:09 joetor5 has quit [Remote host closed the connection]

18:37 pablomartin4btc has quit [Ping timeout: 252 seconds]

18:42 pablomartin4btc has joined #bitcoin-core-dev

18:47 <darosior> congrats achow101

18:47 <darosior> "congrats on this, seriously."

18:47 <achow101> if only it didn't cause the rest of my prs to need rebasing

18:50 <TheCharlatan> ^^

18:52 <bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/efac285a0d70...1b1b9f32cfdb

18:52 <bitcoin-git> bitcoin/master 4b6dd97 kevkevinpal: test: remove bdb assert in tool_wallet.py

18:52 <bitcoin-git> bitcoin/master e08e656 kevkevinpal: test: remove assert_dump since it is not used anymore

18:52 <bitcoin-git> bitcoin/master 1b1b9f3 Ava Chow: Merge bitcoin/bitcoin#32440: test: remove bdb assert in tool_wallet.py

18:52 <bitcoin-git> [bitcoin] achow101 merged pull request #32440: test: remove bdb assert in tool_wallet.py (master...removeBDBAssert) https://github.com/bitcoin/bitcoin/pull/32440

18:52 Guyver2 has joined #bitcoin-core-dev

18:54 <bitcoin-git> [bitcoin] MozirDmitriy opened pull request #32441: Fix broken Kyoto Cabinet link in leveldb benchmark doc (master...link) https://github.com/bitcoin/bitcoin/pull/32441

18:55 <bitcoin-git> [bitcoin] fanquake closed pull request #32441: Fix broken Kyoto Cabinet link in leveldb benchmark doc (master...link) https://github.com/bitcoin/bitcoin/pull/32441

19:07 danoprey has quit [Quit: Client closed]

19:24 Talkless has quit [Quit: Konversation terminated!]

19:29 Cory37 has quit [Quit: Client closed]

19:29 Cory37 has joined #bitcoin-core-dev

19:48 pablomartin4btc has quit [Remote host closed the connection]

19:48 pablomartin4btc has joined #bitcoin-core-dev

20:14 pablomartin4btc has quit [Ping timeout: 276 seconds]

20:15 Cory37 has quit [Quit: Client closed]

20:16 Cory37 has joined #bitcoin-core-dev

20:19 laanwj has joined #bitcoin-core-dev

20:19 <laanwj> glad to see the day berkeleydb is finally gone from the source tree, especially that cursed "with incompatible bdb" flag

20:33 pablomartin4btc has joined #bitcoin-core-dev

20:42 pablomartin4btc has quit [Quit: Leaving]

21:06 <sipa> 🥂

21:13 <bitcoin-git> [bitcoin] davidgumberg opened pull request #32442: doc: Add troubleshooting note about Guix on SELinux systems (master...5-7-25-guix-doc) https://github.com/bitcoin/bitcoin/pull/32442

21:15 <fjahr> yepp, congrats achow101

21:19 dzxzg2 has joined #bitcoin-core-dev

21:20 dzxzg has quit [Ping timeout: 268 seconds]

21:32 badkat has quit [Quit: Under attack!]

21:35 badkat has joined #bitcoin-core-dev

21:47 dzxzg has joined #bitcoin-core-dev

21:48 dzxzg2 has quit [Ping timeout: 252 seconds]

21:55 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1b1b9f32cfdb...95bb305b96a8

21:55 <bitcoin-git> bitcoin/master ff35a4b w0xlt: docs: Improve `keypoolrefill` RPC docs

21:55 <bitcoin-git> bitcoin/master 95bb305 Ava Chow: Merge bitcoin/bitcoin#32429: docs: Improve `keypoolrefill` RPC docs

21:55 <bitcoin-git> [bitcoin] achow101 merged pull request #32429: docs: Improve `keypoolrefill` RPC docs (master...keypoolrefill_docs) https://github.com/bitcoin/bitcoin/pull/32429

22:03 dzxzg has quit [Ping timeout: 272 seconds]

22:16 Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]

22:25 bugs_ has quit [Quit: Leaving]

22:47 dzxzg has joined #bitcoin-core-dev

22:57 pyth has joined #bitcoin-core-dev

23:18 deeter has joined #bitcoin-core-dev

23:30 deeter has quit [Quit: Client closed]

23:58 danoprey has joined #bitcoin-core-dev