btcdrak: I would like to write unit test, that creates a block, we assume that current date is 2016-09-01, and in this blog it sets on or off BIP9 flag, and segwit flag, and see if that block would be rejected or accepted
I didn't yet write UTs for btc. Which other existing tests I should study to learn that?
*in this block
emucode: would be better to use a functional test for that than a unit test. Unit tests are meant to test single function/classes in isolation
emucode: as for existing tests, there's a test/functional/segwit.py and test/functional/bip9-softforks.py
not that this matters much post-mempool persistaence, but it seems that during a reindex wallet transactions will fail to be reaccepted because they're all non-final, with chainActive.Height() being 0. Is this intended?
instagibbs: since it retries I dunno that its a problem.
mm true. Just shows as missing balance until then.
gmaxwell, where is the rebroadcast logic set?
ok, one and the same, the first invocation is just useless
[bitcoin] JeremyRubin opened pull request #10145: Separate Contextual checks and handling & switch on enum in net_processing.cpp (master...netprocessing_enum_rebased) https://github.com/bitcoin/bitcoin/pull/10145