06:53 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ebfd65379811...e6033e00b164

06:53 < bitcoin-git> bitcoin/master 4b87973 practicalswift: [rpc] Remove auth cookie on shutdown...

06:53 < bitcoin-git> bitcoin/master e6033e0 Wladimir J. van der Laan: Merge #10139: [rpc] Remove auth cookie on shutdown...

06:53 < bitcoin-git> [bitcoin] laanwj closed pull request #10139: [rpc] Remove auth cookie on shutdown (master...delete-auth-cookies) https://github.com/bitcoin/bitcoin/pull/10139

06:55 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/f15268db3bf1a8c4ea410f4f63c6187b45e06ded

06:55 < bitcoin-git> bitcoin/0.14 f15268d practicalswift: [rpc] Remove auth cookie on shutdown...

10:06 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e6033e00b164...a2cd0b0eecfe

10:06 < bitcoin-git> bitcoin/master 6d5dd60 Thomas Snider: No need to use OpenSSL malloc/free

10:06 < bitcoin-git> bitcoin/master a2cd0b0 Wladimir J. van der Laan: Merge #10058: No need to use OpenSSL malloc/free...

10:07 < bitcoin-git> [bitcoin] laanwj closed pull request #10058: No need to use OpenSSL malloc/free (master...tjps_ssl_mutex) https://github.com/bitcoin/bitcoin/pull/10058

11:24 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a2cd0b0eecfe...cb598cfba1cb

11:24 < bitcoin-git> bitcoin/master 7482781 Pieter Wuille: Allow non-power-of-2 signature cache sizes

11:24 < bitcoin-git> bitcoin/master cb598cf Wladimir J. van der Laan: Merge #9533: Allow non-power-of-2 signature cache sizes...

11:25 < bitcoin-git> [bitcoin] laanwj closed pull request #9533: Allow non-power-of-2 signature cache sizes (master...anysigcachesize) https://github.com/bitcoin/bitcoin/pull/9533

13:05 < rubensayshi> is there a way to restrict a node to only accept incoming connections from local network?

13:06 < sipa> you can bind to localhost

13:06 < sipa> or use a firewall :)

13:08 < rubensayshi> yea, guess I'll firewall it

14:19 < emucode> hi, I would like to learn how to write unit tests, can you give me some hints?

14:19 < emucode> what commands available in test framework could be use for UT for BIP148?

14:22 < sipa> 'commands' ?

14:23 < sipa> the unit tests can access all functions that are exposed by modules in the software to be tested

15:17 < bitcoin-git> [bitcoin] ryanofsky opened pull request #10142: Run bitcoin_test-qt under minimal QPA platform (master...pr/qtmin) https://github.com/bitcoin/bitcoin/pull/10142

15:18 < btcdrak> emucode: the unit tests are in src/tests, where as the functional tests are in qa/rpc

15:19 < bitcoin-git> [bitcoin] ryanofsky closed pull request #10117: Fix "make check" on systems with qt and libxcb but no active DISPLAY (master...pr/noqapp) https://github.com/bitcoin/bitcoin/pull/10117

15:20 < emucode> btcdrak: I would like to write unit test, that creates a block, we assume that current date is 2016-09-01, and in this blog it sets on or off BIP9 flag, and segwit flag, and see if that block would be rejected or accepted

15:21 < emucode> I didn't yet write UTs for btc. Which other existing tests I should study to learn that?

15:21 < emucode> *in this block

15:38 < wumpus> emucode: would be better to use a functional test for that than a unit test. Unit tests are meant to test single function/classes in isolation

15:39 < wumpus> emucode: as for existing tests, there's a test/functional/segwit.py and test/functional/bip9-softforks.py

15:43 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cb598cfba1cb...471ed00fcd3b

15:43 < bitcoin-git> bitcoin/master 3bde556 John Newbery: Add -debugexclude option to switch off logging for specified components

15:43 < bitcoin-git> bitcoin/master 471ed00 Wladimir J. van der Laan: Merge #10123: Allow debug logs to be excluded from specified component...

15:43 < bitcoin-git> [bitcoin] laanwj closed pull request #10123: Allow debug logs to be excluded from specified component (master...debugexclude) https://github.com/bitcoin/bitcoin/pull/10123

15:55 < luke-jr> what prevents a 0-value output with 0-length sPK from being pruned prematurely from the UTXO set?

15:58 < sipa> go add it to to CScript::,×IsProvablyUnsoendable

16:32 < luke-jr> sipa: ? it's *not* unspendable, but CCoins stuff assumes IsNull TxOut is deleted

16:35 < sipa> luke-jr: such a scriptPubKey is unspendable anyway

16:36 < luke-jr> why? scriptSig=OP_TRUE

16:36 < sipa> so treating it as non-existiant is fine

16:36 < sipa> hmm

16:38 < sipa> luke-jr: CTxOut::IsNull requires amount == -1

16:40 < instagibbs> luke-jr, both scritpubkey evaluation has to happen too, right?

16:40 < luke-jr> sipa: aha

16:41 < instagibbs> oh nvm

16:43 < sipa> luke-jr: you had me worried for a minute

16:43 < luke-jr> sorry, oversight of that detail

16:44 < luke-jr> also figured 0.8 was long enough ago that ti wouldn't matter anyay

16:45 < bitcoin-git> [bitcoin] jnewbery opened pull request #10143: [net] Allow disconnectnode RPC to be called with node id (master...disconnect_node_by_id) https://github.com/bitcoin/bitcoin/pull/10143

20:04 < bitcoin-git> [bitcoin] sdaftuar opened pull request #10144: Prioritisetransaction wasn't always updating ancestor fee (master...2017-04-fix-mempool-modified-ancestor-fees) https://github.com/bitcoin/bitcoin/pull/10144

21:30 < instagibbs> not that this matters much post-mempool persistaence, but it seems that during a reindex wallet transactions will fail to be reaccepted because they're all non-final, with chainActive.Height() being 0. Is this intended?

21:31 < gmaxwell> instagibbs: since it retries I dunno that its a problem.

21:32 < instagibbs> mm true. Just shows as missing balance until then.

21:35 < instagibbs> gmaxwell, where is the rebroadcast logic set?

21:35 < gmaxwell> instagibbs: Resendwallettransactions.

21:35 < instagibbs> ok, one and the same, the first invocation is just useless

21:53 < bitcoin-git> [bitcoin] theuni closed pull request #10143: [net] Allow disconnectnode RPC to be called with node id (master...disconnect_node_by_id) https://github.com/bitcoin/bitcoin/pull/10143

21:54 < instagibbs> Ok, the mempool attempt for resend fix also fixes this bug as well.

22:05 < bitcoin-git> [bitcoin] theuni reopened pull request #10143: [net] Allow disconnectnode RPC to be called with node id (master...disconnect_node_by_id) https://github.com/bitcoin/bitcoin/pull/10143

22:13 < bitcoin-git> [bitcoin] JeremyRubin opened pull request #10145: Separate Contextual checks and handling & switch on enum in net_processing.cpp (master...netprocessing_enum_rebased) https://github.com/bitcoin/bitcoin/pull/10145