< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #10279: Add a CChainState class to validation.cpp to take another step towards clarifying internal interfaces (master...2016-12-cconsensus) https://github.com/bitcoin/bitcoin/pull/10279
< BlueMatt>
jtimon: ^ this is rather much in your wheelhouse
< achow101>
gmaxwell: any update with publishing the alert key?
< bitcoin-git>
bitcoin/master 4f3ac7d Chris Gavin: Remove unused variable from `macdeployqtplus` script.
< bitcoin-git>
bitcoin/master e8babc4 Chris Gavin: Use `with` in `macdeployqtplus` script.
< bitcoin-git>
bitcoin/master 8979f45 Wladimir J. van der Laan: Merge #10273: [scripts] Minor improvements to `macdeployqtplus` script....
< bitcoin-git>
[bitcoin] laanwj closed pull request #10273: [scripts] Minor improvements to `macdeployqtplus` script. (master...macdeployqtplus) https://github.com/bitcoin/bitcoin/pull/10273
< MarcoFalke>
wumpus: I am not convinced that we need to implement every function twice. (Once in the code and a second time in the unit tests; Then check for equality)
< MarcoFalke>
(re 10278)
< MarcoFalke>
Also, the SoftSetArg has effect on all test that run after it
<@wumpus>
MarcoFalke: this is just a very simple function to test
<@wumpus>
the test fully checks the behavior of GetListenPort, though
<@wumpus>
feel free to suggest other ways to test GetListenPort, or do you mean no unit test should exist for it at all?
< MarcoFalke>
I mean it is a 1:1 copy of the implementation
<@wumpus>
yes, it doesn't reset the argument afterward, probaly should
< MarcoFalke>
I more think of unit test to cover corner cases
<@wumpus>
it is, but I wouldn't know how to test this otherwise
<@wumpus>
it's just a silly little function that only does one thing
<@wumpus>
so the only way to test it is to do that silly little thing too
<@wumpus>
you could argue it is useless, I don't know, maybe it'll catch an error if someone changes the GetListenPort implementation
< MarcoFalke>
Hmm, I suspect pretty much everything else breaks if the implementation is changed.
< MarcoFalke>
I don't care too much about this very function, but I am worried there will be pulls coming up for literally any function.
<@wumpus>
possibly. But the point of the unit test is to check that function, and it does that.
<@wumpus>
yes, feel free to nudge him in the direction of writing more useful tests
<@wumpus>
just trying to encourage him a bit, it's good to have a new contributor that cares about testing
< MarcoFalke>
Yes, getting that merged was probably a good way to motivate more contributions
< * MarcoFalke>
off
<@wumpus>
right, he has admitted this is part of his learning process
<@wumpus>
later
<@wumpus>
oh wow TIL github has a "reviews -> awaiting review from you" selection for PRs
<@wumpus>
that could be useful, at least if someone had tagged me as reviewr for anything :)
< bitcoin-git>
[bitcoin] luke-jr opened pull request #10282: Expire bitcoind & bitcoin-qt 7-8 years after its last change (master...timebomb) https://github.com/bitcoin/bitcoin/pull/10282
< achow101>
gmaxwell: any update on publishing the alert key?
< bitcoin-git>
[bitcoin] morcos opened pull request #10283: Cleanup: reduce to one GetMinimumFee call signature (master...oneGetMinimumFee) https://github.com/bitcoin/bitcoin/pull/10283
< bitcoin-git>
[bitcoin] morcos opened pull request #10284: Always log debug information for fee calculation in CreateTransaction (master...debugEstimates) https://github.com/bitcoin/bitcoin/pull/10284