< bitcoin-git> [bitcoin] jimmysong opened pull request #10223: Tests: Refactor to create witness script creation function (master...refactor_blocktools_for_segwit) https://github.com/bitcoin/bitcoin/pull/10223
< bitcoin-git> [bitcoin] jimmysong opened pull request #10224: Tests: Add simple test for getaddednodeinfo (master...test_getaddednodeinfo) https://github.com/bitcoin/bitcoin/pull/10224
< midnightmagic> sipa: What does the green spike represent here in your graph? http://bitcoin.sipa.be/ver9-50k.png
< achow101> midnightmagic: that's csv signalling
< midnightmagic> achow101: Thanks. I'm colourblind. I thought the blue line next to the first 144 block average was green.
< NicolasDorier> sipa: https://github.com/bitcoin/bitcoin/pull/10195 is really too hard to review for me. I think an easier approach for review, would be to make a first PR which only change CCoinView class while making no change to the underlying storage. Then a second PR dealing with the storage change/optimization.
< NicolasDorier> by "change to CCoinView" I mean only the method signatures to be per txout
< NicolasDorier> without changing any underlying storage
< sipa> NicolasDorier: there is no easy way first do one without the other, but i'll try
< sipa> NicolasDorier: and signatures have nothing to do with it
< NicolasDorier> I said method signature
< NicolasDorier> ie like GetCoins() is per Outpoint instead of uint256
< sipa> also, please review #10408 first
< gribble> https://github.com/bitcoin/bitcoin/issues/10408 | HTTP Error 404: Not Found
< sipa> ah yes, my apologies!
< NicolasDorier> you were in the wrong namespace => using OOP; :D
< NicolasDorier> mmh 10408 does not exist
< NicolasDorier> ha
< sipa> yes indeed
< sipa> sorry, i just woke up
< NicolasDorier> sipa: I will try myself to just change CCoinView signature
< NicolasDorier> method signatures
< NicolasDorier> will make a PR if it is usable and indeed easier to review
< NicolasDorier> will try that today after reviewing https://github.com/bitcoin/bitcoin/pull/10148
< sipa> NicolasDorier: that's very nontrivial
< sipa> you'd need a translation layer with ths database
< sipa> if you create one, i'll happily include, though?
< sipa> s/?/!/
< NicolasDorier> ok I will try
< sipa> it may be easier to do the opposite; first change the db and then CCoinsView
< sipa> because all that needs is a loop at read or write time to merge the db records/split ccoims
< NicolasDorier> Not really related to the PR but tricky: https://github.com/bitcoin/bitcoin/blob/2584925077f9658b3953ad931b74779006e59807/src/validation.cpp#L1591 . fClean is passed either as pointer or return value. If pointer is used, return value is useless.
< sipa> no, the return value still indicates disk corruption
< sipa> pfClean is only for database inconsistencies
< sipa> i'll add a comment to explain
< sipa> but thank you very much for having a look at these PRs
< sipa> i know they're pretty invasive
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d86bb075bf6d...393160cf6cda
< bitcoin-git> bitcoin/master 75a08e7 Kalle Alm: [wallet] Add support for aborting wallet transaction rescans.
< bitcoin-git> bitcoin/master 9141622 Kalle Alm: [rpc] Add abortrescan command to RPC interface.
< bitcoin-git> bitcoin/master 393160c Wladimir J. van der Laan: Merge #10208: [wallet] Rescan abortability...
< bitcoin-git> [bitcoin] laanwj closed pull request #10208: [wallet] Rescan abortability (master...rescan-abortability) https://github.com/bitcoin/bitcoin/pull/10208
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/393160cf6cda...a86255b11633
< bitcoin-git> bitcoin/master 846dc17 Kalle Alm: [doc] Wording fixes in CONTRIBUTING.md.
< bitcoin-git> bitcoin/master 3ddd227 Kalle Alm: [doc] Add blob about finding reviewers.
< bitcoin-git> bitcoin/master a86255b Wladimir J. van der Laan: Merge #10211: [doc] Contributor fixes & new "finding reviewers" section...
< bitcoin-git> [bitcoin] laanwj closed pull request #10211: [doc] Contributor fixes & new "finding reviewers" section (master...contributor-finding-reviewers) https://github.com/bitcoin/bitcoin/pull/10211
< sipa> wumpus: not sure if you know this, but you can run with -reindex, make it process a couple block files, and then abort and restart with -reindex-chainstate
< sipa> that will just make it fully process those couple files
<@wumpus> didn't know that, thanks
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a86255b11633...9111df9673be
< bitcoin-git> bitcoin/master 637706d Jimmy Song: Tests: Put Extended tests first when they're included...
< bitcoin-git> bitcoin/master 9111df9 MarcoFalke: Merge #10219: Tests: Order Python Tests Differently...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10219: Tests: Order Python Tests Differently (master...order_tests_by_duration) https://github.com/bitcoin/bitcoin/pull/10219
< bitcoin-git> [bitcoin] kallewoof opened pull request #10225: [test] Add aborttrescan tests (master...abort-rescan-tests) https://github.com/bitcoin/bitcoin/pull/10225
< SopaXorzTaker> Can anyone do me a favor?
< SopaXorzTaker> please broadcast this nonstandard tx: 0100000001af73ff160d0434f1d8da871552ba06b1c24af1e91b494b2f4cbe25457eb9734300000000080106010701000100ffffffff01e0090200000000001976a914f6746dece46a2cd331f9ff7960135bcb587862ac88ac00000000'
< SopaXorzTaker> (remove the trailing quote, of course)
< jonasschnelli> SopaXorzTaker: broadcast yourself?
<@wumpus> only makes sense to send it direct to miners, broadcasting it will just cause it to be ignored/rejected
<@wumpus> my nodes don't want it at least
< jonasschnelli> Ah. It's non-std. Yes. maybe google the miners IP and use something like https://github.com/libbtc/libbtc#the-bitcoin-send-tx-cli
< SopaXorzTaker> jonasschnelli, thanks
< SopaXorzTaker> I alrready found that
< SopaXorzTaker> I am currently doing just that, too
< SopaXorzTaker> jonasschnelli, I can't
< SopaXorzTaker> I will have to compile bitcoind
< jonasschnelli> SopaXorzTaker: why?
< SopaXorzTaker> lazy
< SopaXorzTaker> Arch doesn't install it
< SopaXorzTaker> and if it did, I'd have to download the blockchain
< SopaXorzTaker> I have to compile it myself without the checks
< sipa> no offence, but this channel is about development of bitcoin core
< sipa> if you're not planning to even run it, why are you here?
< SopaXorzTaker> I am compiling it now
< SopaXorzTaker> that'd take a while
< SopaXorzTaker> and I am bored
< sipa> ok :)
< SopaXorzTaker> tx e1995a7ee78fd11a24591e35f3a7d3cda92c6cf4126879a8e133377d85906284
< SopaXorzTaker> sipa, could you do it
< SopaXorzTaker> " sendrawtransaction 0100000001af73ff160d0434f1d8da871552ba06b1c24af1e91b494b2f4cbe25457eb9734300000000080106010701000100ffffffff01e0090200000000001976a914f6746dece46a2cd331f9ff7960135bcb587862ac88ac00000000"
< SopaXorzTaker> with a full blockchain, obviously
< sipa> SopaXorzTaker: i tried, it would reject it because it's nonstandard
< sipa> SopaXorzTaker: and modifying the code wouldn't help, as other peers would reject it too
< sipa> you need to send it directly to miners, as you were told above
<@wumpus> yes I tried that about an hour ago, on a few nodes. Please don't repeat yourself. This channel is not for idle bitcoin discussion or technical help but for development discussion
< bitcoin-git> [bitcoin] laanwj closed pull request #10220: Experiment: test: Disable fsync in travis tests (master...2017_04_tests_eatmydata) https://github.com/bitcoin/bitcoin/pull/10220
< aguyonabike> Hi, I'm not sure if this is the right place to ask this question, but could Segwit be changed to be covert-asicboost-compatible? The way I figure this could be done is similar to the extension blocks proposal, adding a special transaction "at the end" instead of using coinbase space for the witness commit
<@wumpus> yes, wrong channel, this is about concrete development of the source code on github, may be better to ask in #bitcoin-wizards or such
< aguyonabike> sorry about it :) thanks
< SopaXorzTaker> sipa, eligius doesn't reject
< SopaXorzTaker> how do I feed that to a miner node?
<@wumpus> SopaXorzTaker: different channel please, this is not development related
< SopaXorzTaker> sorry
<@wumpus> general questions like that belong in#bitcoin
<@wumpus> alternatively, the bitcoin stack exchange can be useful for community support, it doesn't rely on people being who know being around at the time
<@wumpus> -being
< SopaXorzTaker> offtopic: give an example of a miner node that I can feed the transaction to, please
< SopaXorzTaker> wumpus, sipa ^
< SopaXorzTaker> I can't find any
< sipa> SopaXorzTaker: not here, offtopic
< SopaXorzTaker> okay
<@wumpus> this is not a "highlight developers to get support" channel, last warning
< SopaXorzTaker> wumpus, fine
< SopaXorzTaker> and sorry for that
< SopaXorzTaker> guys
< SopaXorzTaker> oops
< bincap> back to srs busines on other hand
< bincap> luke-jr: laanwj was so kind and confirmed gitian for knots+bip148 https://github.com/magmaship/bitcoin-special-gitian.sigs/pull/1
< bincap> dang wrong #bitcoin channel. Disregard that, moving to #bitcoin
< bitcoin-git> [bitcoin] luke-jr opened pull request #10226: wallet: Use boost to more portably ensure -wallet specifies only a filename (master...refactor_wallet_pathsep) https://github.com/bitcoin/bitcoin/pull/10226
< bitcoin-git> [bitcoin] jtimon opened pull request #10227: Make functions in validation.cpp static: (master...b14-chainparams-validation-static) https://github.com/bitcoin/bitcoin/pull/10227
< jtimon> so what's next for #10189 ?
< gribble> https://github.com/bitcoin/bitcoin/issues/10189 | devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private. by theuni · Pull Request #10189 · bitcoin/bitcoin · GitHub
< jtimon> I also read the topic on last meeting which I missed, it seems we agree that this facilitates review but doesn't replace it
< BlueMatt> jtimon: I believe cfields has a few things to update on it?
< jtimon> BlueMatt: apart from requiring a specific prefix (which can be done later), anything else?
< BlueMatt> that was my only comment
< BlueMatt> dont think it should be done in a separate pr, though? you dont want to gratuitously change it so that old commits are no longer verifyable for no reason
< BlueMatt> (plus its super trivial)
< cfields> sure, will add
< jtimon> yeah, I actually didn't thought about making it mandatory for the script to be checked, just as a convention to put in the development notes with some explanation on how to use this, but ack on making the script check for the tittle prefix
< jtimon> BlueMatt: ack on completing it further, thanks guys
< jtimon> I'm also not sure if there's any blocker for #9494, maybe squashing #10119 into it?
< gribble> https://github.com/bitcoin/bitcoin/issues/9494 | Introduce an ArgsManager class encapsulating cs_args, mapArgs and mapMultiArgs by jtimon · Pull Request #9494 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10119 | Util: Remove ArgsManager wrappers: by jtimon · Pull Request #10119 · bitcoin/bitcoin · GitHub
< jtimon> ping: jeremyrubin
< jtimon> btw, as much excited as I am about #10193, the part replacing BOOST_REVERSE_FOREACH isn't even compiling for prevector_tests.cpp (see https://github.com/bitcoin/bitcoin/pull/10193/commits/cfef34884684e71c6f43ef3e4f2e87590fc87c9e ), and thus https://github.com/bitcoin/bitcoin/pull/10193/commits/d0cbbbe1147dfdf407087816a4e999990907a565 should be done either as it is
< gribble> https://github.com/bitcoin/bitcoin/issues/10193 | scripted-diff: Remove #include foreach.hpp> by jtimon · Pull Request #10193 · bitcoin bitcoin · GitHub
< jtimon> perhaps I should reduce the scope if I can't find a fix (and I'm still pretty clueless about why the code I "stole" from the interwebs isn't working)
< bitcoin-git> [bitcoin] theuni opened pull request #10228: build: regenerate bitcoin-config.h as necessary (master...fix-config-h) https://github.com/bitcoin/bitcoin/pull/10228