07:46 < wumpus> luke-jr: ok, feel free to change that

11:31 < stevenroose> I haven't looked into Core's code too much, but I feel like there is quite a lack of code documentation..

11:31 < stevenroose> F.e. https://github.com/bitcoin/bitcoin/blob/f93f9b92969b4a3f77d3f1c2a30ba3bf558e0cac/src/txmempool.cpp#L759

11:31 < stevenroose> It says "compare" and returns a bool.

11:31 < stevenroose> Compare methods commonly return an int that is negative for <, 0 for == and positive for >

11:32 < stevenroose> Also, it might be useful to document what it is basing the comparison on

11:32 < stevenroose> Even thought the method name says depth and score, it doesn;t say if a higher depth and higher score mean higher ranking (which is then either true or false)

12:29 < sipa> stevenroose: in C++ a comparator is a function that acts like (a < b)

12:35 < gmaxwell> s/C++/stl/

12:58 < sipa> gmaxwell: which is part of the C++ standard, but ok, other libraries can do things differently

13:47 < sipa> gmaxwell: i guess i should have said "in c++ it is common practice to use comparators which compute the less-than relation"

13:58 < gmaxwell> it just sounded weird to say "in C++"

14:43 < bitcoin-git> [bitcoin] sipa closed pull request #8087: Introduce CBlockchain and move CheckBlockHeader (master...2016-05-22-cblockchain) https://github.com/bitcoin/bitcoin/pull/8087

16:01 < bitcoin-git> [bitcoin] sipa closed pull request #9599: [WIP] Perform validation in a separate thread to message handling. (master...ValidationThread) https://github.com/bitcoin/bitcoin/pull/9599

20:20 < stevenroose> well, fwiw, Go's sort.Interface.Less() method does the same thing, so I figured as much. but still "Less()" is more explanatory than "operator()". but thanks, I'm making sense of the code

22:02 < sipa> stevenroose: and comments are always welcome :)