< wumpus> luke-jr: ok, feel free to change that
< stevenroose> I haven't looked into Core's code too much, but I feel like there is quite a lack of code documentation..
< stevenroose> It says "compare" and returns a bool.
< stevenroose> Compare methods commonly return an int that is negative for <, 0 for == and positive for >
< stevenroose> Also, it might be useful to document what it is basing the comparison on
< stevenroose> Even thought the method name says depth and score, it doesn;t say if a higher depth and higher score mean higher ranking (which is then either true or false)
< sipa> stevenroose: in C++ a comparator is a function that acts like (a < b)
< gmaxwell> s/C++/stl/
< sipa> gmaxwell: which is part of the C++ standard, but ok, other libraries can do things differently
< sipa> gmaxwell: i guess i should have said "in c++ it is common practice to use comparators which compute the less-than relation"
< gmaxwell> it just sounded weird to say "in C++"
< bitcoin-git> [bitcoin] sipa closed pull request #8087: Introduce CBlockchain and move CheckBlockHeader (master...2016-05-22-cblockchain) https://github.com/bitcoin/bitcoin/pull/8087
< bitcoin-git> [bitcoin] sipa closed pull request #9599: [WIP] Perform validation in a separate thread to message handling. (master...ValidationThread) https://github.com/bitcoin/bitcoin/pull/9599
< stevenroose> well, fwiw, Go's sort.Interface.Less() method does the same thing, so I figured as much. but still "Less()" is more explanatory than "operator()". but thanks, I'm making sense of the code
< sipa> stevenroose: and comments are always welcome :)