< bitcoin-git> [bitcoin] fanquake opened pull request #10270: Remove Clang workaround for Boost 1.46 (master...remove-boost-clang-workaround) https://github.com/bitcoin/bitcoin/pull/10270
< bitcoin-git> [bitcoin] fanquake opened pull request #10271: Use std::thread::hardware_concurrency, instead of Boost, to determine available cores (master...replace-boost-getnumcores) https://github.com/bitcoin/bitcoin/pull/10271
< bitcoin-git> [bitcoin] paveljanik opened pull request #10272: [Tests] Prevent warning: variable 'x' is uninitialized (master...20170425_FastRandomContext_test_warnings) https://github.com/bitcoin/bitcoin/pull/10272
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c73af5416b66...54e2d87e792f
< bitcoin-git> bitcoin/master 5ec8836 Pavel Janík: Prevent warning: variable 'x' is uninitialized
< bitcoin-git> bitcoin/master 54e2d87 Wladimir J. van der Laan: Merge #10272: [Tests] Prevent warning: variable 'x' is uninitialized...
< bitcoin-git> [bitcoin] laanwj closed pull request #10272: [Tests] Prevent warning: variable 'x' is uninitialized (master...20170425_FastRandomContext_test_warnings) https://github.com/bitcoin/bitcoin/pull/10272
< bitcoin-git> [bitcoin] practicalswift closed pull request #10212: Make sure parameter names in .cpp and .h files are in sync (master...make-doxygen-happy-by-using-consistent-parameter-names) https://github.com/bitcoin/bitcoin/pull/10212
< jl2012> are all 127.0.0.1 peers (incoming and outgoing) whitelisted by default?
<@wumpus> no, absolutely not
<@wumpus> remember, that's where tor onion connections come from
< gmaxwell> jl2012: localhost does not get banned however.
< gmaxwell> but it will happily be kicked.
< gmaxwell> (also whitelisting implies a bunch of other stuff)
< gmaxwell> I wonder if we define a FORCETX message that is only accepted from WL peers if we could get rid of that forced relay behavior...
<@wumpus> unless someone implements https://github.com/bitcoin/bitcoin/issues/8973 to make onion connections come in on either an alternative port or a unix socket, it's unsafe to whitelist 127.0.0.1 [by default]
<@wumpus> of course if you're not using tor, yuu can do that
< jl2012> i see. I start with --whitelist=127.0.0.1 --addnode=127.0.0.1:9333 , but in getpeerinfo it says "whitelisted": false,
<@wumpus> outgoing connections are not whitelisted ever
< jl2012> good, thanks!
< bitcoin-git> [bitcoin] chrisgavin opened pull request #10273: [scripts] Minor improvements to `macdeployqtplus` script. (master...macdeployqtplus) https://github.com/bitcoin/bitcoin/pull/10273
< bitcoin-git> [bitcoin] ericchong opened pull request #10274: Replace by fee v0.11.2 (master...replace-by-fee-v0.11.2) https://github.com/bitcoin/bitcoin/pull/10274
< bitcoin-git> [bitcoin] kallewoof opened pull request #10275: [rpc] Allow fetching tx directly from specified block in getrawtransaction (master...gettx-with-blockhash) https://github.com/bitcoin/bitcoin/pull/10275
< bitcoin-git> [bitcoin] laanwj closed pull request #10274: Replace by fee v0.11.2 (master...replace-by-fee-v0.11.2) https://github.com/bitcoin/bitcoin/pull/10274
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/54e2d87e792f...95f5e4407502
< bitcoin-git> bitcoin/master 93dbb15 fanquake: Remove Clang workaround for Boost 1.46
< bitcoin-git> bitcoin/master 95f5e44 Wladimir J. van der Laan: Merge #10270: Remove Clang workaround for Boost 1.46...
< bitcoin-git> [bitcoin] laanwj closed pull request #10270: Remove Clang workaround for Boost 1.46 (master...remove-boost-clang-workaround) https://github.com/bitcoin/bitcoin/pull/10270
< bitcoin-git> [bitcoin] knocte opened pull request #10276: contrib/verifybinaries: allow filtering by platform (master...filterByPlatformInVerifySh) https://github.com/bitcoin/bitcoin/pull/10276
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/95f5e4407502...cb007e4346cf
< bitcoin-git> bitcoin/master 94807be CryptAxe: Trivial: fix fee estimate write error log message
< bitcoin-git> bitcoin/master cb007e4 Wladimir J. van der Laan: Merge #10263: Trivial: fix fee estimate write error log message...
< bitcoin-git> [bitcoin] laanwj closed pull request #10263: Trivial: fix fee estimate write error log message (master...coinbase) https://github.com/bitcoin/bitcoin/pull/10263
< * wumpus> removes high/medium priority tags from issues older than 2016, that's just silly
<@wumpus> disconnect_ban.py | ✓ Passed | 908 s
<@wumpus> here this test is *much* slower than all of the others (runner-up is p2p-fullblocktest with 187s)
<@wumpus> anyone else experiencing that?
< jnewbery> I shouldn't have added that line until #10234 was merged
< gribble> https://github.com/bitcoin/bitcoin/issues/10234 | [net] listbanned RPC and QT should show correct banned subnets by jnewbery · Pull Request #10234 · bitcoin/bitcoin · GitHub
<@wumpus> jnewbery: ok in that case it makes sense to aim for #10234 to be merged instead of work on a workaround, thanks
< gribble> https://github.com/bitcoin/bitcoin/issues/10234 | [net] listbanned RPC and QT should show correct banned subnets by jnewbery · Pull Request #10234 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cb007e4346cf...c29a0d48129d
< bitcoin-git> bitcoin/master c36ea69 Karl-Johan Alm: [wallet] Make sure pindex is non-null before possibly referencing in LogPrintf call.
< bitcoin-git> bitcoin/master c29a0d4 Wladimir J. van der Laan: Merge #10265: [wallet] [moveonly] Check non-null pindex before potentially referencing...
< bitcoin-git> [bitcoin] laanwj closed pull request #10265: [wallet] [moveonly] Check non-null pindex before potentially referencing (master...fix-check-pindex-scanforwallettx) https://github.com/bitcoin/bitcoin/pull/10265
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c29a0d48129d...e0a7e1994e6f
< bitcoin-git> bitcoin/master ed60970 Karl-Johan Alm: [test] Test abortrescan command.
< bitcoin-git> bitcoin/master e0a7e19 Wladimir J. van der Laan: Merge #10225: [test] Add aborttrescan tests...
< bitcoin-git> [bitcoin] laanwj closed pull request #10225: [test] Add aborttrescan tests (master...abort-rescan-tests) https://github.com/bitcoin/bitcoin/pull/10225
< bitcoin-git> [bitcoin] mm-s opened pull request #10277: Improved efficiency in constructors of COutPoint (master...master) https://github.com/bitcoin/bitcoin/pull/10277
< cfields> jnewbery: too late to second the request having GetBanned call SweepBanned there? I think that's the right thing to do
< bitcoin-git> [bitcoin] jimmysong opened pull request #10278: [test] Add Unit Test for GetListenPort (master...test_listenport) https://github.com/bitcoin/bitcoin/pull/10278
<@wumpus> cfields: jnewbery had already agreed with that, just he still had some concern: https://github.com/bitcoin/bitcoin/pull/10234#issuecomment-295354958
< cfields> wumpus: right, I just didn't want to set him back since I didn't follow-up then. Will respond there now.
< jnewbery> ok, thanks cfields. Not too late to change this
<@wumpus> never too late
< BlueMatt> for those who follow fibre, rebased on 0.14.1 with two small bug fixes and local device support: https://github.com/bitcoinfibre/bitcoinfibre/releases/tag/v0.14.1-fibre0.7
<@wumpus> nice
< BlueMatt> (ie you can write to a named pipe)
< BlueMatt> or read
< sipa> BlueMatt: finally support for rfc 1149
< BlueMatt> well you can already do that, but now we support FIBREoAC directly, no need for the pesky overhead of IP
< sipa> well with P2P over IP over avian carrier you'd get ping timeouts
< BlueMatt> ah, suppose you would via native FIBRE as well, indeed, i guess you need the local device support either way
< cfields> sipa: probably more efficient for the avian carriers to tweet.
< sipa> benchmarking libsecp256k1 signature validation, there is hardly any advantage for using hyperthreading cores
< sipa> that doesn't mean there is no advantage for HT cores in bitcoin block validation, as ECDSA verification isn't the only thing involved
< gmaxwell> sipa: what are you benchmarking on? because I saw non-trivial advantages before.
< sipa> laptop, which is thermally throttled
< sipa> though the effect is immediate
< gmaxwell> wait you said hardly, how little is hardly. I would call 3% a lot.
< sipa> oh, i would call 50% a lot
< sipa> it's more like 5% benefit
< gmaxwell> I'm doubtful 50% is really possible even with memory latency bound workloads, you'll bottleneck the instruction decoder.
< BlueMatt> gmaxwell: lol, fucking x86 and its instruction decompressor
< gmaxwell> BlueMatt: you mean icache expander. :P
< gmaxwell> Cache doubler technology.
< BlueMatt> lol
< BlueMatt> yea
< BlueMatt> I'm surprised their marketing material doesnt refer to x86 as "effecient instruction stream compression to double cache performance"
< gmaxwell> IIRC one of the extensions for riscv is an explicit instruction stream compression.
< BlueMatt> lol
< ryan-c> I told bitcoind 0.14.0 to shutdown via bitcoin-cli over four hours ago, and it's still running. strace shows it waiting on a futex call. Is there anything I should do before sending it a kill -9? The system is not low on memory.
< BlueMatt> ryan-c: a gdb "thread apply all bt" would be nice
< ryan-c> BlueMatt: Can you walk me through that?
< ryan-c> installing gdb one sec
< BlueMatt> ryan-c: do you have a copy of the binary you are running (and does it have debug symbols)?
< BlueMatt> if not, just kill -9, not much to be had
< ryan-c> BlueMatt: It's the binary release from bitcoin.org, sha256sum 860a046514961aeead8b640f1a321da8eb575d727fd8c37de5a4cee5908bbd9d
< ryan-c> `file` says the binary is stripped
< ryan-c> waiting to for you to confirm there's nothing useful to dump before killing it
< gmaxwell> ryan-c: 0.14.0? are you using addnode?
< BlueMatt> ohoh, .1, duh
< ryan-c> gmaxwell: yes, i am using addnode
< BlueMatt> yea, kill -9
< BlueMatt> known issue, fixed in .1
< gmaxwell> ryan-c: known issue, run 0.14.1
< gmaxwell> If you have more than 8 addnode peers it can get stuck in shutdowin in 0.14.0
< ryan-c> gmaxwell: okay, cool thanks - I was shutting it down to replace with 0.14.1
< gmaxwell> it's harmless to kill it.
< gmaxwell> Sorry about that.
< BlueMatt> can we close #10209 now that we fixed the "regenerate bitcoin-config.h" issue and #10210 now that #10215 is merged?
< gribble> https://github.com/bitcoin/bitcoin/issues/10209 | Stalled shutdown · Issue #10209 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10210 | Frozen (for 15 minutes) on shutdown · Issue #10210 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/10215 | Check interruptNet during dnsseed lookups by TheBlueMatt · Pull Request #10215 · bitcoin/bitcoin · GitHub
< ryan-c> I'm not getting peers automatically from my testnet node
< ryan-c> last time i ended up manually running
< ryan-c> host testnet-seed.bitcoin.jonasschnelli.ch | grep ' has address ' | awk '{print$4}' | xargs -n1 -I IP bitcoin-cli -testnet addnode IP add
< ryan-c> to get it online
< ryan-c> is there something else I should do instead?
< jonasschnelli> testnet-seed.bitcoin.jonasschnelli.ch should be up and running... do you use tor?
< ryan-c> I do not use tor.
< jonasschnelli> Hmm.. maybe pastebin your debug.log
< jonasschnelli> You should see what seeders where asked to retrieve addrs.
< ryan-c> jonasschnelli: it's like 10MB, wanna give me something to grep for?
< jonasschnelli> let me look...
< jonasschnelli> Maybe check for "DNS seeds"
< ryan-c> I have a message that DNS seeding is disabled
< ryan-c> oh
< ryan-c> Okay, well that's probably because for not-testnet I've got peers explicitly configred via connect=
< ryan-c> starting with -forcednsseed should resolve?
< jonasschnelli> Ah.. yes. connect= will bypass seeders.
< BlueMatt> just addnode a few public seeds
< BlueMatt> testnet is usually otherwise broken
< ryan-c> -forcednsseed does not fix it
< ryan-c> -forcednsseed -dnsseed gives me the message '130 addresses found from DNS seeds', but i'm not seeing it actually connect
< gmaxwell> ryan-c: I'm confused by your comments, if you use connect you won't automatically connect to anyone else.
< ryan-c> gmaxwell: It won't automatically connect to anyone else even if I manually enable dnsseed?
< gmaxwell> ryan-c: -connect's purpose is to disable automatic connection generation completely.
< ryan-c> ah
< sipa> gmaxwell: better benchmark with fixed CPU frequency now, it's more like 14% faster with 8 threads in parallel than 4
< sipa> (secp256k1 only, so no memory effects)