< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/88799ea1b1c0...703202180bde
< bitcoin-git> bitcoin/master dd7e43e John Newbery: Fix build warning from #error text
< bitcoin-git> bitcoin/master 7032021 Wladimir J. van der Laan: Merge #10168: Fix build warning from #error text...
< bitcoin-git> [bitcoin] laanwj closed pull request #10168: Fix build warning from #error text (master...fixbuildwarning) https://github.com/bitcoin/bitcoin/pull/10168
< sipa> oh great, i just wanted to create a PR for that
< wumpus> always check which PRs already exist :)
< sipa> this is good advice
< gmaxwell> I wish there were like a local ncurses interface to this stuff... so slow to check via the browser. :P
< midnightmagic> It's all available via the github API isn't it?
< paveljanik> git interface to the issues and PRs would be nice. And git grep over it ;-)
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/703202180bde...ed09dd3f5a87
< bitcoin-git> bitcoin/master bf10264 Russell Yanofsky: Run bitcoin_test-qt under minimal QPA platform...
< bitcoin-git> bitcoin/master ed09dd3 Wladimir J. van der Laan: Merge #10142: Run bitcoin_test-qt under minimal QPA platform...
< bitcoin-git> [bitcoin] laanwj closed pull request #10142: Run bitcoin_test-qt under minimal QPA platform (master...pr/qtmin) https://github.com/bitcoin/bitcoin/pull/10142
< wumpus> gmaxwell: yes please!
< wumpus> I've always wanted a github ncurses client, but never got around to building one. Same for travis, the website can be so slow especially for large logs
< wumpus> and not having to switch form console to browser all the time would be a productivity win
< wumpus> though it's possible to at least view the logs inthe console: https://github.com/bitcoin/bitcoin/pull/10159#issuecomment-292102755 however to get the identifiers you still need to visit the website
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ed09dd3f5a87...813eacf81b73
< bitcoin-git> bitcoin/master bcca57e practicalswift: [trivial] Fix typo ("improssible" → "impossible")
< bitcoin-git> bitcoin/master 813eacf Wladimir J. van der Laan: Merge #10167: [trivial] Fix typo ("improssible" → "impossible")...
< bitcoin-git> [bitcoin] laanwj closed pull request #10167: [trivial] Fix typo ("improssible" → "impossible") (master...improssible) https://github.com/bitcoin/bitcoin/pull/10167
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/813eacf81b73...64962aecb6be
< bitcoin-git> bitcoin/master 9eaf718 Pavel Janík: Ignore Doxyfile generated from Doxyfile.in template.
< bitcoin-git> bitcoin/master 64962ae Wladimir J. van der Laan: Merge #10166: Ignore Doxyfile generated from Doxyfile.in template....
< bitcoin-git> [bitcoin] laanwj closed pull request #10166: Ignore Doxyfile generated from Doxyfile.in template. (master...20170407_gitignoreDoxyfile) https://github.com/bitcoin/bitcoin/pull/10166
< midnightmagic> Hrm. Wasn't someone mirroring all that data in case Github goes crazy?
< midnightmagic> .. who then said they were going to start again since I said the exact same thing already and they said they were but then stopped but should start up again..
< bitcoin-git> [bitcoin] practicalswift opened pull request #10175: Remove excess logic. (master...excess-logic) https://github.com/bitcoin/bitcoin/pull/10175
< wumpus> midnightmagic: yes, the github info is being mirrored https://github.com/zw/bitcoin-gh-meta
< midnightmagic> \o/
< midnightmagic> ah, I'm already mirroring the mirror. well, there we go.
< wumpus> I'm also mirroring it, though not publicly
< wumpus> it would be nice to mirror it on an online accessible repository that is not on github. Right now, if github is down, most will not be able to access it.
< wumpus> haven't looked at what this gitlab fuss is about
< midnightmagic> there's a gitlab fuss?
< midnightmagic> They hired a bunch of people away from companies I know about, but I think that was just people jumping from a sinking ship.
< wumpus> fuss=heard it come up in unrelated discussions here and there
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/64962aecb6be...1fa4ae67a330
< bitcoin-git> bitcoin/master 9ab9e7d Eric Shaw Jr: Add a button to open the config file in a text editor
< bitcoin-git> bitcoin/master 1fa4ae6 Jonas Schnelli: Merge #9890: Add a button to open the config file in a text editor...
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #9890: Add a button to open the config file in a text editor (master...master) https://github.com/bitcoin/bitcoin/pull/9890
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1fa4ae67a330...51833a17347f
< bitcoin-git> bitcoin/master e9ff818 Allan Doensen: Fix for issues with startup and multiple monitors on windows.
< bitcoin-git> bitcoin/master 51833a1 Wladimir J. van der Laan: Merge #10156: Fix for issues with startup and multiple monitors on windows....
< bitcoin-git> [bitcoin] laanwj closed pull request #10156: Fix for issues with startup and multiple monitors on windows. (master...masterMultiMonFix) https://github.com/bitcoin/bitcoin/pull/10156
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/51833a17347f...a27dbc55b1aa
< bitcoin-git> bitcoin/master 218d915 practicalswift: [bench] Avoid function call arguments which are pointers to uninitialized values
< bitcoin-git> bitcoin/master a27dbc5 Wladimir J. van der Laan: Merge #9949: [bench] Avoid function call arguments which are pointers to uninitialized values...
< bitcoin-git> [bitcoin] laanwj closed pull request #9949: [bench] Avoid function call arguments which are pointers to uninitialized values (master...avoid-pointers-to-unitialized-values-in-function-calls) https://github.com/bitcoin/bitcoin/pull/9949
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a27dbc55b1aa...e19586a8a955
< bitcoin-git> bitcoin/master 5d08c9c John Newbery: Send the correct error code in reject messages
< bitcoin-git> bitcoin/master e19586a Wladimir J. van der Laan: Merge #10135: [p2p] Send the correct error code in reject messages...
< bitcoin-git> [bitcoin] laanwj closed pull request #10135: [p2p] Send the correct error code in reject messages (master...correctrejectmessages) https://github.com/bitcoin/bitcoin/pull/10135
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e19586a8a955...e183ea2047b3
< bitcoin-git> bitcoin/master 3491476 Kewde: Wallet: reduce excess logic InMemPool()...
< bitcoin-git> bitcoin/master e183ea2 Wladimir J. van der Laan: Merge #10164: Wallet: reduce excess logic InMempool()...
< bitcoin-git> [bitcoin] laanwj closed pull request #10164: Wallet: reduce excess logic InMempool() (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10164
< bitcoin-git> [bitcoin] mrwhythat closed pull request #10161: Support for Tor's Single Onion Service (master...tor-single-onion-service) https://github.com/bitcoin/bitcoin/pull/10161
< cfields> BlueMatt: ping
< cfields> BlueMatt: i need some hints about locks in 9725. Trying to give it a final ACK.
< cfields> oh, heh
< cfields> BlueMatt: unping. locking in 461e49fee29 looked wonky. But the next commit addresses it. all good.
< bitcoin-git> [bitcoin] theuni opened pull request #10176: net: gracefully handle NodeId wrapping (master...nodeid-no-wrap) https://github.com/bitcoin/bitcoin/pull/10176
< bitcoin-git> [bitcoin] KibbledJiveElkZoo opened pull request #10177: Changed "Send" button default status from true to false (master...ui_fixes) https://github.com/bitcoin/bitcoin/pull/10177
< jtimon> weird, for some reason travis didn't checked https://github.com/bitcoin/bitcoin/pull/9494 after last rebase
< BlueMatt> cfields: cool, thanks
< BlueMatt> cfields: for the avoidance of doubt on #10176, can we also make it a int64?
< gribble> https://github.com/bitcoin/bitcoin/issues/10176 | net: gracefully handle NodeId wrapping by theuni · Pull Request #10176 · bitcoin/bitcoin · GitHub
< BlueMatt> that way at least any api callers wont get confused
< cfields> BlueMatt: wrt the ip->int32 representation, you mean?
< cfields> *ipv4
< BlueMatt> hmm? no, NodeId int64_t
< BlueMatt> cfields: ahh, ok, so to clarify, i mean if an api caller meant to refer to an old node, but the NodeId got wrapped
< BlueMatt> so it accidentally refers to a new node
< BlueMatt> better to use int64_ts because then the likelyhood of the issue is super, super, super tiny
< BlueMatt> or just switch to 64 bit and not make any other changes
< BlueMatt> :)
< BlueMatt> 29 billion connections per second for 10 years...I think we'll be ok
< cfields> BlueMatt: oh, that.
< cfields> sure
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10178: Remove CValidationInterface::UpdatedTransaction (master...2017-01-wallet-cache-inmempool-2) https://github.com/bitcoin/bitcoin/pull/10178
< BlueMatt> only 3 more prs to go to get wallet-update-in-background, but at least ^ is only one commit, the following 2 are a bit more
< BlueMatt> :)
< bitcoin-git> [bitcoin] laanwj pushed 13 new commits to master: https://github.com/bitcoin/bitcoin/compare/e183ea2047b3...67023e9004ba
< bitcoin-git> bitcoin/master f5e9a01 Matt Corallo: Include missing #include in zmqnotificationinterface.h
< bitcoin-git> bitcoin/master 822000c Matt Corallo: Add pblock to connectTrace at the end of ConnectTip, not start...
< bitcoin-git> bitcoin/master 29e6e23 Matt Corallo: Make ConnectTrace::blocksConnected private, hide behind accessors
< bitcoin-git> [bitcoin] laanwj closed pull request #9725: CValidationInterface Cleanups (master...2017-01-wallet-cache-inmempool-1) https://github.com/bitcoin/bitcoin/pull/9725
< warren> Are there 0.14.1rc1 binaries?
< Lauda> Why is it called test.rc1?
< MarcoFalke> It is a release candidate for testing purposes.
< Lauda> Ah, I thought 0.14.1 was final already. My bad
< * cfields> smacks BlueMatt with an optional parameter
< BlueMatt> whad I do?
< cfields> oh wait, those aren't new. They were just in the header before
< BlueMatt> yeayea
< BlueMatt> just move-only
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10179: Give CValidationInterface Support for calling notifications on the CScheduler Thread (master...2017-01-wallet-cache-inmempool-3) https://github.com/bitcoin/bitcoin/pull/10179
< cfields> yep, it just wasn't obvious from the diff. nm.
< BlueMatt> k
< bitcoin-git> [bitcoin] practicalswift opened pull request #10180: [trivial] Fix typos (tempoarily → temporarily, inadvertantly → inadvertently) (master...inadvertantly-and-tempoarily) https://github.com/bitcoin/bitcoin/pull/10180
< jcorgan> jonasschnelli: is there a bip150 work-in-progress branch anywhere?
< cfields> BlueMatt: for #10178, is it necessary for NotifyTransactionChanged to be under the same cs_main/wallet lock? or just might as well?
< gribble> https://github.com/bitcoin/bitcoin/issues/10178 | Remove CValidationInterface::UpdatedTransaction by TheBlueMatt · Pull Request #10178 · bitcoin/bitcoin · GitHub
< BlueMatt> probably not neccessary, i assume, given the old version was not
< BlueMatt> oh, wait, no, it was under the same lock previously
< BlueMatt> anyway, i astill assume not, but easier to not change that
< BlueMatt> iirc its +/- only for gui
< cfields> ok, wasn't sure if this was fixing another wallet race issue as well, or just tidying up the interface.
< BlueMatt> i do not believe there is a race except the one described in the commit message
< BlueMatt> (ie coinbase payout immediately prior to restart, restart
< cfields> roger