< bitcoin-git> [bitcoin] dusty-wil opened pull request #11465: rpc: Update named args documentation for importprivkey (master...master) https://github.com/bitcoin/bitcoin/pull/11465
< bitcoin-git> [bitcoin] MeshCollider opened pull request #11466: [WIP] Specify custom wallet directory with -walletdir param (master...201710_walletdir) https://github.com/bitcoin/bitcoin/pull/11466
< bitcoin-git> [bitcoin] practicalswift opened pull request #11467: Fix typos. Use nullptr instead of NULL. Use quote form for local includes. (master...cleanups-20171009) https://github.com/bitcoin/bitcoin/pull/11467
< bitcoin-git> [bitcoin] jnewbery opened pull request #11468: [tests] Make comp test framework more debuggable (master...comp_test_debuggable) https://github.com/bitcoin/bitcoin/pull/11468
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/17f2acedbe07...d473e6ddc55c
< bitcoin-git> bitcoin/master ce2418f Cristian Mircea Messel: [gui] reset addrProxy/addrSeparateProxyTor if colon char missing...
< bitcoin-git> bitcoin/master d473e6d Wladimir J. van der Laan: Merge #11448: [gui] reset addrProxy/addrSeparateProxyTor if colon char missing...
< bitcoin-git> [bitcoin] laanwj closed pull request #11448: [gui] reset addrProxy/addrSeparateProxyTor if colon char missing (master...ensure_colon_in_proxies_qsettings_storage) https://github.com/bitcoin/bitcoin/pull/11448
< promag> wumpus: addrProxy and addrSeparateProxyTor are always loaded with qsettings, and qsettings supports external changes
< promag> just saying.. I know that changing the settings externally is bad usage
< promag> For reference see http://doc.qt.io/qt-5/qsettings.html#sync
< wumpus> promag: addrProxy and addrSeparateProxy are only loaded *from* the qsettings in the constructor, right?
< promag> no
< wumpus> I know qsettings can be updated extenrally, but we don't pay attention to changes in the qsettings after the initial start
< wumpus> then what triggers a re-load of settings from qsettings to bitcoin core settings?
< promag> doesn't matter, qsettings will refresh it's internal data
< wumpus> I know , but we don't look at that
< wumpus> we don't care about qsettings internal data
< wumpus> we don't parse it
< promag> I know, but then in runtime we do settings.value("addrProxy").toString().split(":")
< wumpus> after the one0-time constructor of the optionsmodel
< wumpus> oh really? crap
< wumpus> that shouldn't be the case
< promag> that was my point, sorry if I didn't explain it well
< wumpus> goddamnit that code is crap
< promag> in the constructor we only sanitize
< promag> I can submit a PR dealing with qsettings.value()
< wumpus> yeah, probably shouldn't even have merged this
< wumpus> it's that it had so many acks
< promag> either we store in memory the value or we validate the (possible new) qsettings.value
< promag> it has mine too
< wumpus> it would take so much to handle external changes to qsettings sanely
< wumpus> and as I mentioned I don't think this was an issue worth fixing in any case
< wumpus> there's tons of ways to crash bitcoin with corrupted settings
< promag> can be improved for sure
< wumpus> but is it any kind of goal? why?
< wumpus> please, let's focus on things that matter
< wumpus> there's 240 PRs open, more every day
< wumpus> no one can review all of this, there's not even any getting started to it anymore
< bitcoin-git> [bitcoin] laanwj closed pull request #10907: Prefer iterators arrow operator over iterator dereference (master...20170722-refactor-arrow-1) https://github.com/bitcoin/bitcoin/pull/10907
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d473e6ddc55c...da0478e6e5d9
< bitcoin-git> bitcoin/master c6a995e practicalswift: Improve readability of DecodeBase58Check(...)
< bitcoin-git> bitcoin/master da0478e Wladimir J. van der Laan: Merge #10961: Improve readability of DecodeBase58Check(...)...
< bitcoin-git> [bitcoin] laanwj closed pull request #10961: Improve readability of DecodeBase58Check(...) (master...DecodeBase58Check-cleanup) https://github.com/bitcoin/bitcoin/pull/10961
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/da0478e6e5d9...3a93270c5587
< bitcoin-git> bitcoin/master b7dfc6c Daniel Edgecumbe: [rpc] getblockchaininfo: add size_on_disk, prune_target_size, automatic_pruning...
< bitcoin-git> bitcoin/master 3a93270 Wladimir J. van der Laan: Merge #11367: [rpc] getblockchaininfo: add size_on_disk, prune_target_size...
< bitcoin-git> [bitcoin] laanwj closed pull request #11367: [rpc] getblockchaininfo: add size_on_disk, prune_target_size (master...2017-09-getblockchaininfo-addsize) https://github.com/bitcoin/bitcoin/pull/11367
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3a93270c5587...92eadc395071
< bitcoin-git> bitcoin/master aa57590 Dusty Williams: Update importprivkey named args documentation...
< bitcoin-git> bitcoin/master 92eadc3 MarcoFalke: Merge #11465: rpc: Update named args documentation for importprivkey...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11465: rpc: Update named args documentation for importprivkey (master...master) https://github.com/bitcoin/bitcoin/pull/11465
< bitcoin-git> [bitcoin] kanigsson opened pull request #11469: fix typo in comment of chain.cpp (master...typo-fix-in-comment) https://github.com/bitcoin/bitcoin/pull/11469
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/92eadc395071...c63364610f4a
< bitcoin-git> bitcoin/master 5864e9c John Newbery: [tests] remove direct testing on JSONRPCException from individual test cases
< bitcoin-git> bitcoin/master 677d893 John Newbery: [tests] do not allow assert_raises_message to be called with JSONRPCException
< bitcoin-git> bitcoin/master 47ba8cf John Newbery: scripted-diff: rename assert_raises_jsonrpc to assert_raises_rpc error...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #10853: [tests] Fix RPC failure testing (again) (master...cleanup_jsonrpc_asserts) https://github.com/bitcoin/bitcoin/pull/10853
< jimpo> Ping again on #11113
< gribble> https://github.com/bitcoin/bitcoin/issues/11113 | [net] Ignore getheaders requests for very old side blocks by jimpo · Pull Request #11113 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c63364610f4a...e022463a4b23
< bitcoin-git> bitcoin/master 46b752a fanquake: [depends] native_mac_alias 2.0.6
< bitcoin-git> bitcoin/master f617d1b fanquake: [depends] native_ds_store 1.1.2
< bitcoin-git> bitcoin/master e022463 Jonas Schnelli: Merge #11460: [depends] mac_alias 2.0.6, ds_store 1.1.2...
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #11460: [depends] mac_alias 2.0.6, ds_store 1.1.2 (master...update-mac-alias) https://github.com/bitcoin/bitcoin/pull/11460
< jonasschnelli> wumpus: I think #11113 is RTM
< gribble> https://github.com/bitcoin/bitcoin/issues/11113 | [net] Ignore getheaders requests for very old side blocks by jimpo · Pull Request #11113 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #11471: [Qt] Optimize SendToSelf rendering with a single non-change output (master...2017/10/qt_sendtoself) https://github.com/bitcoin/bitcoin/pull/11471
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #11472: qa: Make tmpdir option an absolute path (master...Mf1710-qaMultiwalletRelDir) https://github.com/bitcoin/bitcoin/pull/11472