< bitcoin-git> [bitcoin] jnewbery opened pull request #11513: [trivial] [tests] A few Python3 tidy ups (master...authproxy_tidyups) https://github.com/bitcoin/bitcoin/pull/11513
< aj> jtimon: re: getblockstats rpc tests, aren't tx sizes non-deterministic due to the signatures sometimes being a byte short due to a leading \x00 getting skipped due to DER encoding?
< jtimon> aj: oh, right, that must be it...
< jtimon> isn't there a way to solve that?
< sipa> aj: how does thatmake them nondeterministic?
< sipa> DER is deterministic
< sipa> or you mean the low-S malleability?
< gmaxwell> sipa: I think he thinks the signature is non-determinstic?
< aj> sipa: running the same test case repeatedly doesn't generate the same R each time does it?
< gmaxwell> it will if the transaction is the same.
< gmaxwell> (and key)
< sipa> aj: you can always choose to create a tx with a larger or smaller sig
< sipa> by grinding
< sipa> but if you have an actual tx, the serialization of that sig is fixed
< aj> sipa: ack. but the test suite doesn't ensure it produces a deterministic chain, so txes will vary between test suite runs, yes/no?
< sipa> no, our own signing is deterministic
< sipa> you can't assume that other's signatures are - but the ones we create ourselves are
< aj> sipa: okay, again, correct me if i'm wrong, but i'm seeing "self.nodes[0].getnewaddress()" giving different results between test_runner.py invocations, which (even despite deterministic signing) should result in non-deterministic tx sizes aiui
< sipa> aj: oh, sure
< sipa> if the the transaction isn't the same
< aj> sipa: yeah. i wasn't following whether the implication was that there was meant to be deterministic generation of addresses/chains to have the test suite results be deterministic
< sipa> aj: i just read some more context of the discussion, i wasn't aware you were talking about entire tests being deterministic
< bitcoin-git> [bitcoin] promag opened pull request #11514: Iterate and remove nodes without container copy (master...201710-node-iterate-and-erase) https://github.com/bitcoin/bitcoin/pull/11514
< bitcoin-git> [bitcoin] promag opened pull request #11515: Assert cs_main is held when retrieving node state (master...201710-node-state-guard) https://github.com/bitcoin/bitcoin/pull/11515
< bitcoin-git> [bitcoin] practicalswift opened pull request #11516: crypto: Avoid creating of one-past-the-end pointer and performing a noop memset call (HMAC-SHA{256,512}) (master...one-past-the-end) https://github.com/bitcoin/bitcoin/pull/11516
< bitcoin-git> [bitcoin] simonmulser closed pull request #11510: Net: Log when peer reached MAX_BLOCKS_IN_TRANSIT_PER_PEER (master...add_log) https://github.com/bitcoin/bitcoin/pull/11510
< pedrobranco> Hello, any change of getting https://github.com/bitcoin/bitcoin/pull/11483 merged soon since it's a bug in importmulti?
< jonasschnelli> pedrobranco: Needs more reviews first..
< jonasschnelli> Is it something we want to backport, right?
< pedrobranco> jonasschnelli: Yes it needs more reviews.
< bitcoin-git> [bitcoin] martinus opened pull request #11517: Tests: Improve benchmark precision by inlining performance critical code (master...improved-benchmarking) https://github.com/bitcoin/bitcoin/pull/11517
< jonasschnelli> pedrobranco: I guess another one and we'll be fine. Its a simple change
< pedrobranco> jonasschnelli: ty
< BlueMatt> #11483 could get a merge, imo, dunno if anyone merging is around today, though
< gribble> https://github.com/bitcoin/bitcoin/issues/11483 | Fix importmulti bug when importing an already imported key by pedrobranco · Pull Request #11483 · bitcoin/bitcoin · GitHub
< mess110> hi, working on adding a proxy icon, wanted to ask for feedback.
< mess110> it is made out of chevron-left and 3 device-desktop from http://s-ings.com/typicons/
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/2c66cea2d186...14b860bf6402
< bitcoin-git> bitcoin/master fc0176d John Newbery: [tests] use python3 for authproxy.py
< bitcoin-git> bitcoin/master 323d8f6 John Newbery: [tests] fix flake8 warnings in authproxy.py
< bitcoin-git> bitcoin/master 8f9e362 John Newbery: [tests] authproxy.py: tidy up __init__()
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11513: [trivial] [tests] A few Python3 tidy ups (master...authproxy_tidyups) https://github.com/bitcoin/bitcoin/pull/11513
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/14b860bf6402...808c84f89d0e
< bitcoin-git> bitcoin/master a44a215 Pedro Branco: Fix importmulti bug when importing an already imported key
< bitcoin-git> bitcoin/master 808c84f MarcoFalke: Merge #11483: Fix importmulti bug when importing an already imported key...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #11483: Fix importmulti bug when importing an already imported key (master...bugfix/fix-importmulti-bug) https://github.com/bitcoin/bitcoin/pull/11483
< cfields> sipa: i forget your preference. You like a github review (batch), or individual comments?
< BlueMatt> cfields: for the sake of (most peoples') inbox, batch
< cfields> heh, fair enough. iirc someone complained about the batches because it screwed up their workflow.
< cfields> hmm, maybe that was you, with your online/offline split?
< sdaftuar> cfields: i'm thinking about adding a way to mock out addrman for the purposes of regtest-testing our outbound peer logic. does that sound like a reasonable thing to do?
< cfields> sdaftuar: yep! I've already got it halfway done, though...
< sdaftuar> oh, cool
< sdaftuar> any chance you have a commit i can steal then? :)
< cfields> heh, it's just waiting on #11457
< gribble> https://github.com/bitcoin/bitcoin/issues/11457 | Introduce BanMan by theuni · Pull Request #11457 · bitcoin/bitcoin · GitHub
< cfields> sure
< cfields> it's broken out the same way
< cfields> sdaftuar: will push it up tonight, need to clean up/rebase
< sdaftuar> cool, thanks. i'll takea look at 11457
< bitcoin-git> [bitcoin] jnewbery opened pull request #11518: [WIP] [tests] Simplify/clarify the NodeConn/NodeConnCB mininode classes (master...node_conn_big_refactor) https://github.com/bitcoin/bitcoin/pull/11518
< promag> jnewbery: where is P2PInterface?
< promag> nevermind 1st question