< bitcoin-git> [bitcoin] promag closed pull request #10966: Add walletnotify functional test (master...2017-07-walletnotify-functional-test) https://github.com/bitcoin/bitcoin/pull/10966
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e022463a4b23...5a9da37fb3f4
< bitcoin-git> bitcoin/master f902e40 Johannes Kanig: fix typo in comment of chain.cpp
< bitcoin-git> bitcoin/master 5a9da37 Wladimir J. van der Laan: Merge #11469: fix typo in comment of chain.cpp...
< bitcoin-git> [bitcoin] laanwj closed pull request #11469: fix typo in comment of chain.cpp (master...typo-fix-in-comment) https://github.com/bitcoin/bitcoin/pull/11469
< fanquake> wumpus are you able to merge #7 on the univalue repo. The same change had ACKs from sipa and gmaxwell in #6 if your waiting for more reviewers.
< gribble> https://github.com/bitcoin/bitcoin/issues/7 | Block-header-only, faster startup client · Issue #7 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/6 | Treat wallet as a generic keystore · Issue #6 · bitcoin/bitcoin · GitHub
< fanquake> Then we can review and merge #11420 on the main repo.
< gribble> https://github.com/bitcoin/bitcoin/issues/11420 | Bump univalue subtree and fix json formatting in tests by MarcoFalke · Pull Request #11420 · bitcoin/bitcoin · GitHub
< sipa> fanquake: will do tomorrow
< fanquake> sipa cheers
< thermoman> the contents of https://bitcoin.org/bin/bitcoin-core- is in a subdirectory named "bitcoin-0.15.0".
< thermoman> that's bad since the version in the extracted directory is not exacly the version of the archive file
< thermoman> this adds confusion, especially if you had extracted bitcoin-0.15.0.tar.gz earlier
< thermoman> % tar tf bitcoin- | head -n 1
< thermoman> bitcoin-0.15.0/
< Guest81526> Chico then?
< hardik_> hi
< jnewbery> #7061 should be merged soon. It's been reviewed to death. Perhaps reACKs from ryanofsky kallewoof if they're still interested.
< gribble> https://github.com/bitcoin/bitcoin/issues/7061 | [Wallet] Add RPC call "rescanblockchain " by jonasschnelli · Pull Request #7061 · bitcoin/bitcoin · GitHub
< GAit> wumpus: just noticed an error in the release notes for 0.15.0/ not sure if already reported: "maximumCount - a number specifying the minimum number of UTXOs" - minimum vs maximum
< promag> GAit: IIRC that was already detected
< instagibbs> yes there's already a PR for a fix
< promag> jnewbery: regarding #7061, at the moment the RPC can block a lot of time
< gribble> https://github.com/bitcoin/bitcoin/issues/7061 | [Wallet] Add RPC call "rescanblockchain " by jonasschnelli · Pull Request #7061 · bitcoin/bitcoin · GitHub
< promag> do you think this can be avoided in followups?
< bitcoin-git> [bitcoin] thomasstep opened pull request #11474: Fixing pointer asterisk (master...TypoFix) https://github.com/bitcoin/bitcoin/pull/11474
< bitcoin-git> [bitcoin] mess110 closed pull request #11455: CTxMemPool::GetMinFee should not return CFeeRate(0) (master...fix_mempool_GetMinFee_bug_returning_below_minRelayTxFee) https://github.com/bitcoin/bitcoin/pull/11455
< bitcoin-git> [bitcoin] mess110 opened pull request #11475: [rpc] mempoolinfo should take ::minRelayTxFee into account (master...include_minRelayTxFee_in_getmempoolinfo_rpc) https://github.com/bitcoin/bitcoin/pull/11475
< jnewbery> promag: I don't think that's a showstopper, but others may feel differently. Perhaps it can be addressed in a follow-up PR
< jonasschnelli> promag: Yes. 7061 is blocking...Its not directly related to this PR. See #11281 for an possible improvement of the rescan locking
< gribble> https://github.com/bitcoin/bitcoin/issues/11281 | Avoid pemanent cs_main/cs_wallet lock during RescanFromTime by jonasschnelli · Pull Request #11281 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #11474: Fixing pointer asterisk (master...TypoFix) https://github.com/bitcoin/bitcoin/pull/11474
< bitcoin-git> [bitcoin] ryanofsky opened pull request #11476: Avoid opening copied wallet databases simultaneously (master...pr/wid) https://github.com/bitcoin/bitcoin/pull/11476
< meshcollider> jnewbery: do you have time to discuss some of your points in #11466? Re: moving GetWalletDir() out of utils.cpp, is there already a wallet util file you'd suggest moving it too, or I should create one?
< gribble> https://github.com/bitcoin/bitcoin/issues/11466 | [WIP] Specify custom wallet directory with -walletdir param by MeshCollider · Pull Request #11466 · bitcoin/bitcoin · GitHub
< meshcollider> I still haven't fully thought through where to put the initial directory creation stuff, to move it out of the GetDataDir function and allow the path caching to be removed
< meshcollider> So if I made a InitDataDir() function to call just once on initialization, which would check for datadir existence and make default one if it doesn't exist, that should store the data directory path and just return it on GetDataDir()
< meshcollider> But we want to create the wallet dir on first run, so should a wallets/ directory always be created when the datadir is? Or is that still too much mixing of server + wallet stuff?
< esotericnonsense> meshcollider: I haven't looked at the code; when/where is wallet.dat opened and written for the first time? that seems like a natural point?
< esotericnonsense> (you don't need a wallets folder until you actually have something to put in it)
< esotericnonsense> argh I missed a line above gribble's. ignore
< meshcollider> esotericnonsense: the problem is that you only want to create a wallets/ folder if this is the first run, because otherwise you'll already have a wallet.dat in the datadir root which would get ignored from that point on
< meshcollider> And from what I can think, the best way to know if this is a first-run is if we are creating the datadir too
< meshcollider> Hmm perhaps it should go in wallet/init.cpp?
< meshcollider> Also wanted to discuss how best to list `available` wallets without relying on .dat extension
< meshcollider> Relying*
< promag> meshcollider: I would like some feedback here https://github.com/bitcoin/bitcoin/pull/11466#discussion_r143733780
< meshcollider> I'm personally unsure on motivation, it was just suggested by John in the comment he linked
< meshcollider> Because of the point wumpus made in the OP
< promag> let me check
< promag> wumpus point on backups?
< promag> I still don't see the point. It's not possible to create new wallets via RPC. I really think it's noise for your PR. cc @jnewbery
< meshcollider> Could be yeah, I'll see what they say 👍