< bitcoin-git> [bitcoin] richardkiss opened pull request #12600: Add a test for large tx output scripts with segwit input. (master...feature/segwit_big_txout_script) https://github.com/bitcoin/bitcoin/pull/12600
< larafale> sipa_: thx a lot pieter
< larafale> luke-jr: also thx, appreciate the feedbacks :)
< Popkultur> Hi, just a question: What about bit rot on the blockchain? This might not yet be an issue, but there might be a good idea to implement some sort of error checking algorithm which consolidates historical blocks by p2p?
< Popkultur> okay, thinking further I guess this already happens by downloading a fresh copy of the blockchain. And there are checksums, too.
< jojeyh> kek
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to 0.16: https://github.com/bitcoin/bitcoin/compare/a17fecfdf0d7...72a3290c9012
< bitcoin-git> bitcoin/0.16 25afebc fanquake: depends: Switch expat download to GitHub
< bitcoin-git> bitcoin/0.16 72a3290 MarcoFalke: Merge #12585: [0.16] depends: Switch to downloading expat from GitHub...
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6012f1caf744...480f42630cbd
< bitcoin-git> bitcoin/master d918eb7 practicalswift: Fix typos
< bitcoin-git> bitcoin/master 480f426 MarcoFalke: Merge #12543: Fix typos...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12543: Fix typos (master...typos-201802) https://github.com/bitcoin/bitcoin/pull/12543
< eklitzke> bitcoin perf flame graphs w/ annotations (red = system/libc, green = bitcoin, blue = kernel): https://monad.io/flamegraph-annotations.svg
< sipa> i've marked #9037 as high priority for review; it has a few acks, and been waiting for 1.5 years...
< gribble> https://github.com/bitcoin/bitcoin/issues/9037 | net: Add test-before-evict discipline to addrman by EthanHeilman · Pull Request #9037 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/480f42630cbd...ce56fdd2e8cd
< bitcoin-git> bitcoin/master ee04119 Chris Moore: Show a transaction's virtual size in its details dialog.
< bitcoin-git> bitcoin/master ce56fdd MarcoFalke: Merge #12580: Show a transaction's virtual size in its details dialog...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12580: Show a transaction's virtual size in its details dialog (master...show_vsize) https://github.com/bitcoin/bitcoin/pull/12580
< Randolf> MarcoFalke: If you've got a moment, please also see PR #12501 -- after last week's meeting it seems that this should be okay to go, but if you think it needs more peer-review that's fine too.
< gribble> https://github.com/bitcoin/bitcoin/issues/12501 | [qt] Improved "custom fee" explanation in tooltip by randolf · Pull Request #12501 · bitcoin/bitcoin · GitHub
< luke-jr> jonasschnelli: #11383 has 3 ACKs, and your redesign is actually much worse; it'd be nice to not delay it longer :/
< gribble> https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ce56fdd2e8cd...07d2d2a21c50
< bitcoin-git> bitcoin/master fa41d68 MarcoFalke: qa: Fix python TypeError in script.py
< bitcoin-git> bitcoin/master 07d2d2a Wladimir J. van der Laan: Merge #12475: qa: Fix python TypeError in script.py...
< bitcoin-git> [bitcoin] laanwj closed pull request #12475: qa: Fix python TypeError in script.py (master...Mf1802-qaPythonSyntax) https://github.com/bitcoin/bitcoin/pull/12475
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/07d2d2a21c50...21e2670de3bc
< bitcoin-git> bitcoin/master fa94614 MarcoFalke: [doc] dev-notes: Members should be initialized...
< bitcoin-git> bitcoin/master 21e2670 Wladimir J. van der Laan: Merge #12434: [doc] dev-notes: Members should be initialized...
< bitcoin-git> [bitcoin] laanwj closed pull request #12410: [Docs] Updated examples in CONTRIBUTING.md (master...CONTRIBUTING.md) https://github.com/bitcoin/bitcoin/pull/12410
< bitcoin-git> [bitcoin] laanwj closed pull request #12434: [doc] dev-notes: Members should be initialized (master...Mf1802-docDevMemberInit) https://github.com/bitcoin/bitcoin/pull/12434
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/21e2670de3bc...71f56da384af
< bitcoin-git> bitcoin/master 4d14d06 DaveFromBinary: docs: clarified systemd installation instructions in init.md for Ubuntu users....
< bitcoin-git> bitcoin/master 71f56da Wladimir J. van der Laan: Merge #12452: docs: clarified systemd installation instructions in init.md for Ubuntu users....
< bitcoin-git> [bitcoin] laanwj closed pull request #12452: docs: clarified systemd installation instructions in init.md for Ubuntu users. (master...doc-init-updates) https://github.com/bitcoin/bitcoin/pull/12452
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/71f56da384af...9d49dcf9fab3
< bitcoin-git> bitcoin/master 7eb665f Felix Wolfsteller: [Trivial] link mentioned scripted-diff-commit
< bitcoin-git> bitcoin/master 9d49dcf Wladimir J. van der Laan: Merge #12260: [Trivial] link mentioned scripted-diff-commit (developer-doc)...
< bitcoin-git> [bitcoin] laanwj closed pull request #12260: [Trivial] link mentioned scripted-diff-commit (developer-doc) (master...LINK_COMMIT_IN_DOC_DEVNOTES) https://github.com/bitcoin/bitcoin/pull/12260
< bitcoin-git> [bitcoin] fanquake closed pull request #12041: doc: OpenBSD build instructions revamp (master...openbsd-build-revamp) https://github.com/bitcoin/bitcoin/pull/12041
< bitcoin-git> [bitcoin] laanwj closed pull request #10922: New file-partition.md doc describing how to partition files to ensure fast initial blockchain synchronization.. (master...master) https://github.com/bitcoin/bitcoin/pull/10922
< stevenroose> gmaxwell: quick question: do you remember around what time the (txt) document on confidential transaction was published? (the confidential_values.txt)
< sipa> stevenroose: may 2015 iirc
< stevenroose> Phew, that's been some time
< stevenroose> It seems like we're getting closer though :)
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9d49dcf9fab3...cbc1fcf576cd
< bitcoin-git> bitcoin/master 1830784 532479301: Consensus: Fix bug when compiler do not support __builtin_clz*...
< bitcoin-git> bitcoin/master cbc1fcf Wladimir J. van der Laan: Merge #12573: Fix compilation when compiler do not support __builtin_clz*...
< bitcoin-git> [bitcoin] laanwj closed pull request #12573: Fix compilation when compiler do not support __builtin_clz* (master...vs2017) https://github.com/bitcoin/bitcoin/pull/12573
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cbc1fcf576cd...d77b4a7bcf23
< bitcoin-git> bitcoin/master 87c4320 Ken Lee: gitian-build.sh: fix signProg being recognized as two parameters
< bitcoin-git> bitcoin/master d77b4a7 Wladimir J. van der Laan: Merge #12527: gitian-build.sh: fix signProg being recognized as two parameters...
< bitcoin-git> [bitcoin] laanwj closed pull request #12527: gitian-build.sh: fix signProg being recognized as two parameters (master...master) https://github.com/bitcoin/bitcoin/pull/12527
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d77b4a7bcf23...6645eaf0ab30
< bitcoin-git> bitcoin/master 992f568 fanquake: depends: Only use D_DARWIN_C_SOURCE when building miniupnpc on darwin
< bitcoin-git> bitcoin/master 6645eaf Wladimir J. van der Laan: Merge #12466: depends: Only use D_DARWIN_C_SOURCE when building miniupnpc on darwin...
< bitcoin-git> [bitcoin] laanwj closed pull request #12466: depends: Only use D_DARWIN_C_SOURCE when building miniupnpc on darwin (master...fix-miniupnpc-darwin) https://github.com/bitcoin/bitcoin/pull/12466
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6645eaf0ab30...7f999643212d
< bitcoin-git> bitcoin/master 2736c9e practicalswift: Avoid unintentional unsigned integer wraparounds in tests
< bitcoin-git> bitcoin/master 7f99964 Wladimir J. van der Laan: Merge #12516: Avoid unintentional unsigned integer wraparounds in tests...
< bitcoin-git> [bitcoin] laanwj closed pull request #12516: Avoid unintentional unsigned integer wraparounds in tests (master...unsigned-integer-wraparounds-in-tests) https://github.com/bitcoin/bitcoin/pull/12516
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7f999643212d...47a7666dbe38
< bitcoin-git> bitcoin/master 9360f50 Russell Yanofsky: Drop extra script variable in ProduceSignature...
< bitcoin-git> bitcoin/master 47a7666 Wladimir J. van der Laan: Merge #11889: Drop extra script variable in ProduceSignature...
< bitcoin-git> [bitcoin] laanwj closed pull request #11889: Drop extra script variable in ProduceSignature (master...pr/dupvar) https://github.com/bitcoin/bitcoin/pull/11889
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/47a7666dbe38...c8ea91aa1d16
< bitcoin-git> bitcoin/master 0bc095e Randolf Richardson: [qt] Improved "custom fee" explanation in tooltip
< bitcoin-git> bitcoin/master c8ea91a Wladimir J. van der Laan: Merge #12501: [qt] Improved "custom fee" explanation in tooltip...
< bitcoin-git> [bitcoin] laanwj closed pull request #12501: [qt] Improved "custom fee" explanation in tooltip (master...patch-2) https://github.com/bitcoin/bitcoin/pull/12501
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c8ea91aa1d16...d59b8d6aa110
< bitcoin-git> bitcoin/master 9c5a4a6 Matt Corallo: Stop special-casing phashBlock handling in validation for TBV
< bitcoin-git> bitcoin/master d59b8d6 Wladimir J. van der Laan: Merge #11880: Stop special-casing phashBlock handling in validation for TBV...
< bitcoin-git> [bitcoin] laanwj closed pull request #11880: Stop special-casing phashBlock handling in validation for TBV (master...2017-12-tbv-phash) https://github.com/bitcoin/bitcoin/pull/11880
< bitcoin-git> [bitcoin] ajtowns closed pull request #11862: [wip] Network specific conf sections (master...netconf-sections) https://github.com/bitcoin/bitcoin/pull/11862
< bitcoin-git> [bitcoin] ajtowns reopened pull request #11862: [wip] Network specific conf sections (master...netconf-sections) https://github.com/bitcoin/bitcoin/pull/11862
< bitcoin-git> [bitcoin] jamesob opened pull request #12603: [docs] PeerLogicValidation interface (master...jamesob/2018-03-peerlogicvalidation-doc) https://github.com/bitcoin/bitcoin/pull/12603
< bitcoin-git> [bitcoin] eklitzke opened pull request #12604: Add DynamicMemoryUsage() to CDBWrapper to estimate LevelDB memory use (master...leveldb_memory) https://github.com/bitcoin/bitcoin/pull/12604
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d59b8d6aa110...9a75902c568a
< bitcoin-git> bitcoin/master 2b1f794 fanquake: [Depends] Fix Qt build with Xcode 9.2
< bitcoin-git> bitcoin/master 9a75902 Wladimir J. van der Laan: Merge #11995: [depends] Fix Qt build with Xcode 9...
< bitcoin-git> [bitcoin] laanwj closed pull request #11995: [depends] Fix Qt build with Xcode 9 (master...macos-10-13-fix-depends-qt) https://github.com/bitcoin/bitcoin/pull/11995
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9a75902c568a...955fd23517bf
< bitcoin-git> bitcoin/master 55f89da Ben Woosley: Don't test against the mempool min fee information in mempool_limit.py...
< bitcoin-git> bitcoin/master 955fd23 Wladimir J. van der Laan: Merge #12512: Don't test against the mempool min fee information in mempool_limit.py...
< bitcoin-git> [bitcoin] laanwj closed pull request #12512: Don't test against the mempool min fee information in mempool_limit.py (master...fix-min-fee-test) https://github.com/bitcoin/bitcoin/pull/12512
< bitcoin-git> [bitcoin] Sjors closed pull request #12482: [tests] bind functional test nodes to 127.0.0.1 (master...2018/02/test-framework-bind) https://github.com/bitcoin/bitcoin/pull/12482
< bitcoin-git> [bitcoin] Sjors reopened pull request #12482: [tests] bind functional test nodes to 127.0.0.1 (master...2018/02/test-framework-bind) https://github.com/bitcoin/bitcoin/pull/12482
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/955fd23517bf...ed6ae8059cdb
< bitcoin-git> bitcoin/master 874e818 Luke Dashjr: Allow dustrelayfee to be set to zero
< bitcoin-git> bitcoin/master ed6ae80 Wladimir J. van der Laan: Merge #12568: Allow dustrelayfee to be set to zero...
< bitcoin-git> [bitcoin] laanwj closed pull request #12568: Allow dustrelayfee to be set to zero (master...zero_dustrelayfee_opt) https://github.com/bitcoin/bitcoin/pull/12568
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #12606: [depends] Revert "ccache 3.4.1" (master...Mf1803-dependsCCache) https://github.com/bitcoin/bitcoin/pull/12606
< bitcoin-git> [bitcoin] fanquake opened pull request #12607: [WIP] depends: Remove ccache (master...ccache-removal) https://github.com/bitcoin/bitcoin/pull/12607
< theymos> There's some sort of bug related to accounts (which I know you intend to deprecate at some point, but still exist). Bitcointalk.org uses the used-to-be-standard accounts pattern of 'getaccountaddress <account>' & 'getbalance <account>'. Upon upgrading from 0.14.2 to 0.16.0, addresses are being given out by getaccountaddress, but at some point they no longer become associated with the account.
< theymos> I haven't tracked down exactly where the account designation gets lost. I'm just going to take this opportunity to get rid of accounts usage. Though I suppose that other people will run into this problem, since it was the standard pattern some years ago.
< achow101> theymos: can you open an issue on github about that?
< theymos> ok
< ProfMac> Hmm. I kind of liked accounts. Where is the archive discussion about this?
< mlz> ProfMac, look in the logs of this channel
< luke-jr> theymos: getaccountaddress wasn't the standard pattern ever AFAIK; that's going to result in address reuse..
< luke-jr> should be getnewaddress <account>
< theymos> getaccountaddress generates a new address for the account when the old one receives a payment
< luke-jr> yes, which it might not have yet
< luke-jr> liable to give the same address to two people using the website at the same time, and then get paid by both to the same
< midnightmagic> accounts have always been broken, in some way or other. :(
< gmaxwell> luke-jr: that wouldn't happen if each person is a different account.
< gmaxwell> giving one person the same address multiple times until you've seen a payment on the old one isn't _that_ bad.
< theymos> The ideal is probably invoice-based accounting, but that's a huge change from balances-based accounting. So currently bitcointalk.org is just reusing addresses 100%, since getaccountaddress is broken and I don't have time to implement the address-changing thing right now...
< ProfMac> By happenstance, I have 0.8.1 -qt open. When I go to "receive coins" --> "new address" and drop in an existing label, it returns a new address. This occured when only 1 address existed and had received funds, and also when there were multiple addresses, several of which had never received funds.