< bitcoin-git> [bitcoin] sipa opened pull request #12740: Add native support for serializing char arrays without FLATDATA (master...201803_chararray) https://github.com/bitcoin/bitcoin/pull/12740
< meshcollider> wumpus: do you think #4676 should be closed now?
< gribble> https://github.com/bitcoin/bitcoin/issues/4676 | Follow standard Unix daemon practices · Issue #4676 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa opened pull request #12742: Make FastRandomContext support standard C++11 RNG interface (master...201803_stdrandom) https://github.com/bitcoin/bitcoin/pull/12742
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4ba3d4f4393d...9b8b1079ddab
< bitcoin-git> bitcoin/master 34ca750 Russell Yanofsky: Remove unnecessary NONNEGATIVE_SIGNED...
< bitcoin-git> bitcoin/master 9b8b107 Pieter Wuille: Merge #12737: Remove unnecessary NONNEGATIVE_SIGNED...
< bitcoin-git> [bitcoin] sipa closed pull request #12737: Remove unnecessary NONNEGATIVE_SIGNED (master...pr/nosigned) https://github.com/bitcoin/bitcoin/pull/12737
< CubicEar_> Bitcoin Devs = Heros
< Randolf> CubicEar_: Your sentiments are appreciated. Are you interested in contributing?
< bitcoin-git> [bitcoin] sipa opened pull request #12743: Fix csBestBlock/cvBlockChange waiting in rpc/mining (master...201803_waitblockchange) https://github.com/bitcoin/bitcoin/pull/12743
< CubicEar_> Randolf: I am always trying to increase my knowledge to the point where I could :)
< Randolf> CubicEar_: Well, one good place to start, depending on your level of programming expertise, is: https://www.github.com/bitcoin/
< CubicEar_> I browse it from time to time
< CubicEar_> Randolf: Thanks for being inviting. I expect that soon I will be working with a few devs in-person, so that will be nice
< Randolf> Welcome!
< Randolf> I've found the core developers to be very helpful.
< jimpo> sipa: Updated #12254 with mean element size stats (consistently ~21.6 bits)
< gribble> https://github.com/bitcoin/bitcoin/issues/12254 | BIP 158: Compact Block Filters for Light Clients by jimpo · Pull Request #12254 · bitcoin/bitcoin · GitHub
< jimpo> compression is abismal for small numbers of elements, which is why relative filter sizes are so large for early blocks
< jimpo> fun graph of mean element size vs number of elements (compression efficacy): https://gateway.ipfs.io/ipfs/QmaAceymvLdiw1tv5BLVgDkfKfd21mRNx4m41D5yhXrkcq
< sipa> jimpo: 21.6 is really good
< sipa> using a bloom filter instead would be at least 28.85
< jimpo> Yeah, it gets down to 22 at ~750 elements per set
< jimpo> Also, I created filters using scriptPubKey instead of the parsed scriptPubKey and the difference in avg filter size is negligible
< sipa> jimpo: that's expected... but just scriptPubKey seems much more predictable
< eklitzke> just noticed that we link against boost::program_options
< eklitzke> funny
< eklitzke> seemingly just to use a file iterator in one line of code of util.cpp
< eklitzke> i might try and fix that
< sipa> eklitzke: i bekieve there's an issue about that somewhere
< sipa> or maybe it was discussed in a meeting at some point
< bitcoin-git> [bitcoin] eklitzke opened pull request #12744: Completely eliminate dependency on boost::program_options (master...program_options) https://github.com/bitcoin/bitcoin/pull/12744
< eklitzke> probably needs more tests too
< fanquake> thumbs up for less Boost
< eklitzke> we're getting pretty close to removing it
< eklitzke> if there was a replacement ready for boost::filesystem i think we could sort out all of the other boost stuff pretty fast
< fanquake> Maybe drop boost and qt4 at the same time heh
< bitcoin-git> [bitcoin] practicalswift closed pull request #11694: rpc: Add missing cs_main lock in getblocktemplate(...) (master...missing-lock-in-getblocktemplate) https://github.com/bitcoin/bitcoin/pull/11694
< fanquake> If anyone wants some GUI review, #12723 is pretty much ACK ready
< gribble> https://github.com/bitcoin/bitcoin/issues/12723 | Qt5: Warning users about invalid-BIP21 URI bitcoin:// by krab · Pull Request #12723 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Empact opened pull request #12745: Expose node relay fee settings in help, independent of -help-debug (master...expose-relay-fee-settings-help) https://github.com/bitcoin/bitcoin/pull/12745
< bitcoin-git> [bitcoin] practicalswift opened pull request #12746: tests: Remove unused argument max_invalid from check_estimates(...) (master...check_estimates-max_invalid) https://github.com/bitcoin/bitcoin/pull/12746
< bitcoin-git> [bitcoin] practicalswift opened pull request #12747: Fix typos (master...typos-201803) https://github.com/bitcoin/bitcoin/pull/12747
< timothy> hi, do you think a pull request in order to add systemd notify support may be accepted?
< timothy> currently I'm using an hack in order to start lnd after bitcoind
< timothy> but, I think, using notify may be a better solution
< p3tr> timothy: i think a pull request will be more than welcome
< p3tr> anyway i'm using monit to make sure lnd starts after bitcoind is running
< timothy> p3tr: I'm using ExecStartPost=/bin/sh -c 'while sleep 10; do /home/bitcoin/bin/bitcoin-cli ping && break; done'
< timothy> so bitcoind.service is up only when the RPC is online
< timothy> but it sux as solution :)
< fanquake> timothy best way to get feedback is to just open a PR
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9b8b1079ddab...4ad3b3c72c73
< bitcoin-git> bitcoin/master 4d9b425 Dimitris Apostolou: Fix typos
< bitcoin-git> bitcoin/master 4ad3b3c MarcoFalke: Merge #12716: Fix typos and cleanup in various files...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12716: Fix typos and cleanup in various files (master...fix-typos) https://github.com/bitcoin/bitcoin/pull/12716
< fanquake> You can never truly escape all the typos.
< Randolf> fanquake: It's nice to get so many corrected at once though. :)
< bcqtsyncprob> Hi
< bcqtsyncprob> I'm having issues with blocksync. Can anybody help me?
< fanquake> try #bitcoin
< bcqtsyncprob> Tried
< bcqtsyncprob> Nobody knows there why is the client polling fd=5
< bcqtsyncprob> I assure you, I have problems with bitcoin core, and it's not disk-space, network etc. related at all
< fanquake> If you have info/debug logs ect, opening an issue is a good option: https://github.com/bitcoin/bitcoin/issues . Assuming you are running 0.16.0 ?
< paffo> hello everybody, a question. is there a repository on github or a tool where i can get all the wallet information history by insert the hashof the wallet?
< bcqtsyncprob> I can see new nodes connecting, a few million packages received, then it stops till tcp times out. In the meantime number of blocks left does not decrease
< bcqtsyncprob> strace shows the the client does nothing, just calling poll(fd=5) in an endless loop which times out
< bcqtsyncprob> Yes, I'm running the lates
< bcqtsyncprob> latest
< bcqtsyncprob> 8 days ago it was working properly, I'm experiencing these problems only in the last 3 days. I've updated the kernel in the meantime, I was wondering, could that cause that?
< bcqtsyncprob> paffo: tried blockchain.info? It will do precicely that.
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4ad3b3c72c73...310dc61ea3e2
< bitcoin-git> bitcoin/master b7fbcc5 Alexey Ivanov: Qt: Warn users about invalid-BIP21 URI bitcoin://
< bitcoin-git> bitcoin/master 310dc61 Wladimir J. van der Laan: Merge #12723: Qt5: Warning users about invalid-BIP21 URI bitcoin://...
< bitcoin-git> [bitcoin] laanwj closed pull request #12723: Qt5: Warning users about invalid-BIP21 URI bitcoin:// (master...qt5-uri-error-message) https://github.com/bitcoin/bitcoin/pull/12723
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/310dc61ea3e2...2405ce1df043
< bitcoin-git> bitcoin/master a004eb1 practicalswift: tests: Remove unused argument max_invalid from check_estimates(...)
< bitcoin-git> bitcoin/master 2405ce1 MarcoFalke: Merge #12746: tests: Remove unused argument max_invalid from check_estimates(...)...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12746: tests: Remove unused argument max_invalid from check_estimates(...) (master...check_estimates-max_invalid) https://github.com/bitcoin/bitcoin/pull/12746
< achow101> review/merge beg for #12694
< gribble> https://github.com/bitcoin/bitcoin/issues/12694 | Actually disable BnB when there are preset inputs by achow101 · Pull Request #12694 · bitcoin/bitcoin · GitHub
< jnewbery> wumpus: can you add #10762 to priorities for review? It's a fairly small changeset and removes one of the final server->wallet dependencies
< gribble> https://github.com/bitcoin/bitcoin/issues/10762 | [wallet] Remove Wallet dependencies from init.cpp by jnewbery · Pull Request #10762 · bitcoin/bitcoin · GitHub
< arubi> importpubkey misbehaves now. running importpubkey then validateaddress on the p2pkh\p2sh\p2wpkh addresses for that pubkey no loner returns the output that shows that the wallet knows about the pubkey for that address. git bisect says the bad commit is 1598f323, but this commit fails to build so it might have happened in the next one, b98bfc5e . the one before these two, 39633ecd , behaves normally
< sipa> arubi: what do you mean by "returns the output" ?
< arubi> I mean, calling validateaddress on an address that the wallet knows the pubkey for will list that pubkey in the output. this no longer happens even if the wallet supposedly knows the pubkey when the pubkey was imported with importpubkey
< jnewbery> arubi: the wallet parts of validateaddress have moved to getaddressinfo
< jnewbery> You found the right commit b98bfc5e. The commit message describes the change
< arubi> doh, let me rebuild. I only did git show
< sipa> arubi: run with -deprecatedrpc=validateaddress
< arubi> oh I'll do that first
< bitcoin-git> [bitcoin] instagibbs opened pull request #12749: feebumper: discard change outputs below discard rate (master...discardbump) https://github.com/bitcoin/bitcoin/pull/12749
< arubi> getaddressinfo returns the expected output, using the -deprecated flag doesn't change the output for validateaddress
< arubi> getaddressinfo is good enough for me :)
< sipa> arubi: it's -deprecatedrpc
< arubi> trying
< arubi> (I mean I'm assuming you're right but just for personal gain :) )
< sipa> well i'd very much like to know if i'm wrong!
< arubi> then I'll let you know
< arubi> `regtest-cli -deprecatedrpc=validateaddress validateaddress mxFyMiGBuZp8sjXUDjQBVgevf4K3sh3HEZ` still returns the "incomplete" output
< arubi> and `regtest-cli -deprecatedrpc validateaddress mxFyMiGBuZp8sjXUDjQBVgevf4K3sh3HEZ` too. I hope it isn't my alias acting up.. let's see if I call it without it
< arubi> same behavior
< sipa> arubi: it's -deprecatedrpc=validateaddress
< sipa> you have to explicitly specify which RPC you want the deprecated behaviour for
< sipa> this forces users to be aware something changed, and are relying on old behaviour, but can still use it if upgrading is too hard
< arubi> right, I did try both with =validateaddress and without
< sipa> oh
< sipa> oh!
< sipa> and -deprecatedrpc=... is an option to bitcoind, not cli
< arubi> yep, full command : `$HOME/software/install/bitcoin/regtest/bin/bitcoin-cli -deprecatedrpc=validateaddress -conf=$HOME/.bitcoin/regtest.conf -rpcuser=regtest_daemon -rpcpassword=LygXyhO0-T5g-IJOQD2TILdlbTOkrd0FCz3rbZ7jC3M= validateaddress mxFyMiGBuZp8sjXUDjQBVgevf4K3sh3HEZ`
< sipa> no, to bitcoind, not to bitcoin-cli
< sipa> you need to restart the daemon
< bitcoin-git> [bitcoin] donaloconnor opened pull request #12750: Replace boost::call_once with std::call_once (master...21032018_call_once) https://github.com/bitcoin/bitcoin/pull/12750
< arubi> ohh my bad one moment
< arubi> success! :)
< sipa> "bitcoin-cli help validateaddress" should show:
< sipa> DEPRECATION WARNING: Parts of this command have been deprecated and moved to getaddressinfo. Clients must
< sipa> transition to using getaddressinfo to access this information before upgrading to v0.18. The following deprecated
< sipa> fields have moved to getaddressinfo and will only be shown here with -deprecatedrpc=validateaddress: ismine, iswatchonly,
< sipa> script, hex, pubkeys, sigsrequired, pubkey, addresses, embedded, iscompressed, account, timestamp, hdkeypath, kdmasterkeyid.
< arubi> it does indeed. it's always the user that fails to RTFM
< cfields> <eklitzke> these two changes have been a valuable lesson in how the separation between the preprocessor, compiler, and linker is more of an illusion than anything else
< cfields> eklitzke: yes, it's nearly impossible to invoke linkers directly these days
< bitcoin-git> [bitcoin] sipa opened pull request #12752: [MOVEONLY] Move compressor utility functions out of class (master...201803_movecompress) https://github.com/bitcoin/bitcoin/pull/12752
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2405ce1df043...2b1c50b9352a
< bitcoin-git> bitcoin/master d27327c practicalswift: Fix typos
< bitcoin-git> bitcoin/master 2b1c50b MarcoFalke: Merge #12747: Fix typos...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12747: Fix typos (master...typos-201803) https://github.com/bitcoin/bitcoin/pull/12747
< bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2b1c50b9352a...e0f7515f5500
< bitcoin-git> bitcoin/master 57dae3f donaloconnor: Replace boost::call_once with std::call_once
< bitcoin-git> bitcoin/master e0f7515 Pieter Wuille: Merge #12750: Replace boost::call_once with std::call_once...
< bitcoin-git> [bitcoin] sipa closed pull request #12750: Replace boost::call_once with std::call_once (master...21032018_call_once) https://github.com/bitcoin/bitcoin/pull/12750