< luke-jr> sipa: any obvious way to perhaps make the dnsseed.dat files compress and/or xdelta better? with 1.2 GB every day, it's starting to add up (~200 GB since 2012, compressed)
< luke-jr> maybe there's some kind of sorting that would help
< sipa> luke-jr: the file is 276 MiB for me
< luke-jr> sipa: 1.2 GB for me XD
< luke-jr> and the xdelta for today to yesterday is 295 MB
< midnightmagic> is there that much churn?
< luke-jr> dunno, I guess if I started over, mine would look closer to sipa's, but it seems more useful to have the diversity of whatever old data is in there
< jtimon> thoughts on https://github.com/bitcoin/bitcoin/pull/10757#issuecomment-377440180 ? specially @MarcoFalke and @aj
< ProfMac> Not totally unrelated to dnsseed.dat, I wrote my first awk script and have been looking at debug.log to see who is connecting to me. I especially looked at IPv6 addresses, and I notice a lot of alias addresses for the same machine. I assume my data is almost identical to the peers.dat data.
< aj> jtimon: sorry, i keep forgetting to send you test case code for getblockstats
< jtimon> aj: feel free to open a pr with my commits plus your tests, I really think it's the best wat to test it in concept but never wrote or seen the code
< jtimon> and of course if you do ping me for review and testing
< aj> BlueMatt: iceweasel rebranding was trademark issues (maybe "can't use firefox trademark if you ship old shit" though, i forget; thought it was just that debian did patches though), but they did away with that and introduced "extended support releases", so firefox-esr is in debian stable these days, and iceweasel is long gone
< jimpo> Do people think that the best-effort getrawtransaction lookup from CCoinsCacheView if the txindex is disabled is a useful thing?
< jimpo> As opposed to requiring either the txindex for the RPC to work or passing in the block_hash argument?
< sipa> see #3220
< gribble> https://github.com/bitcoin/bitcoin/issues/3220 | Getrawtransaction working partially without -txindex is confusing · Issue #3220 · bitcoin/bitcoin · GitHub
< jimpo> Ah, thx
< aj> jtimon: ule>
< aj> TypeError: can't multiply sequence by non-int of type 'float'
< aj> >>> 515792/2016.*(32+4)
< aj> grr
< jtimon> aj: looks very good at a glance, I'm going to bed but I will check it out and test it
< aj> jtimon: yeah, feel free to squash and tidy it up to your preferred style, but i think the approach should work fine
< jtimon> yeah, thanks
< aj> jtimon: np, sorry for taking so long to get back to it :)
< jtimon> np, I didn't have time to code it myself either, but this looks cool
< bitcoin-git> [bitcoin] promag opened pull request #12836: Make WalletInitInterface and DummyWalletInit private (master...2018-03-walletinit) https://github.com/bitcoin/bitcoin/pull/12836
< promag> aj: did you delete the GH comment?
< aj> promag: yeah, the compile i was running with that change failed
< promag> that PR is mostly moving code
< promag> but I think we could make g_wallet_init_interface const
< aj> promag: yeah, it looks very good
< aj> promag: since it doesn't have any member variables, i guess that's right?
< aj> promag: would need to mark all the functions const too which is arguably a bit weird
< promag> I don't mean const in that way
< promag> I mean, don't allow g_wallet_init_interface to take a new value
< promag> let's see what others say
< aj> promag: i think marking it const-pointer fails because it can get optimised away in the module its declared in, while other modules stil try referencing it? (that's what the compile failure looked like anyway)
< aj> promag: it all got confusing anyway, which is why i deleted my comment :)
< promag> :) ok
< bitcoin-git> [bitcoin] joemphilips opened pull request #12837: fix type mistmatch in `listreceivedbyaddress` (master...fix_listreceivedbyaddress_type) https://github.com/bitcoin/bitcoin/pull/12837
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/3b62a9138657...ff48f6267128
< bitcoin-git> bitcoin/master 99f6d48 Matt Corallo: Revert "test: Update trust git root"....
< bitcoin-git> bitcoin/master de7e931 Matt Corallo: Add Marco-expired-key-signed-commits to allow-revsig-commits
< bitcoin-git> bitcoin/master 9471576 Matt Corallo: [verify-commits] Add some additional useful documentation.
< bitcoin-git> [bitcoin] laanwj closed pull request #12822: Revert 7deba93bdc76616011a9f493cbc203d60084416f and fix expired-key-sigs properly (master...master) https://github.com/bitcoin/bitcoin/pull/12822
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ff48f6267128...d2d7267e235a
< bitcoin-git> bitcoin/master 76a9aac Pieter Wuille: Move compressor utility functions out of class
< bitcoin-git> bitcoin/master d2d7267 Wladimir J. van der Laan: Merge #12752: [MOVEONLY] Move compressor utility functions out of class...
< bitcoin-git> [bitcoin] laanwj closed pull request #12752: [MOVEONLY] Move compressor utility functions out of class (master...201803_movecompress) https://github.com/bitcoin/bitcoin/pull/12752
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d2d7267e235a...8203c4c42ed8
< bitcoin-git> bitcoin/master a7c45bc Pieter Wuille: Add native support for serializing char arrays without FLATDATA...
< bitcoin-git> bitcoin/master 8203c4c Wladimir J. van der Laan: Merge #12740: Add native support for serializing char arrays without FLATDATA...
< bitcoin-git> [bitcoin] laanwj closed pull request #12740: Add native support for serializing char arrays without FLATDATA (master...201803_chararray) https://github.com/bitcoin/bitcoin/pull/12740
< bitcoin-git> [bitcoin] laanwj opened pull request #12839: test: Remove travis checkout depth (master...2018_03_travis_depth) https://github.com/bitcoin/bitcoin/pull/12839
< Chris_Stewart_5> MarcoFalke: Can you kick travis on #8469? I think the failure is unrelated?
< gribble> https://github.com/bitcoin/bitcoin/issues/8469 | [POC] Introducing property based testing to Core by Christewart · Pull Request #8469 · bitcoin/bitcoin · GitHub
< jnewbery> Chris_Stewart_5: kicked travis
< Chris_Stewart_5> danke schon
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8203c4c42ed8...40f4baffa211
< bitcoin-git> bitcoin/master 9df1a9c Wladimir J. van der Laan: test: Remove travis checkout depth...
< bitcoin-git> bitcoin/master 40f4baf Wladimir J. van der Laan: Merge #12839: test: Remove travis checkout depth...
< bitcoin-git> [bitcoin] laanwj closed pull request #12839: test: Remove travis checkout depth (master...2018_03_travis_depth) https://github.com/bitcoin/bitcoin/pull/12839
< BlueMatt> aj: yea, it was "cant use firefox trademark if you dont do X, Y, Z" where one of those, iirc, was "if you ship out-of-date shit and then try to backport changes"
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/40f4baffa211...de7e58684176
< bitcoin-git> bitcoin/master 8394300 Roman Zeyde: [Tests] fix a typo in TestNode.assert_start_raises_init_error()...
< bitcoin-git> bitcoin/master de7e586 MarcoFalke: Merge #12810: [Tests] Fix a typo at assert_start_raises_init_error() and use specific exception for initialization error...
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/de7e58684176...5e53b80b0280
< bitcoin-git> bitcoin/master 1360844 MarcoFalke: contrib: Fix check-doc script regexes
< bitcoin-git> bitcoin/master 0c17e27 MarcoFalke: init: Remove help text for non-existent -fuzzmessagestest arg
< bitcoin-git> bitcoin/master 5e53b80 MarcoFalke: Merge #12820: contrib: Fix check-doc script regexes...
< 18WAAOAGJ> [bitcoin] MarcoFalke closed pull request #12810: [Tests] Fix a typo at assert_start_raises_init_error() and use specific exception for initialization error (master...fix-blocksdir-test) https://github.com/bitcoin/bitcoin/pull/12810
< 17SAAXTEF> [bitcoin] MarcoFalke closed pull request #12820: contrib: Fix check-doc script regexes (master...Mf1803-qaCheckDocRegex) https://github.com/bitcoin/bitcoin/pull/12820
< gribble> https://github.com/bitcoin/bitcoin/issues/12810 | [Tests] Fix a typo at assert_start_raises_init_error() and use specific exception for initialization error by romanz · Pull Request #12810 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/12820 | contrib: Fix check-doc script regexes by MarcoFalke · Pull Request #12820 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5e53b80b0280...be299c4a4725
< bitcoin-git> bitcoin/master 6a318e4 practicalswift: Reduce variable scopes
< bitcoin-git> bitcoin/master be299c4 MarcoFalke: Merge #12780: Reduce variable scopes...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12780: Reduce variable scopes (master...limit-variable-scopes) https://github.com/bitcoin/bitcoin/pull/12780
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/be299c4a4725...4490871ed7eb
< bitcoin-git> bitcoin/master 4f872b2 Evan Klitzke: Add additional tests for GetBoolArg()...
< bitcoin-git> bitcoin/master f7683cb Evan Klitzke: Track negated arguments in the argument paser....
< bitcoin-git> bitcoin/master 4490871 MarcoFalke: Merge #12713: Track negated options in the option parser...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12713: Track negated options in the option parser (master...bool-option-parsing) https://github.com/bitcoin/bitcoin/pull/12713
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4490871ed7eb...243c9bb79a3c
< bitcoin-git> bitcoin/master 5a67c05 John Newbery: [tests] Fix intermittent rpc_net.py failure....
< bitcoin-git> bitcoin/master 243c9bb MarcoFalke: Merge #12804: [tests] Fix intermittent rpc_net.py failure....
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #12804: [tests] Fix intermittent rpc_net.py failure. (master...rpc_net_py_fix) https://github.com/bitcoin/bitcoin/pull/12804
< BlueMatt> cfields: you probably have an opinion here: https://github.com/bitcoin/bitcoin/pull/11857#discussion_r178187241
< BlueMatt> sipa: I dont see what your comment has to do with the pr here: https://github.com/bitcoin/bitcoin/pull/11857#issuecomment-377421311
< sipa> BlueMatt: on my phone, hard to check
< sipa> is it my comment on the utxo lookup in getrawtransaction
< sipa> ?
< BlueMatt> yes, your comment was "I dont like utxo lookup in getrawtransaction", the pr is about the utxo db itself
< BlueMatt> it doesnt touch the interface to it
< sipa> jimpo made some comment somewhere about whether it was useful to have the utxo based lookup
< sipa> and i commented on that
< sipa> but from my phone i couldn't directly respond to the review comment, so it probably became a top level comment on the pr
< BlueMatt> ah, I see the discussion thread, anyway, his point about the pr being large is well-made, then you followed up with "well, you could add a new rpc command"
< BlueMatt> anyway, whatever, i was just confused
< sipa> i wasn't suggesting anything change in the PR itself; just giving my opinion on the usefulness of that feature :)
< sipa> i can delete it if it:s confusing
< BlueMatt> nah, all good
< bitcoin-git> [bitcoin] promag opened pull request #12842: Prevent concurrent savemempool (master...2018-03-concurrent-savemempool) https://github.com/bitcoin/bitcoin/pull/12842
< bitcoin-git> [bitcoin] jnewbery opened pull request #12843: [tests] Test starting bitcoind with -h and -version (master...test_help) https://github.com/bitcoin/bitcoin/pull/12843
< U039bmz> .-. .-.
< U039bmz> .-. .-.
< U039bmz> .-. .-.
< U039bmz> .-. .-.
< U039bmz> / \ / \
< U039bmz> / \ / \
< U039bmz> / \ / \
< U039bmz> / \ / \
< U039bmz> | _ \ / _ |
< U039bmz> | _ \ / _ |
< U039bmz> | _ \ / _ |
< U039bmz> | _ \ / _ |
< U039bmz> ; | \ \ / / | ;
< U039bmz> ; | \ \ / / | ;
< U039bmz> ; | \ \ / / | ;
< U039bmz> ; | \ \ / / | ;
< U039bmz> \ \ \ \_.._/ / / /
< U039bmz> \ \ \ \_.._/ / / /
< U039bmz> \ \ \ \_.._/ / / /
< U039bmz> \ \ \ \_.._/ / / /
< U039bmz> '. '.;' ';,' .'
< U039bmz> '. '.;' ';,' .'
< U039bmz> '. '.;' ';,' .'
< U039bmz> '. '.;' ';,' .'
< U039bmz> './ _ _ \.'
< U039bmz> './ _ _ \.'
< U039bmz> './ _ _ \.'
< U039bmz> './ _ _ \.'
< U039bmz> .' a __ a '.
< U039bmz> .' a __ a '.
< U039bmz> .' a __ a '.
< U039bmz> .' a __ a '.
< U039bmz> '--./ _, \/ ,_ \.--'
< U039bmz> '--./ _, \/ ,_ \.--'
< U039bmz> '--./ _, \/ ,_ \.--'
< U039bmz> '--./ _, \/ ,_ \.--'
< U039bmz> ----| \ /\ / |----
< U039bmz> ----| \ /\ / |----
< U039bmz> ----| \ /\ / |----
< U039bmz> ----| \ /\ / |----
< U039bmz> .--'\ '-' '-' /'--.
< U039bmz> .--'\ '-' '-' /'--.
< U039bmz> .--'\ '-' '-' /'--.
< U039bmz> .--'\ '-' '-' /'--.
< U039bmz> _>.__ -- _.- `;
< U039bmz> _>.__ -- _.- `;
< U039bmz> _>.__ -- _.- `;
< U039bmz> _>.__ -- _.- `;
< U039bmz> .' _ __/ _/
< U039bmz> .' _ __/ _/
< U039bmz> .' _ __/ _/
< U039bmz> .' _ __/ _/
< U039bmz> / '.,:".-\ /:,
< U039bmz> / '.,:".-\ /:,
< U039bmz> / '.,:".-\ /:,
< U039bmz> / '.,:".-\ /:,
< U039bmz> | \.' `""`'.\\
< U039bmz> | \.' `""`'.\\
< U039bmz> | \.' `""`'.\\
< U039bmz> | \.' `""`'.\\
< U039bmz> '-,.__/ _ .-. ;|_
< U039bmz> '-,.__/ _ .-. ;|_
< U039bmz> '-,.__/ _ .-. ;|_
< U039bmz> '-,.__/ _ .-. ;|_
< U039bmz> /` `|| _/ `\/_ \_|| `\
< U039bmz> /` `|| _/ `\/_ \_|| `\
< U039bmz> /` `|| _/ `\/_ \_|| `\
< U039bmz> /` `|| _/ `\/_ \_|| `\
< U039bmz> | ||/ \-./` \ / || |
< U039bmz> | ||/ \-./` \ / || |
< U039bmz> | ||/ \-./` \ / || |
< U039bmz> | ||/ \-./` \ / || |
< U039bmz> \ ||__/__|___|__|| /
< U039bmz> \ ||__/__|___|__|| /
< U039bmz> \ ||__/__|___|__|| /
< U039bmz> \ ||__/__|___|__|| /
< U039bmz> \_ |_Happy Easter_| /
< U039bmz> \_ |_Happy Easter_| /
< U039bmz> \_ |_Happy Easter_| /
< U039bmz> \_ |_Happy Easter_| /
< U039bmz> jgs .' \ = _= _ = _= /`\
< U039bmz> jgs .' \ = _= _ = _= /`\
< U039bmz> jgs .' \ = _= _ = _= /`\
< U039bmz> jgs .' \ = _= _ = _= /`\
< U039bmz> / `-;----=--;--' \
< U039bmz> / `-;----=--;--' \
< U039bmz> / `-;----=--;--' \
< U039bmz> / `-;----=--;--' \
< U039bmz> \ _.-' '. /
< U039bmz> \ _.-' '. /
< U039bmz> \ _.-' '. /
< U039bmz> \ _.-' '. /
< jimpo> BlueMatt: The fact that the block index may not be synced to fs before a BlockConnected/BlockDisconnected callback is quite annoying
< jimpo> Makes the interface quite difficult to work with/reason about
< BlueMatt> jimpo: true, but otherwise block connection would be way slower :/
< BlueMatt> jimpo: there is a separate callback for the wallet that indicates things have been flushed
< BlueMatt> so you kinda have to go the direction of the wallet and use a locator
< jimpo> Yeah, the locator is probably the way to go
< jimpo> What is the flushed callback?