< bitcoin-git> [bitcoin] MarcoFalke opened pull request #13120: policy: Treat segwit as always active (master...Mf1805-segwitGenesisPolicy) https://github.com/bitcoin/bitcoin/pull/13120
< mryandao> MarcoFalke: can you have a look at #13109? i've addressed your comments
< gribble> https://github.com/bitcoin/bitcoin/issues/13109 | [rpc] nit: fix typo for entry description string by mryandao · Pull Request #13109 · bitcoin/bitcoin · GitHub
< MarcoFalke> mryandao: thx LGTM
< MarcoFalke> mryandao: Missing white space between "in" and "BTC", no?
< * MarcoFalke> zzz
< mryandao> MarcoFalke: ok added the space :/
< jonasschnelli> roasbeef: that is what I'm doing.. but it still complains after 1.3GB that the map is full
< bitcoin-git> [bitcoin] laanwj closed pull request #13113: tests: Make it clear that MAX_INV_SZ is not covered by functional tests (master...add-note-about-MAX_INV_SZ) https://github.com/bitcoin/bitcoin/pull/13113
< wumpus> jonasschnelli: I found it strange too, but it's what e.g. monero is doing
< wumpus> jonasschnelli: I think they double the map size every time that is needed
< jonasschnelli> wumpus: okay... funny... also, I can't find any hint in the documentation... it looks like it should be possible to initialize a 4GB map size and fill it up.
< jonasschnelli> wumpus: do you know how monero deals with the 4GB 32bit limitation?
< wumpus> jonasschnelli: probably better to take it #monero-dev, but IIRC monero doesn't run on 32-bit
< jonasschnelli> thanks
< fanquake> wumpus #13119 & #13109 probably ready to go in
< gribble> https://github.com/bitcoin/bitcoin/issues/13119 | Remove script to clean up datadirs by MarcoFalke · Pull Request #13119 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/13109 | [rpc] nit: fix typo for entry description string by mryandao · Pull Request #13109 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3315007e03f5...81743b5b24c0
< bitcoin-git> bitcoin/master fa85de9 MarcoFalke: Remove script to clean up datadirs...
< bitcoin-git> bitcoin/master 81743b5 Jonas Schnelli: Merge #13119: Remove script to clean up datadirs...
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #13119: Remove script to clean up datadirs (master...Mf1805-deleteTidyDatadir) https://github.com/bitcoin/bitcoin/pull/13119
< jonasschnelli> Thanks fanquake: I think 13019 should get another ack (re-kicked travis as well)
< bitcoin-git> [bitcoin] dbolser opened pull request #13122: --disable-asm is required to compile on FreeBSD (master...patch-4) https://github.com/bitcoin/bitcoin/pull/13122
< fanquake> jonasschnelli I've ACK'd it, travis is now green too.
< wumpus> fanquake: will take al ook
< bitcoin-git> [bitcoin] practicalswift opened pull request #13123: Add Clang thread safety annotations for guarded variables in the networking code (master...net-guarded-by) https://github.com/bitcoin/bitcoin/pull/13123
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/81743b5b24c0...219970524d8a
< bitcoin-git> bitcoin/master f7c414d mryandao: nit: fix typo for entry description string
< bitcoin-git> bitcoin/master 2199705 Wladimir J. van der Laan: Merge #13109: [rpc] nit: fix typo for entry description string...
< bitcoin-git> [bitcoin] laanwj closed pull request #13109: [rpc] nit: fix typo for entry description string (master...fix-getrawmempool-fee-representation) https://github.com/bitcoin/bitcoin/pull/13109
< mryandao> even the spelling of descentd(e|a)nt is contentious, kek
< mryandao> promag: just to be sure what i'm looking at here -- is it just the "descendent" in the release-notes that needs fixing?
< promag> mryandao: right
< bitcoin-git> [bitcoin] mryandao opened pull request #13124: [doc] nit: descendent should be spelled descendant even in the release-notes (master...fix-getrawmempool-fee-representation) https://github.com/bitcoin/bitcoin/pull/13124
< bitcoin-git> [bitcoin] practicalswift opened pull request #13125: scheduler: Add Clang thread safety annotations for variables guarded by m_cs_callbacks_pending (master...m_cs_callbacks_pending) https://github.com/bitcoin/bitcoin/pull/13125
< fanquake> #13124 can go in now too, and that'll be the end of "descendent".
< gribble> https://github.com/bitcoin/bitcoin/issues/13124 | [doc] nit: descendent should be spelled descendant even in the release-notes by mryandao · Pull Request #13124 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #13126: util: Add Clang thread safety annotations for variables guarded by cs_args (master...guarded-by-cs_args) https://github.com/bitcoin/bitcoin/pull/13126
< wumpus> lol couldn't that be done in one PR
< fanquake> wumpus unfortunately I forgot to search after looking at the last one..
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/219970524d8a...19fadd9d6883
< bitcoin-git> bitcoin/master 9b78ef3 mryandao: nit: descendent should be spelled descendant even in the release-notes
< bitcoin-git> bitcoin/master 19fadd9 Wladimir J. van der Laan: Merge #13124: [doc] nit: descendent should be spelled descendant even in the release-notes...
< bitcoin-git> [bitcoin] laanwj closed pull request #13124: [doc] nit: descendent should be spelled descendant even in the release-notes (master...fix-getrawmempool-fee-representation) https://github.com/bitcoin/bitcoin/pull/13124
< fanquake> The GH UI lags a fair way behind a merge being announced here by the git bot
< wumpus> yes, I've also noticed, can be quite long before the UI notices
< wumpus> all the requests on their server must be like stampeding unicorns
< fanquake> hehe
< bitcoin-git> [bitcoin] practicalswift opened pull request #13127: wallet: Add Clang thread safety annotations for variables guarded by cs_db (master...guarded-by-cs_db) https://github.com/bitcoin/bitcoin/pull/13127
< wumpus> we should probably poke practicalswift to group these things, not create a zillion PRs in a day
< promag> afaiu he is splitting?
< fanquake> wumpus I thought there was already one large PR that grouped all these together, and they were now being split up.
< fanquake> Although I agree, a couple PRs a day is probably enough.
< wumpus> ok...
< promag> imo he should go easy
< promag> wait for a merge and submit a new one
< promag> otherwise it's overwhelming
< wumpus> right, it feels a bit like a swarm attack on reviewers
< wumpus> and I know he doesn't mean it that way...
< promag> honestly atm I try to avoid those PR
< wumpus> we should review BlueMatt's PRs more
< promag> you mean #12979?
< gribble> https://github.com/bitcoin/bitcoin/issues/12979 | Split validationinterface into paralell validation/mempool interfaces by TheBlueMatt · Pull Request #12979 · bitcoin/bitcoin · GitHub
< wumpus> currently looking at #13106
< gribble> https://github.com/bitcoin/bitcoin/issues/13106 | Simplify semantics of ChainStateFlushed callback by TheBlueMatt · Pull Request #13106 · bitcoin/bitcoin · GitHub
< wumpus> but yes definitely that one too
< provoostenator> "Makefile:5697: recipe for target 'libbitcoin_server_a-init.o' failed" on Ubuntu 16.04 on VM with 2 GB RAM, 30% of which used up by some other process.
< provoostenator> Killing said process makes the problem go away. But it seems we're quite close to the limit of the minimum recommended system RAM (2 GB) for that file.
< provoostenator> (the other process being sipa's DNS seeder FYI :-)
< wumpus> which compiler/version?
< wumpus> FWIW in the issue about compiler memory usage (#6658) there are some cflags that can be used to tone down memory usage for at least gcc..
< gribble> https://github.com/bitcoin/bitcoin/issues/6658 | Building requires >1GB memory · Issue #6658 · bitcoin/bitcoin · GitHub
< provoostenator> gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9
< wumpus> adding swap also helps
< promag> merge #13028 ?
< gribble> https://github.com/bitcoin/bitcoin/issues/13028 | Make vpwallets usage thread safe by promag · Pull Request #13028 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/19fadd9d6883...9e9b48df72db
< bitcoin-git> bitcoin/master bf720c1 James O'Beirne: Add --failfast option to functional test runner...
< bitcoin-git> bitcoin/master 58f9a0a James O'Beirne: Use --failfast when running functional tests on Travis
< bitcoin-git> bitcoin/master 9e9b48d Wladimir J. van der Laan: Merge #13105: [qa] Add --failfast option to functional test runner...
< bitcoin-git> [bitcoin] laanwj closed pull request #13105: [qa] Add --failfast option to functional test runner (master...2018-04-testrunner-failfast) https://github.com/bitcoin/bitcoin/pull/13105
< bitcoin-git> [bitcoin] practicalswift closed pull request #12914: scripted-diff: Remove redundant license reference (HTTP URL) (master...copyright-headers) https://github.com/bitcoin/bitcoin/pull/12914
< bitcoin-git> [bitcoin] practicalswift opened pull request #13128: policy: Add Clang thread safety annotations for variables guarded by cs_feeEstimator (master...guarded-by-cs_feeEstimator) https://github.com/bitcoin/bitcoin/pull/13128
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9e9b48df72db...783bb6455e18
< bitcoin-git> bitcoin/master e2f58f4 João Barbosa: wallet: Make vpwallets usage thread safe
< bitcoin-git> bitcoin/master 783bb64 Wladimir J. van der Laan: Merge #13028: Make vpwallets usage thread safe...
< bitcoin-git> [bitcoin] laanwj closed pull request #13028: Make vpwallets usage thread safe (master...2018-04-cs_wallets) https://github.com/bitcoin/bitcoin/pull/13028
< promag> jnewbery: fast rebase on 10740 :)
< bitcoin-git> [bitcoin] practicalswift closed pull request #11596: Add missing cs_main locks when accessing chainActive (master...chainActive) https://github.com/bitcoin/bitcoin/pull/11596
< bitcoin-git> [bitcoin] jnewbery opened pull request #13130: [tests] Fix race in rpc_deprecated.py (master...fix_rpc_deprecated) https://github.com/bitcoin/bitcoin/pull/13130
< jnewbery> thanks promag!
< jnewbery> #12953 has introduced a race in rpc_deprecated.py. Sorry
< gribble> https://github.com/bitcoin/bitcoin/issues/12953 | Deprecate accounts by jnewbery · Pull Request #12953 · bitcoin/bitcoin · GitHub
< jnewbery> Fix is in #13130
< gribble> https://github.com/bitcoin/bitcoin/issues/13130 | [tests] Fix race in rpc_deprecated.py by jnewbery · Pull Request #13130 · bitcoin/bitcoin · GitHub
< jnewbery> MarcoFalke, wumpus ^^ should merge the above to fix intermittent travis failures
< bitcoin-git> [bitcoin] ken2812221 opened pull request #13131: Add Windows shutdown handler (master...win-quit) https://github.com/bitcoin/bitcoin/pull/13131
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/783bb6455e18...3186ad4a81a4
< bitcoin-git> bitcoin/master a95bf64 John Newbery: [tests] Fix race in rpc_deprecated.py...
< bitcoin-git> bitcoin/master 3186ad4 MarcoFalke: Merge #13130: [tests] Fix race in rpc_deprecated.py...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13130: [tests] Fix race in rpc_deprecated.py (master...fix_rpc_deprecated) https://github.com/bitcoin/bitcoin/pull/13130
< provoostenator> I rebased my Gitian doc PR from February: https://github.com/bitcoin-core/docs/pull/25
< provoostenator> Would be nice to get this merged before all the Ubuntu 18.04 changes start piling in...
< provoostenator> (nvm the latter, since these instructions are about the host, not the building machine)
< jimpo> Any more comments on #12954?
< gribble> https://github.com/bitcoin/bitcoin/issues/12954 | util: Refactor logging code into a global object by jimpo · Pull Request #12954 · bitcoin/bitcoin · GitHub