< aj> jnewbery: yeah, wallet_multiwallet --usecli takes forever for me fwiw
< aj> jnewbery: like 5x as long as without --usecli
< sipa> could this be since RNG changes?
< gmaxwell> considering the rdrand and strenghtening fixes haven't been merged, I'd be surprised.
< aj> i'd seen it in december, as at cb52cee2 fwiw
< fanquake> aj I see the same, created #15309
< gribble> https://github.com/bitcoin/bitcoin/issues/15309 | tests: Running with --usecli ~5x slower than without · Issue #15309 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #15313: Qt: avoid AskPassphraseDialog synchronous QDialog.exec() calls (master...019/01/qt_exec) https://github.com/bitcoin/bitcoin/pull/15313
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/cb35f1d305d8...3e38d4087379
< bitcoin-git> bitcoin/master 1f77f67 Andrew Chow: tests: unify RPC argument to cli argument conversion and handle dicts and ...
< bitcoin-git> bitcoin/master b5c5021 Andrew Chow: Refactor importwallet to extract data from the file and then import
< bitcoin-git> bitcoin/master e6c58d3 Andrew Chow: Do not import private keys to wallets with private keys disabled
< bitcoin-git> [bitcoin] laanwj merged pull request #15235: Do not import private keys to wallets with private keys disabled (master...fix-noprivs-import) https://github.com/bitcoin/bitcoin/pull/15235
< bitcoin-git> [bitcoin] harding opened pull request #15314: [Doc] update release notes for changes up to cb35f1d (master...019-02-monthly-release-notes-update) https://github.com/bitcoin/bitcoin/pull/15314
< bitcoin-git> [bitcoin] harding opened pull request #15315: [0.17] [Doc] Backport release note about PSBT doc (.17...019-02-backport-release-notes) https://github.com/bitcoin/bitcoin/pull/15315
< promag_> jnewbery: #15297 could be in https://github.com/bitcoin/bitcoin/projects/2
< gribble> https://github.com/bitcoin/bitcoin/issues/15297 | wallet: Releases dangling files on BerkeleyEnvironment::Close by promag · Pull Request #15297 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3e38d4087379...5c99bb004700
< bitcoin-git> bitcoin/master fa21983 MarcoFalke: qa: Style-only fixes in touched files
< bitcoin-git> bitcoin/master fa5278a MarcoFalke: qa: Use wallet to retrieve raw transactions
< bitcoin-git> bitcoin/master 5c99bb0 MarcoFalke: Merge #15247: qa: Use wallet to retrieve raw transactions
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15247: qa: Use wallet to retrieve raw transactions (master...Mf1901-qaWalletRaw) https://github.com/bitcoin/bitcoin/pull/15247
< dongcarl> Hi all, if anyone can add https://github.com/bitcoin/bitcoin/pull/14856 to the "P2P refactor" board that'd be great. Also, could I get permissions to modify that board?
< dongcarl> Do people think that future consensus meanings of the witness reserved value will most likely be in the form of a sha256d commitment?
< rex4539> On master HEAD, I have few tests failing reliably. It's an old, slow machine with 4GB RAM so slowness could definitely be a factor here.
< provoostenator> I'm trying to build a Descriptor composer. It should allow something like auto desc = PKHDescriptor(myCPubKey);
< provoostenator> Not sure what the right approach is, and the abstract class stuff is a bit over my head.
< sipa> provoostenator: oh, i was thinking about that
< sipa> i'll pr it
< provoostenator> The end goal is that I want to generate a descriptor like wpkh([000000/84'/0'/0']xpub.../0/*) without weird string concatenation.
< provoostenator> sipa: awesome that would help!
< provoostenator> Once that works, I would like to introduce descriptor-requests somehow. The same, but with xpub missing. The point of that is to ask a signer to fill in that part.
< provoostenator> With that I can significantly reduce the amount of spaghetti in my hardware wallet integration WIP PR :-)
< provoostenator> I suppose the lazy solution is just an all 0 public key.
< wumpus> rex4539: by default it runs four tests at the same time which is too much for slower systems, certainly with little memory; it might help if you set -j1 on test runner?
< rex4539> Running them individually it's the same failure.
< wumpus> definitely looks like a test that takes much longer than expected and hits the timeout
< wumpus> you might be able to make it pass by increasing the timeout value in the source
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/5c99bb004700...2c0867a1811b
< bitcoin-git> bitcoin/master 1971f5b Ben Woosley: Piecewise construct to avoid invalid construction
< bitcoin-git> bitcoin/master 267eac0 Ben Woosley: Prefer boost::optional#get_value_or over #value_or
< bitcoin-git> bitcoin/master 64f2854 Ben Woosley: Revert "travis: Compile trusty with depends for now"
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15308: build: Restore compatibility with older boost (master...trusty-no-depends) https://github.com/bitcoin/bitcoin/pull/15308
< bitcoin-git> [bitcoin] Sjors opened pull request #15320: [Do Not Merge] break < Qt5.6 compatibility for addAction to test Travis (master...019/02/do-not-merge-qt52) https://github.com/bitcoin/bitcoin/pull/15320
< provoostenator> (guess I could have done that on my own fork, anyway...)
< MarcoFalke> provoostenator: The issue was closed accidentally because the description in #15308 was not updated to reflect the latest status of the pull
< gribble> https://github.com/bitcoin/bitcoin/issues/15308 | build: Restore compatibility with older boost by Empact · Pull Request #15308 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15321: doc: Add cs_main lock annotations for mapBlockIndex (master...Mf1902-docLoc) https://github.com/bitcoin/bitcoin/pull/15321
< bitcoin-git> [bitcoin] practicalswift closed pull request #15111: Avoid UB (member call on nullptr) when failing to read randomness in the startup process (master...random-ub) https://github.com/bitcoin/bitcoin/pull/15111
< dongcarl> ryanofsky:
< dongcarl> ryanofsky: Could you see if the wording I just pushed makes sense?
< dongcarl> Or should we explicitly mention that out of the box you can't override datadir?
< dongcarl> talking about #12255 ofc
< gribble> https://github.com/bitcoin/bitcoin/issues/12255 | Update bitcoin.service to conform to init.md by dongcarl · Pull Request #12255 · bitcoin/bitcoin · GitHub
< ryanofsky> previous ca07fa88c82 seems better than current 9c8d535211d. new wording is ok but less clear
< bitcoin-git> [bitcoin] promag opened pull request #15322: wallet: Add missing cs_db lock (master...019-01-cs_db) https://github.com/bitcoin/bitcoin/pull/15322
< dongcarl> ryanofsky: Okay I'll revert then
< promag> was this mentioned in the past? I wasn't aware :/
< sipa> promag: what are you referring to?
< promag> no thread safety analysis on constructors and destructors
< sipa> yes, i can read
< sipa> i don't know what you want to convey
< promag> see #15322, initially I couldn't understand who held the lock when ~BerkeleyEnvironment, then I realized there was no checking at destructors
< gribble> https://github.com/bitcoin/bitcoin/issues/15322 | wallet: Add missing cs_db lock by promag · Pull Request #15322 · bitcoin/bitcoin · GitHub
< sipa> ah
< promag> so I wonder if there are more cases like that
< sipa> sorry, i thought you were trying to say we should use something mentioned in that document, and i couldn't figure out what
< promag> no problem
< promag> I think this is tricky because we may be missing some important locks and we think it's all good because annotations "protect" us
< gmaxwell> I hope people aren't relying on those annotations instead of actually reviewing...
< bitcoin-git> [bitcoin] Empact opened pull request #15323: rpc: Expose g_is_mempool_loaded via getmempoolinfo (master...load-mempool-race) https://github.com/bitcoin/bitcoin/pull/15323
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15324: test: Make bloom tests deterministic (master...Mf1902-qaBloom) https://github.com/bitcoin/bitcoin/pull/15324
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/2c0867a1811b...b3a715301a0f
< bitcoin-git> bitcoin/master faee6c9 MarcoFalke: travis: Remove unused FUNCTIONAL_TESTS_CONFIG
< bitcoin-git> bitcoin/master facaae4 MarcoFalke: travis: Save cache when compilation took very long
< bitcoin-git> bitcoin/master b3a7153 MarcoFalke: Merge #15303: travis: Remove unused FUNCTIONAL_TESTS_CONFIG
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15303: travis: Remove unused FUNCTIONAL_TESTS_CONFIG (master...Mf1901-travisFun) https://github.com/bitcoin/bitcoin/pull/15303