< bitcoin-git>
bitcoin/master 1f77f67 Andrew Chow: tests: unify RPC argument to cli argument conversion and handle dicts and ...
< bitcoin-git>
bitcoin/master b5c5021 Andrew Chow: Refactor importwallet to extract data from the file and then import
< bitcoin-git>
bitcoin/master e6c58d3 Andrew Chow: Do not import private keys to wallets with private keys disabled
< bitcoin-git>
[bitcoin] laanwj merged pull request #15235: Do not import private keys to wallets with private keys disabled (master...fix-noprivs-import) https://github.com/bitcoin/bitcoin/pull/15235
< bitcoin-git>
[bitcoin] harding opened pull request #15314: [Doc] update release notes for changes up to cb35f1d (master...019-02-monthly-release-notes-update) https://github.com/bitcoin/bitcoin/pull/15314
< bitcoin-git>
[bitcoin] harding opened pull request #15315: [0.17] [Doc] Backport release note about PSBT doc (.17...019-02-backport-release-notes) https://github.com/bitcoin/bitcoin/pull/15315
< bitcoin-git>
bitcoin/master fa5278a MarcoFalke: qa: Use wallet to retrieve raw transactions
< bitcoin-git>
bitcoin/master 5c99bb0 MarcoFalke: Merge #15247: qa: Use wallet to retrieve raw transactions
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #15247: qa: Use wallet to retrieve raw transactions (master...Mf1901-qaWalletRaw) https://github.com/bitcoin/bitcoin/pull/15247
< dongcarl>
Hi all, if anyone can add https://github.com/bitcoin/bitcoin/pull/14856 to the "P2P refactor" board that'd be great. Also, could I get permissions to modify that board?
< dongcarl>
Do people think that future consensus meanings of the witness reserved value will most likely be in the form of a sha256d commitment?
< rex4539>
On master HEAD, I have few tests failing reliably. It's an old, slow machine with 4GB RAM so slowness could definitely be a factor here.
< provoostenator>
I'm trying to build a Descriptor composer. It should allow something like auto desc = PKHDescriptor(myCPubKey);
< provoostenator>
Not sure what the right approach is, and the abstract class stuff is a bit over my head.
< sipa>
provoostenator: oh, i was thinking about that
< sipa>
i'll pr it
< provoostenator>
The end goal is that I want to generate a descriptor like wpkh([000000/84'/0'/0']xpub.../0/*) without weird string concatenation.
< provoostenator>
sipa: awesome that would help!
< provoostenator>
Once that works, I would like to introduce descriptor-requests somehow. The same, but with xpub missing. The point of that is to ask a signer to fill in that part.
< provoostenator>
With that I can significantly reduce the amount of spaghetti in my hardware wallet integration WIP PR :-)
< provoostenator>
I suppose the lazy solution is just an all 0 public key.
< wumpus>
rex4539: by default it runs four tests at the same time which is too much for slower systems, certainly with little memory; it might help if you set -j1 on test runner?
< rex4539>
Running them individually it's the same failure.
< wumpus>
definitely looks like a test that takes much longer than expected and hits the timeout
< wumpus>
you might be able to make it pass by increasing the timeout value in the source
< bitcoin-git>
[bitcoin] Sjors opened pull request #15320: [Do Not Merge] break < Qt5.6 compatibility for addAction to test Travis (master...019/02/do-not-merge-qt52) https://github.com/bitcoin/bitcoin/pull/15320
< provoostenator>
(guess I could have done that on my own fork, anyway...)
< MarcoFalke>
provoostenator: The issue was closed accidentally because the description in #15308 was not updated to reflect the latest status of the pull
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #15321: doc: Add cs_main lock annotations for mapBlockIndex (master...Mf1902-docLoc) https://github.com/bitcoin/bitcoin/pull/15321
< bitcoin-git>
[bitcoin] practicalswift closed pull request #15111: Avoid UB (member call on nullptr) when failing to read randomness in the startup process (master...random-ub) https://github.com/bitcoin/bitcoin/pull/15111
< dongcarl>
ryanofsky:
< dongcarl>
ryanofsky: Could you see if the wording I just pushed makes sense?
< dongcarl>
Or should we explicitly mention that out of the box you can't override datadir?
< promag>
was this mentioned in the past? I wasn't aware :/
< sipa>
promag: what are you referring to?
< promag>
no thread safety analysis on constructors and destructors
< sipa>
yes, i can read
< sipa>
i don't know what you want to convey
< promag>
see #15322, initially I couldn't understand who held the lock when ~BerkeleyEnvironment, then I realized there was no checking at destructors