< bitcoin-git> [bitcoin] promag opened pull request #15350: qa: Drop RPC connection if --usecli (master...2019-01-fixusecli) https://github.com/bitcoin/bitcoin/pull/15350
< CubicEarth> Does anyone know the status of SIGHASH_NOINPUT? Discussion on the ML seems to have quieted down...
< bitcoin-git> [bitcoin] OverlordQ opened pull request #15351: Update linearize-hashes.py (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15351
< nelsonhb> Guangdong Pilot Free Trade Zone
< nelsonhb> Guilin High-tech Industrial Development Zone
< nelsonhb> Nanning Economic & Technological Development Area
< nelsonhb> Kunming High-tech Industrial Development Zone (biological medicine, new materials, electronic information, photoelectron, agriculture) and Kunming Economic and Technology Development Zone (mechanical equipment production, biological science and food industry, information industry, software).
< nelsonhb> Chenggong Industrial Park
< nelsonhb> Anning Industrial Park
< nelsonhb> Songming Yanglin Industrial Development Zone
< nelsonhb> Dongchuan Special Industrial Park
< nelsonhb> Xundian Special Industrial Park
< nelsonhb> Kunming Haikou Industrial Park.
< sidhujag> hey guys just wondering is coinbase outputs to witness programs (bech32) considered safe?
< sidhujag> i thought you normally would pay to legacy addresses in coinbase because witness programs aren't verified in coinbase
< sidhujag> i was watching blocks found a weird one pop up with 1 tx only.. and saw its outputting to a bech32
< sidhujag> 0000000000000000000ad0dd07019a8dae9aa5b6eb3d39782e9af8e082353b39
< bitcoin-git> [bitcoin] practicalswift opened pull request #15352: tests: Reduce noise level in test_bitcoin output (master...test_bitcoin-output-spam) https://github.com/bitcoin/bitcoin/pull/15352
< fanquake> jonasschnelli Are #7949 or #9502 Prs you'd still like to try and get into 0.18.0 ?
< gribble> https://github.com/bitcoin/bitcoin/issues/7949 | [RPC] Add RPC long poll notifications by jonasschnelli · Pull Request #7949 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9502 | [Qt] Add option to pause/resume block downloads by jonasschnelli · Pull Request #9502 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] merland opened pull request #15353: docs: Minor textual improvements in translation_strings_policy.md (master...patch-3) https://github.com/bitcoin/bitcoin/pull/15353
< provoostenator> Two new RPC methods probably ready, but awaiting a little more review love #14667 & #15226
< gribble> https://github.com/bitcoin/bitcoin/issues/14667 | Add deriveaddresses RPC util method by Sjors · Pull Request #14667 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15226 | Allow creating blank (empty) wallets (alternative) by achow101 · Pull Request #15226 · bitcoin/bitcoin · GitHub
< instagibbs> well, if we're letting a pure utility function in, I'll review...
< provoostenator> There was some general discussion about that. There's not really a safe alternative for deriveaddresses, because you'd have to implement descriptors. At least until we figure out how to properly library-ify the codebase.
< provoostenator> Longer term though: #14671
< gribble> https://github.com/bitcoin/bitcoin/issues/14671 | Utility to replace RPC calls that dont need wallet or chain context · Issue #14671 · bitcoin/bitcoin · GitHub
< luke-jr> dunno if it's worth finishing up, but at least as an example of a way to do a non-fork blockchain feature: https://github.com/bitcoin/bitcoin/compare/v0.17.1…luke-jr:extra_weight
< luke-jr> ugh, elipsis collapsed..
< luke-jr> dunno if it's worth finishing up, but at least as an example of a way to do a non-fork blockchain feature: https://github.com/bitcoin/bitcoin/compare/v0.17.1...luke-jr:extra_weight
< wumpus> some of the PRs in the 0.18 tag haven't been active for ages (#7949, #9502), might be better to remove them?
< gribble> https://github.com/bitcoin/bitcoin/issues/7949 | [RPC] Add RPC long poll notifications by jonasschnelli · Pull Request #7949 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9502 | [Qt] Add option to pause/resume block downloads by jonasschnelli · Pull Request #9502 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15354: doc: Add missing bitcoin-wallet tool manpages (master...Mf1902-docWalletTool) https://github.com/bitcoin/bitcoin/pull/15354
< sdaftuar> does anyone look at appveyor failures?
< wumpus> you mean, in general?
< sdaftuar> yeah
< wumpus> we do try to have both appveyor and travis pass before merging
< sdaftuar> ok... i can try to debug then. seems like it fails randomly so wasn't sure how to treat failures on a PR
< wumpus> is there a problem with that at the moment?
< wumpus> yea two CI's is double the chance of random failures, unfortunately
< sdaftuar> i haven't tried to do any debugging yet, i'll see if i can track it down
< wumpus> ok let me know if you'd like me to have a look
< luke-jr> it'd be nice if a failure popped up a console on the dev's screen to debug :P
< wumpus> oh yes
< wumpus> interactive debug that would be a great feature
< instagibbs> I've previously tried to get travis to cough up a core dump on various kinds of errors, was unable to
< wumpus> much more efficient than trying to reproduce the exact environment locally (for appveyor that isn't even an option for me I don't have windows)
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5029e94f855c...645a1264f336
< bitcoin-git> bitcoin/master 7fdb92e OverlordQ: Update linearize-hashes.py
< bitcoin-git> bitcoin/master 645a126 MarcoFalke: Merge #15351: Update linearize-hashes.py
< wumpus> "Update linearize-hashes.py" that's a terrible PR title
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15351: Update linearize-hashes.py (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15351
< luke-jr> wumpus: re status of #13339 there's quite a few unresolved issues; I have an older version I use in Knots that ignores the escaping issue entirely, but it seemed like people didn't like that
< gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
< luke-jr> (the current PR has copyrighted code that isn't licensed for redistribution)
< Randolf> That could be a big problem. Whoops!
< wumpus> ok, removiing it from the tag then
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/645a1264f336...ddae781a0cc1
< bitcoin-git> bitcoin/master fa1db33 MarcoFalke: travis: Only exit early if compilation took longer than 30 min
< bitcoin-git> bitcoin/master ddae781 MarcoFalke: Merge #15349: travis: Only exit early if compilation took longer than 30 m...
< wumpus> (this doesn't mean it can't still make 0.18, but I don't think it makes sense to prioritize it for review as it is)
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15349: travis: Only exit early if compilation took longer than 30 min (master...Mf1902-travis30) https://github.com/bitcoin/bitcoin/pull/15349
< wumpus> luke-jr: I'm surprised and shocked that escaping turns out to be so difficult
< wumpus> I used to think it was simply replacing ' by '\'' and surrounding by single quotes
< wumpus> though usually it's preferable to avoid it entirely by not going through the shell and passing the arguments one-to-one directly to execv() etc
< luke-jr> wumpus: that works fine on *nix, just not Windows
< luke-jr> wumpus: on Windows, the command line is passed as one big string to the program, and the program decides how to parse it
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ddae781a0cc1...12a910c9435c
< bitcoin-git> bitcoin/master 7bb45e4 Jonas Schnelli: Qt: update header count regardless of update delay
< bitcoin-git> bitcoin/master e8db6b8 Jonas Schnelli: Qt: Fix update headers-count
< bitcoin-git> bitcoin/master 12a910c Wladimir J. van der Laan: Merge #15091: GUI: fix model overlay header sync
< bitcoin-git> [bitcoin] laanwj merged pull request #15091: GUI: fix model overlay header sync (master...2019/01/qt_fix_modal) https://github.com/bitcoin/bitcoin/pull/15091
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/12a910c9435c...1a6036978e9d
< bitcoin-git> bitcoin/master fa0fe3b MarcoFalke: contrib: Add missing wallet tool to gen-manpages.sh
< bitcoin-git> bitcoin/master fa1e281 MarcoFalke: doc: Add missing wallet-tool manpages
< bitcoin-git> bitcoin/master 1a60369 MarcoFalke: Merge #15354: doc: Add missing bitcoin-wallet tool manpages
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15354: doc: Add missing bitcoin-wallet tool manpages (master...Mf1902-docWalletTool) https://github.com/bitcoin/bitcoin/pull/15354
< sdaftuar> wumpus: fyi one of the appveyor test failures we regularly see is due to an actual test bug, i'll PR something soon
< wumpus> sdaftuar: thanks !
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1a6036978e9d...5cdb82111cc1
< bitcoin-git> bitcoin/master fa2a69f practicalswift: doc: Add cs_main lock annotations for mapBlockIndex
< bitcoin-git> bitcoin/master 5cdb821 MarcoFalke: Merge #15321: doc: Add cs_main lock annotations for mapBlockIndex
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15321: doc: Add cs_main lock annotations for mapBlockIndex (master...Mf1902-docLoc) https://github.com/bitcoin/bitcoin/pull/15321
< bitcoin-git> [bitcoin] JBaczuk opened pull request #15357: Move maxTxFee initialization to init.cpp (master...fix_maxtxfee) https://github.com/bitcoin/bitcoin/pull/15357
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15358: util: Add SetupHelpOptions() (master...Mf1902-Help) https://github.com/bitcoin/bitcoin/pull/15358
< promag> sdaftuar: please include #15350 in your branch and see if it fixes the slow down
< gribble> https://github.com/bitcoin/bitcoin/issues/15350 | qa: Drop RPC connection if --usecli by promag · Pull Request #15350 · bitcoin/bitcoin · GitHub
< kewde[m]> randrange(0) -> wraps around and caused our tests to hang for a while :P (found by @tecnovert)
< kewde[m]> 0 is a nonsensical value to enter, but our test suite sometimes found itself in that situation and created some interesting fireworks..
< gmaxwell> kewde[m]: I'm not sure of the purpose of your report.
< gmaxwell> If there was any place in the codebase where it could be called with 0 that would be a bug.
< gmaxwell> But AFAIK there is not.
< gmaxwell> so it just sounds like your test suite is broken.
< sipa> we can document the precondition range>0
< sipa> but otherwise i don't see what needs to be done
< gmaxwell> hm. did we have clearer docs on another one? I thought we did.
< bitcoin-git> [bitcoin] kewde opened pull request #15359: Prevent undefined behavior of randrange() (@tecnovert) (master...patch-2) https://github.com/bitcoin/bitcoin/pull/15359
< gmaxwell> That isn't undefined behavior.
< sipa> does it go into an infinite loop? (if so, that's technically UB)
< gmaxwell> it's not an infinite loop, technically. :)
< kewde[m]> It caused weird behavior when the value was used afterwards, anyways, it returned a value that was out of the max of the range became 0xFFFFFFFFFFFFFFFF.
< sipa> well you're using the function wrong
< gmaxwell> If it were to change at all, it should change to assert. But considering randrange gets used in innerloops and whatnot, I'm dubious of the value of that tradeoff.
< sipa> returning 0 is equally invalid, as it's outside of the range [0, 0)
< bitcoin-git> [bitcoin] kewde closed pull request #15359: Add zero check to randrange() (@tecnovert) (master...patch-2) https://github.com/bitcoin/bitcoin/pull/15359
< kewde[m]> Yeah makes sense, I didn't spot the ) bracket at the end. I just thought I'd make a note of it, it was interesting bug we had.
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5cdb82111cc1...72d34c0edc5a
< bitcoin-git> bitcoin/master 6180b5f Carl Dong: netaddress: Fix indentation in IsLocal
< bitcoin-git> bitcoin/master 87aa0b4 Carl Dong: netaddress: Make IPv4 loopback comment more descriptive
< bitcoin-git> bitcoin/master 72d34c0 Wladimir J. van der Laan: Merge #15343: [doc] netaddress: Make IPv4 loopback comment more descriptiv...
< bitcoin-git> [bitcoin] laanwj merged pull request #15343: [doc] netaddress: Make IPv4 loopback comment more descriptive (master...2019-02-islocal-clarify) https://github.com/bitcoin/bitcoin/pull/15343
< bitcoin-git> [bitcoin] sdaftuar opened pull request #15360: [qa] Create cached blocks with current timestamps (master...2019-01-debug-appveyor) https://github.com/bitcoin/bitcoin/pull/15360