00:04 < anon563718> what's the recommended way, using walletnotify to reach the server for own transactions, or using zmq and filter every transaction to see if it belongs to the wallet?

00:04 < anon563718> I see there was a time someone proposed a zmq for wallet transactions only, but never got implemented

00:07 < gmaxwell> Poll the RPC.

00:07 < gmaxwell> Any kind of notify has the risk of missing messages, so you need to poll regardless. And once you've implemented polling the only additional gain from any kind of notifying is a potential latency reduction.

00:08 < gmaxwell> But even a once per second poll is very slow, and yet provides reasonably low latency for transaction delay for almost any application.

00:09 < gmaxwell> Polling isn't a good solution for some public web service where there might be thousands of clients, but on a private system where there is only one or a few clients, it's an excellent, simple, and reliable solution.

00:26 < promag> anon563718: +1 gmaxwell, you can also have a large period, say 30sec, and use -walletnotify to trigger a faster poll

00:27 < promag> anon563718: you might be interested in #7949

00:27 < gribble> https://github.com/bitcoin/bitcoin/issues/7949 | [RPC] Add RPC long poll notifications by jonasschnelli · Pull Request #7949 · bitcoin/bitcoin · GitHub

00:39 < anon563718> Thanks for the recommendations, I came across 7949 but it seems it's not implemented yet

00:43 < anon563718> when you mention polling rpc, which command is the one you refer to? listsinceblocks?

01:07 < belcher> anon563718 listtransactions

01:32 < kanzure> i've implemented polling in the context of web applications with many workers or clients; the trick is to find the most recent common block that you have processed vs haven't processed yet.

02:17 < echeveria> kanzure: and handle reorgs.

02:19 < kanzure> yes. most recent common is required because otherwise you wont handle reorgs correctly.

11:29 < provoostenator> Any wallet / keypool gurus want to review #14075? I got confused multiple times mostly due to my own stupidity, but I think it's correct now...

11:29 < gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub

12:04 < bitcoin-git> [bitcoin] domob1812 opened pull request #15381: Optionally return HTTP_OK for RPC errors (master...httprpc-error-code) https://github.com/bitcoin/bitcoin/pull/15381

12:28 < provoostenator> #proposedmeetingtopic minimum QT version for v0.18, see #13478

12:28 < gribble> https://github.com/bitcoin/bitcoin/issues/13478 | [RFC] gui: Minimum required Qt5 · Issue #13478 · bitcoin/bitcoin · GitHub

12:28 < provoostenator> moneyball: I don't think that worked

13:10 < fanquake> provoostenator I'll update the parent of that issue

13:11 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6f4e0d154256...e84e0d4b5e1f

13:11 < bitcoin-git> bitcoin/master 30d0f7b benthecarman: rpc: Fix for segfault if combinepsbt called with empty inputs

13:11 < bitcoin-git> bitcoin/master e84e0d4 MarcoFalke: Merge #15337: rpc: Fix for segfault if combinepsbt called with empty input...

13:12 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15337: rpc: Fix for segfault if combinepsbt called with empty inputs (master...rpc_combinepbst_empty_fix) https://github.com/bitcoin/bitcoin/pull/15337

13:24 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15380: trivial: correct parameter name in comments (master...fix-comment) https://github.com/bitcoin/bitcoin/pull/15380

13:37 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ff9e197212eb...ad039aa0d3e8

13:37 < bitcoin-git> bitcoin/master 50e6472 Russell Yanofsky: Move ParseConfirmTarget from rpc/mining to rpc/util

13:37 < bitcoin-git> bitcoin/master ad039aa MarcoFalke: Merge #15373: Move ParseConfirmTarget from rpc/mining to rpc/util

13:37 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15373: Move ParseConfirmTarget from rpc/mining to rpc/util (master...pr/movtarget) https://github.com/bitcoin/bitcoin/pull/15373

13:48 < moneyball> provoostenator: thanks for the proposed topic I'll add it now

14:28 < wumpus> PSA I've bumped my gpg key's expiration date (both the binaries signing key and my personal one), please --refresh-keys or they'll expire in three days

14:37 < midnightmagic> wumpus: thanks for notifying!

14:52 < wumpus> np!

15:03 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ad039aa0d3e8...1bc149d05b09

15:03 < bitcoin-git> bitcoin/master a94e470 Martin Erlandsson: A few textual improvements

15:03 < bitcoin-git> bitcoin/master 1bc149d MarcoFalke: Merge #15353: docs: Minor textual improvements in translation_strings_poli...

15:04 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15353: docs: Minor textual improvements in translation_strings_policy.md (master...patch-3) https://github.com/bitcoin/bitcoin/pull/15353

15:09 < bitcoin-git> [bitcoin] Sjors opened pull request #15382: WIP [util] add runCommandParseJSON (master...2019/02/runCommandParseJSON) https://github.com/bitcoin/bitcoin/pull/15382

16:35 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15383: [rpc] mining: Report -1 for uninitialized currentblockweight and currentblocktx (master...Mf1902-rpcMining) https://github.com/bitcoin/bitcoin/pull/15383

17:06 < phantomcircuit> echeveria, if (reorg) assert(false)

19:46 < meshcollider> provoostenator: re. https://github.com/bitcoin/bitcoin/pull/14481#pullrequestreview-202070495

19:46 < meshcollider> redeemScript isn't overloaded in listunspent

19:47 < meshcollider> I realise I forgot to update the release notes but is that what you're referring to?

20:51 < bitcoin-git> [bitcoin] Empact closed pull request #15377: build: Disallow shadowing variables via -isystem, -Wshadow (master...wshadow) https://github.com/bitcoin/bitcoin/pull/15377

21:19 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15336: Enable moving of hashes, uints, outpoints (master...master) https://github.com/bitcoin/bitcoin/pull/15336

21:44 < bitcoin-git> [bitcoin] macgeek30 opened pull request #15384: Removed unnecessary commas in a compound predicate. (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15384

21:45 < bitcoin-git> [bitcoin] macgeek30 closed pull request #15384: Removed unnecessary commas in a compound predicate. (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15384

21:50 < bitcoin-git> [bitcoin] practicalswift closed pull request #14239: Avoid dividing by zero in EstimateMedianVal (policy)/ConnectTip (validation)/CreateTransaction (wallet) (master...undefined-behaviour-division-by-zero) https://github.com/bitcoin/bitcoin/pull/14239

21:55 < bitcoin-git> [bitcoin] macgeek30 opened pull request #15385: Removed unnecessary commas in README.md (master...patch-3) https://github.com/bitcoin/bitcoin/pull/15385

22:02 < bitcoin-git> [bitcoin] macgeek30 closed pull request #15385: Removed unnecessary commas in README.md (master...patch-3) https://github.com/bitcoin/bitcoin/pull/15385

22:04 < gmaxwell> what,is,happening,here?

22:23 < bitcoin-git> [bitcoin] practicalswift closed pull request #15262: build: Enable C++14 in build, require C++14 compiler. (master...c++14) https://github.com/bitcoin/bitcoin/pull/15262

22:51 < bitcoin-git> [bitcoin] practicalswift closed pull request #14479: serialization: Don't invoke undefined behaviour when doing type punning (master...serialization-ub) https://github.com/bitcoin/bitcoin/pull/14479

23:15 < bitcoin-git> [bitcoin] Csi18nAlistairMann closed pull request #15374: docs: add "sections" info to example bitcoin.conf (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15374