< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15489: doc: Update release process for snap package (master...1902-docSnap) https://github.com/bitcoin/bitcoin/pull/15489
< sipa> promag_: i think so
< promag_> sipa: could that cause problems?
< sipa> we should try that, but i don't think so
< promag_> in a way both work for each other by calling DisconnectTip
< sipa> right, they'll at best just take turns in calling DisconnectTip
< promag_> eventually the higher invalidation quits first
< promag_> not sure about the code after that loop
< promag_> InvalidChainFound and NotifyBlockTip
< sipa> shouldn't hurt to call either of those twice
< sipa> (i say should; it's a good point that we should test this)
< promag_> maybe by adding some sleeps between iterations?
< promag_> we could disallow concurrent invalidateblock
< gwillen> achow101: okay after investigating I think the most likely cause is that I ran some prior version of your PR before it was merged, and fucked up my wallet, so nevermind
< sipa> gwillen: #15427 may be of interest to you
< gribble> https://github.com/bitcoin/bitcoin/issues/15427 | Add support for descriptors to utxoupdatepsbt by sipa · Pull Request #15427 · bitcoin/bitcoin · GitHub
< gwillen> (my CKeyMetadata entries have the KeyOriginInfo, but they are missing the has_key_origin bool afterwards. I can't imagine any likely way that could have happened other than "I ran a version of the code that didn't have that yet"
< gwillen> sipa: this is indeed of interest to me, thanks -- I had made a note to look at it, but not gotten around to doing so
< bitcoin-git> [bitcoin] iamgru opened pull request #15490: Update copyright headers to 2019 (master...master) https://github.com/bitcoin/bitcoin/pull/15490
< bitcoin-git> [bitcoin] fanquake closed pull request #15490: Update copyright headers to 2019 (master...master) https://github.com/bitcoin/bitcoin/pull/15490
< bitcoin-git> [bitcoin] gwillen opened pull request #15491: wallet: Improve log output for errors during load (master...feature-improve-wallet-load-debug-output) https://github.com/bitcoin/bitcoin/pull/15491
< abc> help
< abc> ls
< abc> HELP
< abc> --HELP
< provoostenator> gwillen: #15424 can help you get rid of these messages, though we should make sure nobody who didn't use any intermediate achow101 branches does not see this message.
< gribble> https://github.com/bitcoin/bitcoin/issues/15424 | [wallet] wallet-tool: command to remove key metadata by Sjors · Pull Request #15424 · bitcoin/bitcoin · GitHub
< gwillen> aha, thanks provoostenator
< gwillen> I am 95% sure my use of intermediate achow branches is the culprit here
< gwillen> fortunately it's just a test wallet anyway so not a big issue in my case
< gwillen> provoostenator: #15491 makes the messages slightly more informative
< gribble> https://github.com/bitcoin/bitcoin/issues/15491 | wallet: Improve log output for errors during load by gwillen · Pull Request #15491 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] Sjors opened pull request #15492: [rpc] remove deprecated generate method (master...2019/02/rpc-generate-remove) https://github.com/bitcoin/bitcoin/pull/15492
< bitcoin-git> [bitcoin] promag opened pull request #15493: rfc: Add -printconfig arg to bitcoind (master...2019-02-printconfig) https://github.com/bitcoin/bitcoin/pull/15493
< fanquake> wumpus could merge 15462 if you're happy with it
< wumpus> okay thanks !
< promag> that's the smallest change to fix the problem
< promag> but I believe #15478 is a superior solution - after branching 0.18
< gribble> https://github.com/bitcoin/bitcoin/issues/15478 | wip: gui: Refactor open wallet activity by promag · Pull Request #15478 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d88f7f8764b1...6f43ed4c5a3a
< bitcoin-git> bitcoin/master a720a98 João Barbosa: gui: Fix async open wallet call order
< bitcoin-git> bitcoin/master 6f43ed4 Wladimir J. van der Laan: Merge #15462: gui: Fix async open wallet call order
< bitcoin-git> [bitcoin] laanwj merged pull request #15462: gui: Fix async open wallet call order (master...2019-02-fix-15455) https://github.com/bitcoin/bitcoin/pull/15462
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6f43ed4c5a3a...a4f9c024c650
< bitcoin-git> bitcoin/master 6ad79cb Chun Kuan Lee: wallet: Use fsbridge::ifstream to fix Windows path issue
< bitcoin-git> bitcoin/master a4f9c02 Wladimir J. van der Laan: Merge #15468: wallet: Use fsbridge::ifstream to fix Windows path issue
< bitcoin-git> [bitcoin] laanwj merged pull request #15468: wallet: Use fsbridge::ifstream to fix Windows path issue (master...win-wallet-fix) https://github.com/bitcoin/bitcoin/pull/15468
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a4f9c024c650...a0d4e79b4dbb
< bitcoin-git> bitcoin/master fa9ff8f MarcoFalke: doc: Remove misleading hint in getrawtransaction
< bitcoin-git> bitcoin/master 9999879 MarcoFalke: refactor: Use RPCHelpMan::IsValidNumArgs in getrawtransaction
< bitcoin-git> bitcoin/master a0d4e79 Wladimir J. van der Laan: Merge #15477: doc: Remove misleading hint in getrawtransaction
< bitcoin-git> [bitcoin] laanwj merged pull request #15477: doc: Remove misleading hint in getrawtransaction (master...Mf1902-rpcRawDocFix) https://github.com/bitcoin/bitcoin/pull/15477
< provoostenator> Two wish list ites for Github: 1) order commits logically, not by timestamp. 2) show header files above implementation files instead of alphabetically.
< promag> provoostenator: 1) +1 2) don't understand
< promag> provoostenator: btw, mind checking #15493?
< gribble> https://github.com/bitcoin/bitcoin/issues/15493 | rfc: Add -printconfig arg to bitcoind by promag · Pull Request #15493 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #15494: rpc: Return whether the block was invalidated on invalidateblock (master...2019-02-invalidateblock) https://github.com/bitcoin/bitcoin/pull/15494
< provoostenator> promag: github shows .cpp files above .h files which also confuses me when I read top to bottom.
< promag> oh got it
< sdaftuar> gmaxwell: good idea re: crediting the bug report author; i added a credit to one of the commit messages
< bitcoin-git> [bitcoin] domob1812 opened pull request #15495: Add regtests for HTTP status codes. (master...test-http-code) https://github.com/bitcoin/bitcoin/pull/15495
< wumpus> yes, crediting reporters of bugs is a good thing
< bitcoin-git> [bitcoin] Sjors opened pull request #15496: [rpc] deriveaddress: rename range 'begin' argument to 'start' (master...2019/02/begin_start) https://github.com/bitcoin/bitcoin/pull/15496
< provoostenator> ^ fixes inconsistency with importmutli
< instagibbs> my ideas, so ack ;)
< provoostenator> Needs poet
< promag> :)
< bitcoin-git> [bitcoin] sipa opened pull request #15497: Consistent range arguments in scantxoutset/importmulti/deriveaddresses (master...201902_rpcconsistentrange) https://github.com/bitcoin/bitcoin/pull/15497
< gmaxwell> sipa: IIRC scan is explicitly expiremental without an interface we've promised to make stable.
< sipa> gmaxwell: right, but my PR doesn't break scantxoutset
< sipa> so i don't think it matters
< sipa> it breaks the (unreleased) notation for importmulti and deriveaddresses
< gmaxwell> sipa: Right, my point was that if you shyed away from breaking it and would have done something else otherwise, you didn't need to.
< sipa> ah, i see