< promag_>
in a way both work for each other by calling DisconnectTip
< sipa>
right, they'll at best just take turns in calling DisconnectTip
< promag_>
eventually the higher invalidation quits first
< promag_>
not sure about the code after that loop
< promag_>
InvalidChainFound and NotifyBlockTip
< sipa>
shouldn't hurt to call either of those twice
< sipa>
(i say should; it's a good point that we should test this)
< promag_>
maybe by adding some sleeps between iterations?
< promag_>
we could disallow concurrent invalidateblock
< gwillen>
achow101: okay after investigating I think the most likely cause is that I ran some prior version of your PR before it was merged, and fucked up my wallet, so nevermind
< gwillen>
(my CKeyMetadata entries have the KeyOriginInfo, but they are missing the has_key_origin bool afterwards. I can't imagine any likely way that could have happened other than "I ran a version of the code that didn't have that yet"
< gwillen>
sipa: this is indeed of interest to me, thanks -- I had made a note to look at it, but not gotten around to doing so
< bitcoin-git>
[bitcoin] gwillen opened pull request #15491: wallet: Improve log output for errors during load (master...feature-improve-wallet-load-debug-output) https://github.com/bitcoin/bitcoin/pull/15491
< abc>
help
< abc>
ls
< abc>
HELP
< abc>
--HELP
< provoostenator>
gwillen: #15424 can help you get rid of these messages, though we should make sure nobody who didn't use any intermediate achow101 branches does not see this message.
< bitcoin-git>
bitcoin/master fa9ff8f MarcoFalke: doc: Remove misleading hint in getrawtransaction
< bitcoin-git>
bitcoin/master 9999879 MarcoFalke: refactor: Use RPCHelpMan::IsValidNumArgs in getrawtransaction
< bitcoin-git>
bitcoin/master a0d4e79 Wladimir J. van der Laan: Merge #15477: doc: Remove misleading hint in getrawtransaction
< bitcoin-git>
[bitcoin] laanwj merged pull request #15477: doc: Remove misleading hint in getrawtransaction (master...Mf1902-rpcRawDocFix) https://github.com/bitcoin/bitcoin/pull/15477
< provoostenator>
Two wish list ites for Github: 1) order commits logically, not by timestamp. 2) show header files above implementation files instead of alphabetically.
< bitcoin-git>
[bitcoin] promag opened pull request #15494: rpc: Return whether the block was invalidated on invalidateblock (master...2019-02-invalidateblock) https://github.com/bitcoin/bitcoin/pull/15494
< provoostenator>
promag: github shows .cpp files above .h files which also confuses me when I read top to bottom.
< promag>
oh got it
< sdaftuar>
gmaxwell: good idea re: crediting the bug report author; i added a credit to one of the commit messages
< wumpus>
yes, crediting reporters of bugs is a good thing
< bitcoin-git>
[bitcoin] Sjors opened pull request #15496: [rpc] deriveaddress: rename range 'begin' argument to 'start' (master...2019/02/begin_start) https://github.com/bitcoin/bitcoin/pull/15496
< provoostenator>
^ fixes inconsistency with importmutli
< instagibbs>
my ideas, so ack ;)
< provoostenator>
Needs poet
< promag>
:)
< bitcoin-git>
[bitcoin] sipa opened pull request #15497: Consistent range arguments in scantxoutset/importmulti/deriveaddresses (master...201902_rpcconsistentrange) https://github.com/bitcoin/bitcoin/pull/15497
< gmaxwell>
sipa: IIRC scan is explicitly expiremental without an interface we've promised to make stable.
< sipa>
gmaxwell: right, but my PR doesn't break scantxoutset
< sipa>
so i don't think it matters
< sipa>
it breaks the (unreleased) notation for importmulti and deriveaddresses
< gmaxwell>
sipa: Right, my point was that if you shyed away from breaking it and would have done something else otherwise, you didn't need to.