04:12
<
bitcoin-git >
bitcoin/master 1cff3d6 Gleb Naumenko: Change in transaction pull scheduling to prevent InvBlock-related attacks
04:12
<
bitcoin-git >
bitcoin/master b9b26d9 Pieter Wuille: Merge #14897: randomize GETDATA(tx) request order and introduce bias towar...
04:29
<
meshcollider >
I've put a few wallet PRs that we could hope to get in on the milestone, maybe not all are feasible, depends how avid reviewers are this week :)
04:30
<
meshcollider >
Definitely the open wallet menu should go in, and it'd be nice to have the listuspent segwit PR since its the last unmerged on the segwit project
06:55
<
fanquake >
promag think 15153 is good enough now. Still some behaviour that can be cleaned up later. Could you rebase 15195 ontop of the latest version of 15153, be good to get that into 0.18 too.
09:34
<
promag >
fanquanke: I prefer to rebase after merge, otherwise I'll have to rebase again
09:41
<
provoostenator >
promag: I can't reason about the things that might go wrong when a wallet keeps rescanning after a user cancels the load action.
09:41
<
provoostenator >
Can it lead to data loss? Crashes?
09:41
<
provoostenator >
I fully expect users to just keep trying to open the same wallet, while that rescan is still going.
11:31
<
bitcoin-git >
bitcoin/master d855e4c practicalswift: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an in...
11:31
<
bitcoin-git >
bitcoin/master 6fc656a Wladimir J. van der Laan: Merge #14242: Avoid triggering undefined behaviour (std::memset(nullptr, 0...
11:31
<
bitcoin-git >
[bitcoin] laanwj merged pull request #14242: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid string is passed to DecodeSecret(...) (master...ub-in-DecodeSecret)
https://github.com/bitcoin/bitcoin/pull/14242
13:49
<
fanquake >
promag fair enough, I'll review post rebase
14:01
<
bitcoin-git >
bitcoin/master eea02be practicalswift: Add locking annotation for vNodes. vNodes is guarded by cs_vNodes.
14:01
<
bitcoin-git >
bitcoin/master 30495d1 MarcoFalke: Merge #15201: net: Add missing locking annotation for vNodes. vNodes is gu...
14:25
<
benthecarman >
Is there a better way for checking the address format than just seeing what the address starts with
14:31
<
promag >
benthecarman: not that I'm aware of, why?
14:32
<
benthecarman >
promag: just making sure I am doing something correctly
15:39
<
bitcoin-git >
bitcoin/master faa4647 MarcoFalke: wallet: Add lock annotation for mapAddressBook
15:39
<
bitcoin-git >
bitcoin/master 0206956 MarcoFalke: Merge #15365: wallet: Add lock annotation for mapAddressBook
15:44
<
bitcoin-git >
bitcoin/master faf3d22 MarcoFalke: test_runner: Remove unused --force option
15:44
<
bitcoin-git >
bitcoin/master fae8b8b MarcoFalke: qa: Add tool-prefix to functional test readme
15:44
<
bitcoin-git >
bitcoin/master 1477933 MarcoFalke: Merge #15370: test_runner: Remove unused --force option
17:49
<
bitcoin-git >
bitcoin/master 9ad5ca1 David A. Harding: Release notes: integrate detached & rm backports
17:49
<
bitcoin-git >
bitcoin/master 5d35d43 David A. Harding: Update release notes through to cb35f1d3
17:49
<
bitcoin-git >
bitcoin/master d5dbb45 MarcoFalke: Merge #15314: [Doc] update release notes for changes up to cb35f1d
18:40
<
achow101 >
there's a wallet meeting today, right?
18:44
<
gwillen >
achow101: as far as I know, in 15 minutes
18:46
<
sipa >
yup, will be there
18:53
<
meshcollider >
Yep
19:00
<
meshcollider >
#startmeeting
19:00
<
lightningbot >
Useful Commands: #action #agreed #help #info #idea #link #topic.
19:00
<
meshcollider >
#bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
19:01
<
achow101 >
only half here
19:01
<
meshcollider >
Ok, topics?
19:01
<
meshcollider >
I guess we should start with discussing what wallet PRs we can aim to get into 0.18
19:03
<
gwillen >
yes hello
19:04
<
gwillen >
I am pestering for people to go review #13932
19:04
<
achow101 >
also review #15226 pls
19:05
<
jnewbery >
only wallet PRs ^
19:06
<
achow101 >
#14075 and #14021 would be nice, but they're a bit more involved
19:06
<
meshcollider >
Yes, I put them on the milestone but not sure they'll be ready in time
19:07
<
achow101 >
there's also a merge conflict between those two and 15226 which may not be trivial to resolve, so i don't think we can get all of them in
19:09
<
meshcollider >
I would really like at least #14021 but we'll see I guess
19:09
<
meshcollider >
achow101: Is 15226 your highest priority one
19:10
<
jnewbery >
I'd love to see #15288 merged soon since we now seem to have some momentum in that series of PRs, but it might be better to do that after forking 0.18
19:10
<
jnewbery >
it's a very easy review. Lots of line change but all very mechanical, and nicely structured commits
19:10
<
meshcollider >
jnewbery: yeah I think after 0.18 is better, but I agree
19:10
<
achow101 >
currently 14021 is my highest priority
19:11
<
achow101 >
(since 14491 is merged now)
19:12
<
jnewbery >
achow101: perhaps you could give a summary of the state of HWI? How far are we from HWI in master?
19:12
<
jnewbery >
instagibbs: or you if you're around ^
19:12
<
meshcollider >
I think #14912 is tracking
19:13
<
achow101 >
hwi has all basic functionality completed for the 5 common hardware wallets
19:13
<
achow101 >
provoostenator has a branch for calling it from core
19:14
<
achow101 >
we would need that and 14021 and 14075 for hwi to work.
19:15
<
achow101 >
(gtg, have to take a quiz now)
19:15
<
meshcollider >
Also #14481 is the last PR on the "Segwit" github project which hasn't gone in, it'd be nice to have that in for 0.18
19:16
<
meshcollider >
Quite a small PR to review
19:16
<
sipa >
meshcollider: i'm slightly inclined to instead just aim to have signrawtransaction etc work with descriptors
19:16
<
sipa >
as listunspent gives the descriptors already
19:17
<
sipa >
(not an objection to also doing that PR... but i suspect in the end the descriptor based approach is more convenient)
19:19
<
meshcollider >
sipa: I think having both is nice, but yeah making descriptors more consistently used across the RPCs would be a nice change
19:19
<
meshcollider >
But we can't aim for that in 0.18
19:21
<
meshcollider >
Does anyone have any other topics for the meeting?
19:21
<
meshcollider >
sipa: how's the checksum search coming
19:22
<
sipa >
meshcollider: #15368
19:22
<
sipa >
i'll add documentation and release notes today
19:24
<
meshcollider >
Looks like there's nothing else to discuss this week
19:25
<
meshcollider >
#endmeeting
19:25
<
meshcollider >
Thanks everyone
19:25
<
promag >
jnewbery: do you think I should fix your case in the open wallet pr?
19:26
<
jnewbery >
I think so, unless you can explain why it isn't a problem
19:26
<
jnewbery >
is there a reason you wouldn't want the file checking in the LoadWallet() function?
19:27
<
promag >
I don't think I thought of that, it was just a small step towards minimizing code duplication
19:28
<
promag >
long term I'd like to break CreateWalletFromFile so that the UI can have the wallet interface asap
19:29
<
promag >
I'll update the branch then
19:37
<
jnewbery >
thanks!
19:44
<
bitcoin-git >
bitcoin/master dfbf117 Jordan Baczuk: Move maxTxFee initialization to init.cpp
19:44
<
bitcoin-git >
bitcoin/master 2945492 MarcoFalke: Merge #15357: rpc: Don't ignore `-maxtxfee` when wallet is disabled
19:55
<
promag >
forgot to mention #15341 on the meeting.. is it worth?