< bitcoin-git> [bitcoin] sipa pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9127bd7abaf8...b9b26d9c3615
< bitcoin-git> bitcoin/master 1cff3d6 Gleb Naumenko: Change in transaction pull scheduling to prevent InvBlock-related attacks
< bitcoin-git> bitcoin/master b9b26d9 Pieter Wuille: Merge #14897: randomize GETDATA(tx) request order and introduce bias towar...
< bitcoin-git> [bitcoin] sipa merged pull request #14897: randomize GETDATA(tx) request order and introduce bias toward outbound (master...master) https://github.com/bitcoin/bitcoin/pull/14897
< meshcollider> I've put a few wallet PRs that we could hope to get in on the milestone, maybe not all are feasible, depends how avid reviewers are this week :)
< meshcollider> Definitely the open wallet menu should go in, and it'd be nice to have the listuspent segwit PR since its the last unmerged on the segwit project
< fanquake> promag think 15153 is good enough now. Still some behaviour that can be cleaned up later. Could you rebase 15195 ontop of the latest version of 15153, be good to get that into 0.18 too.
< sipa> #15153
< gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
< promag> fanquanke: I prefer to rebase after merge, otherwise I'll have to rebase again
< provoostenator> promag: I can't reason about the things that might go wrong when a wallet keeps rescanning after a user cancels the load action.
< provoostenator> Can it lead to data loss? Crashes?
< provoostenator> I fully expect users to just keep trying to open the same wallet, while that rescan is still going.
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b9b26d9c3615...6fc656a410b6
< bitcoin-git> bitcoin/master d855e4c practicalswift: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an in...
< bitcoin-git> bitcoin/master 6fc656a Wladimir J. van der Laan: Merge #14242: Avoid triggering undefined behaviour (std::memset(nullptr, 0...
< bitcoin-git> [bitcoin] laanwj merged pull request #14242: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid string is passed to DecodeSecret(...) (master...ub-in-DecodeSecret) https://github.com/bitcoin/bitcoin/pull/14242
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #15370: test_runner: Remove unused --force option (master...Mf1902-qaWinForce) https://github.com/bitcoin/bitcoin/pull/15370
< fanquake> promag fair enough, I'll review post rebase
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6fc656a410b6...30495d1e756c
< bitcoin-git> bitcoin/master eea02be practicalswift: Add locking annotation for vNodes. vNodes is guarded by cs_vNodes.
< bitcoin-git> bitcoin/master 30495d1 MarcoFalke: Merge #15201: net: Add missing locking annotation for vNodes. vNodes is gu...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15201: net: Add missing locking annotation for vNodes. vNodes is guarded by cs_vNodes. (master...cs_vNodes) https://github.com/bitcoin/bitcoin/pull/15201
< benthecarman> Is there a better way for checking the address format than just seeing what the address starts with
< promag> benthecarman: not that I'm aware of, why?
< benthecarman> promag: just making sure I am doing something correctly
< bitcoin-git> [bitcoin] benthecarman opened pull request #15371: gui: Optimization for bech32 qr codes (master...gui_bech_32_optimized_qr_codes) https://github.com/bitcoin/bitcoin/pull/15371
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/30495d1e756c...020695660859
< bitcoin-git> bitcoin/master faa4647 MarcoFalke: wallet: Add lock annotation for mapAddressBook
< bitcoin-git> bitcoin/master 0206956 MarcoFalke: Merge #15365: wallet: Add lock annotation for mapAddressBook
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15365: wallet: Add lock annotation for mapAddressBook (master...Mf1902-LockAnnotmapAddressBook) https://github.com/bitcoin/bitcoin/pull/15365
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/020695660859...1477933f289e
< bitcoin-git> bitcoin/master faf3d22 MarcoFalke: test_runner: Remove unused --force option
< bitcoin-git> bitcoin/master fae8b8b MarcoFalke: qa: Add tool-prefix to functional test readme
< bitcoin-git> bitcoin/master 1477933 MarcoFalke: Merge #15370: test_runner: Remove unused --force option
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15370: test_runner: Remove unused --force option (master...Mf1902-qaWinForce) https://github.com/bitcoin/bitcoin/pull/15370
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15364: qa: Fix race in feature_notifications (master...Mf1902-qaNotifRace) https://github.com/bitcoin/bitcoin/pull/15364
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1477933f289e...d5dbb45bdf7d
< bitcoin-git> bitcoin/master 9ad5ca1 David A. Harding: Release notes: integrate detached & rm backports
< bitcoin-git> bitcoin/master 5d35d43 David A. Harding: Update release notes through to cb35f1d3
< bitcoin-git> bitcoin/master d5dbb45 MarcoFalke: Merge #15314: [Doc] update release notes for changes up to cb35f1d
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15314: [Doc] update release notes for changes up to cb35f1d (master...2019-02-monthly-release-notes-update) https://github.com/bitcoin/bitcoin/pull/15314
< achow101> there's a wallet meeting today, right?
< gwillen> achow101: as far as I know, in 15 minutes
< sipa> yup, will be there
< meshcollider> Yep
< meshcollider> #startmeeting
< lightningbot> Meeting started Fri Feb 8 19:00:32 2019 UTC. The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
< lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
< achow101> only half here
< sipa> here
< promag> hi
< meshcollider> Ok, topics?
< meshcollider> I guess we should start with discussing what wallet PRs we can aim to get into 0.18
< jnewbery> hi
< gwillen> yes hello
< gwillen> I am pestering for people to go review #13932
< gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
< sipa> will do
< achow101> also review #15226 pls
< gribble> https://github.com/bitcoin/bitcoin/issues/15226 | Allow creating blank (empty) wallets (alternative) by achow101 · Pull Request #15226 · bitcoin/bitcoin · GitHub
< jnewbery> only wallet PRs ^
< achow101> #14075 and #14021 would be nice, but they're a bit more involved
< gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
< meshcollider> Yes, I put them on the milestone but not sure they'll be ready in time
< achow101> there's also a merge conflict between those two and 15226 which may not be trivial to resolve, so i don't think we can get all of them in
< meshcollider> I would really like at least #14021 but we'll see I guess
< gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
< meshcollider> achow101: Is 15226 your highest priority one
< jnewbery> I'd love to see #15288 merged soon since we now seem to have some momentum in that series of PRs, but it might be better to do that after forking 0.18
< gribble> https://github.com/bitcoin/bitcoin/issues/15288 | Remove wallet -> node global function calls by ryanofsky · Pull Request #15288 · bitcoin/bitcoin · GitHub
< kanzure> hi.
< jnewbery> it's a very easy review. Lots of line change but all very mechanical, and nicely structured commits
< meshcollider> jnewbery: yeah I think after 0.18 is better, but I agree
< achow101> currently 14021 is my highest priority
< achow101> (since 14491 is merged now)
< jnewbery> achow101: perhaps you could give a summary of the state of HWI? How far are we from HWI in master?
< jnewbery> instagibbs: or you if you're around ^
< meshcollider> I think #14912 is tracking
< gribble> https://github.com/bitcoin/bitcoin/issues/14912 | [WIP] External signer support (e.g. hardware wallet) by Sjors · Pull Request #14912 · bitcoin/bitcoin · GitHub
< achow101> hwi has all basic functionality completed for the 5 common hardware wallets
< achow101> provoostenator has a branch for calling it from core
< achow101> we would need that and 14021 and 14075 for hwi to work.
< achow101> (gtg, have to take a quiz now)
< meshcollider> Also #14481 is the last PR on the "Segwit" github project which hasn't gone in, it'd be nice to have that in for 0.18
< gribble> https://github.com/bitcoin/bitcoin/issues/14481 | Add P2SH-P2WSH support to listunspent RPC by MeshCollider · Pull Request #14481 · bitcoin/bitcoin · GitHub
< meshcollider> Quite a small PR to review
< sipa> meshcollider: i'm slightly inclined to instead just aim to have signrawtransaction etc work with descriptors
< sipa> as listunspent gives the descriptors already
< sipa> (not an objection to also doing that PR... but i suspect in the end the descriptor based approach is more convenient)
< meshcollider> sipa: I think having both is nice, but yeah making descriptors more consistently used across the RPCs would be a nice change
< meshcollider> But we can't aim for that in 0.18
< sipa> agree
< meshcollider> Does anyone have any other topics for the meeting?
< meshcollider> sipa: how's the checksum search coming
< sipa> meshcollider: #15368
< gribble> https://github.com/bitcoin/bitcoin/issues/15368 | Descriptor checksums by sipa · Pull Request #15368 · bitcoin/bitcoin · GitHub
< sipa> i'll add documentation and release notes today
< meshcollider> Ok
< meshcollider> Looks like there's nothing else to discuss this week
< meshcollider> #endmeeting
< lightningbot> Meeting ended Fri Feb 8 19:25:13 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
< meshcollider> Thanks everyone
< promag> jnewbery: do you think I should fix your case in the open wallet pr?
< jnewbery> I think so, unless you can explain why it isn't a problem
< jnewbery> is there a reason you wouldn't want the file checking in the LoadWallet() function?
< promag> I don't think I thought of that, it was just a small step towards minimizing code duplication
< promag> long term I'd like to break CreateWalletFromFile so that the UI can have the wallet interface asap
< promag> I'll update the branch then
< jnewbery> thanks!
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d5dbb45bdf7d...294549242493
< bitcoin-git> bitcoin/master dfbf117 Jordan Baczuk: Move maxTxFee initialization to init.cpp
< bitcoin-git> bitcoin/master 2945492 MarcoFalke: Merge #15357: rpc: Don't ignore `-maxtxfee` when wallet is disabled
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15357: rpc: Don't ignore `-maxtxfee` when wallet is disabled (master...fix_maxtxfee) https://github.com/bitcoin/bitcoin/pull/15357
< bitcoin-git> [bitcoin] sdaftuar closed pull request #15360: [qa] Create cached blocks with current timestamps (master...2019-01-debug-appveyor) https://github.com/bitcoin/bitcoin/pull/15360
< promag> forgot to mention #15341 on the meeting.. is it worth?
< gribble> https://github.com/bitcoin/bitcoin/issues/15341 | rpc: Support specifying change address in bumpfee by promag · Pull Request #15341 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] ryanofsky opened pull request #15373: Move ParseConfirmTarget from rpc/mining to rpc/util (master...pr/movtarget) https://github.com/bitcoin/bitcoin/pull/15373