< gwillen>
do I need to get more people to look at #14978
< gribble>
https://github.com/bitcoin/bitcoin/issues/14978 | Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. by gwillen · Pull Request #14978 · bitcoin/bitcoin · GitHub
< gwillen>
it feels like it is almost there :-)
< bitcoin-git>
[bitcoin] sipa opened pull request #15402: Granular invalidateblock and RewindBlockIndex (master...201902_limitrewindinvalidate) https://github.com/bitcoin/bitcoin/pull/15402
< sipa>
gmaxwell, wumpus: ^
< sipa>
infinite depth invalidateblock
< gmaxwell>
rewinding irrelevancy is also because the rewind is slow...
< gmaxwell>
might even be faster to reindex now
< sipa>
it very likely is
< meshcollider>
gwillen: I agree, it'd be good to get a post-rebase re-ACK from someone though
< meshcollider>
Or a review from ryanofsky who had commented on it a few times
< provoostenator>
In #15382 I added "C:\tools\vcpkg\installed -> appveyor.yml" to .appveyor.yml to bust the package cache whenever that file is modified.
< bitcoin-git>
bitcoin/master c734aaa Glenn Willen: Split DecodePSBT into Base64 and Raw versions
< bitcoin-git>
bitcoin/master 81cd958 Glenn Willen: Factor BroadcastTransaction out of sendrawtransaction
< bitcoin-git>
[bitcoin] MeshCollider merged pull request #14978: Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. (master...feature-refactor-psbt-rpcs) https://github.com/bitcoin/bitcoin/pull/14978
< provoostenator>
^ watching my rebase hell slowly come to an end, thanks MeshCollider :-)
< gribble>
https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< provoostenator>
I'll try rebasing #15388 and see if that magically fixes AppVeyor. If not, someone who actually understands it should take a look...
< provoostenator>
Update: I have no idea how to make the AppVeyor errors on master go away. There's probably some extra configuration needed for bitcoin-wallet, but #15388 doesn't do the trick.
< bitcoin-git>
[bitcoin] ken2812221 opened pull request #15407: msvc: Fix silent merge conflict between #13926 and #14372 part II (master...msvc-bitcoin-wallet-leveldb) https://github.com/bitcoin/bitcoin/pull/15407
< provoostenator>
I cancelled some ongoing AppVeyor builds to make room for ^
< luke-jr>
hm, someone had a good idea: if nodes store their own UTXO hashes, they can safely recover from other nodes if something gets corrupt rather than a re-IBD
< gribble>
https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< gmaxwell>
luke-jr: do you have a 32-bit host with rdrand (modern intel/amd cpu running in 32bit mode)? would be nice to test #15250 on that. (doesn't block merge, I guess since it could be fixed before release if there were an issue)
< jamesob>
intend on building in a SERIAL_SCHEDULER_EXECUTION flag (or something) for use in CI in the next couple days
< jamesob>
(offtopic, sorry)
< wumpus>
#topic minimum QT version for v0.18 (provoostenator)
< phantomcircuit>
gmaxwell, that cant be checked in a vm?
< gmaxwell>
phantomcircuit: absolutely can be
< luke-jr>
[19:03:49] <luke-jr> I also don't see where/if anyone done a check for what versions come with current stable distros.
< luke-jr>
I tried doing ^ myself, but I couldn't figure out what version RHEL 7 has
< provoostenator>
I think we should either make Travis test older versions of QT or bump the min version.
< MarcoFalke>
luke-jr: The benefit is that it is easier to just bump the minimum than to make it compile with 5.2
< provoostenator>
Currently it doesn't even compile in 5.2
< MarcoFalke>
^
< wumpus>
5.2 is ancient anyway
< luke-jr>
but who does this cut off?
< luke-jr>
what version does RHEL 7 have?
< MarcoFalke>
If someone wants to build on an acient system with an EOL qt, they are better off with depends
< provoostenator>
As for stable distros: we can narrow that down to stable distros where the depends system doesn't work?
< luke-jr>
RHEL 7 is current
< wumpus>
didn't we have a discussion about this in a github issue?
< jonasschnelli>
Yes
< luke-jr>
provoostenator: depends should not be the norm
< MarcoFalke>
luke-jr: rhel7 can use depends
< wumpus>
is there anything new to add to that or is this just another repeat of that?
< jonasschnelli>
I think just updating Qt for the sake of updating seems pointless
< wumpus>
this comes up too often
< jonasschnelli>
What we need is advantages/disadvantage comparison
< luke-jr>
updating is fine. cutting off people who reasonably have an old version isn't.
< meshcollider>
Hi, sorry im late
< wumpus>
jonasschnelli: he isn't updating qt, only changing the minimum requirement in the build system to the actual minimum requirement IIRC
< provoostenator>
jonasschnelli: it's not for the sake of updating, it's because we're constantly breaking old versions.
< wumpus>
it doesn't work with qt 5.2, no one is testing it with that, so it's kind of a moot point
< gmaxwell>
Just pushing to new versions for the sake of updating is a bad pattern. If there is a problem or a new feature, then great. Matching minimums to the actual minimums is also good (excepting in cases where we should fix the minimum because we're cutting something out people are currently using)
< wumpus>
no one is updating qt !
< jonasschnelli>
I see. Sorry for the confusion.
< wumpus>
this isn't the point of tha pr
< wumpus>
#15393 bumps the minimum version checked by the bulid system
< MarcoFalke>
Then, please someone add a debian_8 travis job. Otherwise this will be broken again
< jonasschnelli>
yes... but we need to expect users run it close to the LTS end... but I'm fine with setting Qt 5.5.1 as min
< wumpus>
I guess it's possible to build through depends still, but we can't support old versions of distributions that are already known to carry old packages forever
< luke-jr>
MarcoFalke: we don't need to support oldstable IMO
< wumpus>
no, we don't need a debian 8 travis job
< jonasschnelli>
Yes. We have the depends build for those
< bitcoin-git>
bitcoin/master 9975282 Luke Dashjr: GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing
< bitcoin-git>
bitcoin/master 113f000 Luke Dashjr: GUI: If BIP70 is disabled, give a proper error when trying to open a payme...
< bitcoin-git>
bitcoin/master 84f5315 Luke Dashjr: Travis: Add test without BIP70 (but still full wallet + tests)
< bitcoin-git>
[bitcoin] jonasschnelli merged pull request #15063: GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing (master...bip70_fallback_to_bip21) https://github.com/bitcoin/bitcoin/pull/15063
< wumpus>
I guess not
< wumpus>
#endmeeting
< jonasschnelli>
looks like
< lightningbot>
Meeting ended Thu Feb 14 19:34:14 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
< bitcoin-git>
bitcoin/master fa535af MarcoFalke: fuzz: test_runner: Better error message when built with afl
< bitcoin-git>
bitcoin/master 31f7c6d MarcoFalke: Merge #15295: fuzz: Add test/fuzz/test_runner.py and run it in travis
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #15295: fuzz: Add test/fuzz/test_runner.py and run it in travis (master...Mf1901-qaFuzz) https://github.com/bitcoin/bitcoin/pull/15295
< bitcoin-git>
bitcoin/master 0890339 Sjors Provoost: build: prefer python3.4 even if newer versions are present on the system
< bitcoin-git>
bitcoin/master 33480c6 MarcoFalke: Merge #15285: build: Prefer Python 3.4 even if newer versions are present ...
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #15285: build: Prefer Python 3.4 even if newer versions are present on the system (master...2019/01/bitcoin-util-test-python) https://github.com/bitcoin/bitcoin/pull/15285
< achow101>
meshcollider: do you think #14021 is RTM?
< bitcoin-git>
bitcoin/master c45415f Andrew Chow: Refactor keymetadata writing to a separate method
< bitcoin-git>
bitcoin/master e7652d3 Andrew Chow: Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}
< bitcoin-git>
bitcoin/master bac8c67 Andrew Chow: Add a method to CWallet to write just CKeyMetadata
< bitcoin-git>
[bitcoin] MeshCollider merged pull request #14021: Import key origin data through descriptors in importmulti (master...import-multi-hd) https://github.com/bitcoin/bitcoin/pull/14021
< meshcollider>
ok achow101 please rebase #14075 :)
< gribble>
https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
< achow101>
wohoo
< achow101>
meshcollider: rebased. i'm gonna check it against hwi real quick to make sure I didn't screw up anything
< meshcollider>
ok
< Aequitas_>
Hello, is there a valid bitcoin core binary release signing key? It looks like the key with fingerprint 01EA 5486 DE18 A882 D4C2 6845 90C8 019E 36C2 E964 expired today.
< meshcollider>
Aequitas_: yes, wumpus bumped the key expiry a few days ago
< bitcoin-git>
bitcoin/master 99cccb9 Andrew Chow: Add a method to add a pubkey to the keypool
< bitcoin-git>
bitcoin/master 9b81fd1 Andrew Chow: Fetch keys from keypool when private keys are disabled
< bitcoin-git>
bitcoin/master 513719c Andrew Chow: Add option to importmulti add an imported pubkey to the keypool
< bitcoin-git>
[bitcoin] MeshCollider merged pull request #14075: Import watch only pubkeys to the keypool if private keys are disabled (master...watch-only-keypool) https://github.com/bitcoin/bitcoin/pull/14075