< wumpus> uhmmmm
< wumpus> hyperwang: please fix your internet
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1212808762f6...3ccab6470a61
< bitcoin-git> bitcoin/master d975338 practicalswift: addrdb: Remove temporary files created in SerializeFileDB. Fixes non-deter...
< bitcoin-git> bitcoin/master 3ccab64 Wladimir J. van der Laan: Merge #16212: addrdb: Avoid eating inodes - remove temporary files created...
< bitcoin-git> [bitcoin] laanwj merged pull request #16212: addrdb: Avoid eating inodes - remove temporary files created by SerializeFileDB in case of errors (master...SerializeFileDB-non-determinism) https://github.com/bitcoin/bitcoin/pull/16212
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3ccab6470a61...6c21a801f3df
< bitcoin-git> bitcoin/master 276972c Gregory Sanders: wallet_bumpfee.py: Make sure coin selection produces change
< bitcoin-git> bitcoin/master 6c21a80 Wladimir J. van der Laan: Merge #15538: wallet_bumpfee.py: Make sure coin selection produces change
< promag> can #16261 be in HP? it's base for achow101 PR which is in HP
< gribble> https://github.com/bitcoin/bitcoin/issues/16261 | gui: Refactor OpenWalletActivity by promag · Pull Request #16261 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj merged pull request #15538: wallet_bumpfee.py: Make sure coin selection produces change (master...bumpfee_change_test) https://github.com/bitcoin/bitcoin/pull/15538
< fanquake> promag ok
< promag> hi fanquake, ty
< promag> can't reproduce your latest issues regarding load/unload
< fanquake> btw, create wallet is no longer in HP
< promag> for instance #16307
< gribble> https://github.com/bitcoin/bitcoin/issues/16307 | scheduler: crash after releasing wallet · Issue #16307 · bitcoin/bitcoin · GitHub
< promag> oh really? why not?
< fanquake> however its's had lots of review, and probably close to merge, so makes sense for your refactor to get some as well.
< promag> yeah, unless it's all merged there
< fanquake> I've left one last comment about fixing the autofocussing, once that is done, assuming it's correct, i'd like to see some final review
< fanquake> Be good to just get that into master.
< fanquake> I'll need to get some more concrete steps for producing those crashes.
< promag> fanquake: that would be great, afaik hebasto also couldn't reproduce
< hebasto_> Yes, cannot reproduce #16296. Detailed steps are needed.
< gribble> https://github.com/bitcoin/bitcoin/issues/16296 | gui: crash with loadwallet & QT_FATAL_WARNINGS · Issue #16296 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag opened pull request #16322: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction (master...2019-07-fix-16257) https://github.com/bitcoin/bitcoin/pull/16322
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/6c21a801f3df...c6e42f1ca9c8
< bitcoin-git> bitcoin/master fa0c9db MarcoFalke: txpool: Make nTransactionsUpdated atomic
< bitcoin-git> bitcoin/master fabeb1f MarcoFalke: validation: Add missing mempool locks
< bitcoin-git> bitcoin/master fa2b083 MarcoFalke: [test] Add test to check mempool consistency in case of reorgs
< bitcoin-git> [bitcoin] laanwj merged pull request #14193: validation: Add missing mempool locks (master...Mf1809-valLocksMempool) https://github.com/bitcoin/bitcoin/pull/14193
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/c6e42f1ca9c8...2f717fb5cdfc
< bitcoin-git> bitcoin/master eaf4f88 Pieter Wuille: Abstract out IsSegWitOutput from utxoupdatepsbt
< bitcoin-git> bitcoin/master fb90ec3 Pieter Wuille: Abstract out EvalDescriptorStringOrObject from scantxoutset
< bitcoin-git> bitcoin/master 3135c1a Pieter Wuille: Abstract out UpdatePSBTOutput from FillPSBT
< bitcoin-git> [bitcoin] laanwj merged pull request #15427: Add support for descriptors to utxoupdatepsbt (master...201902_utxoupdatepsbtdesc) https://github.com/bitcoin/bitcoin/pull/15427
<@wumpus> promag: I didn't really understand the comment there, code seemed correct to me
< promag> like ryanofsky said, while (true) { foo(); continue; } <- continue is pointless?
< wumpus> ok, but also harmless
< promag> sure, I've replied there
< pinheadmz> Should this be == and not >= ?
< pinheadmz> With the comment right there, its a bit confusing. Though I realize a vector of 1001 won't ever happen
< promag> pinheadmz: yeah, just to be "safe"
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/2f717fb5cdfc...c84349a14832
< bitcoin-git> bitcoin/master 01fafe5 Hennadii Stepanov: Include Objective-C source files
< bitcoin-git> bitcoin/master 621463d Hennadii Stepanov: Drop no-longer-relevant copyright holder name
< bitcoin-git> bitcoin/master ca11606 Hennadii Stepanov: Fix: "Bitcoin Core" -> "The Bitcoin Core"
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16314: scripts and tools: Update copyright_header.py script (master...20190629-copyright-headers) https://github.com/bitcoin/bitcoin/pull/16314
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #16323: Call ProcessNewBlock() asynchronously (master...2019-07-background-pnb) https://github.com/bitcoin/bitcoin/pull/16323
< BlueMatt> sipa: the aforementioned minimal-change-to-get-started ^
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #16324: Get cs_main out of the critical path in ProcessMessages (master...2019-07-peerstate-initial-moves) https://github.com/bitcoin/bitcoin/pull/16324
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16325: rpc: Clarify that block count means height excl genesis (master...1907-rpcBlockCount) https://github.com/bitcoin/bitcoin/pull/16325
< instagibbs> promag, you just linked the same PR? :P https://github.com/bitcoin/bitcoin/pull/16292#issuecomment-507754182
< instagibbs> #16325 you mean?
< gribble> https://github.com/bitcoin/bitcoin/issues/16325 | rpc: Clarify that block count means height excl genesis by MarcoFalke · Pull Request #16325 · bitcoin/bitcoin · GitHub
< promag> instagibbs: heh :P
< bitcoin-git> [bitcoin] instagibbs closed pull request #16292: wallet_resendwallettransaction.py: fix coinbase height (master...resend_test_height) https://github.com/bitcoin/bitcoin/pull/16292
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c84349a14832...4db2f8cf0f63
< bitcoin-git> bitcoin/master db26e8e Josu Goñi: Add antialiasing to traffic graph widget
< bitcoin-git> bitcoin/master 4db2f8c Wladimir J. van der Laan: Merge #16153: Qt: Add antialiasing to traffic graph widget
< bitcoin-git> [bitcoin] laanwj merged pull request #16153: Qt: Add antialiasing to traffic graph widget (master...antialiasing) https://github.com/bitcoin/bitcoin/pull/16153
< promag> fanquake: can you see #16106?
< gribble> https://github.com/bitcoin/bitcoin/issues/16106 | gui: Sort wallets in open wallet menu by promag · Pull Request #16106 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jnewbery opened pull request #16326: [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and CPRCCvertParam tables (master...2019-07-utxoupdatepsbt-args) https://github.com/bitcoin/bitcoin/pull/16326
< bitcoin-git> [bitcoin] hebasto opened pull request #16327: scripts and tools: Update ShellCheck linter (master...20190702-shellcheck) https://github.com/bitcoin/bitcoin/pull/16327
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16328: rpc: Tidy up reporting of buried and ongoing softforks (master...1907-rpcSoftforks) https://github.com/bitcoin/bitcoin/pull/16328
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16329: test: Add tests for getblockchaininfo.softforks (master...1907-qaSoftforksHeight) https://github.com/bitcoin/bitcoin/pull/16329
< bitcoin-git> [bitcoin] hebasto opened pull request #16330: docs: Update release signing key expiration date (master...20190702-key-expiration) https://github.com/bitcoin/bitcoin/pull/16330
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4db2f8cf0f63...e06067387e75
< bitcoin-git> bitcoin/master 0117459 Anthony Towns: signrawtransactionwithkey: report error when missing redeemScript/witnessS...
< bitcoin-git> bitcoin/master e060673 MarcoFalke: Merge #16250: signrawtransactionwithkey: report error when missing redeemS...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16250: signrawtransactionwithkey: report error when missing redeemScript/witnessScript (master...201906-signrawerror-regression) https://github.com/bitcoin/bitcoin/pull/16250
< fanquake> promag_: will take a look today
< promag> fanquake: cool thanks!