< meshcollider>
sdaftuar: the filter by author dropdown looks the same to me? I still only see the org members
< meshcollider>
the same list as the assign or request review menus
< sipa>
oh, it's fixed
< aj>
hmm, i'm getting irregular hangs with test_bitcoin-qt on master
< wumpus>
did you get a backtrace?
< aj>
"int r = mBox.exec()" qt/bitcoingui.cpp:1096 maybe? not entirely sure which thread i should backtrace
< wumpus>
in a hang case it tends to make sense to look at all of them (e.g. thread apply all bt)
< wumpus>
though the main/GUI thread is probably the most likely to be the culprit, I don't think the qt tests are heavily threaded
< aj>
oh, if i leave it long enough the test suite timesout and gives me stack traces
< bitcoin-git>
[bitcoin] qmma70 opened pull request #16336: [lib] Refactor bloom filter class data member names (master...bloom_refactor) https://github.com/bitcoin/bitcoin/pull/16336
< aj>
although now it's refusing to hang again
< wumpus>
on qt/bitcoingui.cpp:1096 it is displaying a message and waiting for the user, might be that something untintentially triggers that, do you have the stack frames above it?
< aj>
qt/test/apptests.cpp:79 :-/ everything else is in a library
< aj>
hmm, maybe it's only hanging long enough to be annoying when i watch it, but timing out internally before the test case timeout hits?
< aj>
yeah, looks like it hangs for 20s then decides "oh well whatever" and lets the tests pass
< aj>
aha, got it; i think it's CConnman::Bind calling clientInterface->ThreadSafeMessageBox because the port's already in use (possibly because i run "make -j5 check"?)
< achow101>
aj: iirc test_bitcoin-qt binds to the regtest port. Make sure you aren't running a regtest at the same time
< achow101>
*regtest node
< aj>
ah, that would be it then
< aj>
it was still sometimes taking 20s instead of the usual 6s
< bitcoin-git>
[bitcoin] fanquake closed pull request #16336: [lib] Refactor bloom filter class data member names (master...bloom_refactor) https://github.com/bitcoin/bitcoin/pull/16336
< wumpus>
hehe it should probably not be displaying a messagebox in that case
< bitcoin-git>
[bitcoin] emilengler closed pull request #16317: RPC: Add feature to getblock by using the index (master...getblock-improvement) https://github.com/bitcoin/bitcoin/pull/16317
< wumpus>
meeting in 1hr
< sipa>
wumpus: ah thanks for the reminder
< wumpus>
meeting starting in a bit
< achow101>
meeting?
< wumpus>
#startmeeting
< lightningbot>
Meeting started Thu Jul 4 19:00:26 2019 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
< wumpus>
anything to add, remove, or ready to be merged ?
< wumpus>
ok, seems not
< meshcollider>
Very quiet meeting
< sipa>
sorry i haven't found much time for review; i've been spending a lot of time on improving and implementing miniscript, which i hope will at some point be integratable in bitcoin core
< wumpus>
wheeree is everyone
< achow101>
most americans are probably gone because independence day
< sipa>
wumpus: 4th of july
< achow101>
national holiday
< wumpus>
ohh
< sipa>
FREEDOM DAY
< wumpus>
freedom from meetings
< sipa>
in general yes :)
< wumpus>
short meeting then :)
< dongcarl>
#15759 is somewhat ready for merge I think
< bitcoin-git>
[bitcoin] qmma70 opened pull request #16338: test: Disable other targets when enable-fuzz is set (master...enable-fuzz) https://github.com/bitcoin/bitcoin/pull/16338
< luke-jr>
[19:05:49] <wumpus> freedom from meetings <-- lol