07:46 < bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/24dbcf380844...459baa1756b7

07:46 < bitcoin-git> bitcoin/master d9ff862 Gregory Sanders: CreateTransaction calls KeepDestination on ReserveDestination before succe...

07:46 < bitcoin-git> bitcoin/master e10e1e8 Gregory Sanders: Restrict lifetime of ReserveDestination to CWallet::CreateTransaction

07:46 < bitcoin-git> bitcoin/master 459baa1 MeshCollider: Merge #16208: wallet: Consume ReserveDestination on successful CreateTrans...

07:47 < bitcoin-git> [bitcoin] meshcollider merged pull request #16208: wallet: Consume ReserveDestination on successful CreateTransaction (master...createtransaction_keepkey) https://github.com/bitcoin/bitcoin/pull/16208

13:45 < bitcoin-git> [bitcoin] promag opened pull request #16404: qa: Test ZMQ notification after chain reorg (master...2019-07-zmq-reorg) https://github.com/bitcoin/bitcoin/pull/16404

14:33 < bitcoin-git> [bitcoin] promag opened pull request #16405: fix: tor: Call event_base_loopbreak from the event's callback (master...2019-07-fix-break-before-dispatch) https://github.com/bitcoin/bitcoin/pull/16405

15:24 < bitcoin-git> [bitcoin] promag opened pull request #16406: 0.18: fix: tor: Call event_base_loopbreak from the event's callback (0.18...2019-07-backport-16405) https://github.com/bitcoin/bitcoin/pull/16406

15:31 < promag> is it too bad to drop positional arguments? (hides)

16:02 < achow101> how do I return a pointer without causing a memory leak? need this for GetSigningProvider for SPKManagers

16:03 < sipa> you can return pointers to objects that will outlive the caller

16:03 < achow101> but then you have to delete them later, right?

16:03 < sipa> oh

16:04 < sipa> you mean a newly instantiated one?

16:04 < sipa> use std::unique_ptr

16:04 < achow101> can you return `this` as a unique_ptr?

16:04 < sipa> so return std::unique_ptr<SigningProvider> from the function

16:04 < sipa> when the returned variable goes out of scope, the signingprovider is automatically deleted

16:04 < achow101> I tried using shared_ptr but that didn't work

16:05 < sipa> unique_ptr is simpler and more efficient

16:05 < sipa> let me know of you need help

16:08 < achow101> the problem is just getting LegacyScriptPubKeyMan to return this but in the smart pointer

16:10 < sipa> you can't do that

16:10 < achow101> I figured as much

16:10 < sipa> but you could return a wrapper that just forwards to the internal legacy one, in a unique_ptr

16:11 < achow101> ah

16:11 < sipa> and then for the descriptor wallet one return an actual newly instantiated one, of a different type

21:14 < bitcoin-git> [bitcoin] dongcarl opened pull request #16408: depends: Prune X packages (master...2019-07-depends-X-pruning) https://github.com/bitcoin/bitcoin/pull/16408

23:04 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16409: Remove mempool expiry, treat txs as replaceable instead (master...1907-noExpiryButReplace) https://github.com/bitcoin/bitcoin/pull/16409