< bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/24dbcf380844...459baa1756b7
< bitcoin-git> bitcoin/master d9ff862 Gregory Sanders: CreateTransaction calls KeepDestination on ReserveDestination before succe...
< bitcoin-git> bitcoin/master e10e1e8 Gregory Sanders: Restrict lifetime of ReserveDestination to CWallet::CreateTransaction
< bitcoin-git> bitcoin/master 459baa1 MeshCollider: Merge #16208: wallet: Consume ReserveDestination on successful CreateTrans...
< bitcoin-git> [bitcoin] meshcollider merged pull request #16208: wallet: Consume ReserveDestination on successful CreateTransaction (master...createtransaction_keepkey) https://github.com/bitcoin/bitcoin/pull/16208
< bitcoin-git> [bitcoin] promag opened pull request #16404: qa: Test ZMQ notification after chain reorg (master...2019-07-zmq-reorg) https://github.com/bitcoin/bitcoin/pull/16404
< bitcoin-git> [bitcoin] promag opened pull request #16405: fix: tor: Call event_base_loopbreak from the event's callback (master...2019-07-fix-break-before-dispatch) https://github.com/bitcoin/bitcoin/pull/16405
< bitcoin-git> [bitcoin] promag opened pull request #16406: 0.18: fix: tor: Call event_base_loopbreak from the event's callback (0.18...2019-07-backport-16405) https://github.com/bitcoin/bitcoin/pull/16406
< promag> is it too bad to drop positional arguments? (hides)
< achow101> how do I return a pointer without causing a memory leak? need this for GetSigningProvider for SPKManagers
< sipa> you can return pointers to objects that will outlive the caller
< achow101> but then you have to delete them later, right?
< sipa> oh
< sipa> you mean a newly instantiated one?
< sipa> use std::unique_ptr
< achow101> can you return `this` as a unique_ptr?
< sipa> so return std::unique_ptr<SigningProvider> from the function
< sipa> when the returned variable goes out of scope, the signingprovider is automatically deleted
< achow101> I tried using shared_ptr but that didn't work
< sipa> unique_ptr is simpler and more efficient
< sipa> let me know of you need help
< achow101> the problem is just getting LegacyScriptPubKeyMan to return this but in the smart pointer
< sipa> you can't do that
< achow101> I figured as much
< sipa> but you could return a wrapper that just forwards to the internal legacy one, in a unique_ptr
< achow101> ah
< sipa> and then for the descriptor wallet one return an actual newly instantiated one, of a different type
< bitcoin-git> [bitcoin] dongcarl opened pull request #16408: depends: Prune X packages (master...2019-07-depends-X-pruning) https://github.com/bitcoin/bitcoin/pull/16408
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16409: Remove mempool expiry, treat txs as replaceable instead (master...1907-noExpiryButReplace) https://github.com/bitcoin/bitcoin/pull/16409