04:28 < achow101> would it be possible to block this fqlx guy? I get that he's trying to help by reviewing, but he clearly doesn't understand this codebase or have read any of the contributing docs so most of his comments are noise

04:29 < fanquake> achow101 I've just commented in that thread.

04:31 < fanquake> Seems to have been an inflow of new commenters over the past few days.

04:31 < achow101> fanquake: I think they maybe coming from the pr review club? If so, I think it would be prudent to make it clear there that people actually need to read the contributor guidelines before they start reviewing

04:35 < fanquake> achow101 Especially in that kind of PR. That's already going to be a noisy WIP, and right now it only needs concept level review.

04:35 < fanquake> There's no point having everyone jump in and start nit-picking on the nearly 100 commits, that are already being reviewed in separate PRs.

04:35 < achow101> most of their comments are on previous PRs too..

04:36 < fanquake> Doubling up the same comments/review is definitely not what we want

06:42 < achow101> anyone familiar with MSVC know what's up with this error: https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/25786259?

07:03 < hebasto> promag: hi, could you look into https://travis-ci.org/bitcoin/bitcoin/jobs/554836240 ?

13:10 < emilengler> How can I add a test for a new RPC command? I currently have problems at this.

13:16 < fanquake> emilengler https://github.com/bitcoin/bitcoin/tree/master/test/functional. Please also read through https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md if you haven't already.

13:17 < emilengler> fanquake, thank you

13:24 < promag> fanquake: have you got the chance to write steps to reproduce those bugs related to load/unload wallet?

13:26 < fanquake> promag: can do it now. It's not really anything special, basically build master, start syncing on mainnet and load & unload wallets until you see a crash.

13:27 < promag> oh it doesn't blow on first try?

13:27 < fanquake> promag: only sometimes.

13:27 < promag> those are the worst :D

15:26 < promag> achow101: concept ACK on #16341 - just to not increase comment count X)

15:26 < gribble> https://github.com/bitcoin/bitcoin/issues/16341 | WIP: Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub

16:00 < bitcoin-git> [bitcoin] dongcarl opened pull request #16347: doc: Include static members in Doxygen (master...2019-07-doxygen-extract-static) https://github.com/bitcoin/bitcoin/pull/16347

16:22 < bitcoin-git> [bitcoin] promag opened pull request #16348: qt: Assert QMetaObject::invokeMethod result (master...2019-07-assert-invoke-method) https://github.com/bitcoin/bitcoin/pull/16348

19:11 < bitcoin-git> [bitcoin] hebasto opened pull request #16349: Fix "opening a wallet" issue #15453 (master...20190706-fix15453) https://github.com/bitcoin/bitcoin/pull/16349