00:22
<
bitcoin-git >
bitcoin/master d003110 Hennadii Stepanov: Remove unused guard
00:23
<
bitcoin-git >
bitcoin/master 05623c0 fanquake: Merge #16350: qt: Remove unused guard
00:35
<
bitcoin-git >
bitcoin/master 64b27c4 fanquake: docs: add reduce-memory.md
00:35
<
bitcoin-git >
bitcoin/master 2b46519 fanquake: Merge #16339: doc: add reduce-memory.md
07:30
<
bitcoin-git >
bitcoin/master 84ad4d2 Carl Dong: doc: Include static members in Doxygen
07:30
<
bitcoin-git >
bitcoin/master e1a8d76 Wladimir J. van der Laan: Merge #16347: doc: Include static members in Doxygen
09:13
<
promag >
imo #16106 is ready to merge
09:14
<
promag >
#15305 seems like forgotten
09:24
<
fanquake >
promag I’ll look at sort wallets tonight, sorry.
09:24
<
promag >
no worries
09:25
<
promag >
#16285 is also a pretty simple change
09:26
<
hebasto >
promag: fanquake: hi, did you try to build with downloaded Qt 5.7.1?
09:26
<
promag >
hebasto: no
09:27
<
promag >
hebasto: the problem only exists with 5.7.1?
09:27
<
fanquake >
on Debian with -nowallet? I used apt installed.
09:27
<
hebasto >
it seems so...
09:27
<
fanquake >
Assuming I’m thinking of the right issue.
09:28
<
promag >
let's just bump to qt 5.10 X)
09:29
<
hebasto >
yes, i build on Debian, but it is not convenient to investigate a bug with system Qt
09:29
<
hebasto >
promag: we should wait for stretch EOL at least ;)
09:30
<
promag >
hebasto: if the problem doesn't exists with depends then I wouldn't be too worried
09:32
<
hebasto >
anyway, consider to remove a private slot in #16349, if you don't mind
10:24
<
promag >
hebasto: wrong pr?
10:26
<
hebasto >
promag: correct ;) I mean WalletController::addWallet private slot.
10:26
<
promag >
whats the problem with that?
10:27
<
hebasto >
It seems redundant: everything could be run in one thread, IMO
10:30
<
promag >
hebasto: but it's not
10:30
<
promag >
m_node.handleLoadWallet
10:31
<
promag >
that callback is called from different thread
10:31
<
promag >
for instance, from the loadwallet rpc thread
10:33
<
hebasto >
I'll look into it more thoroughly.
10:58
<
bitcoin-git >
bitcoin/master a30bd09 Gregory Sanders: Add logpath description for getrpcinfo
10:58
<
bitcoin-git >
bitcoin/master f5a01cf Wladimir J. van der Laan: Merge #16332: rpc: Add logpath description for getrpcinfo
10:59
<
wumpus >
getLoadedWallets() lol
11:00
<
fanquake >
wumpus: too explicit?
11:00
<
wumpus >
promag_: I'm not a native speaker but that sounds somehow wrong
11:01
<
wumpus >
at least it's funny
11:03
<
wumpus >
I'm not sure all the additional changes are necessary in a PR that just adds deterministic sorting, but YMMV
11:07
<
wumpus >
ok using a map in listWalletDir seems an improvement because there's a second pass that is now O(N^2)
11:12
<
wumpus >
well not N^2 but ... removing things one by one from a vector is still a code stink usually
11:15
<
wumpus >
so +1 on that, did leave a comment about some other (likely unexpected) change of behavior
11:33
<
bitcoin-git >
bitcoin/master e8fabd9 fanquake: build: prune dbus from depends
11:33
<
bitcoin-git >
bitcoin/master 983c848 Wladimir J. van der Laan: Merge #16352: build: prune dbus from depends
12:03
<
cdecker >
Bind alt-n to toggle the nicklist.
12:03
<
cdecker >
Oops, wrong window ^^"
12:58
<
bitcoin-git >
bitcoin/master 1eb13f0 Jon Atack: test: Add log messages to test/functional/tool_wallet.py
12:58
<
bitcoin-git >
bitcoin/master 3bf2b3a Jon Atack: test: Split tool_wallet.py test into subtests
12:58
<
bitcoin-git >
bitcoin/master 7195fa7 Jon Atack: test: Tool wallet test coverage for unexpected writes to wallet
13:05
<
promag >
wumpus: what the problem with getLoadedWallets?
13:08
<
wumpus >
promag: it sounds strange to me (and not just because of the double definition of 'loaded' esp in the context of money)
13:09
<
promag >
I could drop 2nd commit or rename to something else
13:09
<
wumpus >
yea, I'm not sure the renaming is necessary at all
13:09
<
promag >
but more importantly is that currently listWalletDir is called twice
13:11
<
promag >
I'm going to address your comment, let me know if the rename can be dropped (could keep a comment thought)
13:15
<
wumpus >
getOpenWallets maybe ?
13:16
<
wumpus >
let's do that then :)
13:52
<
wumpus >
promag: I think something went wrong in 16106
14:13
<
promag >
wumpus: yeah, outdated branch
14:13
<
promag >
wumpus: should be ok now
14:27
<
wumpus >
rechecking
14:32
<
bitcoin-git >
bitcoin/master 224eb95 João Barbosa: gui: Sort wallets in open wallet menu
14:32
<
bitcoin-git >
bitcoin/master fa90fe6 João Barbosa: refactor: Rename getWallets to getOpenWallets in WalletController
14:32
<
bitcoin-git >
bitcoin/master 2679bb8 Wladimir J. van der Laan: Merge #16106: gui: Sort wallets in open wallet menu
16:04
<
jnewbery >
MarcoFalke: is #15891 ready for merge or are there comments outstanding? It has 3 ACKs
16:07
<
jnewbery >
achow101: what makes you think fqlx is from the review club? I don't think he's ever commented in there
16:09
<
jnewbery >
also, why would we block someone who's clearly just trying to help?! Can't you just ask him to look at the contributing docs and review smaller PRs first?
16:20
<
achow101 >
jnewbery: he was asked multiple times and didn't seem to actually do it
16:21
<
promag >
hebasto: omg
16:21
<
promag >
someone: how can I search git history for a string?
16:28
<
jarthur >
If searching commit messages, specifically: `git log --grep=<pattern>` To search the actual code changes: `git grep <regexp> $(git rev-list --all)`
16:30
<
promag >
jarthur: thanks, I've used git log -S
17:07
<
wumpus >
I agree blocking them goes a bit far if they're just trying to help, though if they keep commenting while clearly not understanding the code it is kind of annoying
17:16
<
jb55 >
promag: I've always used git log -G for searching for strings, it seems to work well.
17:16
<
jb55 >
there is some subtle difference between the two which I have yet to understand
17:30
<
hebasto >
promag: the question remains: why only Qt 5.7.1 needs that bugfix?
17:41
<
bitcoin-git >
bitcoin/master fa5e9f1 MarcoFalke: build: Stop translating PACKAGE_NAME
17:41
<
bitcoin-git >
bitcoin/master fabe87d MarcoFalke: scripted-diff: Avoid passing PACKAGE_NAME for translation
17:41
<
bitcoin-git >
bitcoin/master fab8520 MarcoFalke: qt: Run «make translate» in ./src/
18:15
<
bitcoin-git >
bitcoin/master 91509ff Kirill Fomichev: bench: Benchmark blockToJSON
18:15
<
bitcoin-git >
bitcoin/master 0a6ee97 Wladimir J. van der Laan: Merge #16267: bench: Benchmark blockToJSON
18:29
<
bitcoin-git >
bitcoin/master c4606b8 practicalswift: Add Travis check for single parameter constructors not marked "explicit"
18:29
<
bitcoin-git >
bitcoin/master 345f42a Wladimir J. van der Laan: Merge #14505: test: Add linter to make sure single parameter constructors ...
18:45
<
bitcoin-git >
bitcoin/master e1a5569 Gregory Sanders: Delete error-prone CScript constructor
18:45
<
bitcoin-git >
bitcoin/master c799976 Wladimir J. van der Laan: Merge #16128: Delete error-prone CScript constructor only used with FindAn...
21:01
<
achow101 >
does bdb handle large binary blobs well? or should I break it up into separate records?
21:02
<
sipa >
achow101: are you going to rewrite all of them everytime something is updated?
21:02
<
achow101 >
maybe? it'd be the descriptor cache
21:02
<
sipa >
probably better to split that up in per-index entries
21:02
<
sipa >
as they're only written once
21:03
<
sipa >
if they are a single blob, you'd be rewriting the whole thing every time