< bitcoin-git> [bitcoin] fanquake closed pull request #14137: gui: Add Windows taskbar progress (master...qt-windows-progress-bar) https://github.com/bitcoin/bitcoin/pull/14137
< bitcoin-git> [bitcoin] laanwj closed pull request #14633: Fix height serialization inside script of coinbase input (master...fix_height_serialization_in_coinbase) https://github.com/bitcoin/bitcoin/pull/14633
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e06067387e75...7d7b832d6707
< bitcoin-git> bitcoin/master 3b9bf0e Patrick Strateman: rpc: Allow shutdown while in generateblocks
< bitcoin-git> bitcoin/master 7d7b832 Wladimir J. van der Laan: Merge #16262: rpc: Allow shutdown while in generateblocks
< bitcoin-git> [bitcoin] laanwj merged pull request #16262: rpc: Allow shutdown while in generateblocks (master...2019-06-21-generateblocks) https://github.com/bitcoin/bitcoin/pull/16262
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7d7b832d6707...7f985d6c8159
< bitcoin-git> bitcoin/master cac30a4 Tim Ruffing: Clean up logic in memory_cleanse() for MSVC
< bitcoin-git> bitcoin/master f53a70c Tim Ruffing: Improve documentation of memory_cleanse()
< bitcoin-git> bitcoin/master 7f985d6 Wladimir J. van der Laan: Merge #16158: Fix logic of memory_cleanse() on MSVC and clean up docs
< bitcoin-git> [bitcoin] laanwj merged pull request #16158: Fix logic of memory_cleanse() on MSVC and clean up docs (master...cleanup-cleanse) https://github.com/bitcoin/bitcoin/pull/16158
< bitcoin-git> [bitcoin] practicalswift opened pull request #16331: build: Add configure option --enable-lowmem to allow for building in low-memory environments (master...low-mem) https://github.com/bitcoin/bitcoin/pull/16331
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7f985d6c8159...38fbb575e252
< bitcoin-git> bitcoin/master faa1e0f MarcoFalke: qt: test: Create at most one testing setup
< bitcoin-git> bitcoin/master 38fbb57 Wladimir J. van der Laan: Merge #16294: qt: test: Create at most one testing setup
< bitcoin-git> [bitcoin] laanwj merged pull request #16294: qt: test: Create at most one testing setup (master...1906-qtTestOnlyOneTestingSetup) https://github.com/bitcoin/bitcoin/pull/16294
< bitcoin-git> [bitcoin] NicolasDorier closed pull request #16319: [MSVC] Simplify AppVeyor build by using user customized project file (master...msvc/appveyor-refactor) https://github.com/bitcoin/bitcoin/pull/16319
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/38fbb575e252...085cac6b9043
< bitcoin-git> bitcoin/master 0f459d8 Kaz Wesley: fix an undefined behavior in uint::SetHex
< bitcoin-git> bitcoin/master 085cac6 Wladimir J. van der Laan: Merge #14734: fix an undefined behavior in uint::SetHex
< bitcoin-git> [bitcoin] laanwj merged pull request #14734: fix an undefined behavior in uint::SetHex (master...SetHex-bad-ptr) https://github.com/bitcoin/bitcoin/pull/14734
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/085cac6b9043...9339008a9dce
< bitcoin-git> bitcoin/master 8a6810d darosior: Add a 'logpath' field to getrpcinfo
< bitcoin-git> bitcoin/master 9339008 Wladimir J. van der Laan: Merge #15483: rpc: Adding a 'logpath' entry to getrpcinfo
< bitcoin-git> [bitcoin] laanwj merged pull request #15483: rpc: Adding a 'logpath' entry to getrpcinfo (master...getrpcinfo_logpath) https://github.com/bitcoin/bitcoin/pull/15483
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9339008a9dce...11de669d8b7a
< bitcoin-git> bitcoin/master fab0c82 MarcoFalke: rpc: Clarify that block count means height excl genesis
< bitcoin-git> bitcoin/master 11de669 Wladimir J. van der Laan: Merge #16325: rpc: Clarify that block count means height excl genesis
< bitcoin-git> [bitcoin] laanwj merged pull request #16325: rpc: Clarify that block count means height excl genesis (master...1907-rpcBlockCount) https://github.com/bitcoin/bitcoin/pull/16325
< bitcoin-git> [bitcoin] instagibbs opened pull request #16332: Add logpath description for getrpcinfo (master...getrpcinfo_logpath_help) https://github.com/bitcoin/bitcoin/pull/16332
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #16333: test: Set BIP34Height = 2 for regtest (master...1906-bip34H2) https://github.com/bitcoin/bitcoin/pull/16333
< wumpus> fanquake: re #16270 I think we need a discussion about when to bump indirect dependencies, don't think we need to track every minor version of expat
< gribble> https://github.com/bitcoin/bitcoin/issues/16270 | depends: expat 2.2.7 by fanquake · Pull Request #16270 · bitcoin/bitcoin · GitHub
< fanquake> wumpus: agree. I think dependency bumps, if warranted, early in the release cycle would be preferred. Happy to discuss tomorrow.
< fanquake> depends is likely to be somewhat simplified going forward as well. There are some sub dependencies that could potentially be removed entirely.
< wumpus> oh that would be wonderful
< wumpus> and yes in this case of expat the "worry" is a DoS, however, expat isn't even part of the final executable and only used by Qt tooling, so the only possible use of the CVE would be to "make the build take longer"
< fanquake> Yes. There is only the slight benefit of passing the new flags to “build less”, but the gain will be small.
< aj> MarcoFalke: i've done a backport of #16250 for 0.18 on top of #16035 at https://github.com/ajtowns/bitcoin/tree/201906-signrawerror-regression-018 fwiw
< gribble> https://github.com/bitcoin/bitcoin/issues/16250 | signrawtransactionwithkey: report error when missing redeemScript/witnessScript by ajtowns · Pull Request #16250 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/16035 | 0.18.1: Backports by MarcoFalke · Pull Request #16035 · bitcoin/bitcoin · GitHub
< dongcarl> Wondering how useful propagation benchmarks would be? I was informed that they can be done quite simply by spinning up two mininodes and seeing how long it takes for a block to be processed by bitcoind and spit out the other end.
< wumpus> fanquake: oh hadn't noticed that "building less" part, that is nice
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/11de669d8b7a...91c345eb9282
< bitcoin-git> bitcoin/master 3d60a03 João Barbosa: bench: Move generated data to a dedicated translation unit
< bitcoin-git> bitcoin/master 91c345e MarcoFalke: Merge #16299: bench: Move generated data to a dedicated translation unit
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16299: bench: Move generated data to a dedicated translation unit (master...2019-06-benchmark-data) https://github.com/bitcoin/bitcoin/pull/16299
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #16333: test: Set BIP34Height = 2 for regtest (master...1906-bip34H2) https://github.com/bitcoin/bitcoin/pull/16333
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16333: test: Set BIP34Height = 2 for regtest (master...1906-bip34H2) https://github.com/bitcoin/bitcoin/pull/16333
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/91c345eb9282...1381ddbcfcb6
< bitcoin-git> bitcoin/master faf6caf MarcoFalke: test: Add tests for getblockchaininfo.softforks
< bitcoin-git> bitcoin/master 1381ddb MarcoFalke: Merge #16329: test: Add tests for getblockchaininfo.softforks
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16329: test: Add tests for getblockchaininfo.softforks (master...1907-qaSoftforksHeight) https://github.com/bitcoin/bitcoin/pull/16329
< sdaftuar> oy, something changed in github with how the "filter by author" dropdown is populated, and now i'm seeing zillions of names i don't recognize
< achow101> sdaftuar: looks like they started doing it alphabetically :(
< sdaftuar> but without regard to organization?
< sdaftuar> it used to just be a list of 20-ish regular contributors right?
< sipa> yeah
< sipa> that was the reason to mark people as contributor actually
< sipa> as ot doesn't convey any capabilities
< bitcoin-git> [bitcoin] dongcarl opened pull request #16334: test: rpc_users: Also test rpcauth.py with password. (master...2019-07-rpcauth-passwd-specified-case) https://github.com/bitcoin/bitcoin/pull/16334
< stevenroose> Can Core already work with BIP158 filters? F.e. serve then over RPC?
< harding> stevenroose: on master you can enable the configuration option blockfilterindex=1 and then use the getblockfilter RPC
< harding> (It takes about an hour to index the full chain on a laptop, but you get use the getblockfilter RPC immediately on any blocks that have been indexed so far.)