< jeremyrubin> I forget: is std::swap(x[i], x[i]) correct on all platforms? I vaguely recall there being come bug in some platforms we support
< bitcoin-git> [bitcoin] zachwylde00 opened pull request #18250: create merge (master...master) https://github.com/bitcoin/bitcoin/pull/18250
< bitcoin-git> [bitcoin] fanquake closed pull request #18250: create merge (master...master) https://github.com/bitcoin/bitcoin/pull/18250
< bitcoin-git> [bitcoin] zachwylde00 opened pull request #18251: 0.15 (master...0.15) https://github.com/bitcoin/bitcoin/pull/18251
< bitcoin-git> [bitcoin] fanquake closed pull request #18251: 0.15 (master...0.15) https://github.com/bitcoin/bitcoin/pull/18251
< fanquake> wumpus / sipa Can you block zachwylde00 from GH. 3rd garbage PR in a row.
< sipa> fanquake: done
< fanquake> thanks
< hadjiszs> sipa: MarcoFalke: what about Dandelion Lite for BIP156 ? eg. this implementation: https://github.com/dtr-org/unit-e/pull/302/
< hadjiszs> the fingerprint on the mempool logic seems more interesting
< hebasto> promag: #16710 has your concept ack; mind reviewing?
< gribble> https://github.com/bitcoin/bitcoin/issues/16710 | build: Enable -Wsuggest-override if available by hebasto · Pull Request #16710 · bitcoin/bitcoin · GitHub
< promag> hebasto: sure
< promag> not sure about the autotools stuff though
< promag> re #18239
< gribble> https://github.com/bitcoin/bitcoin/issues/18239 | wip: gui: Refactor to drop client and wallet models setters by promag · Pull Request #18239 · bitcoin/bitcoin · GitHub
< promag> reached the rabbit hole of BitcoinApplication etc :/
< pingwindyktator> Im trying to understand how exactly should we interpret block nVersion. Since BIP09 the 2, 3, 4 version actually refers to top bits in nVersion. So, given nVersion == dec(1073725440) == hex(0x3fffc000) == version 3 with some softfork bits set.
< pingwindyktator> And knowing this, those check cannot work as intended, its like if (1073725440 < 3 && ...)
< bitcoin-git> [bitcoin] vasild opened pull request #18252: build: fix compiler warning in formatPingTime() (master...implicit-change-formatPingTime) https://github.com/bitcoin/bitcoin/pull/18252
< pingwindyktator> Probably those nversion bits should be trimmed here? Something like this: https://wandbox.org/permlink/0bm1UJFqEF7HloWA just to get top bits and then compare
< pingwindyktator> Im trying to think that this code is obsolete: it only applies to blocks before BIP9, which was indeed version 2, 3, 4. Now we're interpreting nVersion differently and this code is here just to be sure we're not breaking consensus. Can anyone confirm this?
< bitcoin-git> [bitcoin] Empact opened pull request #18253: doc: Correct spelling errors in comments (master...2020-03-lint-spelling) https://github.com/bitcoin/bitcoin/pull/18253
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18255: test: Add bad-txns-*-toolarge test cases to invalid_txs (master...2003-testTooLarge) https://github.com/bitcoin/bitcoin/pull/18255
< bitcoin-git> [bitcoin] ACES-Source opened pull request #18256: BTC (master...master) https://github.com/bitcoin/bitcoin/pull/18256
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #18256: BTC (master...master) https://github.com/bitcoin/bitcoin/pull/18256